| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clean environment.
This includes:
* A TestScrubber runs between all test to kill stray IE and Chrome processes and delete the user data dir.
* Refactored CFACWithChrome and ProxyFactoryTest tests to get rid of copy-n-paste.
* Tests in ChromeFrameTestWithWebServer that launch Chrome now use a fresh user data dir so as not to collide with a users' existing profile.
BUG=81479,114386
TEST=chrome_frame_tests.exe is green on the win_cf trybot
Review URL: https://chromiumcodereview.appspot.com/9460019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes disabling a test that is flaky on IE9.
BUG=114369
TEST=Chrome Frame net tests run reliably on IE9, including on try bots and the waterfall.
Review URL: http://codereview.chromium.org/9465016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=none
Review URL: http://codereview.chromium.org/9442038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and possibly made frame rate tests fail: http://crbug.com/115477. Will revert
the revert if it doesn't help.) - Fix media code to work with new ffmpeg.
Once ffmpeg git, svn are updated to new ffmpeg, will update DEPS
in this CL. Which when committed, should seal the deal for the
ffmpeg roll.
API Changes:
avutil: SampleFormat->AVSampleFormat
avutil: av_get_bits_per_sample_fmt -> av_get_bytes_per_sample
avcodec: avcodec_open -> avcodec_open2(..., NULL)
avcodec: avcodec_decode_video2(... AVPacket ...) -> const AVPacket.
avformat: av_open_input_file -> avformat_open_input
avformat: av_register_protocol2 -> ffurl_register_protocol
avformat: av_close_input_file -> avformat_close_input(&...)
avformat: av_find_stream_info -> avformat_find_stream_info(..., NULL)
URLContext now has a url_open2 method as well, for now I've set this
to NULL.
Also fixes:
- ffmpeg_unittests change threading to mirror ffmpeg_video_decoder. There's
an issue where threading causes the last frames of a no-audio video to be
clipped. It existed before this ffmpeg roll, but because threading was
disabled by default in ffmpeg, we never noticed it.
- ffmpeg_demuxer_tests: GetBitrate_UnsetInContainer_NoFileSize now passes.
- New ffmpeg_unittests passes:
sync0_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync0.ogv"
sync1_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync1.ogv"
sync2_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync2.ogv"
FFmpeg fixups here, https://chromiumcodereview.appspot.com/9325049/
New git repo here: http://git.chromium.org/gitweb/?p=chromium/third_party/ffmpeg.git;a=summary
Merge+Patches diff: https://chromiumcodereview.appspot.com/9317107
BUG=110776
TEST=unittests, layouttests, etc. Trybots.
Review URL: https://chromiumcodereview.appspot.com/9317096
TBR=dalecurtis@google.com
Review URL: https://chromiumcodereview.appspot.com/9455018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLRequestTestHTTP over loopback, due to mysterious failures.
Revert the revert - too fast on the trigger
Depends on:
http://codereview.chromium.org/9419053/ (make GetNetworkList filter-out 'down' adapters)
http://codereview.chromium.org/9368031/ (make HTTP tests parameterizable)
http://codereview.chromium.org/9369029/ (make TestServer parameterizable)
BUG=114369
TEST=chrome_frame_net_tests pass on the try bots.
Review URL: http://codereview.chromium.org/9401013
TBR=erikwright@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9444001
TBR=groby@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9438002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
loopback, due to mysterious failures.
Reverted due to win compile failure
Depends on:
http://codereview.chromium.org/9419053/ (make GetNetworkList filter-out 'down' adapters)
http://codereview.chromium.org/9368031/ (make HTTP tests parameterizable)
http://codereview.chromium.org/9369029/ (make TestServer parameterizable)
BUG=114369
TEST=chrome_frame_net_tests pass on the try bots.
Review URL: http://codereview.chromium.org/9401013
TBR=erikwright@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9444001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Once ffmpeg git, svn are updated to new ffmpeg, will update DEPS
in this CL. Which when committed, should seal the deal for the
ffmpeg roll.
API Changes:
avutil: SampleFormat->AVSampleFormat
avutil: av_get_bits_per_sample_fmt -> av_get_bytes_per_sample
avcodec: avcodec_open -> avcodec_open2(..., NULL)
avcodec: avcodec_decode_video2(... AVPacket ...) -> const AVPacket.
avformat: av_open_input_file -> avformat_open_input
avformat: av_register_protocol2 -> ffurl_register_protocol
avformat: av_close_input_file -> avformat_close_input(&...)
avformat: av_find_stream_info -> avformat_find_stream_info(..., NULL)
URLContext now has a url_open2 method as well, for now I've set this
to NULL.
Also fixes:
- ffmpeg_unittests change threading to mirror ffmpeg_video_decoder. There's
an issue where threading causes the last frames of a no-audio video to be
clipped. It existed before this ffmpeg roll, but because threading was
disabled by default in ffmpeg, we never noticed it.
- ffmpeg_demuxer_tests: GetBitrate_UnsetInContainer_NoFileSize now passes.
- New ffmpeg_unittests passes:
sync0_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync0.ogv"
sync1_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync1.ogv"
sync2_ogv/FFmpegTest.Seek_Video/0, where GetParam() = "sync2.ogv"
FFmpeg fixups here, https://chromiumcodereview.appspot.com/9325049/
New git repo here: http://git.chromium.org/gitweb/?p=chromium/third_party/ffmpeg.git;a=summary
Merge+Patches diff: https://chromiumcodereview.appspot.com/9317107
BUG=110776
TEST=unittests, layouttests, etc. Trybots.
Review URL: https://chromiumcodereview.appspot.com/9317096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mysterious failures.
Depends on:
http://codereview.chromium.org/9419053/ (make GetNetworkList filter-out 'down' adapters)
http://codereview.chromium.org/9368031/ (make HTTP tests parameterizable)
http://codereview.chromium.org/9369029/ (make TestServer parameterizable)
BUG=114369
TEST=chrome_frame_net_tests pass on the try bots.
Review URL: http://codereview.chromium.org/9401013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK: add support for writing to primary selection (BUFFER_SELECTION).
BUG=none
TEST=ui_unittests
TBR=ananta
Review URL: http://codereview.chromium.org/9232075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=chrome_frame_net_tests pass on IE8
Review URL: http://codereview.chromium.org/9432001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/fcec09fc659f39a6
BUG=114386,109405,38404
TBR=sky
Review URL: http://codereview.chromium.org/9405024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=ananta@chromium.org
BUG=114386
TEST=none
TBR=ananta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9403020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
included in VS2010.
Fix ATL assert that happens when COM is not correctly initialized.
Remove spurious HungCOMCallDetector logging messages.
BUG=114609
TEST=chrome_frame_tests.exe
Review URL: http://codereview.chromium.org/9348086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/fcec09fc659f39a6
BUG=81479,83133,37088,32321,111074,114058,90791,83114,64794
Review URL: http://codereview.chromium.org/9391011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=95568
TEST=do something on a page that calls window.print(); expect IE's print dialog to appear. should be covered by new test in chrome_frame_tests.exe.
Review URL: http://codereview.chromium.org/9350044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with the ATL included with VS2010.
BUG=114609
TEST=chrome_frame_tests.exe
Review URL: http://codereview.chromium.org/9391014
TBR=robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9360038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
included with VS2010.
BUG=114609
TEST=chrome_frame_tests.exe
Review URL: http://codereview.chromium.org/9391014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(try #3).
For the browser use case it is convenient to have a single ContentMain entry point function that handles all initialization, run and shutdown. For embedded use cases it is often necessary to integrate with existing application message loops where initialization and shutdown must be handled separately.
To support sharing of this code the following changes were required:
1. Refactor the ContentMain function to create a ContentMainRunner class containing separate initialization, run and shutdown functions.
2. Refactor the BrowserMain function and BrowserMainLoop class to create a BrowserMainRunner class containing separate initialization, run and shutdown functions.
3. Add a new BrowserMainParts::GetMainMessageLoop method. This is necessary to support creation of a custom MessageLoop implementation while sharing BrowserMainRunner initialization and shutdown code.
BUG=112507
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9375017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
embedded use cases (try #2).
Tests failing.
Review URL: https://chromiumcodereview.appspot.com/9372027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(try #2).
For the browser use case it is convenient to have a single ContentMain entry point function that handles all initialization, run and shutdown. For embedded use cases it is often necessary to integrate with existing application message loops where initialization and shutdown must be handled separately.
To support sharing of this code the following changes were required:
1. Refactor the ContentMain function to create a ContentMainRunner class containing separate initialization, run and shutdown functions.
2. Refactor the BrowserMain function and BrowserMainLoop class to create a BrowserMainRunner class containing separate initialization, run and shutdown functions.
3. Add a new BrowserMainParts::GetMainMessageLoop method. This is necessary to support creation of a custom MessageLoop implementation while sharing BrowserMainRunner initialization and shutdown code.
BUG=112507
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9347022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
use cases."
This reverts commit r120574. Test failures.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the browser use case it is convenient to have a single ContentMain entry point function that handles all initialization, run and shutdown. For embedded use cases it is often necessary to integrate with existing application message loops where initialization and shutdown must be handled separately.
To support sharing of this code the following changes were required:
1. Refactor the ContentMain function to create a ContentMainRunner class containing separate initialization, run and shutdown functions.
2. Refactor the BrowserMain function and BrowserMainLoop class to create a BrowserMainRunner class containing separate initialization, run and shutdown functions.
3. Add a new BrowserMainParts::GetMainMessageLoop method. This is necessary to support creation of a custom MessageLoop implementation while sharing BrowserMainRunner initialization and shutdown code.
BUG=112507
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9190018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PartialPreReadImage has much the smae interface as PreReadImage except the bytes to read becomes a percentage to read and it reads a certain percentage of each section in the binary.
Also adds some unittest coverage.
BUG=chromium:98508
TEST=
Review URL: http://codereview.chromium.org/9235053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Responses were being cached by IE, so there was a reasonable probability that two permutations used the same URL. This change adds a no-cache header so the URL doesn't matter.
BUG=99235
TEST=none -- covered by chrome_frame_tests.exe
Review URL: https://chromiumcodereview.appspot.com/9323031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because it consistently fails and times out.
BUG=112599
TEST=none
TBR=robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9325027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These tests were counting on a guarantee that value change events would come in before menu popup events. As it happens, this isn't always the case. The tests now wait for the inital value change event to come in before performing subsequent operations, thereby avoiding the race.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9323025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, a magic timeout of 4s was used to end certain tests (listed below). This changes them so that they stop when they're done. This makes the test FASTER in release builds (yay!) and WORK in debug builds (omg!). Given the nature of these tests, I won't be surprised if there's a failure on some combination of OS/IE versions. Hopefully these can be fixed without adding 4s delays.
I found that, at least on my machine, explicitly putting a Cache-control: no-cache header on responses helped make the tests more reliable.
The tests are:
*/FullTabNavigationTest.RefreshContents/*
FullTabDownloadTest.TopLevelPostReissueFromChromeFramePage
*/FullTabNavigationTest.RefreshContentsUATest/*
BUG=none
TEST=win_cf trybot runs chrome_frame_tests.exe, so no special testing is needed.
Review URL: https://chromiumcodereview.appspot.com/9316022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The matcher TabContentsTitleEq is now used by expectations so that actions are only performed when the relevant render window's document is loaded.
BUG=111916
TEST=covered by chrome_frame_tests.exe
Review URL: https://chromiumcodereview.appspot.com/9159030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make sure early return from PreCreateThreads aborts the startup sequence.
BUG=110671
TEST=Launch Chrome with --try-chrome-again=0, select "Dont bug me" and Chrome should not launch.
Review URL: https://chromiumcodereview.appspot.com/9150033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9225051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
files.
BUG=111326
R=jam
TBR=sky,tony,ajwong,ananta
Review URL: http://codereview.chromium.org/9232060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that could result in an IE browser hang on a JS error dialog.
BUG=111384
TEST=chrome_frame_tests.exe
Review URL: https://chromiumcodereview.appspot.com/9290026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The tests verify whether requests can be cancelled when blocking in certain states. A first pass seems to suggest that, under Chrome Frame, the Chrome network stack never enters these states (the transitions occur entirely in IE network stack), thus cannot block in them, and thus the tests are not relevant.
TEST=chrome_frame_net_tests run and pass on machines with IE9 installed.
R=robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9270045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a useful return value to LaunchIEAndNavigate, indicating which step failed.
Also fix a crash in the HungCOMCallDetector if LaunchIEAndNavigate() fails.
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9160029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In component=shared_library builds, it isn't safe to load npchrome_frame.dll into a process that has its own AtExit manager, singletons, logging, etc. So now spin off a new run of the given test executable to do the registration.
BUG=110492
TEST=none (covered by cf_win trybot)
Review URL: https://chromiumcodereview.appspot.com/9146054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[ RUN ] ChromeFrameTestWithWebServer.FullTabModeIE_WindowClose
.\test\test_with_web_server.cc(214): error: Value of: server_mock_.posted_result()
Actual: ""
Expected: result
Which is: "OK"
[ FAILED ] ChromeFrameTestWithWebServer.FullTabModeIE_WindowClose (45217 ms)
BUG=111074
TEST=marked flaky
Review URL: http://codereview.chromium.org/9235013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=110492
TEST=none
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/9270056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
comprehensible logs, and log the method and path received by the test web server when it handles a request. Such logging is no longer limited to debug builds.
BUG=none
TEST=run any GCF test with --v=1 and watch the events fly by
Review URL: http://codereview.chromium.org/9272004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PathService will give back the path to base.dll, which isn't what is wanted in specific cases. For the DLL redirector, the true path to npchrome_frame must be used, primarily for testing purposes, but it's also the right thing to do. For pinnig, npchrome_frame.dll must be pinned rather than base.dll.
BUG=110492
TEST=the integration tests (chrome_frame_tests.exe) cover it
R=robertshield@chromium.org
Review URL: http://codereview.chromium.org/9141015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=110492
TEST=none
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/9250003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=ananta@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9187024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes a race condition in Chrome Frame's net tests that could cause URLRequestJobs to be created and destroyed on different threads. This in turn leaks PowerObservers from SystemMonitor's observer list, resulting in an observer list full of dangling pointers. In debug mode this may eventually dcheck if heap addresses are reused.
BUG=109733
TEST=chrome_frame_net_tests.exe does not DCHECK.
Review URL: http://codereview.chromium.org/9158012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117078
Review URL: http://codereview.chromium.org/9150016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PluginService to content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead.
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Review URL: http://codereview.chromium.org/9150016
TBR=jam@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead.
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Review URL: http://codereview.chromium.org/9150016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bypass tricks to run IE in special ways if the tests are running at high integrity. Otherwise, the medium-integrity broker exits and low-integrity IE is therefore unable to get chrome_launcher running at medium integrity.
BUG=60987
TEST=no manual testing needed; chrome_frame_tests.exe will either become better or worse.
Review URL: http://codereview.chromium.org/9133001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Over 341 CLs, in ~3 months, touching 3251 unique files!
Top 5 most CLs:
(121) jhawkins
( 45) dcheng
( 24) achuith
( 23) csilv
( 12) tfarina
( 12) groby
~1000 files touched:
(918) jhawkins
100+ files touched:
(486) ajwong
(385) willchan
(372) dcheng
(126) csilv
(123) fischman
(112) sergeyu
49+ files touched:
(65) tfarina
(57) acolwell
(52) adamk
(49) tzik
BUG=35223
TEST=existing
Review URL: http://codereview.chromium.org/9114020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
line.
This makes debugging easier for developers, since crashes will start the postmortem debugger.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9123008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98919
TEST=existing
Review URL: http://codereview.chromium.org/9111032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:109114
TEST=flakes go away.
TBR=amit@chromium.org
Review URL: http://codereview.chromium.org/9088007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116298 0039d316-1c4b-4281-b951-d872f2087c98
|