summaryrefslogtreecommitdiffstats
path: root/chrome_frame/test
Commit message (Collapse)AuthorAgeFilesLines
* More context menu testsamit@chromium.org2010-03-0411-282/+574
| | | | | | | | | | | | | Refactored code to monitor windows so that it could be used with our mock to watch for dialogs and chrome windows. Added new tests for 'Page Info', 'Dev Tools' and 'Save As' menu options. BUG=34673 TESTS=newly added Review URL: http://codereview.chromium.org/667005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40654 0039d316-1c4b-4281-b951-d872f2087c98
* Another try at fixing include soupamit@chromium.org2010-03-031-1/+0
| | | | | | | | | | TBR=ananta BUG=none TEST=none Review URL: http://codereview.chromium.org/661465 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40513 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build breakage due to includeamit@chromium.org2010-03-031-1/+1
| | | | | | | | | | TBR=ananta BUG=none TEST=none Review URL: http://codereview.chromium.org/661464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40512 0039d316-1c4b-4281-b951-d872f2087c98
* More compact mock testsamit@chromium.org2010-03-034-511/+181
| | | | | | | | | | | | | | | Factor out the common expectations for navigations in macros so as to avoid code duplication and make tests more readable. Next step is probably to create a testing::ExpectionSet and use functions instead of macros. BUG=none TEST=all the modified tests Review URL: http://codereview.chromium.org/661390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40511 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the FullTabModeIE_UnloadEventTest as it consistently fails while I ↵ananta@chromium.org2010-03-021-1/+2
| | | | | | | | | | | debug it. Bug=37231 TBR=amit Review URL: http://codereview.chromium.org/660401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the full tab mode unload event test by moving the FileDownload ↵ananta@chromium.org2010-03-021-12/+4
| | | | | | | | | | | | expectation before the testing::InSequence specification and getting rid of the duplicate FileDownload expectations. TBR=amit Review URL: http://codereview.chromium.org/661385 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40409 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame should honor the host browser's cookie policy. To achieve this ↵ananta@chromium.org2010-03-024-78/+33
| | | | | | | | | | | | | | | | we always read the cookies from the host browser when the renderer requests them. This also cleans up the mess with the host network stack code parsing cookies from the host looking for persistent cookies. Fixes bug http://code.google.com/p/chromium/issues/detail?id=34151 Bug=34151 Test=Covered by existing host network stack tests and chrome frame cookie tests. Review URL: http://codereview.chromium.org/661290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40402 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the WidgetModeFF_CFInstanceRPCInternal as flaky.ananta@chromium.org2010-03-021-1/+2
| | | | | | | | | Bug=37204 TBR=amit Review URL: http://codereview.chromium.org/660386 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40392 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a little utility function to make logging guids easiertommi@chromium.org2010-03-011-0/+13
| | | | | | | | | | | and a dlog to see when we decide that a request is a subframe request. TEST=Unit test is provided. BUG=none Review URL: http://codereview.chromium.org/660289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40288 0039d316-1c4b-4281-b951-d872f2087c98
* Marking some more tests as flaky since they fail randomly on waterfall.amit@chromium.org2010-03-011-3/+6
| | | | | | | | | TBR=iyengar TEST=none Review URL: http://codereview.chromium.org/660285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40281 0039d316-1c4b-4281-b951-d872f2087c98
* Marking WidgetModeFF_InHead as flaky as it randomly fails on buildbotsamit@chromium.org2010-02-281-1/+2
| | | | | | | | TBR=ananta Review URL: http://codereview.chromium.org/661258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40236 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ui test crashes on Linux. There is a race condition between the ↵ananta@chromium.org2010-02-261-1/+1
| | | | | | | | | | | | | | channel getting destroyed and it being referenced in the background thread. Fix is to use the underlying IPC::Channel pointer passed to the message filter when the filter gets Added to send and receive messages. This ensures that the SyncChannel is not used across threads. Review URL: http://codereview.chromium.org/661109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40076 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test for the multiple request issues we've been seeing.tommi@chromium.org2010-02-256-35/+178
| | | | | | | | | | | The test is disabled until we fix the actual problem. TEST=n/a BUG=33332 Review URL: http://codereview.chromium.org/661017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39954 0039d316-1c4b-4281-b951-d872f2087c98
* Update Chrome Frame's reliability tests to allow them to register a given CF ↵robertshield@chromium.org2010-02-241-1/+30
| | | | | | | | | | | dll. BUG=29451 TEST=Reliability tests can be staged more easily on the vm tests. Review URL: http://codereview.chromium.org/656021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39903 0039d316-1c4b-4281-b951-d872f2087c98
* Mark four more FullTabModeIE tests as flakystuartmorgan@chromium.org2010-02-191-4/+12
| | | | | | | | | | | | | | | | FullTabModeIE_ContextMenuBackForward FullTabModeIE_ContextMenuReload FullTabModeIE_ContextMenuViewSource FullTabModeIE_KeyboardBackForwardTes TBR=ananta BUG=26549 TEST=none Review URL: http://codereview.chromium.org/650041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39459 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-192-2/+2
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-191-0/+1
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the FullTabModeIE_ReferrerTest as FLAKY as this still intermittently ↵ananta@chromium.org2010-02-191-1/+3
| | | | | | | | | | | fails. Bug=34812 TBR=tommi Review URL: http://codereview.chromium.org/646073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39404 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for referrer flakyness. There were two problems:tommi@chromium.org2010-02-181-3/+2
| | | | | | | | | | | | | | | Grabbing the referrer header when the request is made and not in BeforeNavigate2. The request headers aren't always available in BeforeNavigate2. Mshtml provides these headers in IHttpNegotiate::BeginningTransaction, which is where we now grab them. There was a race in chrome_frame_automation.cc where we use std::string to store the referrer url and then access that string from different threads. This was causing the referrer URL to be missing at some times and at other times be sent over to chrome as bad string (e.g. containing embedded nulls) and subsequently be deemed an invalid URL and dropped. TEST=Fixes referrer header flakyness. BUG=34812 Review URL: http://codereview.chromium.org/646013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39383 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporating review comments from Amit. The keyboard based back forward ↵ananta@chromium.org2010-02-174-61/+30
| | | | | | | | | | | | | | | test only needs simple HTML files with the meta tag to switch to Chrome. Removed the fulltab_forward_page.html amd fulltab_back_page.html and replaced them with the sub_frame1.html and sub_frame2.html Other changes include to use SetFocusToChrome helper function to give focus to the Chrome renderer window instead of sending a WM_LBUTTONDOWN and to use ComStackObjectWithUninitialize mock class to ensure that things get cleaned up correctly. Review URL: http://codereview.chromium.org/608033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39246 0039d316-1c4b-4281-b951-d872f2087c98
* We need to support the following accelerators in the ChromeFrame Active ↵ananta@chromium.org2010-02-177-7/+187
| | | | | | | | | | | | | | | | | | | | | | | | document, to ensure that the following accelerators navigate backwards and forwards in IE history. 1. VK_BACK and Alt + VK_LEFT to navigate back. 2. Shift + VK_BACK and Alt + VK_RIGHT to navigate forward. This CL adds support for this. We load the accelerator table in our Active document and when we receive an accelerator from Chrome, we first call the Windows API TranslateAccelerator to translate any accelerators and then continue with the default handling. Added handlers for navigating back and forward. Test=covered by unit test. Fixes bug http://code.google.com/p/chromium/issues/detail?id=35629 Bug=35629 Review URL: http://codereview.chromium.org/600117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39208 0039d316-1c4b-4281-b951-d872f2087c98
* Beginnings of a unit test for downloads that occur in a new window.tommi@chromium.org2010-02-176-130/+429
| | | | | | | | | | | | | | | | | | For now this works for IE regularly (no cf in the picture) and triggers a download in a new window. It is disabled since support for this scenario is not yet ready in CF. I'm adding a couple of things to WebBrowserEventSink: - A way to gracefully close IE. This way we allow IE to quit on its own and don't go the "kill" route unless necessary. This should help with reducing cases where we've killed IE and the next time it is started it presents the user with an "IE crashed" dialog which could cause subsequent unit tests to fail. Another thing this adds is support for the OnQuit event that can be useful to add to unit tests as an expected event. - A new OnFileDownload event. I also updated several tests to expect this event. TEST=Adds a unit test. BUG=none Review URL: http://codereview.chromium.org/569011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39190 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash caused by incorrecly passing in a wstring to StringPrintf in the ↵ananta@chromium.org2010-02-161-2/+3
| | | | | | | | | | format %ls. TBR=tommi Review URL: http://codereview.chromium.org/611003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39145 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cfinstance chrome tests. Before they were either failing to launchtommi@chromium.org2010-02-162-6/+21
| | | | | | | | | | | | chrome (if chrome itself wasn't installed) or launching the installed chrome and not the one from the build directory. TEST=Run *WidgetModeChrome_* unit tests. BUG=35868 Review URL: http://codereview.chromium.org/606066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39132 0039d316-1c4b-4281-b951-d872f2087c98
* Added factories for HttpAuthHandler.cbentzel@chromium.org2010-02-151-2/+6
| | | | | | | | | | | | | | | | | | | The driving rationale for this change was to prevent choosing an AuthHandler when it is not supported on the system due to a missing runtime component (such as not being able to locate a gssapi shared library when seeing a Negotiate scheme). It also has the advantage (currently unused) of determining some per-auth-scheme properties only the first time that a challenge for that scheme is seen (such as maximum token length for the SSPI implementation of NTLM). Finally, it may make unit tests easier to generate since the factory can be easily mocked. BUG=34795 TEST=New unit test for HttpAuthHandlerDispatchFactory. Review URL: http://codereview.chromium.org/582007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39065 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing file for the UrlmonUrlRequestTest.ZeroLengthResponse test.stoyan@chromium.org2010-02-121-0/+0
| | | | | | | TBR=amit Review URL: http://codereview.chromium.org/603044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38907 0039d316-1c4b-4281-b951-d872f2087c98
* First batch of context menu testsamit@chromium.org2010-02-1210-536/+842
| | | | | | | | | | | | | | | | Refactored various methods to send keyboard and mouse input. Fixed the context menu focus issue on IE7. Improved existing tests to make them less flaky and added 3 new tests for context menu items. BUG=34673 TEST=new tests added Review URL: http://codereview.chromium.org/604014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38905 0039d316-1c4b-4281-b951-d872f2087c98
* Proper notification in OnStopBinding if headers are not availble (i.e. ↵stoyan@chromium.org2010-02-122-153/+233
| | | | | | | | | | | connection failed). Test added. TEST=chrome_frame_net_tests BUG=none Review URL: http://codereview.chromium.org/593065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38900 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the ChromeFrameTestWithWebServer,.FullTabModeIE_ViewSource as FLAKY.ananta@chromium.org2010-02-111-1/+3
| | | | | | | | | Bug=35370 TBR=amit Review URL: http://codereview.chromium.org/603022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38743 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the revert... This has the cumulative effect of relanding 38694.eroman@chromium.org2010-02-111-1/+1
| | | | | | | | | | | | | | | | The chrome frame failure appears to be unrelated. Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/596048 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/604012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38728 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38694 - For some reason this seems to be hanging chrome frame tests, ↵eroman@chromium.org2010-02-101-1/+1
| | | | | | | | | | | | | even though this should be a strictly no-op change... Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 TBR=eroman@chromium.org Review URL: http://codereview.chromium.org/596048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38707 0039d316-1c4b-4281-b951-d872f2087c98
* Add some tests to CookieMonster for overwriting persistent cookies, and ↵eroman@chromium.org2010-02-101-1/+1
| | | | | | | | checking that the PersistentCookieStore interface is exercised correctly. Review URL: http://codereview.chromium.org/600040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38694 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the following net tests for ChromeFrame as this functionality does ↵ananta@chromium.org2010-02-101-1/+5
| | | | | | | | | | | | | | | | not exist there. 1. URLRequestTest.DoNotSendCookies 2. URLRequestTest.DoNotSendCookies_ViaPolicy_Async 3. URLRequestTest.CancelTest_During_OnGetCookiesBlocked 4. URLRequestTest.CancelTest_During_OnSetCookieBlocked TBR=amit Review URL: http://codereview.chromium.org/601020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38585 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash. Happens in LaunchDelegate::LaunchComplete if delegate ↵stoyan@chromium.org2010-02-101-0/+40
| | | | | | | | | | (ChromeFrameAutomationClient) is destroyed before launch callback is invoked. Happens when underlying automation proxy is going to be shared to new instance of ChromeFrameAutomationClient and we destroy that instance before receiving LaunchComplete callback. Still have a race (and possible crash) for automation_server_ in ReleaseAutomationServer and LaunchComplete, TEST=test added. Review URL: http://codereview.chromium.org/582018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38551 0039d316-1c4b-4281-b951-d872f2087c98
* A new unit test for the latest issue with switching renderers.tommi@chromium.org2010-02-066-23/+151
| | | | | | | | | | | | | | This affects both the httpequiv and IInternetProtocol mechanisms we've been using. The problem is going from mshtml to a CF page via POST. In this case the original POST request is issued once, but then a subsequent GET is issued for the same URL. On top of that, the referrer is missing. TEST=This test is disabled for now. BUG=none Review URL: http://codereview.chromium.org/580001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38282 0039d316-1c4b-4281-b951-d872f2087c98
* The FullTabModeIE_ReferrerTest has been marked FLAKY. It appears to be a ↵ananta@chromium.org2010-02-051-1/+3
| | | | | | | | | | | recent regression. Bug=34812 TBR=tommi Review URL: http://codereview.chromium.org/573033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38262 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the URLRequestTest.CookiePolicy_ForceSession test to the list of ↵ananta@chromium.org2010-02-051-0/+1
| | | | | | | | | | | | disabled tests as it does not apply to the host network stack. TBR=amit Review URL: http://codereview.chromium.org/572040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38230 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize chrome_frame_unittest.h/ccamit@chromium.org2010-02-0411-2111/+2154
| | | | | | | | | | | | | | Split this monsterinto 4 different h/cc files based on the type of tests. No real code changes. Things should become easier to find/manage now. BUG=None TEST=None Review URL: http://codereview.chromium.org/574006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38144 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Navigation failed testamit@chromium.org2010-02-041-18/+39
| | | | | | | | | | | | Also fix a bug in SetConfigInt to create the 'ChromeFrame' config key if it does not exist. BUG=24104 TEST=CFACWithChrome.NavigateFailed Review URL: http://codereview.chromium.org/560041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38103 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the following url request tests for ChromeFrame as these policies ↵ananta@chromium.org2010-02-041-0/+6
| | | | | | | | | | | | | | | | don't apply to the host network stack as it should be honoring the host browser's cookie policy. 1.URLRequestTest.DoNotSaveCookies_ViaPolicy 2.URLRequestTest.DoNotSendCookies_ViaPolicy 3.URLRequestTest.DoNotSaveCookies_ViaPolicy_Async TBR=amit Review URL: http://codereview.chromium.org/569034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38058 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the NetworkChangeNotifier to HostResolver.willchan@chromium.org2010-02-041-2/+3
| | | | | | | | | | | | | | | This requires the following refactors: (1) NetworkChangeNotifier moves out of HttpNetworkSession into IOThread. (2) HostResolver gets initialized with NetworkChangeNotifier. (3) NetworkChangeNotifier needs to get passed into HttpCache and HttpNetworkSession (required updating a lot of files). (4) NetworkChangeNotifier is no longer reference counted. It is owned by IOThread. (5) IOThread gains a new struct: Globals. It can only be used on the io thread. (6) ChromeURLRequestContextFactory uses IOThread::Globals to initialize ChromeURLRequest objects with the host resolver and network change notifier. BUG=26159 Review URL: http://codereview.chromium.org/552117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38052 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the three tests broken by gcf: change.amit@chromium.org2010-02-032-13/+19
| | | | | | | | | BUG=34461 TEST=Fixed and enabled tests CFProtocol, Persistent cookie and NavigateOut Review URL: http://codereview.chromium.org/561057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38029 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling NavigateOut test since that also depends on theamit@chromium.org2010-02-031-1/+3
| | | | | | | | | | gcf: protocol that's now disabled. TBR=ananta Review URL: http://codereview.chromium.org/560035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37990 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing tests and change GMock'ism foramit@chromium.org2010-02-031-21/+25
| | | | | | | | | | | | testing::AnyNumber() to be followed by WillRepeatedly(...) instead of WillOnce TBR=ananta Review URL: http://codereview.chromium.org/563019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37988 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cf: protocolamit@chromium.org2010-02-037-42/+194
| | | | | | | | | | | | | | | | | | | | Well, almost. cf: is now changed to gcf: protocol. gcf: protocol now is supported only for the following cases: 1. gcf:attach_external_tabXXX urls. These are URLs used internally by Chrome Frame to implement window.open 2. gcf:about:xxx 3. gcf:view-source:xxx 4 For any other URLs ONLY if it is enabled by setting a registry value 'EnableGCFProtocol' to 1 in HKCU\Software\Google\ChromeFrame BUG=22721,23006,23175,29350 TEST=changed existing cf: tests to new gcf: tests, added a new test for cf:view-source Review URL: http://codereview.chromium.org/562008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37981 0039d316-1c4b-4281-b951-d872f2087c98
* Renabling the FullTabModeIE_ChromeFrameUnloadEventTest ChromeFrame test. ↵ananta@chromium.org2010-02-031-3/+1
| | | | | | | | | | | | | | | | | | | | | | | This test failed at times on the builder due to a deadlock between the urlmon worker thread in IE and the ui thread. This would occur when the active document instance was going away while the worker thread was waiting for a COM call to be marshaled to the UI thread which expects the thread to pump messages. The only interface which needs to be marshaled to the worker thread is the IBindCtx interface. Turns out that there is nothing of note in this object, except the bind options. The rest of the properties queried for all fail initially and then the caller register its own variants of these properties. Fix is to create a new IBindCtx interface and copy over the BIND_OPTs to this interface. Fixes bug http://code.google.com/p/chromium/issues/detail?id=34246 Bug=34246 Review URL: http://codereview.chromium.org/566026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37916 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the FullTabModeIE_ChromeFrameUnloadEventTest as it hangs on the ↵ananta@chromium.org2010-02-021-1/+3
| | | | | | | | | | | | builder, while I debug the cause. Bug=34246 TBR=amit Review URL: http://codereview.chromium.org/560017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37870 0039d316-1c4b-4281-b951-d872f2087c98
* TEST=new tests added.stoyan@chromium.org2010-02-013-11/+162
| | | | | | Review URL: http://codereview.chromium.org/545093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37728 0039d316-1c4b-4281-b951-d872f2087c98
* The FullTabModeIE_WindowOpenInChrome ChromeFrame test should not quit the ↵ananta@chromium.org2010-01-301-2/+1
| | | | | | | | | | | | | | message loop on receiving the NewWindow event as it needs to ensure that the new popup window shunted correctly into Chrome. This should ensure that this test passes now. TBR=amit Review URL: http://codereview.chromium.org/548213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37623 0039d316-1c4b-4281-b951-d872f2087c98
* In IE8 new windows opened within ChromeFrame via window.open calls at times ↵ananta@chromium.org2010-01-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bypass the host network stack. In this case we don't get control over the navigation as window.open calls expect to carry the opener relationship over to the new window. This basically means that navigation occurs in Chrome and the new tab/window created by the host attaches to the newly created ExternalTabContainer instance. In IE8 the new tab opens in a new IE process, which basically uses a new automation channel to talk to Chrome. The host network stack implementation routes network requests issued by registered render views to the host browser over the automation channel. There is a timing window between the new window getting created and issuing network requests and the channel being established with the new iexplore instance. As a result network requests issued by the new window don't use the host network stack. Fix is to register the render view and process as a pending view when we get notified about the new TabContents in the original ExternalTabContainers implementation of TabContentsDelegate::AddNewContents. Any network requests issued for this view would result in the corresponding URLRequestAutomationJob instances getting created as pending as well. When the host browser connects to the new ExternalTabContainer instance, we pass over the new automation channel and tab handle to the URLRequestAutomationJob instances and resume them. This fixes bug http://code.google.com/p/chromium/issues/detail?id=33516 Bug=33516 Test=Login to gmail in IE8 in ChromeFrame. Open up a new conversation and click on New Window which opens up a tear off window. This should not bring up the login prompt again. Will think about a good approach to write a unit test for this behavior and send out a separate CL for that. Review URL: http://codereview.chromium.org/554134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37585 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 06:11:06 +0000