| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
has more control about the backend instantiation.
BUG=none
TEST=current unit tests.
Review URL: http://codereview.chromium.org/2000011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WidgetModeIE_InitializeHidden test on the IE6 bot to avoid a hang issue. Alex is already working on a proper fix.
TEST=n/a
BUG=none
TBR=slightlyoff
Review URL: http://codereview.chromium.org/2013014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
TBR=ananta
BUG=none
Review URL: http://codereview.chromium.org/2000007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=slightlyoff
Review URL: http://codereview.chromium.org/1997012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions.
TEST=This is an attempt to reduce flakiness of Chrome Frame net tests.
BUG=none
TBR=ananta
Review URL: http://codereview.chromium.org/2051004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
download issue.
See also:
http://codereview.chromium.org/1718025 (initial change)
http://codereview.chromium.org/1829001 (fix for Head test)
http://codereview.chromium.org/1887001 (fix for download issue)
TEST=Monitor the Chrome Frame IE6 build bot for flakiness. Particularly the net tests.
BUG=none
Review URL: http://codereview.chromium.org/1821001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window class in DllMain on attach and tag it with our module handle, then unregister said window class on detach.
BUG=43343
Review URL: http://codereview.chromium.org/1994007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the NavigateToRestrictedSite
test is behind the console window.
Fix is to not attempt to close the dialog by clicking on it. We now close the window by the DoClosewindow
helper which posts the WM_CLOSE message to it.
TBR=amit
Review URL: http://codereview.chromium.org/2041003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CreateStreamOnHGlobal may fail if the underlying GlobalAlloc fails. It has
a strange behavaior where if we pass in an HGlobal, it can create more
streams per process. So the fix is to:
1. not register us as a bind status callback if we cannot create a stream
for sniffing data and
2. When initializing the data sniffing stream pre-create a HGlobal
BUG=To be filed
TEST=none
Review URL: http://codereview.chromium.org/1983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
code to set cookies in IE incorrectly parses the cookies into name
value pairs. In this scenario we end up with an empty name string which causes cookies to not get set correctly. It appears that an empty
name string is not treated on the same lines as NULL. In any case we should not be doing any parsing and should just set the cookie as is.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=42818. Added a unit test to validate this case.
Bug=42818
Review URL: http://codereview.chromium.org/1917005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- also suppress dialogs caused by __debugbreak on Windows
- avoid bad interactions with gtest (they cause odd problems, really)
TEST=none
BUG=29997
Review URL: http://codereview.chromium.org/1867001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resubmit.
Revert 46188 - Not using an intermediate cache between urlmon and chrome reads.
Instead we hang on to stream objects from urlmon and read from them when chrome asks for data.
TEST=Run all tests verify that sites like wave and vimeo work correctly etc.
BUG=none
Review URL: http://codereview.chromium.org/1718025
TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/1928001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resubmit.
Revert 46189 - Temporarily disable the Head test.
TBR=amit
BUG=none
Review URL: http://codereview.chromium.org/1828001
TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/1927001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resubmit.
Revert 46190 - Reenable the Head test.
TEST=Fixes the UrlRequest Head test
BUG=none
TBR=amit
Review URL: http://codereview.chromium.org/1829001
TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/1901002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FullTabModeIE_TestMultipleGet and FullTabModeIE_TestPostReissue
tests. These tests expect the last request received to be /quit?OK. However at times it appears that we receive an additional
accept request which ends up failing this test.
Fix is to add a custom function which returns the request associated with a path. Changed the expectations accordingly.
Review URL: http://codereview.chromium.org/1903001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Fixes the UrlRequest Head test
BUG=none
TBR=amit
Review URL: http://codereview.chromium.org/1829001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=amit
BUG=none
Review URL: http://codereview.chromium.org/1828001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Instead we hang on to stream objects from urlmon and read from them when chrome asks for data.
TEST=Run all tests verify that sites like wave and vimeo work correctly etc.
BUG=none
Review URL: http://codereview.chromium.org/1718025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
original implementation of BindToStorage() when we do not wrap the bind status callback.
BUG=42660
TEST=Induce exception in code called under original IMoniker::BindToStorage implementation when we don't wrap the callback and notice that no crash is reported.
Review URL: http://codereview.chromium.org/1748016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42790
TEST=run chrome_frame_tests.exe --gtest_filter=*InstallFlow*
Review URL: http://codereview.chromium.org/1727018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tommi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- URLRequestTestContext (from now on use TestURLRequestContext)
- TestServerPageW (use TestServerPage).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1814002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/1733021/show
BUG=42660
TEST=none
Review URL: http://codereview.chromium.org/1703015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
another crash which occurs when the remote COM apartment running
in Ie shuts down and tries to free references to the web browser event sink. We unsubscribe from the event sink in the destructor of the
ComStackObjectWithUninitialize object. The call to DispEventUnadvise fails every time. Unsubscribing and call CoDisconnectObject to release
the server side stub references in the OnQuit notification fixes the crash.
To aid debugging this issue in the future we now override the purecall handler in chrome frame tests.
Bug=41980
TBR=amit
Review URL: http://codereview.chromium.org/1695015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
server and end up crashing while
dereferencing a NULL server pointer. Added expectations and checks to handle this gracefully.
Bug=41980
TBR=amit
Review URL: http://codereview.chromium.org/1706011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and the FullTabModeIE_WindowOpenInChrome test. We need to set focus to the
Chrome renderer window.
Review URL: http://codereview.chromium.org/1736014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One of these fixes is in the ChromeFrame ActiveX
where we were invoking the onload/onmessage handlers on a NULL interface pointer. The other fix is in the chrome frame test
code where we need to protect against reentrancy while in the context of an outgoing COM interface call.
Fixes http://code.google.com/p/chromium/issues/detail?id=41980
Bug=41980
Review URL: http://codereview.chromium.org/1691012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ComObjectstackEx instances which handle new IE windows to
before the message loop to ensure that they remain valid when the message loop is destroyed.
Bug=41980
Review URL: http://codereview.chromium.org/1761005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests. This crash happens because the timed message loop object attempts
to destroy pending tasks, which point to a deleted CComObjectStackEx instance in its destructor.
Fix is to ensure that the CComObjectStackEx instance which holds chrome frame mocks outlives the message loop.
Fixes http://code.google.com/p/chromium/issues/detail?id=41980
Bug=41980
TBR=stoyan
Review URL: http://codereview.chromium.org/1772001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CL now applies after r45225 (Throw out preferences files that are corrupt rather than keeping them in read-only mode), which means that the changes in that commit moved to JsonPrefStore.
I updated JsonPrefStoreTest.InvalidFile to test the new behavior.
***
In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.
Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.
BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*
Review URL: http://codereview.chromium.org/1717007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
retrieve the IBrowserService interface.
Disabling this test for IE6 for now.
Review URL: http://codereview.chromium.org/1731003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
runs. It appears to be caused by a race
condition during disconnecting from chrome frame and receiving a callback from IE (Chrome Frame).
Added checks to detect and work around this issue.
Should fix http://code.google.com/p/chromium/issues/detail?id=41980
Bug=41980
Review URL: http://codereview.chromium.org/1703003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
loaded in CF regardless of the target mime type. If CF turns around and wants to download the target, we would hit an infinite loop.
TEST=Verify that issue 40046 is resolved. OptIn urls should work with the moniker patch and downloads should not cause an infinite loop.
BUG=40046
Review URL: http://codereview.chromium.org/1715004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
into |PrefStore|.
In order to implement platformspecific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.
Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.
BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*
Review URL: http://codereview.chromium.org/1687001
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1688004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.
Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.
BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*
Review URL: http://codereview.chromium.org/1687001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
urls in the BHO.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=42155
Bug=42155
Review URL: http://codereview.chromium.org/1706003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Enable the unload event test.
BUG=40814
TEST=unload event test
Review URL: http://codereview.chromium.org/1629027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to implement platformspecific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.
Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.
BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*
Review URL: http://codereview.chromium.org/1523023
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/1682001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests.
Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|.
BUG=40259
TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.*
Review URL: http://codereview.chromium.org/1523023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1650015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
should be.
BUG=42019
TEST=X-FRAME-OPTIONS et al start to work.
Review URL: http://codereview.chromium.org/1539045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I fix them.
TEST=none
BUG=none
TBR=amit
Review URL: http://codereview.chromium.org/1633020
TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/1648017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=amit
Review URL: http://codereview.chromium.org/1633020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
functionality provided by Chrome's network stack
like the ability to override a proxy for a URL request, etc.
1. URLRequestTestHTTP.ProxyTunnelRedirectTest
2.URLRequestTestHTTP.UnexpectedServerAuthTest.
TBR=amit
Review URL: http://codereview.chromium.org/1667003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The contract of the cache stream is changed to return
S_FALSE if the data is completely read and this was the
last data notification. Adjusted unit test expectations
accordingly
BUG=none
TEST=Tests from MonikerPatchTest
TBR=ananta
Review URL: http://codereview.chromium.org/1523027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whether we should switch to Chrome, was not being
drained correctly to the delegate, resulting in the delegate continuing to wait for more data when there was none. This caused
sites like go/wave to not redirect correctly to CF.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=41365
Bug=41365
Review URL: http://codereview.chromium.org/1637017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correctly to Chrome when we switch from IE to CF. In ChromeFrame
the referrer is set in the navigation manager which receives this in the IHttpNegotiate::BeginningTransaction patch. When we switch from IE
to cF via the moniker patch we receive two calls to BeginningTransaction, the first one with the referrer and the other one without the
referrer for the same URL causing the referrer to be overwritten.
Fix is to handle this case. The referrer is cleared in our BeforeNavigate notification.
I also moved some functions to chrome frame utils as part of this CL.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=41680
Bug=41680
Review URL: http://codereview.chromium.org/1653006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NavigationToRestrictedSite
TBR=ananta
Review URL: http://codereview.chromium.org/1629022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=41680
TEST=referrer test
TBR=ananta
Review URL: http://codereview.chromium.org/1631020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
set to 0x9999 in a recent CL. Correcting this
to get the IE8 builder green.
TBR=amit
Review URL: http://codereview.chromium.org/1545039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44651 0039d316-1c4b-4281-b951-d872f2087c98
|