summaryrefslogtreecommitdiffstats
path: root/chrome_frame/utils.cc
Commit message (Collapse)AuthorAgeFilesLines
* Update uses of UTF conversions in chrome_frame/, chromeos/, components/ to ↵avi@chromium.org2013-12-251-4/+5
| | | | | | | | | | | | use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/112433004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242493 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: to string16 in chrome_frame/.dbeam@chromium.org2013-12-201-3/+3
| | | | | | | | | R=grt@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/113143006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242115 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the automation code for ChromeFrame since it's not used anymore.jam@chromium.org2013-12-171-66/+0
| | | | | | | | | | | This allows us to more clearly see which automation calls are left, since that code is also deprecated and will be removed in Q1. BUG=316496,316203 R=ananta@chromium.org Review URL: https://codereview.chromium.org/117033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241349 0039d316-1c4b-4281-b951-d872f2087c98
* Sniff out IE11 version properly.grt@chromium.org2013-11-151-1/+4
| | | | | | | | | | BUG=264800 R=robertshield@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/59883014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235357 0039d316-1c4b-4281-b951-d872f2087c98
* Preparing to support fragment resolution against non-hierarchical schemeskristianm@chromium.org2013-10-241-1/+1
| | | | | | | | | | | | | Adds a new GURL::GetContent() to retrieve the text after scheme: specifically intended for use in non-hierarchical schemes (data: etc). Doing the first part of https://codereview.chromium.org/23835019/ in a preparation CL. BUG=291747 Review URL: https://codereview.chromium.org/23549039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230781 0039d316-1c4b-4281-b951-d872f2087c98
* content: Move kHttpScheme constant into content namespace.tfarina@chromium.org2013-09-151-2/+2
| | | | | | | | | | BUG=None TEST=None, no functional change. TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/23658056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223272 0039d316-1c4b-4281-b951-d872f2087c98
* content: Move kHttpsScheme constant into content namespace.tfarina@chromium.org2013-08-261-2/+2
| | | | | | | | | BUG=None TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/23112033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219495 0039d316-1c4b-4281-b951-d872f2087c98
* Added a new policy setting as well as corrisponding registry key to allow ↵joe.knoll@workday.com2013-08-211-0/+20
| | | | | | | | | | | | | | GCF users the option to disable the meta tag check. That is, the tag that websites can use to enable GCF. This way the white/black lists are fully respected by GCF. BUG=225971 TEST=Set HKEY_CURRENT_USER\Software\Google\ChromeFrame\SkipGCFMetaDataCheck to true to disable GCF on sites enabled through the meta data tag (fully respects white/black lists). Contributed by joe.knoll@workday.com TBR=joaodasilva@chromium.org,robertshield@chromium.org Review URL: https://chromiumcodereview.appspot.com/23295005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218626 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate from googleurl/ includes to url/ ones in the remaining top-level ↵tfarina@chromium.org2013-07-131-2/+2
| | | | | | | | | | | directories. BUG=229660 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/18919005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211572 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome Frame turndown prompt.grt@chromium.org2013-06-221-0/+24
| | | | | | | | | | | | Display a prompt to users informing them that Chrome Frame is going away. TBR=cpu@chromium.org BUG= TEST=visit a site rendered in GCF. notice the bar. interact with it. once it goes away, it stays away for a week. Review URL: https://chromiumcodereview.appspot.com/17153006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208093 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome_frame/.avi@chromium.org2013-06-111-3/+3
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16391006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205413 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in chrome_frame/, ↵avi@chromium.org2013-06-071-1/+1
| | | | | | | | | | | | chromeos/, cloud_print/, components/, courgette/, device/, extensions/. BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16614002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204961 0039d316-1c4b-4281-b951-d872f2087c98
* content: Move kViewSourceScheme constant into content namespace.tfarina@chromium.org2013-05-301-1/+1
| | | | | | | | | BUG=None R=thestig@chromium.org,grt@chromium.org,joi@chromium.org,eroman@chromium.org Review URL: https://chromiumcodereview.appspot.com/15950011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203241 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded base/file_util.h includes in chrome_frame, ↵thestig@chromium.org2013-05-161-1/+0
| | | | | | | | courgette, ipc, media, and net. Review URL: https://chromiumcodereview.appspot.com/14820034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200419 0039d316-1c4b-4281-b951-d872f2087c98
* Update the remaining include paths of base/string_piece.h to its new location.tfarina@chromium.org2013-04-171-1/+1
| | | | | | | | | | | string_piece.h was moved into base/strings/ in r191206 - https://chromiumcodereview.appspot.com/12982018/ TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14272007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194693 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite scoped_array<T> to scoped_ptr<T[]> in chrome_frame.dcheng@chromium.org2013-04-111-1/+1
| | | | | | | | | | | | This is a manual cleanup pass using sed for files which are not built on Linux. BUG=171111 Review URL: https://chromiumcodereview.appspot.com/14114005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193703 0039d316-1c4b-4281-b951-d872f2087c98
* Start and stop crash reporting outside of the loader lock.grt@chromium.org2013-03-141-21/+0
| | | | | | | | | | | | | Instead of using DllMain to start/stop crash reporting, it is now done by way of a specialization of a new ScopedInitializationManager template. Instances of this specialization are created on the stack in entrypoints to the DLL (for registration or to get a COM object). The lifetime of crash reporting is ordinarily bound to the lifetime of the ATL module. The exception to this is when the module is pinned, at which point crash reporting is also pinned. This change removes the breakpad_handler_dll target (by reverting http://crrev.com/70898) since it is no longer needed. BUG=163455 TEST=install chrome frame and notice that installation doesn't block for 1 minute while npchrome_frame.dll is registered. Review URL: https://chromiumcodereview.appspot.com/12521002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188207 0039d316-1c4b-4281-b951-d872f2087c98
* Rename FilePath -> base::FilePath in various toplevel directoriesbrettw@chromium.org2013-02-101-7/+8
| | | | | | Review URL: https://codereview.chromium.org/12211108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181639 0039d316-1c4b-4281-b951-d872f2087c98
* Move string tokenizer to base/strings.brettw@chromium.org2013-02-021-2/+2
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/12087091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180211 0039d316-1c4b-4281-b951-d872f2087c98
* Establish /extensions directory and move URLPattern there.aa@chromium.org2012-11-131-1/+2
| | | | | | | | | | | | | This doesn't create an extensions gyp target, or a module with a public API. It does set of DEPS rules and seems like it will make it easier for people to write correctly layered code today, while we are in transition. BUG=159265 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/11410015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167454 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing missed deallocation of pointer from ↵huangs@chromium.org2012-09-151-4/+3
| | | | | | | | | | | | FileVersionInfo::CreateFileVersionInfoForCurrentModule(). BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10910257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156952 0039d316-1c4b-4281-b951-d872f2087c98
* Share the "get CF profile dir" code between ChromeFramePlugin and ↵joi@chromium.org2012-05-031-0/+7
| | | | | | | | | | | | | chrome_frame_test_utils.h. This addresses a long-standing TODO. Cleanup is good for the soul. BUG=none Review URL: http://codereview.chromium.org/10197011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135145 0039d316-1c4b-4281-b951-d872f2087c98
* Add a setting to CF to remove 'chromeframe' from the UserAgent on a ↵robertshield@chromium.org2012-03-301-37/+69
| | | | | | | | | | | | | | per-pattern basis. Useful for testing and dealing with sites with broken UA parsing. BUG=117157 TEST=chrome_frame_tests,chrome_frame_unittests,add a ExcludeUAFromDomain key to the CF settings, add some pattern values, observe that the UA string does not contain CF. Review URL: http://codereview.chromium.org/9720001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129985 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in ProcessSingleton. These originated as candidate fixes for issue ↵joi@chromium.org2012-02-101-6/+0
| | | | | | | | | | | | | | | | | 111361, but the true fix is cpu@'s r119830. a) Unify code to retrieve HMODULE based on address in base::GetModuleFromAddress. (cpu@'s r119830 already has the fix to use the DLL's HMODULE 119830 rather than the EXE's HINSTANCE) b) Try harder to unregister the window class, by trying it first in ProcessSingleton::Cleanup, which gets called before the fast shutdown path calls ExitProcess(). Also, use correct HMODULE to unregister. c) Avoid any possibility of a race to create the message window when the Create() method is called from NotifyOtherProcessOrCreate() or from outside the class by moving the implementation of Create(), which was always called from the constructor, into the constructor and making Create() just return true or false based on the success of the work already done. BUG=111361 Review URL: http://codereview.chromium.org/9121046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121480 0039d316-1c4b-4281-b951-d872f2087c98
* Fix npchrome_frame dll lookups for shared_library builds.grt@chromium.org2012-01-201-9/+10
| | | | | | | | | | | | PathService will give back the path to base.dll, which isn't what is wanted in specific cases. For the DLL redirector, the true path to npchrome_frame must be used, primarily for testing purposes, but it's also the right thing to do. For pinnig, npchrome_frame.dll must be pinned rather than base.dll. BUG=110492 TEST=the integration tests (chrome_frame_tests.exe) cover it R=robertshield@chromium.org Review URL: http://codereview.chromium.org/9141015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118519 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-191-1/+4
| | | | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114944 Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114993 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114944 - Standardize StringToInt{,64} interface.battre@chromium.org2011-12-181-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Revert due to compile breakage on ChromeOS. These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Review URL: http://codereview.chromium.org/8921006 TBR=tedvessenes@gmail.com Review URL: http://codereview.chromium.org/8990002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114945 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-181-1/+4
| | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114944 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114929 - Standardize StringToInt{,64} interface.rsleevi@chromium.org2011-12-171-4/+1
| | | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Review URL: http://codereview.chromium.org/8921006 TBR=tedvessenes@gmail.com Review URL: http://codereview.chromium.org/8984007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114930 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-171-1/+4
| | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114929 0039d316-1c4b-4281-b951-d872f2087c98
* ake string_util::WriteInto() DCHECK() that the supplied |length_with_null| > ↵pkasting@chromium.org2011-11-291-0/+1
| | | | | | | | | | | | 1, meaning that the without-'\0' string is non-empty. This replaces the conditional code added recently that makes this case return NULL. It's easier to understand if it's simply an error to call WriteInto() in this case at all. Add DCHECK()s or conditionals as appropriate to callers in order to ensure this assertion holds. BUG=none TEST=none Review URL: http://codereview.chromium.org/8418034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112005 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move UnescapeRule into the net namespace.tfarina@chromium.org2011-11-151-1/+1
| | | | | | | | | | | BUG=64263 TEST=None R=willchan@chromium.org Review URL: http://codereview.chromium.org/8552002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110085 0039d316-1c4b-4281-b951-d872f2087c98
* Allow linker initialization of lazy instancejoth@chromium.org2011-11-151-1/+1
| | | | | | | | | | | | | | Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
* Have Chrome Frame build its .idl artifacts into a sub-folder of ↵robertshield@chromium.org2011-10-191-2/+1
| | | | | | | | | | | | SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98
* Handle UrlRequests in ChromeFrame for resource types except MAIN_FRAME and ↵ananta@chromium.org2011-10-051-0/+5
| | | | | | | | | | | | | | | | | | | | SUB_FRAME in a background worker thread. We have a new request map in ChromeFrame to keep track of these requests. We synchronize access to this map as it is accessed from multiple threads. This is an attempt to verify if the performance issues seen on CF are related to handling all HTTP requests on the IE UI thread. This is configurable via a registry DWORD value "BackgroundHTTPWorkerThread" under HKCU\Software\Google\ChromeFrame Defaults to true. Fixes bug http://code.google.com/p/chromium/issues/detail?id=98510 BUG=98510 Review URL: http://codereview.chromium.org/8115018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104168 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move UnescapeURLComponent() functions into net namespace.tfarina@chromium.org2011-10-021-1/+1
| | | | | | | | | | | BUG=64263 TEST=None R=willchan@chromium.org Review URL: http://codereview.chromium.org/8109004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103677 0039d316-1c4b-4281-b951-d872f2087c98
* Report IE 10 in histograms.grt@chromium.org2011-09-291-2/+5
| | | | | | | | | | BUG=none TEST=look for "METRICS LOG: " in Sawbuck 30 seconds after GCF starts and see what is sent for ChromeFrame.IEVersion. Review URL: http://codereview.chromium.org/8038071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103239 0039d316-1c4b-4281-b951-d872f2087c98
* Convert RenderViewContextMenu to MenuItemView.rhashimoto@chromium.org2011-07-121-45/+52
| | | | | | | | | | | | | | This CL is part of general GTK removal for ChromiumOS. Menu2 uses GTK on linux so we are replacing it with MenuItemView. Chrome Frame currently passes the context menu between processes by using the HMENU. Because MenuItemView does not use HMENU, we need to use another mechanism. This CL creates a ContextMenuModel struct that is serialized into an automation message for Chrome Frame. ContextMenuModel contains the context menu definition in-band replacing the out-of-band HMENU. BUG=chromium-os:13887 TEST=none Review URL: http://codereview.chromium.org/7167002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92182 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 1) NPAPI support from Chrome Frame and 2) Firefox/Opera/Safari tests.grt@chromium.org2011-06-291-52/+7
| | | | | | | | | | BUG=none TEST=automated testing should suffice R=ananta@chromium.org,robertshield@chromium.org Review URL: http://codereview.chromium.org/7276037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90914 0039d316-1c4b-4281-b951-d872f2087c98
* Download requests initiated in a ChromeFrame popup window opened via ↵ananta@chromium.org2011-06-071-11/+5
| | | | | | | | | | | | | | window.open should be reissued in the current navigation context. We use the attach external tab URL prefix as a cue to identify whether the navigation should be reissued in a new window. Fixes bug http://code.google.com/p/chromium/issues/detail?id=84235 BUG=84235 Review URL: http://codereview.chromium.org/7033061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88230 0039d316-1c4b-4281-b951-d872f2087c98
* Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h.tfarina@chromium.org2011-04-121-14/+13
| | | | | | | | | | | | | | | | | Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76880 - ChromeFrame would fail to upload POST data to the server if ↵ananta@chromium.org2011-03-041-9/+30
| | | | | | | | | | | | | | | | | | | | | | | the webserver requested NTLM authentication. This is due to a bug in urlmon on IE6 and IE7 which manifests itself when the post data is passed to urlmon as an IStream. Fix is to pass in the uploaded data as a HGLOBAL. We always pass in a copy of the HGLOBAL which points to the posted data to urlmon. This is to have it accessible for reissuing navigation requests which target downloads. Fixes bug http://code.google.com/p/chromium/issues/detail?id=62687 BUG=62687 TEST=manually at this point. As we need a server which supports NTLM authentication like IIS. Review URL: http://codereview.chromium.org/6603006 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/6626008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76886 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame would fail to upload POST data to the server if the webserver ↵ananta@chromium.org2011-03-041-30/+9
| | | | | | | | | | | | | | | | | | | | requested NTLM authentication. This is due to a bug in urlmon on IE6 and IE7 which manifests itself when the post data is passed to urlmon as an IStream. Fix is to pass in the uploaded data as a HGLOBAL. We always pass in a copy of the HGLOBAL which points to the posted data to urlmon. This is to have it accessible for reissuing navigation requests which target downloads. Fixes bug http://code.google.com/p/chromium/issues/detail?id=62687 BUG=62687 TEST=manually at this point. As we need a server which supports NTLM authentication like IIS. Review URL: http://codereview.chromium.org/6603006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76880 0039d316-1c4b-4281-b951-d872f2087c98
* Download requests in ChromeFrame which occur in response to a POST request ↵ananta@chromium.org2011-02-281-10/+52
| | | | | | | | | | | | | | | | | | | | | | need to pass the post data as well while reissuing the navigation. This ensures that a POST request is correctly sent out at all times instead of a GET request. While the assumption is that reusing the bind context would achieve this behavior, it does not appear to be true at all times. While fixing this I also found that reissuing a navigation via a NavigateWithBindCtx call causes the current chrome frame document to receive an Unload call at times, leading to the page being rendered useless after the request finishes. We should reissue the navigation on a new window to work around this problem. Fixes bug http://code.google.com/p/chromium/issues/detail?id=73985 BUG=73985 TEST=As described in the bug. Review URL: http://codereview.chromium.org/6598016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76282 0039d316-1c4b-4281-b951-d872f2087c98
* Bump up the number of simultaneous connections in IE to 6. This is done via ↵ananta@chromium.org2011-02-161-0/+33
| | | | | | | | | | | | | | | a WinInet API InternetSetOption. Fixes bug http://code.google.com/p/chromium/issues/detail?id=50328 BUG=50328 TEST=none Review URL: http://codereview.chromium.org/6480092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75162 0039d316-1c4b-4281-b951-d872f2087c98
* A number of poorly written IE BHO's crash IE if ChromeFrame is the currently ↵ananta@chromium.org2011-02-111-0/+20
| | | | | | | | | | | | | | | | | | | | | | | loaded document. This is because they expect ChromeFrame to implement interfaces like IHTMLDocument2 on the same lines as regular IE documents. Currently in ChromeFrame we patch the invoke methods of these BHO's prior to firing navigation events from ChromeFrame. However this is not enough as these objects also crash for regular navigation events fired from IE when ChromeFrame is loaded. We now don't fire navigation events for buggy BHO's if ChromeFrame is the current document. The BuggyBho handler instance is now created once for the thread. We patch when we receive navigation notifications from Chrome as before. When we receive a notification on our patched event sink we check if CF is loaded and if yes skip the call. Added helpers to chrome frame utils to check if CF is loaded in the current web browser instance. BUG=55932 TEST=none Review URL: http://codereview.chromium.org/6493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74691 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-211-1/+0
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Regkey functions return error code instead of boolamit@chromium.org2011-01-191-13/+17
| | | | | | | | | | | | | | | | | | | | | | Change the Regkey helper to consistently use and return LONG instead of bool. Fix RegKey usage all over the code base and get rid of workarounds due to lack of return value. Reviewers: brettw: everything (skip parts for other reviewers if you wish) robertshield,grt: chrome_frame, installer siggi: ceee BUG=none TEST=covered by existing tests Review URL: http://codereview.chromium.org/6090006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the ChromeFrame DownloadFromForm test failures on the IE9 builder. ↵ananta@chromium.org2011-01-151-3/+11
| | | | | | | | | | | | | | | | This test causes the latest IE9 developer preview version to crash. Reason being a change in the interface implementing the NavigateWithBindCtx2 method. BUG=none TEST=Covered by existing DownloadFromForm test. TBR=amit Review URL: http://codereview.chromium.org/6253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71532 0039d316-1c4b-4281-b951-d872f2087c98
* Move thread local stuff from base to base/threading and consistently use thebrettw@chromium.org2010-12-301-1/+1
| | | | | | | | | | | base namespace. This also fixes references to TLSSlot to base::ThreadLocalStorage::Slot. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5986012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70322 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 07:22:18 +0000