summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* 3rd try. *sigh*slightlyoff@chromium.org2010-03-2617-94/+333
| | | | | | | | | | | | | See: http://codereview.chromium.org/858003 TBR=tommi BUG=22846 TEST=On IE 8, clear the cache entirely, watch GCF launch (via task manager) Review URL: http://codereview.chromium.org/1343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42732 0039d316-1c4b-4281-b951-d872f2087c98
* Provide the chrome frame content type from tests which is what we handle in ↵tommi@chromium.org2010-03-262-4/+27
| | | | | | | | | | | | our CFUrlmonBindStatusCallback. Also check for the tls browser service flag in OnDataAvailable. TEST=Fixes BindToStorageSwitchContent and BindToStorageCacheContent BUG=39415 TBR=amit Review URL: http://codereview.chromium.org/1361003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42724 0039d316-1c4b-4281-b951-d872f2087c98
* Re-submit of GCF privacy patch in:slightlyoff@chromium.org2010-03-261-3/+2
| | | | | | | | | | | | | http://codereview.chromium.org/858003 But this time with unittests that pass. BUG=22846 TEST=run unit tests, clear caches, see original CL for more details Review URL: http://codereview.chromium.org/1343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42712 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling BindToStorageSwitchContent while I fix it.tommi@chromium.org2010-03-261-1/+3
| | | | | | | | TBR=ananta BUG=39415 Review URL: http://codereview.chromium.org/1379002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42710 0039d316-1c4b-4281-b951-d872f2087c98
* Don't assume that the mime type for documents that mshtml rejects is CF(!)tommi@chromium.org2010-03-262-9/+14
| | | | | | | | | TEST=If a web site reports a content type that mshtml cannot render (e.g application/text, application/pdf etc) we didn't have a check for our mime type. BUG=none Review URL: http://codereview.chromium.org/976007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42706 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to see if this fixes chrome frame unit test failures.ananta@chromium.org2010-03-2516-330/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42684 - Implements IDeleteBrowsing history and moves the GCF profile into the IE TIF directory for nonpriv mode users on IE < 8. Implementation notes: Earlier work enabled InPrivate browsing detection and mapped it to creation of an incognito profile instance.Privacy features and how they operate with this change: "Delete Browsing History": IE 6 & 7: all history (including databases) is deleted if cache is cleared *WITHOUT* an active Chrome process holding references to the profile resources. If GCF is rendering a page when the cache is cleared, history *WILL NOT* be deleted on the GCF side, however GCF will continue to operate and IE will remove all other history artifacts as usual. IE 8: GCF cache is cleared in alignment with the options specified by the user. Clearing Temporary Internet Files may destroy the profile entirely, and so we need to consider not moving the GCF profile on IE 8. "InPrivate Filtering": IE 8 (only): more testing required. "InPrivate Browsing": IE 8 (only): pages rendered in GCF *after* entering InPrivate mode are not persisted to disk (use an incognito wrapper on the specified profile). Currently displayed pages are not effected by the switch, although refreshing them will invoke the new behavior. Generally speaking, BHO's are disabled by IE 8 while in InPrivate mode, so entering this state is wonky to begin with but we handle it as well as can be expected. BUG=22846 TEST=On IE 8, clear the cache entirely, note GCF entries in DbgView (better tests coming) Review URL: http://codereview.chromium.org/858003 TBR=slightlyoff@chromium.org Review URL: http://codereview.chromium.org/1353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42691 0039d316-1c4b-4281-b951-d872f2087c98
* Implements IDeleteBrowsing history and moves the GCF profile into the IE TIF ↵slightlyoff@chromium.org2010-03-2516-94/+330
| | | | | | | | | | | | | | | | | | | | | | | | | | | | directory for non-priv mode users on IE < 8. Implementation notes: Earlier work enabled InPrivate browsing detection and mapped it to creation of an incognito profile instance.Privacy features and how they operate with this change: "Delete Browsing History": IE 6 & 7: all history (including databases) is deleted if cache is cleared *WITHOUT* an active Chrome process holding references to the profile resources. If GCF is rendering a page when the cache is cleared, history *WILL NOT* be deleted on the GCF side, however GCF will continue to operate and IE will remove all other history artifacts as usual. IE 8: GCF cache is cleared in alignment with the options specified by the user. Clearing Temporary Internet Files may destroy the profile entirely, and so we need to consider not moving the GCF profile on IE 8. "InPrivate Filtering": IE 8 (only): more testing required. "InPrivate Browsing": IE 8 (only): pages rendered in GCF *after* entering InPrivate mode are not persisted to disk (use an incognito wrapper on the specified profile). Currently displayed pages are not effected by the switch, although refreshing them will invoke the new behavior. Generally speaking, BHO's are disabled by IE 8 while in InPrivate mode, so entering this state is wonky to begin with but we handle it as well as can be expected. BUG=22846 TEST=On IE 8, clear the cache entirely, note GCF entries in DbgView (better tests coming) Review URL: http://codereview.chromium.org/858003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42684 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for grabbing full dumps from chrome in ChromeFrame reliability ↵ananta@chromium.org2010-03-252-0/+6
| | | | | | | | | | test runs. This is only done if ChromeFrame is running in headless mode. Review URL: http://codereview.chromium.org/1346003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42677 0039d316-1c4b-4281-b951-d872f2087c98
* Not freeing the cached request data when we get OnHttpEquiv(done==TRUE) and ↵tommi@chromium.org2010-03-251-4/+9
| | | | | | | | | | | | | the browser is tagged for CF navigation. I found that if I load a CF page, then go to the address bar and press enter, we will actually get both OnHttpEquiv(done==false) and then followed by OnHttpEquiv(done==TRUE) even though we kicked off a new navigation in between. When this happened we would clear the cache in OnHttpEquiv(done==true) and subsequently we'd have to go to the network to fetch the content once CF is instantiated. TEST=See description. BUG=none Review URL: http://codereview.chromium.org/1330001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42675 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a race issue when chrome decides that a request needs to be ↵tommi@chromium.org2010-03-258-54/+88
| | | | | | | | | | | | | | downloaded by the host browser. Before the request could under some circumstances be terminated before we handed it over to the host for download. In such cases we would just drop the request and not download anything. TEST=Fixes flakyness of _some_ download scenarios. This is only a part of a fix needed for the related bug. BUG=36694 Review URL: http://codereview.chromium.org/1240004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42673 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the disable metrics command line flag, which is no longer used forbrettw@chromium.org2010-03-252-3/+2
| | | | | | | | | | | | | | anything. This flag was leftover from initial product development when there was no opt-in preference for enabling the metrics service. The only user was a ChromeFrame unit test which I modified to use a different one that has the same effect. BUG=none TEST=none Review URL: http://codereview.chromium.org/1290004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42651 0039d316-1c4b-4281-b951-d872f2087c98
* Sidestep a race in GoogleUrl by forcing initialization of the offending ↵siggi@chromium.org2010-03-251-0/+17
| | | | | | | | | | | pointer during DLL loading. BUG=38484 TEST=none Review URL: http://codereview.chromium.org/1233006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42619 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r42473. Add a delegate to CookieMonster and broadcast notifications ↵jochen@chromium.org2010-03-251-1/+1
| | | | | | | | | | | | | | about changes to cookies. This change will allow implementing the experimental cookie extension API, specifically the cookies.onChaned event BUG=none TEST=net_unittests TBR=jochen@ Review URL: http://codereview.chromium.org/1287001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42586 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame referrer test is not flaky anymore.ananta@chromium.org2010-03-251-2/+1
| | | | | | | | Bug=34812 Review URL: http://codereview.chromium.org/1238007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42564 0039d316-1c4b-4281-b951-d872f2087c98
* Support sending a sliced file in chromium.jianli@chromium.org2010-03-241-2/+6
| | | | | | | | | BUG=none TEST=The WebKit Layout test. Review URL: http://codereview.chromium.org/594036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42559 0039d316-1c4b-4281-b951-d872f2087c98
* Completing Chrome Frame localization by adding the resource script ↵robertshield@chromium.org2010-03-247-30/+28
| | | | | | | | | | | containing the dialog template to Chrome's generated_resources.grd. Associated changes in CF to call _AtlBaseModule.SetResourceInstance to get it to load dialog templates from a resource dll. BUG=24305 TEST=The Find in page dialog in full tab Chrome Frame is localized. Review URL: http://codereview.chromium.org/1293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42543 0039d316-1c4b-4281-b951-d872f2087c98
* Make (&CGID_Explorer, SBCMDID_MIXEDZONE) command more sane.stoyan@chromium.org2010-03-244-10/+65
| | | | | | | Add test for navigation to sites in restricted sites zone. Review URL: http://codereview.chromium.org/1217001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42484 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42473 - Add a delegate to CookieMonster and broadcast notifications ↵dhollowa@chromium.org2010-03-241-1/+1
| | | | | | | | | | | | | | | | about changes to cookies. This change will allow implementing the experimental cookie extension API, specifically the cookies.onChanged event BUG=38398 TEST=net_unittests Review URL: http://codereview.chromium.org/1023004 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/1256003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42478 0039d316-1c4b-4281-b951-d872f2087c98
* Add a delegate to CookieMonster and broadcast notifications about changes to ↵jochen@chromium.org2010-03-241-1/+1
| | | | | | | | | | | | | cookies. This change will allow implementing the experimental cookie extension API, specifically the cookies.onChanged event BUG=38398 TEST=net_unittests Review URL: http://codereview.chromium.org/1023004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42473 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple resource loader to Chrome Frame that is capable of finding, ↵robertshield@chromium.org2010-03-246-35/+222
| | | | | | | | | | | | | | | loading and extracting resources from the Chrome locale DLLs. Add the Chrome Frame resource strings to the Chrome .grds so they get built directly into the Chrome locale dlls. There is one remaining todo here, which is to load the dialog template into a grd + rc somewhere (probably in generated_resources.grd) and then get CF to load dialog templates from a different module. Will do that in another patch. BUG=24305 TEST=Chrome Frame when loaded on machines whose locales are not US English will display strings appropriate to those locales. Review URL: http://codereview.chromium.org/1240001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42423 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for HEAD requests.tommi@chromium.org2010-03-232-4/+56
| | | | | | | | | TEST=Http HEAD requests are now supported for IE. BUG=none Review URL: http://codereview.chromium.org/1186002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42382 0039d316-1c4b-4281-b951-d872f2087c98
* Reimplementation of FunctionStub to avoid rewriting potentially executing ↵siggi@chromium.org2010-03-238-248/+813
| | | | | | | | | | | | | code for a slight improvement in thread safety. Make VTABLE patching treadsafe to the extent possible. As-is it's now safe against itself running on other threads at lease, as well as against other similar implementations, though the inherent VM operation race is resolved by retrying. BUG=27415 TEST=Included unittests. Review URL: http://codereview.chromium.org/992008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42381 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42366 - Allow TabContentsDelegate classes to specify whether InfoBars ↵joi@chromium.org2010-03-239-123/+45
| | | | | | | | | | | | | | | | are enabled. Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer. BUG=2444936 Patch contributed by ericdingle@google.com Original review at http://codereview.chromium.org/890005 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/1205001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42378 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame referrer test which was flaky due to incorrect http header ↵ananta@chromium.org2010-03-233-14/+11
| | | | | | | | | | | | | | | | | | | | | | | | | parsing. To pass the referrer to Chrome during navigation we were converting normalized HTTP headers which are terminated with \r\n to raw headers and attempting to parse them. Converting to raw headers basically replaces \r\n with the NULL terminator which causes the parsing to fail as a result of which we fail to retrieve the referrer. Fix is to not convert the headers to raw and just parse the orignal headers. The other change is to only flag success or failure in the referrer frame test if we are running in Chrome. This page loads initially in IE as well due to the vagaries of the http equiv patch. Flagging an error if we don't find a referrer basically causes the test to fail. This should fix http://code.google.com/p/chromium/issues/detail?id=34812 Will remove the flaky attribute on the ChromeFrame Referrer test in a subsequent CL if all goes well. Bug=34812 Review URL: http://codereview.chromium.org/1128013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42372 0039d316-1c4b-4281-b951-d872f2087c98
* Allow TabContentsDelegate classes to specify whether InfoBars are enabled.joi@chromium.org2010-03-239-45/+123
| | | | | | | | | | | Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer. BUG=2444936 Patch contributed by ericdingle@google.com Original review at http://codereview.chromium.org/890005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42366 0039d316-1c4b-4281-b951-d872f2087c98
* Also switching the default of the tests to default to the moniker patch.tommi@chromium.org2010-03-231-3/+3
| | | | | | | | | | TEST=Switches tests to default PatchProtocols=2. BUG=none TBR=amit Review URL: http://codereview.chromium.org/1147008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42309 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the moniker patch by default.tommi@chromium.org2010-03-231-1/+1
| | | | | | | | | | TBR=amit BUG=none TEST=This enables PatchProtocols=2 by default. Review URL: http://codereview.chromium.org/1171001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42294 0039d316-1c4b-4281-b951-d872f2087c98
* When ChromeFrame is running in privileged mode, we should fail the ↵ananta@chromium.org2010-03-224-5/+27
| | | | | | | | | | | | | IAuthenticate::Authenticate method to prevent an authentication dialog from being displayed by IE. This CL passes this information to the Url request manager which in turn passes this to the requests. Review URL: http://codereview.chromium.org/1153006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42275 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for IE View->Privacy. To support this menu option the active ↵ananta@chromium.org2010-03-1910-16/+302
| | | | | | | | | | | | | | | | | | | | | | | document now implements the Exec command for the CGID_ShellDocView group and command id 75. We invoke the DoPrivacyDlg function exported by shdocvw and pass in our implementation of the IEnumPrivacyServices interface. The actual privacy data is gathered and maintained by the UrlmonUrlRequestManager. If we detect a privacy violation we notify the shell browser via the ITridentService2::FirePrivacyImpactedStateChange function which ensures that IE displays the privacy icon. Thanks to stoyan for his help in getting this done. I will add tests in a followup CL. Fixes bug http://code.google.com/p/chromium/issues/detail?id=25479 Bug=25479 Review URL: http://codereview.chromium.org/1127003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42113 0039d316-1c4b-4281-b951-d872f2087c98
* Fix top crashers in the latest build.amit@chromium.org2010-03-192-2/+4
| | | | | | | | | | | Fixes crashes due to NavigationManager instance being NULL. TBR=tommi BUG=38602,38603 Review URL: http://codereview.chromium.org/1100006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42083 0039d316-1c4b-4281-b951-d872f2087c98
* Don't access front() if the queue is empty.tommi@chromium.org2010-03-191-1/+1
| | | | | | | | | TEST=This fixes a crash that I ran into when testing CF. I was using this page: http://testbed.nicon.nl/googlechrome/testcase_googlechrome.asp?cnt=plus BUG=38547 Review URL: http://codereview.chromium.org/1107005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42054 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash with the IMoniker::BindToObject patch in ChromeFrame which ↵ananta@chromium.org2010-03-191-32/+37
| | | | | | | | | | | | | occurs during View Source. The crash occurs because we don't have a NavigationManager instance. Fix is to just call the original BindToObject method and bail. Review URL: http://codereview.chromium.org/1133003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42044 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FullTabModeIE_MenuSaveAs as it hangs the Chrome Frame tests.jhawkins@chromium.org2010-03-181-1/+2
| | | | | | | | | TBR=thestig BUG=38566 TEST=none Review URL: http://codereview.chromium.org/1096005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42021 0039d316-1c4b-4281-b951-d872f2087c98
* Verify the URL in address baramit@chromium.org2010-03-181-29/+81
| | | | | | | | | | | | | | | | | | Make sure that the URL in the address bar is really the one loaded in chrome under different types of navigations. Part 1 of the checkin covering following cases: - Basic switch - Back/forward - URL fragment navigation - New window (with different protocols about: view-source etc.) BUG=34676 TEST=modified a bunch of existing full tab mode tests Review URL: http://codereview.chromium.org/1044003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41993 0039d316-1c4b-4281-b951-d872f2087c98
* chrome_frame_net_test now depends on net_test_support after r41856.wtc@chromium.org2010-03-171-0/+1
| | | | | | | | | TBR=eroman BUG=none TEST=none Review URL: http://codereview.chromium.org/1051004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41866 0039d316-1c4b-4281-b951-d872f2087c98
* Move cert_test_util.{h,cc} and ssl_test_util.{h,cc} to thewtc@chromium.org2010-03-171-0/+1
| | | | | | | | | | | net_test_support build target. R=eroman BUG=none TEST=no build errors Review URL: http://codereview.chromium.org/1047003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41856 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unused chrome frame resources and merge things into a single .grd ↵robertshield@chromium.org2010-03-174-48/+3
| | | | | | | | | | | file in preparation for localizing Chrome Frame. BUG=24305 TEST=none Review URL: http://codereview.chromium.org/1055002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41835 0039d316-1c4b-4281-b951-d872f2087c98
* IE6 would not switch to ChromeFrame if the url being navigated to contained ↵ananta@chromium.org2010-03-164-3/+39
| | | | | | | | | | | | | | | | | | | | | an anchor. This is presumably because from IE6's perspecive nothing changed. To workaround this issue, we stash the complete url away in the navigation manager and remove it from the URL being navigated to. When the Chrome active document loads we read the actual url from the navigation manager and initiate a navigation to this URL. There is one issue with this approach though. The actual URL in the address bar in IE6 does not contain the anchor tag. Will address that in a follow up CL. This fixes bug http://code.google.com/p/chromium/issues/detail?id=38265 Bug=38265 Test=Covered by existing ChromeFrame anchor URL navigation tests. Review URL: http://codereview.chromium.org/1022003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41776 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome frame should use "parentNode" instead of "parentElement" to get the DOMrogerta@chromium.org2010-03-161-1/+1
| | | | | | | | | | | | parent of the plugin, since this is more compatible. Also, "parentElement" no longer works in FF3.6. BUG=0 TEST=n/a Review URL: http://codereview.chromium.org/1033001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41754 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an automation message to retrieve the list of enabled extensions, and ↵joi@chromium.org2010-03-169-1/+201
| | | | | | | | | | | CF bindings for it. TEST=unit test to follow BUG=none Review URL: http://codereview.chromium.org/901002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41667 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeFrame back forward test failures on the builder by reverting ↵ananta@chromium.org2010-03-161-6/+6
| | | | | | | | | | | | | to the original mock specifications. These test still fail on my machine. Will debug that and submit a fix in a subsequent CL. TBR=amit Review URL: http://codereview.chromium.org/1027001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41665 0039d316-1c4b-4281-b951-d872f2087c98
* When ChromeFrame switches to IE on receiving the OnHttpEquiv notification ↵ananta@chromium.org2010-03-153-11/+128
| | | | | | | | | | | | | | | | | | | | | | | | | | indicating the presence of a meta tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end up assuming that a top level navigation is actually an embedded frame. Attempting another approach to detect the dummy IWebBrowser2 iframe instances which mshtml creates for top level navigations which results in the IE to Chrome switch not working reliably. The location for these dummy browsers is set to about:blank. We now check for the same and ignore these. I have added comments in the code indicating why we are doing this and the cases where it could break. It should be fine for most common cases as this code is only hit when the page has a meta tag. Will revisit this. This fixes http://code.google.com/p/chromium/issues/detail?id=36825 Bug=36825 Test=Covered by unit test. Review URL: http://codereview.chromium.org/911003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41645 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the referrer test as flaky again. It's failing on the build bot but ↵tommi@chromium.org2010-03-151-4/+5
| | | | | | | | | | | I can't repro it locally :-( TBR=ananta BUG=none Review URL: http://codereview.chromium.org/999001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41611 0039d316-1c4b-4281-b951-d872f2087c98
* More integration with host (InternetExplorer) popup blocker.stoyan@chromium.org2010-03-152-4/+35
| | | | | | | BUG=34823 Review URL: http://codereview.chromium.org/907005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41595 0039d316-1c4b-4281-b951-d872f2087c98
* Fix #1 for multiple request issue (both POST and GET) after activating the ↵tommi@chromium.org2010-03-1224-263/+2534
| | | | | | | | | | | | | | | | | | | | | onhttpequiv approach. There's a ton going on here. Brief summary: I'm introducing a caching layer for top level page requests that we then use again when switching the document from mshtml to cf. Also in this change list: * Removing the previous way of shifting the document moniker over to the worker thread when a new chrome document is created. Instead we use a request cache object. * Refactoring the part of the Bho class that offered access to it via TLS. This was needed for better testability but also makes (imho) the separation clearer and will possibly help in the future if we don't have a Bho object. * Added a bit of logging that I'd prefer to keep in there until we're confident enough with onhttpequiv. * Enabling two previously disabled tests (the ones I added for multiple requests) * Adding several more unit tests for the new code. Review URL: http://codereview.chromium.org/668187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41495 0039d316-1c4b-4281-b951-d872f2087c98
* Move metrics api to the experimental name space.rogerta@chromium.org2010-03-121-1/+0
| | | | | | | | | BUG=0 TEST=n/a Review URL: http://codereview.chromium.org/899003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41487 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting due to two broken tests: FullTabModeIE_SubIFram and ↵ericu@google.com2010-03-124-140/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | FullTabModeIE_UnloadEventTest. Revert 41463 - When ChromeFrame switches to IE on receiving the OnHttpEquiv notification indicating the presence of a meta tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end up assuming that a top level navigation is actually an embedded frame. To work around this we now maintain a pending navigation count in BeforeNavigate2, which is decremented in NavigateComplete2 and NavigateError. We perform the check for an embedded document only if the pending navigation count is greater than 1. This fixes http://code.google.com/p/chromium/issues/detail?id=36825 The other change made is to add a delay of 100ms in SendString between each character to better reflect actual timing for real user input. Bug=36825 Review URL: http://codereview.chromium.org/837008 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/877009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41477 0039d316-1c4b-4281-b951-d872f2087c98
* When ChromeFrame switches to IE on receiving the OnHttpEquiv notification ↵ananta@chromium.org2010-03-124-10/+140
| | | | | | | | | | | | | | | | | | | | | | | indicating the presence of a meta tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end up assuming that a top level navigation is actually an embedded frame. To work around this we now maintain a pending navigation count in BeforeNavigate2, which is decremented in NavigateComplete2 and NavigateError. We perform the check for an embedded document only if the pending navigation count is greater than 1. This fixes http://code.google.com/p/chromium/issues/detail?id=36825 The other change made is to add a delay of 100ms in SendString between each character to better reflect actual timing for real user input. Bug=36825 Review URL: http://codereview.chromium.org/837008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41463 0039d316-1c4b-4281-b951-d872f2087c98
* Heuristically avoid reporting crashes during DLL loading.siggi@chromium.org2010-03-125-18/+117
| | | | | | | | | | | Cleanup white space as requested by Robert in CL 882001. BUG=31980 TEST=Unittests in this change. Review URL: http://codereview.chromium.org/872004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41367 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-114-6/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 09:12:22 +0000