| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
histogram. The histogram
macros basically instantiate a static Histogram instance which is then tracked. The static initialization
is not thread safe and thus could cause a crash if there is a race between multiple threads trying
to access the object at the same time.
Fix based on a discussion with Jim is to add thread safe versions of the macros we use for ChromeFrame.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=37470
Bug=37470
Review URL: http://codereview.chromium.org/669135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
has a prefix like
gcf:attach_external_tab&. When the ExternalTabContainer receives an updated navigation state
it passes this off to IE, where we look for the IWebBrowserEventSvc interface to fire navigation events
which cause IE to update the address bar, etc. However this interface does not exist on IE6.
The IDocObjectservice interface is available on IE6 which provides the functionality we need.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=33381
Bug=33381
Review URL: http://codereview.chromium.org/668033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored code to monitor windows so that it could be used with
our mock to watch for dialogs and chrome windows. Added new tests
for 'Page Info', 'Dev Tools' and 'Save As' menu options.
BUG=34673
TESTS=newly added
Review URL: http://codereview.chromium.org/667005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buttons on a link.
The right click would run the TrackPopupMenuEx API which runs a system modal loop and the left click
would cause the current document to be destroyed causing a crash on return while accessing member
variables on a destroyed object.
Fix is to grab a reference on the current active document while handling the context menu event to protect
against us getting destroyed in the context of the TrackPopupMenuEx call.
We also need to NULL check the automation_client_ member in ChromeFramePlugin as this could be detached
from the existing active document and attached to the new active document instance which comes up to
handle the link navigation.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=37220
Bug=37220
Review URL: http://codereview.chromium.org/664009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661464
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factor out the common expectations for navigations in macros so as
to avoid code duplication and make tests more readable.
Next step is probably to create a testing::ExpectionSet and use
functions instead of macros.
BUG=none
TEST=all the modified tests
Review URL: http://codereview.chromium.org/661390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24184
TEST=open page with GCF and with Trident, note same 2px inset border on content in both cases.
Review URL: http://codereview.chromium.org/661330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
debug it.
Bug=37231
TBR=amit
Review URL: http://codereview.chromium.org/660401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
expectation before the
testing::InSequence specification and getting rid of the duplicate FileDownload expectations.
TBR=amit
Review URL: http://codereview.chromium.org/661385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we always read the cookies from
the host browser when the renderer requests them. This also cleans up the mess with the host network stack
code parsing cookies from the host looking for persistent cookies.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=34151
Bug=34151
Test=Covered by existing host network stack tests and chrome frame cookie tests.
Review URL: http://codereview.chromium.org/661290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=37204
TBR=amit
Review URL: http://codereview.chromium.org/660386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and a dlog to see when we decide that a request is a subframe request.
TEST=Unit test is provided.
BUG=none
Review URL: http://codereview.chromium.org/660289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=iyengar
TEST=none
Review URL: http://codereview.chromium.org/660285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ananta
Review URL: http://codereview.chromium.org/661258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check validity of existing document soite before QI for
doc host handler.
BUG=37008
TEST=none
TBR=ananta
Review URL: http://codereview.chromium.org/660255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=amit
TEST=fixes one of the top crashes in the lastest release.
BUG=36985
Review URL: http://codereview.chromium.org/661256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If one tries to upload a file that one doesn't have read access to,
the browser livelocks. It tries to read from the file, gets nothing
but spins forever because it knows that it hasn't finished reading.
To address this, firstly we add a check at stat() time to make sure
that we can read the file. However, this doesn't take care of the case
where the access() call was incorrect, or the permissions have changed
under us. In this case, we replace the missing file with NULs.
(Land attempt three: first in r39446, reverted in r39448. Second in
r39899, reverted in r39901.)
http://codereview.chromium.org/541022
BUG=30850
TEST=Try to upload a file that isn't readable (i.e. /etc/shadow). The resulting upload should be a 0 byte file.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
IInternetProtocolSink_PatchInfo one.
TEST=Should be no change. If there is a regression because of this, it would be in the form of failing to switch to CF for pages that have the CF meta tag.
BUG=none
Review URL: http://codereview.chromium.org/660032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specific DLL,
instead of relying on CoInitialize/CoUninitialize to load and unload at least one DLL.
Add minidump_test as a dependency to make sure it's always built.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://docs.google.com/View?id=dd4ngnpz_0dpsb8n96 for API proposal.
BUG=0
TEST=See unit tests as part of this CL
Review URL: http://codereview.chromium.org/657037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crashes when object is destroyed and there is tasks in the queue.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
channel getting destroyed
and it being referenced in the background thread.
Fix is to use the underlying IPC::Channel pointer passed to the message filter when the
filter gets Added to send and receive messages. This ensures that the SyncChannel is not used across
threads.
Review URL: http://codereview.chromium.org/661109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
cygwin.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The test is disabled until we fix the actual problem.
TEST=n/a
BUG=33332
Review URL: http://codereview.chromium.org/661017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Needed for the CF reliability builder)
Remove the now-unused chrome_frame_builder target in all.gyp.
BUG=29451
TEST=chrome_frame_reliability_tests.exe shows up at http://chrome-web/buildbot/snapshots/chromium-rel-xp/
Review URL: http://codereview.chromium.org/658007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shutdown. This would occur
when we received a redirect notification on an aborted request. We would end up aborting the request twice
which would cause the UrlmonUrlRequest object to be destroyed twice by IE, thus resulting in a junk reference
in the request map.
Fix is to bail out in the IBindStatusCallback::OnProgress callback if it is invoked for an aborted request.
Part of the fix for http://code.google.com/p/chromium/issues/detail?id=34687
The other issue being fixed is a crash in ChromeFrame caused if the UrlmonUrlRequest object gets destroyed
in the context of UrlmonUrlRequest::StartAsyncDownload. The crash would occur while accessing members of the
object on return from this function. Fix is to grab a reference on this object in the context of the call.
Bug=34687
Review URL: http://codereview.chromium.org/652202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dll.
BUG=29451
TEST=Reliability tests can be staged more easily on the vm tests.
Review URL: http://codereview.chromium.org/656021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
threads in IE.
This causes the histogram snapshots to get corrupted.
Fix is to synchronize access to the function which gathers these histograms.
Fixes bugs http://code.google.com/p/chromium/issues/detail?id=36500
http://code.google.com/p/chromium/issues/detail?id=36510
Bug=36500,36510
Review URL: http://codereview.chromium.org/657023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Got a crash while testing something else on a VM and my investigation led to that potential problem.
BUG=0
TEST=Try loading Chrome Frame on very slow machines (like a VM).
Review URL: http://codereview.chromium.org/651036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FullTabModeIE_ContextMenuBackForward
FullTabModeIE_ContextMenuReload
FullTabModeIE_ContextMenuViewSource
FullTabModeIE_KeyboardBackForwardTes
TBR=ananta
BUG=26549
TEST=none
Review URL: http://codereview.chromium.org/650041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to chrome/browser.
This is a part of an effort to remove bad dependency of chrome/common
on chrome/browser.
TEST=unit_tests and ui_tests, just moving code
BUG=none
Review URL: http://codereview.chromium.org/621004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
towards redoing the Callback interfaces.
Added and removed includes as needed.
BUG=35223
TEST=trybots
Review URL: http://codereview.chromium.org/646061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fails.
Bug=34812
TBR=tommi
Review URL: http://codereview.chromium.org/646073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Grabbing the referrer header when the request is made and not in BeforeNavigate2.
The request headers aren't always available in BeforeNavigate2. Mshtml provides these
headers in IHttpNegotiate::BeginningTransaction, which is where we now grab them.
There was a race in chrome_frame_automation.cc where we use std::string to store the referrer url and then access that string from different threads. This was causing the referrer URL to be missing at some times and at other times be sent over to chrome as bad string (e.g. containing embedded nulls) and subsequently be deemed an invalid URL and dropped.
TEST=Fixes referrer header flakyness.
BUG=34812
Review URL: http://codereview.chromium.org/646013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test only needs simple HTML
files with the meta tag to switch to Chrome. Removed the fulltab_forward_page.html amd fulltab_back_page.html
and replaced them with the sub_frame1.html and sub_frame2.html
Other changes include to use SetFocusToChrome helper function to give focus to the Chrome renderer window instead
of sending a WM_LBUTTONDOWN and to use ComStackObjectWithUninitialize mock class to ensure that things get cleaned
up correctly.
Review URL: http://codereview.chromium.org/608033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
document, to ensure that the following
accelerators navigate backwards and forwards in IE history.
1. VK_BACK and Alt + VK_LEFT to navigate back.
2. Shift + VK_BACK and Alt + VK_RIGHT to navigate forward.
This CL adds support for this. We load the accelerator table in our Active document and when we receive an
accelerator from Chrome, we first call the Windows API TranslateAccelerator to translate any accelerators
and then continue with the default handling. Added handlers for navigating back and forward.
Test=covered by unit test.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=35629
Bug=35629
Review URL: http://codereview.chromium.org/600117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For now this works for IE regularly (no cf in the picture) and triggers a download in a new window.
It is disabled since support for this scenario is not yet ready in CF.
I'm adding a couple of things to WebBrowserEventSink:
- A way to gracefully close IE. This way we allow IE to quit on its own and don't go the "kill" route unless necessary.
This should help with reducing cases where we've killed IE and the next time it is started it presents the user with an "IE crashed" dialog which could cause subsequent unit tests to fail.
Another thing this adds is support for the OnQuit event that can be useful to add to unit tests as an expected event.
- A new OnFileDownload event. I also updated several tests to expect this event.
TEST=Adds a unit test.
BUG=none
Review URL: http://codereview.chromium.org/569011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
format %ls.
TBR=tommi
Review URL: http://codereview.chromium.org/611003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome (if chrome itself wasn't installed) or launching the installed chrome
and not the one from the build directory.
TEST=Run *WidgetModeChrome_* unit tests.
BUG=35868
Review URL: http://codereview.chromium.org/606066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/593111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The driving rationale for this change was to prevent choosing an AuthHandler when it
is not supported on the system due to a missing runtime component (such as not being
able to locate a gssapi shared library when seeing a Negotiate scheme).
It also has the advantage (currently unused) of determining some per-auth-scheme properties
only the first time that a challenge for that scheme is seen (such as maximum token length for
the SSPI implementation of NTLM).
Finally, it may make unit tests easier to generate since the factory can be easily mocked.
BUG=34795
TEST=New unit test for HttpAuthHandlerDispatchFactory.
Review URL: http://codereview.chromium.org/582007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
processed as accelerators. The crash
occured in the call to IBrowserService2::v_MayTranslateAccelerator which takes in a MSG as a parameter.
This message contains the hwnd of the ChromeRenderWidgetHost. Eventually this method tries to DispatchMessage
this message to the same hwnd, which causes a crash possibly because this window is in a different process.
Fix is to switch the hwnd to the parent of the ChromeFrame ActiveX.
The other fix is to send over all keystrokes from the ExternalTabContainer instead of filtering them. With
this fix in BackSpace works correctly in IE7, i.e. it goes back in history. However the other keystrokes like
Shift Backspace, etc don't work. They are probably processed by mshtml. It appears that we may have to
prcess these accelerators in our active document and do the right thing there. That in a separate CL.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=35355
Bug=35355
Review URL: http://codereview.chromium.org/603041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
under Cygwin.
BUG=35342
TEST=in cygwin do: %> devenv /build Debug chrome.sln
Review URL: http://codereview.chromium.org/593087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=amit
Review URL: http://codereview.chromium.org/603044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored various methods to send keyboard and mouse
input. Fixed the context menu focus issue on IE7.
Improved existing tests to make them less flaky and
added 3 new tests for context menu items.
BUG=34673
TEST=new tests added
Review URL: http://codereview.chromium.org/604014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
connection failed).
Test added.
TEST=chrome_frame_net_tests
BUG=none
Review URL: http://codereview.chromium.org/593065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=35370
TBR=amit
Review URL: http://codereview.chromium.org/603022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/600032
TBR=stoyan@chromium.org
Review URL: http://codereview.chromium.org/602026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38734 0039d316-1c4b-4281-b951-d872f2087c98
|