| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
This reverts commit r66623. Some how it causes libnspr4.dll to be linked in
Chrome Frame builds.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on XP only (where there's no superfetch).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5138003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DnsCertProvenanceChecker is introduced to abstract away the action of
uploading reports. It's implemented by ChromeDnsCertProvenanceChecker
which lives in a scoped_ptr off of a URLRequestContext.
It's only active on the main context (i.e. not in incognito mode). This
might change in the future, but it's a nice, conservative choice for the
moment.
The DnsCertProvenanceChecker is plumbed all the way to SSLClientSocket
(via HttpCache) where it replaces the DnsRRResolver. Above
SSLClientSocket, it's plumbed in addition to the DnsRRResolver because
the later will end up going into SSLHostInfo in the future.
At the moment, ChromeDnsCertProvenanceCheckerContext is just a skeleton
to avoid putting too much real code in a plumbing job.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
receive the desired
content are size. To achieve this we first set the desired window styles on the web browser
and then query it for the effective width and height.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=60447
Bug=60447
Test=Covered by existing window open tests.
Review URL: http://codereview.chromium.org/5128002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
make it visible only once the content is done loading. This avoids any flicker
at startup, and fixes a bug where the chrome frame instance is removed after
a print preview.
Also added support to chrome frame to send an uninitialized ready state
when its being torn down. Did some cleanup in the chrome frame tests which
were broke the first time this change was committed.
BUG=62979
TEST=Make sure that there is no UI flicker on chrome frame startup, and make
sure that the extenions works correct after showing print preview and closing
it.
Review URL: http://codereview.chromium.org/5022003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
version.
Also fix a memory leak in the Chrome Frame automation code.
BUG=61609
TEST=Chrome.exe always loads the specified chrome.dll when run by Chrome Frame.
Review URL: http://codereview.chromium.org/5090001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pre-existing Chrome process and run tests on it. This is an addition to the low level interface underlying testing frameworks like PyAuto and WebDriver.
Normally, test frameworks communicate with Chrome over an unnamed socket pair on POSIX. The test creates the socket pair and then launches the browser as a child process, passing an open file descriptor for one end of the socket to the browser. This change adds a command line switch that, when passed to the browser, causes it to listen on a named socket instead, eliminating this parent/child process requirement. Therefore, you can potentially connect any number of tests to a preexisting browser process.
For ChromeOS, this allows you to run tests on the instance of Chrome that is launched on startup, which controls things like the login and lock screens, the battery meter, the wireless UI, etc. Currently there is no way to run tests on a pre-existing Chrome instance. Eventually this will also allow you to connect both PyAuto and WebDriver to the same Chrome instance and run both in the same test.
If you pass the browser the following command line switch:
./chrome --testing-channel=NamedTestingInterface:/path/to/file
This causes the browser to listen for incoming connections. An AutomationProxy can connect to the browser by connecting a Unix domain socket to the specified path and control the browser over the socket.
This is currently only for POSIX. Windows support will come in a future change. Also, this initial change only allows one connection; multiple connection support will come in a future change.
BUG=chromium-os:8512
TEST=Run Chrome with --testing-interface=/var/tmp/NamedTestingInterface, then run NamedInterfaceTest.BasicNamedInterface under ui_tests.
Review URL: http://codereview.chromium.org/4202004
TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/5139001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome process and run tests on it. This is an addition to the low level interface underlying testing frameworks like PyAuto and WebDriver.
Normally, test frameworks communicate with Chrome over an unnamed socket pair on POSIX. The test creates the socket pair and then launches the browser as a child process, passing an open file descriptor for one end of the socket to the browser. This change adds a command line switch that, when passed to the browser, causes it to listen on a named socket instead, eliminating this parent/child process requirement. Therefore, you can potentially connect any number of tests to a preexisting browser process.
For ChromeOS, this allows you to run tests on the instance of Chrome that is launched on startup, which controls things like the login and lock screens, the battery meter, the wireless UI, etc. Currently there is no way to run tests on a pre-existing Chrome instance. Eventually this will also allow you to connect both PyAuto and WebDriver to the same Chrome instance and run both in the same test.
If you pass the browser the following command line switch:
./chrome --testing-channel=NamedTestingInterface:/path/to/file
This causes the browser to listen for incoming connections. An AutomationProxy can connect to the browser by connecting a Unix domain socket to the specified path and control the browser over the socket.
This is currently only for POSIX. Windows support will come in a future change. Also, this initial change only allows one connection; multiple connection support will come in a future change.
BUG=chromium-os:8512
TEST=Run Chrome with --testing-interface=/var/tmp/NamedTestingInterface, then run NamedInterfaceTest.BasicNamedInterface under ui_tests.
Review URL: http://codereview.chromium.org/4202004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
current version. This may well fail on older (read non-NTFS) systems since you can't secure file mappings without a securable file system underneath.
BUG=61609
TEST=No DCHECKing at startup when running on a non-NTFS system.
Review URL: http://codereview.chromium.org/5057007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amit
Review URL: http://codereview.chromium.org/4980004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test. The errors we were seeing on the builders were transient, due to
an IID change.
I checked the last 5 runs of the 3 CF builders on the waterfall just
now, and also earlier today, and the test passes on all of these runs.
TEST=none
BUG=62636
Review URL: http://codereview.chromium.org/5070001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Windows. (Also fixed some unrelated lint errors.) With this change, l10n_util::GetApplicationLocale first checks for an override of the "configured locale" (in base::i18n) containing the list of preferred Windows UI languages. The browser triggers an override early in startup before the ApplicationLocale is determined. In effect, the browser no longer uses ICU on Windows for language detection. (This locale override mechanism is borrowed from the OS X port.)
Changes in Chrome Frame are largely a refactor, as some Win32 code in there has been moved into base/win.
Also cleaned up language selection in installer_util so that the proper language is chosen for the EULA, installer messages, and shortcuts. In so doing, replaced hand-crafted lists of supported languages with either auto-generated lists (static consts) or logic so that the addition of translations in the future doesn't require code motion (that being said, there may be reason to update the alias and/or wildcard tables in language_selector.cc). In so doing, this change unlocks Amharic, Farsi, and Swahili translations for installer messages and shortcuts.
BUG=39986,40496,26470
TEST=New MUI/Win32 calls are tested in base/win/i18n_unittest.cc. To test the overall functionality, uninstall Chrome, remove intl.app_locale user pref, switch to a supported display language (via the "Keyboards and Languages" tab of Win7's "Regional and Language" control panel, and install with { "distribution": { "require_eula": true } } in master_preferences (via -installerdata arg to setup.exe). If all goes well, both EULA and outer frame are in the same language as Windows. Also, from gwilson: "Install system-level Chrome in audit mode on a new machine, then go through the out-of-box-experience, select a language, and the in -product EULA (triggered by "require_eula" : true) and Chrome's UI should be in the language that the user selected."
Review URL: http://codereview.chromium.org/4139010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
version beacon. This will allow low integrity processes to access shared memory segment and lock and make shared memory segment read only after creation.
Also use lock names that include the hosting process.
BUG=61609
TEST=Start medium integrity Chrome Frame host running CF version X. Update CF to version Y > X. Start low integrity Chrome Frame host, observe that version X is loaded.
Review URL: http://codereview.chromium.org/5012001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4983004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builder to now run
the tests to completion and hopefully turn green.
1. CF_DownloadFileFromPost. This test expects to see a File save dialog. On IE9
the prompt to save the file is displayed as a link on the frame window.
2. WidgetModeIE_CFInstancePost, WidgetModeIE_CFInstanceRPC, WidgetModeIE_CFInstanceRPCInterna
These tests fail on IE9. Needs more investigation.
TBR=amit
Review URL: http://codereview.chromium.org/4998003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
times to
the python web server. This needs more investigation.
TBR=amit
Review URL: http://codereview.chromium.org/4945001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update the callers to append base:: in the calls to StringAppendF.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4974001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resubmit
Revert 66002 - Change the FF CEEE to create its chrome frame instance initially hidden, and
make it visible only once the content is done loading. This avoids any flicker
at startup, and fixes a bug where the chrome frame instance is removed after
a print preview.
Also added support to chrome frame to send an uninitialized ready state
when its being torn down.
BUG=62979
TEST=Make sure that there is no UI flicker on chrome frame startup, and make
sure that the extenions works correct after showing print preview and closing
it.
Review URL: http://codereview.chromium.org/4882004
TBR=rogerta@chromium.org
Review URL: http://codereview.chromium.org/4855005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=FullTabNavigationTest.TypeAnchorUrl
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/4807004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
make it visible only once the content is done loading. This avoids any flicker
at startup, and fixes a bug where the chrome frame instance is removed after
a print preview.
Also added support to chrome frame to send an uninitialized ready state
when its being torn down.
BUG=62979
TEST=Make sure that there is no UI flicker on chrome frame startup, and make
sure that the extenions works correct after showing print preview and closing
it.
Review URL: http://codereview.chromium.org/4882004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix expectations and check for locked workstation to make
tests depending on user input non-flaky.
BUG=47596,26549
TEST=FullTabUITest.CtrlN,FullTabUITest.KeyboardBackForward
Review URL: http://codereview.chromium.org/4866002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves SecurityStyle and PageType into chrome/common/ and removes the
chrome_frame dependency on chrome/browser/tab_contents/. This undoes the
temporary DEPS hack on chrome/common/.
BUG=51409
TEST=compiles
Review URL: http://codereview.chromium.org/4697005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This preference can be set either via command-line or via group policy.
BUG=53625
TEST=unittests: ConfigurationPolicyPrefStore*; net_unittests: HttpAuthHandlerNegotiateTest.*:HttpAuthGSSAPIPOSIXTest.*; manually: start Chrome with command-line switch --gssapi-library-name=XYZ and see if this results in the Chrome process loading /usr/lib/whatever/XYZ as soon as an authenticated HTTP site is encountered.
Review URL: http://codereview.chromium.org/4560001
Patch from Jakob Kummerow <jkummerow@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=62853
TBR=amit
Review URL: http://codereview.chromium.org/4696005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of outgoing
headers in ChromeFrame sub requests. The crash occurs because the current headers passed
in the BeginningTransaction are NULL.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=62853
Bug=62853
Review URL: http://codereview.chromium.org/4792002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Frame build bots, without turning them red.
BUG=62636
TEST=none
Review URL: http://codereview.chromium.org/4691006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the automation message files from chrome/test/automation to
chrome/common/. This requires a temporary override to chrome/common/DEPS until
Part 3 lands.
BUG=51409
TEST=compiles
Review URL: http://codereview.chromium.org/4758001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4660003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
all the
time.
Bug=62636
TBR=joi
Review URL: http://codereview.chromium.org/4727004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the version mismatch warning dialog. Used this in ceee/ to only show
it once per tab.
Changed the logic in Firefox to show the warning dialog even when
in privileged mode. This will mean it gets shown once per Firefox
window.
Wrote a unit test for the additional logic in ChromeFrameActivex.
To write the unit test, used com_mock.py to generate a mock of
the IChromeFramePrivileged interface. This can be extended to
generate mocks of the other CF interfaces.
Discovered duplication of np_browser_functions.h and .cc, resolved
this to a single copy (the one under chrome_frame).
Changed things around so chrome_tab.idl is built only once; this
also lets me more easily depend on it in the com_mock rule.
BUG=none
TEST=chrome_frame_unittests.exe
Review URL: http://codereview.chromium.org/4563001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
we receive
two window open notifications for the window pattern Internet Explorer*. Not clear why.
Updated the expectations of the test to account for this.
Review URL: http://codereview.chromium.org/4700003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests on a machine separate from your build machine. Useful e.g. if you
are running IE9 on your build machine, which the tests currently aren't
fully compatible with, or if you'd like to get other work done while the
tests run.
BUG=none
TEST=try out the instructions, see if they work
Review URL: http://codereview.chromium.org/4676003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
behind and would
not render any content until the user clicked on them. This is because in this context
IE8 attempts to inplace activate the object with the active document as the doc host.
We don't support in place activation and return E_NOTIMPL.
However ieframe specifically expects the return value to be OLEOBJ_E_INVALIDVERB and ends
up not sending in the other verbs like OLEIVERB_SHOW, OLEIVERB_UIACTIVATE etc leading to
this problem.
Fixes bug http://b/issue?id=3174688
Bug=3174688
Review URL: http://codereview.chromium.org/4690004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This can be useful when hosts have a pointer to the object and need to know the clsid of the implementation.
Currently it is possible to get at this via IPersistPropertyBag, but since we support IPersist directly
in our ActiveDoc implementation I think it's more consistent to support it on the ActiveX implementation as well.
BUG=none
TEST=No change.
Review URL: http://codereview.chromium.org/4669004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The name of this file is a leftover from Windows. Split the command
ids (which are used on all platforms) out, leaving just the
Windows-specific resource IDs in the original file.
TEST=compiles
Review URL: http://codereview.chromium.org/4710001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This applies only the rename of IPC::ContextMenuParams to
IPC::MiniContextMenuParams so that it doesn't conflict with ::ContextMenuParams
(defined in webkit). This is about half the original patch.
BUG=51409
TEST=compiles
Review URL: http://codereview.chromium.org/4669005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fix users of same.
BUG=none
TEST=unittests
Review URL: http://codereview.chromium.org/4517004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
perf builder.
TBR=amit
Review URL: http://codereview.chromium.org/4501002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For tests like CtrlW, CtrlN it's better to notice failures
when they execute and not run them at all if the workstation
is locked i.e. when they will certainly fail. Added a check
to do exactly that :)
BUG=none
TESTS=CtrlR, CtrlW, CtrlN, CtrlF, AltD
Review URL: http://codereview.chromium.org/4615001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ConnectExternalTab.
The ChromeFrame objects now provides an unfrozen interface called IChromeFramePrivate. This interface provides a GetSessionId() which returns the ID used by Chrome in its Tab javascript object. This ID is necessary in CEEE for its tabs management.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4467002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for Chrome Frame.
BUG=61383
TEST=Run IE with version X of CF loaded. Register version Y of CF. Run a second IE process, notice that version Y when loaded defers to version X.
Review URL: http://codereview.chromium.org/4144008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
via the context menu.
This was because the Back and Forward menu items on the context menu were disabled. The context
menu is displayed by the active document in IE and it attempts to enable/disable these items
based on entries in the IE travel log. The enabling of these items was failing as we were
incorrectly passing in the string id of these options instead of their command id equivalents
Should fix bug http://code.google.com/p/chromium/issues/detail?id=34657
Bug=34657
Test=Covered by new ChromeFrame context menu back forward test.
Review URL: http://codereview.chromium.org/4500002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread objects
in ChromeFrame as we don't control the threads on which these objects are instantiated
and thus cannot terminate them gracefully.
This should suppress the annoying DCHECKS during IE shutdown.
Review URL: http://codereview.chromium.org/4517002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=32321,37009,37087,30622
TEST=concerned tests
Review URL: http://codereview.chromium.org/4486001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Libraries that depend on other targets cause the propagation of the other targets closure of library targets to all their dependents. This was the case with chrome_frame_ie, which caused npchrome_frame to link gmock and gtest.
Best case, this will slow down the build.
Worst case we're open to regressions that ship test code, as useful as our unittests are, I don't think users have much appreciation for installing them :).
This may require another change in build\all.gyp, as building the crash tests is no longer implicit in building npchrome_frame.
Also removed the base_noicu target, as all its dependents have a dependency on base.lib, so this won't prevent ICU usage regressions.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4406001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
because the type
lib needs to be generated and included in the chrome frame binary. This may need a clobber.
Bug=61011
TBR=amit
Review URL: http://codereview.chromium.org/4445001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix conflicts like:
2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope
2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare'
Reported-by: Jeff Timanus <twiz@google.com>
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4366001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_dll. This is to avoid having non-versioned matched components in the build directory if only buildingg npchrome_frame which causes all manner of trouble.
BUG=version-mismatched binaries can reside in the build folder when building only npchrome_frame
TEST=NONE
Review URL: http://codereview.chromium.org/4288001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
be appended
twice.
Bug=none
Review URL: http://codereview.chromium.org/4249001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non chrome frame
email site to automatically logout after logging in. ChromeFrame appends the chromeframe string
to the user agent to outgoing requests initiated from IE. However this was only done in the
protocol sink patch for top level requests. Sub requests would carry the IE user agent which
in this case would cause the web server to get confused and drop the connection.
Fix is to resurrent the IHttpNegotiate vtable patch for the protocol patch as well.
Removed the code which read the patch method from the registry and turned on the moniker
or the httpequiv patch. It is unlikely that we will need this in the future. Cleaned
up the http negotiate patch by removing references to the navigation manager and the
ReportProgress patch which is not needed anymore.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=60745
Bug=60745
Review URL: http://codereview.chromium.org/4247001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64688 0039d316-1c4b-4281-b951-d872f2087c98
|