summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Fix random crashes in the ChromeFrame automation proxy mock tests. These ↵ananta@chromium.org2011-04-281-0/+6
| | | | | | | | | | | | | | | | | | | crashes occur when an ASSERTION fails in these tests which causes the ProxyFactory object instantiated at the beginning of the test suite to be destroyed. For the curious the crash occurs in the UMA sending code in ChromeFrame which attempts to dereference the ChromeFrameHistogramSnapshots pointer which has already been destroyed. It is a member of the ProxyFactory class. This crash will not occur in real life as the ProxyFactory is a global singleton in ChromeFrame. Temporary hack to not crash in the test code is to flag the crash metrics object that reporting is active which disables UMA sends to chrome. BUG=none TEST=chrome frame proxy mock tests should not crash. Review URL: http://codereview.chromium.org/6901072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83393 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Adjust dependencies to build with base.dllrvargas@google.com2011-04-262-2/+11
| | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6894040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83082 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome frame tests which regressed after my change to only route content ↵ananta@chromium.org2011-04-211-1/+3
| | | | | | | | | | | | | | | | initiated navigations back to the host browser. The regression occurred because of a check for whether the navigation type is link clicked, which is not needed anymore. Increased the timeout for ChromeFrameTestWithWebServer.FullTabModeIE_TestMultipleGet test which fails randomly on my machine and on some of the builders. BUG=none TEST=ChromeFrame tests should now pass. Review URL: http://codereview.chromium.org/6882104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82527 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the RedirectToInvalidUrl net test which started failing in ChromeFrame ↵ananta@chromium.org2011-04-201-0/+7
| | | | | | | | | | | | | | after the change to set the wininet option to not automatically follow redirects. If the server redirects to an invalid url it fails url validation in wininet and does not notify the bind status callback. We need to convert the corresponding error codes returned by wininet in OnStopBinding to the invalid url net error code as expected by chrome. BUG=none TEST=chrome frame net tests should pass Review URL: http://codereview.chromium.org/6883075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82360 0039d316-1c4b-4281-b951-d872f2087c98
* Switch back to using urlmon (from using Chrome's network stack) to upload ↵grt@chromium.org2011-04-202-261/+128
| | | | | | | | | | | metrics so as to shrink npchrome_frame.dll. This basically reverts r58538. BUG=77445 TEST=uploading metrics should still work, although this is expected to reopen issue 54419. R=ananta@chromium.org Review URL: http://codereview.chromium.org/6881018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82339 0039d316-1c4b-4281-b951-d872f2087c98
* Remove nspr remains from the gyp file.tommi@chromium.org2011-04-201-20/+0
| | | | | | | | TEST=no change. BUG=0 Review URL: http://codereview.chromium.org/6879079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82309 0039d316-1c4b-4281-b951-d872f2087c98
* Set the wininet option to not follow redirects automatically for ChromeFrame ↵ananta@chromium.org2011-04-191-0/+3
| | | | | | | | | | | | requests. This fixes the bug in ChromeFrame where the status codes read off the binding in the BINDSTATUS_REDIRECTING notification would be 0 or 200 instead of valid redirect codes. BUG=none TEST=redirects should continue to work in ChromeFrame, i.e. they should be aborted in IE and followed by Chrome. Review URL: http://codereview.chromium.org/6882051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82173 0039d316-1c4b-4281-b951-d872f2087c98
* This CL implements alternative asynchronous methods for profile and ↵altimofeev@chromium.org2011-04-191-3/+21
| | | | | | | | | | | | | preferences loading. BUG=chromium-os:11104 TEST=UserProfileGotten (see "/tmp/login-times-sent") time doesn't increase, while UI jankness decreases. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81394 (patch set <= 25), but reverted. Review URL: http://codereview.chromium.org/6716025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82096 0039d316-1c4b-4281-b951-d872f2087c98
* If the running IE8 process instance is terminated at the end of a chrome ↵ananta@chromium.org2011-04-193-0/+26
| | | | | | | | | | | | | | | frame test run, then IE brings up the session history dialog on restart which apparently causes subsequet IE server launches to fail randomly. Work around this by ensuring that the session history folder is deleted before launching IE. The documented registry value to disable session restore in IE8 does not work as expected. BUG=none TEST=chrome frame tests should pass on IE8 TBR=amit Review URL: http://codereview.chromium.org/6882036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82078 0039d316-1c4b-4281-b951-d872f2087c98
* Moved ParamTraits specializations that depend on WebKit out of ↵grt@chromium.org2011-04-151-1/+0
| | | | | | | | | | | content/common/common_param_traits and into webkit_param_traits. Also pulled some specializations out of chrome/common/render_messages and into chrome/common/common_param_traits. This is done so that the MS toolchain can succeed in discarding more code at link time. This halves the size of npchrome_frame.dll in ordinary "Release" builds. I hope for a similar reduction in official builds. BUG=77445 TEST=Everything should just work(TM). Review URL: http://codereview.chromium.org/6840044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81803 0039d316-1c4b-4281-b951-d872f2087c98
* Put back "Enable component extensions for DefaultProfile used in login ↵dpolukhin@chromium.org2011-04-151-1/+1
| | | | | | | | | | | | | screen dialogs" Initial commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=79526 BUG=chromium-os:12741 TEST=Run debug Chrome on device Review URL: http://codereview.chromium.org/6737028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81770 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 81394 (broke sync_integration_tests and clang) - This CL implements ↵altimofeev@chromium.org2011-04-131-20/+3
| | | | | | | | | alternative asynchronous methods for profile and preferences loading.BUG=chromium-os:11104TEST=UserProfileGotten (see "/tmp/login-times-sent") time doesn't increase, while UI jankness decreases.Review URL: http://codereview.chromium.org/6716025 TBR=altimofeev@chromium.org Review URL: http://codereview.chromium.org/6834021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81396 0039d316-1c4b-4281-b951-d872f2087c98
* This CL implements alternative asynchronous methods for profile and ↵altimofeev@chromium.org2011-04-131-3/+20
| | | | | | | | | | | preferences loading. BUG=chromium-os:11104 TEST=UserProfileGotten (see "/tmp/login-times-sent") time doesn't increase, while UI jankness decreases. Review URL: http://codereview.chromium.org/6716025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81394 0039d316-1c4b-4281-b951-d872f2087c98
* Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h.tfarina@chromium.org2011-04-1245-282/+287
| | | | | | | | | | | | | | | | | Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Chrome Frame's dependency on xul_runner.tommi@chromium.org2011-04-1118-2117/+32
| | | | | | Review URL: http://codereview.chromium.org/6825026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81171 0039d316-1c4b-4281-b951-d872f2087c98
* Removing command_execution_timeout_ms in favor of action_max_timeout_ms.hnguyen@chromium.org2011-04-111-0/+4
| | | | | | | R=jcivelli@chromium.org,sky@chromium.org,phajdan.jr@chromium.org,nirnimesh@chromium.org Review URL: http://codereview.chromium.org/6685099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81164 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:mergeinfo props from many files.pkasting@chromium.org2011-04-081-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6814027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80878 0039d316-1c4b-4281-b951-d872f2087c98
* Removing a test I missed when removing CEEE-specific functionality.joi@chromium.org2011-04-073-73/+1
| | | | | | | | | BUG=none TEST=chrome_frame_tests Review URL: http://codereview.chromium.org/6806020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80777 0039d316-1c4b-4281-b951-d872f2087c98
* Remove locked histogram macros since jar@chromium.org made the base macros ↵grt@chromium.org2011-04-067-64/+30
| | | | | | | | | | threadsafe in http://crrev.com/80412. BUG=none TEST=metrics should work as before Review URL: http://codereview.chromium.org/6800008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80668 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extension automation support that was used only by CEEE.joi@chromium.org2011-04-0622-818/+23
| | | | | | | | | BUG=none TEST=all automated tests pass Review URL: http://codereview.chromium.org/6756044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80626 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crashing testjoshia@google.com2011-04-062-33/+3
| | | | | | | | | | | | | | | | | | | | | | | This is not a real crash, it is caused by wrapping TestSuite::Run in an exception filter. DllRedirector test uses VerQueryValue to query version from version resource. VerQueryValue, on windows XP, takes a const pointer but tries to modify it causing access violation. So where do you fix this bug? You guessed it right: in kernel32!UnhandledExceptionFilter :) UnhandledExceptionfilter checks if the crash address belongs to a resource section of a binary and then makes it writable. If we install exception filter around VerQueryValue this does not happen and we treat it as a crashed test. solution is to remove the exception filter. This might result in tests crashing levaing around zombie IE/Firefox. We will deal with that when that happens. TEST=DllRedirectorLoadingTest.TestDllRedirection BUG=78209 Review URL: http://codereview.chromium.org/6792053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80623 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Detect browser crashes on shutdown in UI tests. phajdan.jr@chromium.org2011-04-061-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | Previously the automation framework could miss a browser crash during shutdown on POSIX (on Windows there is crash_service.exe that should catch all crashes). This change makes the automation framework avoid losing information about the browser process' exit status (CrashAwareSleep), and fixes a bug in base::WaitForExitCodeWithTimeout (which on POSIX never reported the process has been signaled). Finally, it makes the automation framework use WaitForExitCodeWithTimeout instead of WaitForSingleProcess. This way we can get the exit status information in an accurate and cross-platform way. To avoid trying to close the same process handle twice (it's only an issue on Windows) I've changed WaitForExitCodeWithTimeout not to close the passed handle. It's only used in few places and I think this CL fixes all of them. I've tested this change locally on Mac with a UI test that SIGKILLs the browser. Before this change the test passed (it shouldn't), and after this change the test failed with an information that the browser has not exited cleanly. BUG=56644 Review URL: http://codereview.chromium.org/6689014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80608 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up code in the ChromeFrame test COM message filter by detecting ↵ananta@chromium.org2011-04-051-3/+3
| | | | | | | | | | | | | whether IE is hung in the WM_TIMER handler, instead of peeking with PM_NOREMOVE to detect the same. BUG=none TEST=ChromeFrame tests. TBR=amit Review URL: http://codereview.chromium.org/6693086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80504 0039d316-1c4b-4281-b951-d872f2087c98
* A change in the way User Agent is modified caused Chrome Frame to mistakenly ↵erikwright@chromium.org2011-04-052-19/+5
| | | | | | | | | | disable itself when installing into pre-existing IE processes. BUG=60018 TEST=Open IE when Chrome Frame is not installed. Install Chrome Frame. Instantiate the Chrome Frame ActiveX control and call registerBhoIfNeeded. Visit wordpress.com and verify that ChromeFrame is activated. Review URL: http://codereview.chromium.org/6691063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80497 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 80472 - GTTF: Detect browser crashes on shutdown in UI ↵phajdan.jr@chromium.org2011-04-051-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tests.Previously the automation framework could miss a browsercrash during shutdown on POSIX (on Windows there iscrash_service.exe that should catch all crashes).This change makes the automation framework avoid losinginformation about the browser process' exit status(CrashAwareSleep), and fixes a bug in base::WaitForExitCodeWithTimeout(which on POSIX never reported the process has been signaled).Finally, it makes the automation framework use WaitForExitCodeWithTimeoutinstead of WaitForSingleProcess. This way we can get the exit statusinformation in an accurate and cross-platform way.To avoid trying to close the same process handle twice (it's only an issue on Windows) I've changed WaitForExitCodeWithTimeout not to close the passed handle. It's only used in few places and I think this CL fixes all of them.I've tested this change locally on Mac with a UI test that SIGKILLs the browser.Before this change the test passed (it shouldn't), and after this changethe test failed with an information that the browser has not exited cleanly.BUG=56644Review URL: http://codereview.chromium.org/6689014 TBR=phajdan.jr@chromium.org [----------] 1 test from MultipartResponseUITest [ RUN ] MultipartResponseUITest.SingleVisit [3538:3538:0405/104633:11326126024137:ERROR:process_util_posix.cc(108)] Received signal 11 base::debug::StackTrace::StackTrace() [0xcd194a] base::(anonymous namespace)::StackDumpSignalHandler() [0xcb0e5a] 0x2b835e391100 AutomationProxy::GetBrowserWindowCount() [0x2055e86] ProxyLauncher::IsBrowserRunning() [0xc3f1a2] ProxyLauncher::QuitBrowser() [0xc454b3] ProxyLauncher::CloseBrowserAndServer() [0xc472d6] UITestBase::TearDown() [0xc50d54] UITest::TearDown() [0xc51260] testing::TestInfo::Run() [0xe8de78] testing::TestCase::Run() [0xe8df35] testing::internal::UnitTestImpl::RunAllTests() [0xe8f6e7] testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0xe804d5] testing::internal::HandleExceptionsInMethodIfSupported<>() [0xe8ba92] testing::UnitTest::Run() [0xe8badb] base::TestSuite::Run() [0x212c26d] main [0xc48e41] 0x2b835e37d1c4 0x42fec9 Review URL: http://codereview.chromium.org/6794056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80488 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Detect browser crashes on shutdown in UI tests.phajdan.jr@chromium.org2011-04-051-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | Previously the automation framework could miss a browser crash during shutdown on POSIX (on Windows there is crash_service.exe that should catch all crashes). This change makes the automation framework avoid losing information about the browser process' exit status (CrashAwareSleep), and fixes a bug in base::WaitForExitCodeWithTimeout (which on POSIX never reported the process has been signaled). Finally, it makes the automation framework use WaitForExitCodeWithTimeout instead of WaitForSingleProcess. This way we can get the exit status information in an accurate and cross-platform way. To avoid trying to close the same process handle twice (it's only an issue on Windows) I've changed WaitForExitCodeWithTimeout not to close the passed handle. It's only used in few places and I think this CL fixes all of them. I've tested this change locally on Mac with a UI test that SIGKILLs the browser. Before this change the test passed (it shouldn't), and after this change the test failed with an information that the browser has not exited cleanly. BUG=56644 Review URL: http://codereview.chromium.org/6689014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80472 0039d316-1c4b-4281-b951-d872f2087c98
* Increasing the timeout for the ChromeFrame COM message filter used in the ↵ananta@chromium.org2011-04-041-1/+1
| | | | | | | | | | | | | | test suite to detect whether IE is hung. It appears that a number of chrome frame tests fail on the IE8 builder because the message filter is cancelling outgoing calls. BUG=none TEST=Chromeframe tests should pass on the IE8 builder. TBR=amit Review URL: http://codereview.chromium.org/6693081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80388 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the expectations of the ChromeFrame CFOpenLinkInNewWindow to ensure that ↵ananta@chromium.org2011-04-022-1/+3
| | | | | | | | | | | | | it passes on IE8. Increased the timeout of the CF_DownloadFileFromPost test as it seems to consistently fail on IE8 BUG=none TEST=ChromeFrame tests should pass. TBR=amit Review URL: http://codereview.chromium.org/6794006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80248 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame new window tests fail consistently on the IE8 builder because we ↵ananta@chromium.org2011-04-022-4/+30
| | | | | | | | | | | | | | | | | | | | expect the NewWindow3 event to be fired when a new window is opened. IE8 version 8.0.7601.17514 on the builder seems to be firing the NewWindow2 event consistently which breaks the expectations of these tests. Added supports in the NewWindow2 handler in the event sink to call the OnNewBrowserWindow function which most of the tests expect. A limitation of this approach is we don't see the url in the NewWindow2 event. ChromeFrame tests at this point don't seem to be using the url parameter. BUG=none TEST=ChromeFrame new window tests should pass on the IE8 builder. TBR=amit Review URL: http://codereview.chromium.org/6792004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80246 0039d316-1c4b-4281-b951-d872f2087c98
* Disable crashing DllRedirector testjoshia@google.com2011-04-011-1/+2
| | | | | | | | BUG=78209 TBR=ananta Review URL: http://codereview.chromium.org/6792003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80240 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in the chrome frame relaibility test suite which occurs while ↵ananta@chromium.org2011-03-311-7/+8
| | | | | | | | | | | | | | | | | | | | accessing a deleted CommandLine object. The test suite on startup initializes the command line. It then initializes the gtest TestSuite class which also initializes a new instance of the CommandLine object. This ends up deleting the CommandLine instance initialized before leading to a crash when this is accessed. Fix is to remove the CommandLine initialization code from the test suite. Fixes bug http://code.google.com/p/chromium/issues/detail?id=77984 BUG=77984 TEST=ChromeFrame relaibility tests should now run correctly. TBR=amit Review URL: http://codereview.chromium.org/6781002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80060 0039d316-1c4b-4281-b951-d872f2087c98
* Moved URLRequestContextGetter to net/ so it can be used by projects such as ↵sanjeevr@chromium.org2011-03-311-2/+3
| | | | | | | | | | jingle. BUG=None TEST=Build. Review URL: http://codereview.chromium.org/6778025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80033 0039d316-1c4b-4281-b951-d872f2087c98
* Split out Keywords and Autofill logic from WebDatabase.andybons@chromium.org2011-03-301-2/+3
| | | | | | | | | | | | | | | | | This is simply moving things around. No underlying logic has changed. Since the new class AutofillTable actually encapsulates more than one table within the schema, I'm open to naming suggestions. No plans yet for the migration code. BUG=none TEST=WebDatabaseTest*,AutofillTableTest*,KeywordTableTest*,ProfileSyncServiceAutofillTest.* Review URL: http://codereview.chromium.org/6708110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79834 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome frame support for resizing popup windowsjoshia@google.com2011-03-297-47/+56
| | | | | | | | | | | | | Add necesssary plumbing for window.resizeTo to work within Chrome Frame. BUG=76649 TEST=create a popup window using window.open and resize it using window.resizeTo. Sample test page is here: http://testopenpopup.comuf.com/popUp.html Review URL: http://codereview.chromium.org/6748010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79737 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize grit invokesthomasvl@chromium.org2011-03-281-30/+8
| | | | | | | | | | | | | - Add two gypi files to src/build for the boilerplate added to targets and actions - Update grit_info to also support the -E flag so it can share more of the grit build commandline - switch over all but the webkit and webkit glue grd files to use the common support BUG=22247 TEST=everything still localized correctly Review URL: http://codereview.chromium.org/6705030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79548 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-2847-86/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this as this broke chrome frame net tests as we were not sending ↵ananta@chromium.org2011-03-251-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | the response for the initial request initiated by IE. We need to check whether the request id on the initial request is -1 before deciding whether we should send over a response to Chrome. ChromeFrame would fail to load the page correctly if a manifest was specified in the html tag. This would work the first time and fail on subsequent attempts. Basically the manifest specifies portions of the website that is cached locally. In this case when there is a subsequent navigation to the original URL the cached resource can be served out of the appcache which lives in chrome. ChromeFrame expects the first url request from chrome to match that of the url which the user navigated to. This url is served out of chrome'a app cache thus causing the pending url reques checks to fail. Fix is to validate the pending url request with the request received and stop the pending request if there is no match. We just trace the fact and stop this request. A new request object is created to handle the request received and life goes on. Fixes bug http://code.google.com/p/chromium/issues/detail?id=76439 BUG=76439 TEST=manually as described in the bug. TBR=amit Review URL: http://codereview.chromium.org/6736022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79369 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 79352 - ChromeFrame would fail to load the page correctly if a ↵mrossetti@chromium.org2011-03-251-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | manifest was specified in the html tag. This would work the first time and fail on subsequent attempts. Basically the manifest specifies portions of the website that is cached locally. In this case when there is a subsequent navigation to the original URL the cached resource can be served out of the appcache which lives in chrome. ChromeFrame expects the first url request from chrome to match that of the url which the user navigated to. This url is served out of chrome'a app cache thus causing the pending url reques checks to fail. Fix is to validate the pending url request with the request received and stop the pending request if there is no match. We just trace the fact and stop this request. A new request object is created to handle the request received and life goes on. Fixes bug http://code.google.com/p/chromium/issues/detail?id=76439 BUG=76439 TEST=manually as described in the bug. Review URL: http://codereview.chromium.org/6713112 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/6741001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79361 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame would fail to load the page correctly if a manifest was ↵ananta@chromium.org2011-03-251-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | specified in the html tag. This would work the first time and fail on subsequent attempts. Basically the manifest specifies portions of the website that is cached locally. In this case when there is a subsequent navigation to the original URL the cached resource can be served out of the appcache which lives in chrome. ChromeFrame expects the first url request from chrome to match that of the url which the user navigated to. This url is served out of chrome'a app cache thus causing the pending url reques checks to fail. Fix is to validate the pending url request with the request received and stop the pending request if there is no match. We just trace the fact and stop this request. A new request object is created to handle the request received and life goes on. Fixes bug http://code.google.com/p/chromium/issues/detail?id=76439 BUG=76439 TEST=manually as described in the bug. Review URL: http://codereview.chromium.org/6713112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79352 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the direct includes of common.gypi since that is auto done (and ↵thomasvl@chromium.org2011-03-242-6/+0
| | | | | | | | | | including it twice can cause issues) TEST=none BUG=none Review URL: http://codereview.chromium.org/6676104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79274 0039d316-1c4b-4281-b951-d872f2087c98
* Move the rest of the renderer->browser messages that belong in content. ↵jam@chromium.org2011-03-242-0/+2
| | | | | | | | | | | | | Also do a bunch of cleanup: -move safe browsing messages together -get rid of webkit_param_traits and common_param_trait since they're no longer needed -remove the multiple include of IPC files from places that don't need it TBR=tsepez Review URL: http://codereview.chromium.org/6713084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79235 0039d316-1c4b-4281-b951-d872f2087c98
* WinDDK ATL and MSVC express 2008/2005 compatability mark@chromium.org2011-03-212-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gives 'out of the box' compatability with VC2008 express - i.e. no modifications needed to system headers or .gyp* files or related hacks. Just set the GYP_MSVS_VERSION to 200Xe (e for express, same as the linked blog on the issue and first google hit as well). 1) Changes to build\common.gypi to turn off to define COMPILER_MSVC_EXPRESS if a express is detected (through the GYP_MSVC_VERSION environment variable), turn off the _SECURE_ATL define (which is flagged as an error with WinDDK's ATL, _SECURE_ATL adds [more] CRT checks to other ATL versions) and hard to link to the atl stdthunk library with express editions. Also, explicitly link to the base WinSDK libraries in common.gypi and mini_installer.gypi for MSVC 2005 express. 2) Fixes a few .cc files that have the wrong include order with the ATL headers when using the Windows DDK ATL. The Windows DDK ATL brings in intsafe.h (WinSDK, not WinDDK) with atlwin.h and generates multiple INTXX_MIN/MAX def warnings which get flagged as errors with the warnings as errors flag if not included before other libraries that have the same definitions like ICU. 3) Changes to .rc files to avoid pulling in afxres.h (an MFC header - it's available in the WinDDK) and winres.h which VCExpress doesn't have (it's available in a WinSDK sample, but that kind of the purpose of it). The main Chromium .rc files are already structured this way, I just changed the rest and changed the output of grit to do the same. 4) Removes the memset obj file linking in mini_installer.gyp and simply implements memset for mini_installer.cc. Only changes to the chromium branch now. There are some .rc files in the Python26, Native Client, and Angle in samples that could #3 changes. They are not required for Chromium, however. ------ VC2005SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=7B0B0339-613A-46E6-AB4D-080D4D4A8C4E&displaylang=en (or non-SP1 at http://download.microsoft.com/download/8/3/a/83aad8f9-38ba-4503-b3cd-ba28c360c27b/ENU/vcsetup.exe) VC2008SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=F3FBB04E-92C2-4701-B4BA-92E26E408569&displaylang=en currently. The base developer instructions work fine afterwards with a couple tweaks for express versions: http://www.chromium.org/developers/how-tos/build-instructions-windows Under "Additional (free) downloads" under step 2: X) Only the first 3 Non-SP KB Patches are needed for express. Don't forget to forget GYP_MSVS_VERSION environment as appropriate - 2008e for Visual C++ 2008 Express, for example. Under "Additional (free) downloads" after step 5 [These only apply to 2008 express, 2005 works fine out of the box]: 6A) Download the WinDDK for the atl headers and libs - http://msdn.microsoft.com/en-us/windows/hardware/gg487463.aspx. It works fine, but you do not need to install the whole DDK. In the WDK directory just install headers.msi, libs_x86fre.msi, and libs_x64fre.msi; just grab the atl headers and atl*.lib libs; right click the installers and uninstall afterwards. Add the appropriate include and lib paths to your global settings. 6B) To build x64 targets (x64 Native Client) download: http://www.cppblog.com/Files/xcpp/VCE64BIT_WIN7SDK.zip Follow the readme instructions. Further information behind that and x64 target building with express: - http://jenshuebel.wordpress.com/2009/02/12/visual-c-2008-express-edition-and-64-bit-targets/ - http://www.cppblog.com/xcpp/archive/2009/09/09/vc2008express_64bit_win7sdk.html ---------------- BUG=1433, 5026, 72885 TEST=Compiles in both Debug and Release mode in Visual C++ Express 2008/2005 and does not effect other build setups. In addition, the WinDDK ATL compiles with the secure_atl=0 in the GYP_DEFINES environment variable on non-express versions of MSVC. Review URL: http://codereview.chromium.org/6676030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78921 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/app_switches to ui/gfx/gl/gl_switches.backer@chromium.org2011-03-211-1/+0
| | | | | | | | | | | | | This is in preparation of moving app/gfx/gl to ui/gfx/gl. All of the switches in app_switches are GL related. Removed many includes that were unnecessary. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/6685089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78875 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the chrome frame net tests which crashes on startup due to a missing ↵ananta@chromium.org2011-03-181-2/+7
| | | | | | | | | | | | | | | | ContentRendererClient interface which is part of the ContentClient object. While fixing this I also fixed a memory leak occurring due to a heap allocated ChromeContentBrowserClient object. This object does not need to live on the heap. BUG=none TEST=chrome frame net tests should run. TBR=amit Review URL: http://codereview.chromium.org/6709044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78773 0039d316-1c4b-4281-b951-d872f2087c98
* Add separate ContentClient interfaces for gpu/plugin/renderer processes. ↵jam@chromium.org2011-03-171-1/+1
| | | | | | | | Since we don't have a need for a chrome/gpu or chrome/plugin directory, their chrome implementations are in chrome/common. Use the renderer one for getting the sad plugin image. Review URL: http://codereview.chromium.org/6708013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78617 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remaining files in chrome\common to content\common.jam@chromium.org2011-03-174-5/+5
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6672070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78516 0039d316-1c4b-4281-b951-d872f2087c98
* Removed 'off the record' references from ExternalTabSettings and ↵vipul.bhasin@gmail.com2011-03-171-1/+1
| | | | | | | | | | ProfileIOData::ProfileParams. BUG=3333 Review URL: http://codereview.chromium.org/6700001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78485 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the bootstrapping code in chrome frame net tests. There were a ↵ananta@chromium.org2011-03-161-15/+1
| | | | | | | | | | | | | | number of prefs being registered on a demand basis. Turns out that the helper function RegisterLocalState in the browser namespace registers all the prefs we need. BUG=none TEST=chrome frame net tests should continue to run correctly. Review URL: http://codereview.chromium.org/6674030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78406 0039d316-1c4b-4281-b951-d872f2087c98
* Further modifications to the Ready Mode UI in response to feedback. Height, ↵erikwright@chromium.org2011-03-164-0/+27
| | | | | | | | | | icon dimensions, text positioning are same as IE infobars. Buttons now implement user selected theme. BUG=None TEST=None Review URL: http://codereview.chromium.org/6321025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78311 0039d316-1c4b-4281-b951-d872f2087c98
* Rearrange the bootstrapping code in chrome frame net tests to ensure that it ↵ananta@chromium.org2011-03-151-7/+6
| | | | | | | | | | | | | | works correctly in debug builds without firing any DCHECKs. Registered the proxy dictionary pref which tripped up a recent change to add a system level URLRequestContext. BUG=none TEST=chrome frame net tests should run in debug builds without firing DCHECKs Review URL: http://codereview.chromium.org/6697029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78306 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 04:38:37 +0000