summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Attempt to fix the chrome frame net test failures on the try server. A ↵ananta@chromium.org2010-12-191-1/+8
| | | | | | | | | | | | | | | | | | DCHECK indicating that the RegisterDragDrop API which registers the drop target as part of the chrome widget initialization fails with E_OUTOFMEMORY. Reason the chrome frame net tests were using CoInitializeEx to initialize the COM apartment. As per docs we need to call OleInitialize. BUG=none TEST=chrome frame net tests should pass on the try server. TBR=amit Review URL: http://codereview.chromium.org/6026003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69688 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69592 - file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-182-13/+18
| | | | | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 TBR=dmaclach@chromium.org Review URL: http://codereview.chromium.org/6017003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69601 0039d316-1c4b-4281-b951-d872f2087c98
* file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-182-18/+13
| | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69592 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeFrame BeginningTransaction unit test failures which validate ↵ananta@chromium.org2010-12-181-1/+1
| | | | | | | | | | | | | | | | | | | the HttpNegotiate patch. On IE6/7/8 the chrome frame user agent is added to the ua section in the registry. This causes the test matcher to fail as the actual UA string contains the string chromeframe followed by the version of the dll. Fix is to reduce the scope of the matcher to just look for the string chromeframe. BUG=none TEST=Covered by existing chrome frame BeginningTransaction test. TBR=amit Review URL: http://codereview.chromium.org/6045001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69591 0039d316-1c4b-4281-b951-d872f2087c98
* Restore the IHttpNegotiate patch in ChromeFrame for IE9 which sends the ↵ananta@chromium.org2010-12-175-3/+300
| | | | | | | | | | | | | | | short UA string by default without the Post Platform values which we rely on. This reverts back to the old behavior for IE9 with the bug that certain top level requests like Refresh on a page rendered in IE will be sent out with the UA string without the chrome frame suffix. BUG=45087 TEST=Covered by old http negotiate unit test. Review URL: http://codereview.chromium.org/5957001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69586 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a false positive crasher in chrome frame in version 8.0.552.224. ↵ananta@chromium.org2010-12-171-0/+6
| | | | | | | | | | | | | The crash happens in the IInternetProtocol::UnlockRequest patch. BUG=67264 TEST=none Review URL: http://codereview.chromium.org/5895004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69582 0039d316-1c4b-4281-b951-d872f2087c98
* Stop upload thread when stopping service. Leaked thread may crash process ↵vitalybuka@chromium.org2010-12-171-4/+10
| | | | | | | | | | | | on exit. BUG=64388 TEST=none Review URL: http://codereview.chromium.org/5845004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69516 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69490 - base/version: remove wstring versionsanjeevr@chromium.org2010-12-171-2/+1
| | | | | | | | | | | | | | And fix callers. BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/5848005 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/5905006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69491 0039d316-1c4b-4281-b951-d872f2087c98
* base/version: remove wstring versionevan@chromium.org2010-12-171-1/+2
| | | | | | | | | | | And fix callers. BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/5848005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69490 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ChromeFrame UA in the post platform section in the IE user agent ↵ananta@chromium.org2010-12-169-308/+116
| | | | | | | | | | | | | | | | | | | | | | | | | | string. To achieve this we need to add the desired value in the registry under the Internet Settings\User Agent\Post Platform key. We add this under the per user or per machine section in the registry depending on whether ChromeFrame is being installed in per user or per machine mode. This fixes the bug where certain top level requests in IE would not have the chrome frame UA appended to the IE UA. Removed the BeginningTransaction vtable patch code, which only existed to add chrome frame to the UA in outgoing requests. The limitation with registering the chrome frame UA in the registry is that it will be sent out even in the ChromeFrame BHO is disabled. Fixes bug http://code.google.com/p/chromium/issues/detail?id=45087 BUG=45087 TESt=Covered by new chrome frame test. Review URL: http://codereview.chromium.org/5831002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69442 0039d316-1c4b-4281-b951-d872f2087c98
* Installer cleanupamit@chromium.org2010-12-161-6/+4
| | | | | | | | | | | | | 1] Remove installer::version and use base::version in installer 2] Use file_util::FileEnumerator instead of calling FindFirstFile directly BUG=none TEST=covered by existing tests Review URL: http://codereview.chromium.org/5687004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69433 0039d316-1c4b-4281-b951-d872f2087c98
* Cache certificate verification results in memory.wtc@google.com2010-12-162-1/+10
| | | | | | | | | R=agl BUG=63357 TEST=none Review URL: http://codereview.chromium.org/5386001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69414 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the dependency of a number of chrome frame projects on the ↵ananta@chromium.org2010-12-161-4/+7
| | | | | | | | | | | | | xulrunner_sdk target which brings in dependency on nspr needlessly. BUG=43461 TEST=it compiles Review URL: http://codereview.chromium.org/5931001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69372 0039d316-1c4b-4281-b951-d872f2087c98
* Keep deinlining stuff.erg@google.com2010-12-153-29/+27
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69273 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a regression introduced with r69101, which now prevents Chrome Framerogerta@chromium.org2010-12-158-84/+96
| | | | | | | | | | | | | | from loading chrome extension URL in privileged mode using the NPAPI plugin. The behaviour that was implemented only for the ActiveX control has been moved into the base class NavigationConstraintsImpl, which both the ActieX and NPAPI plugin derive from. TEST=Added new unit tests for this case BUG=0 Review URL: http://codereview.chromium.org/5814004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69257 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the ChromeFrame Firefox tests on Windows 7 due to a bug in Firefox ↵ananta@chromium.org2010-12-151-7/+17
| | | | | | | | | | | | | | | causing it to crash on startup after the machine has been running for a while. For the curious the crash occurs in the tab preview code in Firefox which only executes on Windows 7 and executes even if we disable tab preview. BUG=none TEST=none Review URL: http://codereview.chromium.org/5745008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69218 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to get rid of chrome_frame_perftests dependency on nspr.lib which ↵ananta@chromium.org2010-12-151-1/+1
| | | | | | | | | | | | | | | causes random build errors. TBR=amit BUG=none TEST=none Review URL: http://codereview.chromium.org/5845002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69213 0039d316-1c4b-4281-b951-d872f2087c98
* Have Chrome Frame "support" IE conditional comment tags (of the ↵robertshield@chromium.org2010-12-143-5/+142
| | | | | | | | | | | | | | downlevel-hidden variety) by ignoring them (rather than treating them as comment start/end) when parsing HTML streams. BUG=65627 TEST=chrome_frame_unittests.exe, also syntax like <!--[if IE]><meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"><![endif]--> will now activate CF. Offtopic: I wonder what happens if I paste HTML into CL comments. Heh. Review URL: http://codereview.chromium.org/5708007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69177 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a ReadyPromptContent that displays a prompt to accept, temporarily ↵erikwright@chromium.org2010-12-1412-2/+1245
| | | | | | | | | | decline, or permanently decline ready mode. Implement a RegistryReadyModeState that manages the state (based on user's decision) in the registry. Interfaces to integrate those with the installer. BUG=None TEST=chrome_frame_unittests --gtest_filter='Ready*' Review URL: http://codereview.chromium.org/5747002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69175 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-142-6/+9
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame test failures caused by the change to support about:plugins ↵ananta@chromium.org2010-12-141-3/+4
| | | | | | | | | | | | | in full tab mode. BUG=66118 TBR=none Review URL: http://codereview.chromium.org/5707009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69104 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame perf test builder redness by delay loading nspr4.dll. We ↵ananta@chromium.org2010-12-141-1/+5
| | | | | | | | | | | | | | need to investigate where this dependency comes from. TBR=amit TEST=none BUG=none Review URL: http://codereview.chromium.org/5757004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69103 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for gcf:about:plugins in chrome frame full tab mode. The URL ↵ananta@chromium.org2010-12-1417-120/+350
| | | | | | | | | | | | | | | | | | | validation code path in ChromeFrame now takes in an interface NavigationConstraints which allows the delegateslike the ActiveX, ActiveDocument and the NPAPI plugins to control the navigation decisions. We no longer refer to the InternetSecurityManager interface which is IE only for performing zone decisions in the ChromeFrame NPAPI plugin. Fixes bug http://code.google.com/p/chromium/issues/detail?id=66118 BUG=66118 TEST=Covered by additional CanNavigate unit tests. Review URL: http://codereview.chromium.org/5698005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69101 0039d316-1c4b-4281-b951-d872f2087c98
* An attempt to fix the flakiness with the ChromeFrame Javascript window open ↵ananta@chromium.org2010-12-131-1/+1
| | | | | | | | | | | | | test on IE9. We receive multiple NavigateComplete notifications at times. BUG=none TEST=none Review URL: http://codereview.chromium.org/5703005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69070 0039d316-1c4b-4281-b951-d872f2087c98
* Improve filtering for false positive crashesamit@chromium.org2010-12-133-61/+42
| | | | | | | | | | | | | | | ...by inspecting if the module with the crash has the topmost handler in the SEH chain. If that's the case then the exception will very likely be handled. This covers the case of IsBadReadPtr adn family without any special code. It also lets us address IsValidInterface, an internal helper in urlmon. BUG=64348 TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/5622006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69066 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create bogus 's' key in registry during Chrome Frame registrationgrt@chromium.org2010-12-131-1/+1
| | | | | | | | BUG=none TEST=register Chrome Frame on a fresh machine and note that bogus key HKCR\MIME\Database\s is no longer created. Review URL: http://codereview.chromium.org/5810001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69042 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeFrame perf redness caused by an event name change.ananta@chromium.org2010-12-131-1/+1
| | | | | | | | | | TBR=amit BUG=none TEST=none Review URL: http://codereview.chromium.org/5812002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69026 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-135-9/+9
| | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5685007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add named testing interface."phajdan.jr@chromium.org2010-12-115-17/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=67300 The change has been approved conditionally, i.e. if the outstanding review comments are handled in a follow-up as the top priority. Two weeks have passed, and I have not seen the follow-up. It is risky to keep this change in the tree, as it is already non-trivial to revert. Conflicts: chrome/browser/automation/automation_provider.cc chrome/test/ui/named_interface_uitest.cc ipc/ipc_channel_posix.cc TBR=nirnimesh BUG=chromium-os:8512 TEST=none Review URL: http://codereview.chromium.org/5707006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68944 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68932 - Make members of Singleton<T> private and only visible to the ↵satish@chromium.org2010-12-112-9/+6
| | | | | | | | | | | | | | | | | | singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 TBR=satish@chromium.org Review URL: http://codereview.chromium.org/5721005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68936 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestJob URLRequestJob;tfarina@chromium.org2010-12-111-2/+2
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5607004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68935 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-112-6/+9
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68932 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a unit test broken by overriding reg keysamit@chromium.org2010-12-101-5/+7
| | | | | | | | | | | | | | | Earlier change to temporarily override registry keys caused shell API SHGetFolderLocation to fail. solution is to move this test out of the test fixture. TBR=tommi BUG=none TEST=UtilTests, GetTempInternetFiles Review URL: http://codereview.chromium.org/5769001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68800 0039d316-1c4b-4281-b951-d872f2087c98
* Sanitize PrefStore interface.mnissler@chromium.org2010-12-091-9/+7
| | | | | | | | | | | | | | | | | This reworks the PrefStore interface, specifically: - Split up the interface into PrefStore, which only provides reading functionality, and the derived PersistentPrefStore for the actual user pref store - Remove the hurt-me-plenty prefs() function from PrefStore, instead provide Get/Set/Remove operations - Remove special handling of default and user pref store from PrefValueStore and put it into PrefService - Pref change notification handling now almost exclusively handled through PrefValueStore - Adjust all consumers of these interfaces (but keep ConfigurationPolicyPrefStore untouched, that's up next on the list) BUG=64232 TEST=existing unit tests Review URL: http://codereview.chromium.org/5646003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68736 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary workaround to get tests that reference singletons either directly ↵tommi@chromium.org2010-12-097-88/+138
| | | | | | | | | | | | | | | | or indirectly to pass. With the recent Singleton refactoring, these tests started exposing some inherent problems with singletons, namely that one test can reference a state set by a different test, which can cause all sorts of flakiness. Furthermore, some of these tests could reference the registry which may have some user specific settings that could cause the tests to fail To work around these issues, I'm adding a few utility classes for tests (registry virtualization) and exposing a method to reset singletons before a test is run. TEST=Fixes flakiness and a few tests that could fail on the waterfall. BUG=none Review URL: http://codereview.chromium.org/5564009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68701 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for detecting text selection in chrome frame tests. This ↵kkania@chromium.org2010-12-096-21/+144
| | | | | | | | | | requires adding support for IAccessible2 interfaces. BUG=none TEST=none Review URL: http://codereview.chromium.org/4406002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68680 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Simplify the magic required to create IPC message headers.This gets rid ↵jam@chromium.org2010-12-082-44/+44
| | | | | | | | | of having to include the files in a magic place because of xcode dependency issues, and just makes it simpler to create new IPC message classes. It also gets rid of including the X_messages_internal.h file multiple times, which simplifies things and should make the build a little faster. In a future change, I will remove the "internal.h" files since they're no longer needed. Review URL: http://codereview.chromium.org/5526008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68664 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of std::wstring version of HasSwitch.tfarina@chromium.org2010-12-083-4/+4
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/5649003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68650 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in UrlmonUrlRequest to clear the map during shutdownamit@chromium.org2010-12-081-1/+1
| | | | | | | | | | | | | In UrlmonUrlRequestManager::StopAll we meant to clear the map but used map.empty() instead of map.clear(). BUG=none TEST=none Review URL: http://codereview.chromium.org/5656004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68649 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Chrome Frame metric to track channel errors that result in sad tabs.robertshield@chromium.org2010-12-083-2/+14
| | | | | | | | | BUG=65899 TEST=None Review URL: http://codereview.chromium.org/5665003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68631 0039d316-1c4b-4281-b951-d872f2087c98
* Some installer cleanup: introduced ChannelInfo class for fiddling with "ap" ↵grt@chromium.org2010-12-081-4/+0
| | | | | | | | | | | ClientState value. BUG=61609 TEST=added to and modified chrome/installer_util_unittests.exe appropriately Review URL: http://codereview.chromium.org/5656002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68603 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new GetInstance() method for singleton classes, take 2.satish@chromium.org2010-12-0810-66/+86
| | | | | | | | | | | | | | | | | | This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it. This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs). Suggested files to focus for reviewers: - joi@ for files under src/ceee - tommi@ for files under src/chrome_frame - maruel@ for the rest of the files. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5581008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
* Addressing code review comments from Tommi from the orignal CL ↵ananta@chromium.org2010-12-081-10/+9
| | | | | | | | | | | http://codereview.chromium.org/5632003/ BUG=65295 TEST=As described in the bug Review URL: http://codereview.chromium.org/5535008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68554 0039d316-1c4b-4281-b951-d872f2087c98
* Create new test binary for Chrome Frame for running QA tests. Original patch ↵kkania@chromium.org2010-12-082-0/+124
| | | | | | | | | by mberkowitz@chromium.org. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68546 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a DCHECK which fired in ChromeFrame which indicated that we had a ↵ananta@chromium.org2010-12-071-1/+17
| | | | | | | | | | | | | | | | | | | | | | pending request which is created when we switch into ChromeFrame and the URL request received from Chrome was for a different URL. This scenario occurs when we receive requests from Chrome for the current page which is being navigated away from while a new document is coming up. Fix is to disallow these requests while we have a pending request. The other fix is in the ExternalTabContainer where a spurious DCHECK was being fired in the BeforeUnload code path. Fixes bug http://code.google.com/p/chromium/issues/detail?id=65295 BUG=65295 TEST=As described in the bug. Review URL: http://codereview.chromium.org/5632003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68526 0039d316-1c4b-4281-b951-d872f2087c98
* Add PxSecure.dll to the list of buggy BHOs to which Chrome Frame avoids ↵robertshield@chromium.org2010-12-071-1/+1
| | | | | | | | | | | firing events. BUG=65748 TEST=Fewer crashes are received with PxSecure.dll at the top of the stack. Review URL: http://codereview.chromium.org/5550004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68522 0039d316-1c4b-4281-b951-d872f2087c98
* Removed code which was added only for debugging. ananta@chromium.org2010-12-061-1/+0
| | | | | | | | | | TBR=amit BUG=none TEST=none Review URL: http://codereview.chromium.org/5515005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68359 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race in the ChromeFrame metrics service start up code. This race could ↵ananta@chromium.org2010-12-042-1/+11
| | | | | | | | | | | | | | | | | be triggered if multiple BHO's attempted to start the metrics service object from different threads. Fix is to lock access to the Start and Stop methods. Fixes bug http://b/issue?id=3251823 BUG=3251823 TEST=none Review URL: http://codereview.chromium.org/5519007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68261 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove stub scoped_variant_win.h file.tfarina@chromium.org2010-12-046-30/+27
| | | | | | | | | | | Fix the callers and add base::win in the call sites. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/5507001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68251 0039d316-1c4b-4281-b951-d872f2087c98
* Refreshing a ChromeFrame page which was received in response to a top level ↵ananta@chromium.org2010-12-035-9/+143
| | | | | | | | | | | | | | | | | | | | | | | | | | | POST to a page in IE should reissue the POST request after bringing up a confirmation dialog. This CL adds support to ChromeFrame to achieve this. Ideally we would want IE to display the confirmation dialog for the POST. However the doc object host which is implemented by IEFrame expects the doc object to implement the IHTMLDocument interface and a bunch of private interfaces. To reissue the POST request we save away the POST data and headers in the navigation manager instance which is per BHO. When we refresh the page in ChromeFrame the active document on seeing that we have posted data issues a navigation back to the URL with the posted data and saved headers. All other refreshes continue to work the same way as before, i.e. the refresh request is sent to Chrome on the automation channel. The confirmation dialog is put up by the active document with the same text and caption as that in Chrome. Fixes bug http://code.google.com/p/chromium/issues/detail?id=64901 BUG=64901 TEST=Covered by new ChromeFrame unit test Review URL: http://codereview.chromium.org/5595002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68213 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 21:56:45 +0000