summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Mark the flaky iframe post test as such.slightlyoff@chromium.org2009-10-301-1/+3
| | | | | | | | | | R=ananta TEST=none BUG=26372 Review URL: http://codereview.chromium.org/348026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30649 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize the chrome thread object at the start of the ↵ananta@chromium.org2009-10-301-4/+4
| | | | | | | | | | | | | | | | CFUrlRequestUnittestRunner constructor. This causes a CHECK to fire in the extensions service initialization which happens when we initialize the profile. The CHECK was added in revision 30550. Given the spate of these test failures we should really speed up the process of moving the chrome frame builder to the main waterfall. TBR=tommi Review URL: http://codereview.chromium.org/346019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30556 0039d316-1c4b-4281-b951-d872f2087c98
* The newly added AboutChromeFrame test for IE full tab mode was failing on ↵ananta@chromium.org2009-10-304-14/+10
| | | | | | | | | | | | | | | | | | | the chrome frame builder which is an XP machine with IE8 (It was not supposed to return on IE8 :) The reason being that the VK_UP keyboard message we were passing in via SendInput needs the extended flag to be true. I added the extended flag as an argument to the SendVirtualKey helper function. On a related note, I removed the GetIEVersion check from the utility function which launches IE as a COM server as the IE version checking function checks the version of the current module and compares it against IE versions which is hilarious. In any case these tests work fine. TBR=amit Review URL: http://codereview.chromium.org/339076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30549 0039d316-1c4b-4281-b951-d872f2087c98
* Added unit tests for ChromeFrame IE full tab mode. These test the following ↵ananta@chromium.org2009-10-298-59/+390
| | | | | | | | | | | | | | | | | | | | | cases:- 1. A window.open call issued from a page within ChromeFrame in IE full tab mode makes it back to IE before being shunted into Chrome. 2. Brings up the chrome frame context menu in full tab mode and invokes the About Chrome frame option. While I was working on these tests based on a lot of help from Stoyan, we had these tests use gmock and I also changed the disallowed URL test to use gmock. The other changes are to always run the chrome frame tests in the STA apartment as the newly added full tab mode tests cannot handle calls coming in from background RPC worker threads. Bug=26066,26172 Review URL: http://codereview.chromium.org/340029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30520 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused files.stoyan@google.com2009-10-292-287/+0
| | | | | | Review URL: http://codereview.chromium.org/340010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30505 0039d316-1c4b-4281-b951-d872f2087c98
* Instantiate a dummy notification service instance in chrome frame on the threadananta@chromium.org2009-10-291-0/+3
| | | | | | | | | | | where the network tests run. Some of the url request tests rely on having a valid notification service pointer in the TLS on the current thread. TBR=tommi Review URL: http://codereview.chromium.org/344025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30502 0039d316-1c4b-4281-b951-d872f2087c98
* Using thread safe reference counting to wrap the UploadData instance.Moving ↵tommi@chromium.org2009-10-296-38/+62
| | | | | | | | the post_data_len_ member variable to the PluginUrlRequest class.TEST=This is a tentative fix for bug 25531.BUG=25531 Review URL: http://codereview.chromium.org/340006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30432 0039d316-1c4b-4281-b951-d872f2087c98
* Additional layer of protection to disable funky URLs throughamit@chromium.org2009-10-291-3/+16
| | | | | | | | | | | | view-source in chrome frame BUG=26129 TEST=cf:view-source:javascript:alert('foo') should not work in chrome frame. Review URL: http://codereview.chromium.org/348006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30417 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a DCHECK that happens on every exit of IE. We appear to be leaking ↵robertshield@chromium.org2009-10-281-1/+6
| | | | | | | | | | automation proxies, which I maintain is a bad thing. BUG=Start IE with debug CF installed, navigate to a chrome frame page, exit IE, see the DCHECK. Review URL: http://codereview.chromium.org/342018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30366 0039d316-1c4b-4281-b951-d872f2087c98
* With the change in the constructor for the ChromeThread class, we are seeing ↵ananta@chromium.org2009-10-282-1/+3
| | | | | | | | | | | | | | | | | | | a DCHECK fire in the Chrome frame network tests for whether the current thread is the UI thread. We need to invoke the correct constructor. The other fix is in our com_util::IDispatchImpl class where we end up crashing if we fail to find the type information for the passed in interface. Strangely this is failing for the IChromeFrame interface which is an IDispatch derivative and seems to be correctly registered. It also fails with the ATL IDispatchImpl classes though. However we should not crash here :) I also removed the NOTREACHED as it keeps firing on debug test runs. Will take a look at this closely later. TBR=tommi Review URL: http://codereview.chromium.org/343013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30333 0039d316-1c4b-4281-b951-d872f2087c98
* Setting the SVN eol style to LF on chrome frame sourcesananta@chromium.org2009-10-281-79/+79
| | | | | | Review URL: http://codereview.chromium.org/344009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30332 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Chrome Frame preprocessor define in chrome_constants.cc and deal ↵robertshield@chromium.org2009-10-286-47/+18
| | | | | | | | | | | | with resulting fallout. Also, remove several instances of Chrome Frame using wstrings instead of FilePaths. The main goal of this patch is to move towards ensuring that Chrome Frame and Google Chrome share binary-identical exes and dlls except for setup.exe and mini_installer.exe. Review URL: http://codereview.chromium.org/338025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30290 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build error.ananta@chromium.org2009-10-271-1/+1
| | | | | | | | TBR=amit Review URL: http://codereview.chromium.org/340015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30266 0039d316-1c4b-4281-b951-d872f2087c98
* If a HTTP post to a server returns any redirect code other than 307, then ↵ananta@chromium.org2009-10-275-9/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | browsers don't preserve the request method, i.e. they convert the POST request to GET. For 307 redirects browsers preserve redirects. This CL fixes the following issues :- 1. As per the above description, we reset the method which ensures that we don't generate the post related headers. The Post302RedirectGet net test does test this very case. However it works correctly as Chrome follows the redirect and reissues the GET request. In this case this does not occur as the only calls which are invoked on the bind status callback after the redirect are GetBindInfo and BeginningTransaction where we incorrectly return the post related information. Ideally we would want to turn off follow redirects in Urlmon or Chrome. I tried the latter which has a number of issues. 2. In debug mode the chrome_frame_net_tests cause a DCHECK to be fired which indicates that the test is not being run on the UI thread. 3. As the Urlmon requests are now destroyed asynchronously having a DCHECK after the Stop call on the Urlmon request object in the CleanupAsyncRequests function is incorrect. Removed this DCHECK Fixes bug http://code.google.com/p/chromium/issues/detail?id=25643 Bug=25643 Review URL: http://codereview.chromium.org/333043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30261 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another build break that didn't show up on the try bots.jam@chromium.org2009-10-271-1/+1
| | | | | | | | TBR=darin BUG=25354 Review URL: http://codereview.chromium.org/329035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30167 0039d316-1c4b-4281-b951-d872f2087c98
* More build breakage.evan@chromium.org2009-10-271-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30137 0039d316-1c4b-4281-b951-d872f2087c98
* Move helper_gmock.h from ChromFrame subrtee to testing directory.stoyan@google.com2009-10-272-628/+2
| | | | | | | | BUG=none TEST=builds ok Review URL: http://codereview.chromium.org/295049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30132 0039d316-1c4b-4281-b951-d872f2087c98
* Blind attempt at fixing broken Chrome Frame test utils build.evan@chromium.org2009-10-271-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30129 0039d316-1c4b-4281-b951-d872f2087c98
* Blind attempt at fixing broken Chrome Frame unittests build.evan@chromium.org2009-10-261-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30124 0039d316-1c4b-4281-b951-d872f2087c98
* Blind attempt at fixing broken Chrome Frame build.evan@chromium.org2009-10-261-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30122 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine(std::wstring) ctor.evan@chromium.org2009-10-263-6/+3
| | | | | | | | | | | Add a ctor for creating a CommandLine for carrying arguments; convert all the users to either that or the FilePath version. BUG=24672 Review URL: http://codereview.chromium.org/329017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30117 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully the last of the fixes to get Chrome Frame tests going again.ananta@chromium.org2009-10-243-5/+25
| | | | | | | | | | | | | | | | 1. Added a check in the OnDestroy handler for the ChromeFrame ActiveX as to whether the worker thread is valid before posting a task to it. 2. Added a helper function in ChromeFrameAutomationClient to support asynchronous host network stack requests deletion. If this does not work I will revert the previous CL's. TBR=amit Review URL: http://codereview.chromium.org/338010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30010 0039d316-1c4b-4281-b951-d872f2087c98
* Attempts to get the chrome_frame_tests going again on the chrome frame ↵ananta@chromium.org2009-10-242-14/+21
| | | | | | | | | | | | | | | | | | | | | | builder. Fixes as below:- 1. Removed a DCHECK from ChromeFrameAutomationClient::CleanupRequests which checks if the request was actually deleted. This DCHECK is not correct anymore as the request is stopped asynchronously. 2. We now stop the worker thread in WM_DESTROY as the activex window needs to be valid for Urlmon requests to be released correctly. In some cases IE reuses the ActiveX instance. So we need to create the worker thread on demand. TBR=amit Review URL: http://codereview.chromium.org/334020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30007 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the chrome frame test failures. This was caused a side effect ↵ananta@chromium.org2009-10-241-0/+1
| | | | | | | | | | | | of my change r29986 to run URL requests issued in IE in a separate thread. TBR=amit Review URL: http://codereview.chromium.org/328020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29999 0039d316-1c4b-4281-b951-d872f2087c98
* Currently the host network stack in IE which uses Urlmon interfaces to initiateananta@chromium.org2009-10-247-72/+210
| | | | | | | | | | | | | | | | | | | | | and complete URL downloads requested by ChromeFrame, executes in the UI thread of IE. While this works fine in most cases for large data sizes, the IE UI thread ends up being busy pulling the data in our IBindStatusCallback::OnDataAvailable implementation. As a result the browser hangs until all data is pulled out. The fix is to handle Urlmon requests on a separate thread. This fixes http://code.google.com/p/chromium/issues/detail?id=24007 Changes to plugin_url_request.cc/.h are to set the LF property on these files. Bug=24007 Review URL: http://codereview.chromium.org/292035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29986 0039d316-1c4b-4281-b951-d872f2087c98
* Comment fixed.stoyan@google.com2009-10-231-1/+1
| | | | | | | TBR=amit Review URL: http://codereview.chromium.org/335013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29924 0039d316-1c4b-4281-b951-d872f2087c98
* Do not create dump on custom exception codes.stoyan@google.com2009-10-231-0/+7
| | | | | | | | BUG=23845 TEST=none Review URL: http://codereview.chromium.org/337002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29920 0039d316-1c4b-4281-b951-d872f2087c98
* Enhance extension UI testing by enabling you to select which extensionjoi@chromium.org2009-10-238-13/+50
| | | | | | | | | | | | | | APIs to forward (and thus stub out in your test), while others will keep being fulfilled as per usual. This lets you build tests that stub out one piece of behavior while testing that some side effects of another API happen as expected. BUG=none TEST=Run ui_tests.exe Review URL: http://codereview.chromium.org/314015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29919 0039d316-1c4b-4281-b951-d872f2087c98
* Add bindings to chrome frame to call the new extension automation apis.rogerta@chromium.org2009-10-2312-63/+402
| | | | | | | | | TEST=see unit tests BUG=0 Review URL: http://codereview.chromium.org/284017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29902 0039d316-1c4b-4281-b951-d872f2087c98
* Use scoped_array (not scoped_ptr) with new[].kuchhal@chromium.org2009-10-232-2/+2
| | | | | | | | | BUG=24266 TEST=No functional change so make sure nothing changes. Review URL: http://codereview.chromium.org/307045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29843 0039d316-1c4b-4281-b951-d872f2087c98
* Somewhat useful hack to have the chrome frame integration test run in server ↵robertshield@chromium.org2009-10-221-0/+25
| | | | | | | | | | mode (via a "--server" command line). This allows the test executable to just start the local server and wait which can be useful for debugging failing tests. Review URL: http://codereview.chromium.org/307042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29801 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old ap-value munging code in Chrome Frame.robertshield@chromium.org2009-10-214-170/+0
| | | | | | Review URL: http://codereview.chromium.org/303023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29696 0039d316-1c4b-4281-b951-d872f2087c98
* Give ourselves 20 seconds for Chrome startup vs 4 to help alleviate ↵slightlyoff@chromium.org2009-10-211-1/+4
| | | | | | | | | | | intermittent "blank page" GCF bugs. BUG=23414 TEST=None Review URL: http://codereview.chromium.org/293035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29590 0039d316-1c4b-4281-b951-d872f2087c98
* For Steven Truong (stevet@)mad@chromium.org2009-10-204-187/+215
| | | | | | | | Reviewed in: http://codereview.chromium.org/276068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29543 0039d316-1c4b-4281-b951-d872f2087c98
* Removing hard-coded Chrome Frame output path.robertshield@chromium.org2009-10-201-2/+2
| | | | | | | | | BUG=Builders who generate build artifacts elsewhere than in the source tree break when building setup.exe with CHROME_FRAME_BUILD defined. TEST=Said builders don't break. Review URL: http://codereview.chromium.org/306005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29520 0039d316-1c4b-4281-b951-d872f2087c98
* Assigning INFINITE (which is 0xFFFFFFFF) to an int, is not a very good idea...mad@chromium.org2009-10-191-4/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/285012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29478 0039d316-1c4b-4281-b951-d872f2087c98
* Correcting name of data file used for CF protocol test.robertshield@chromium.org2009-10-191-1/+1
| | | | | | | | BUG=ChromeFrameTestWithWebServer, FullTabModeIE_CFProtocol was failing. TEST=ChromeFrameTestWithWebServer, FullTabModeIE_CFProtocol doesn't fail. Review URL: http://codereview.chromium.org/303005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29445 0039d316-1c4b-4281-b951-d872f2087c98
* If we fail to launch a browser during an integration test, fail the test ↵robertshield@chromium.org2009-10-191-1/+1
| | | | | | | | | | | immediately instead of waiting for stuff to timeout. BUG=CF integration tests that fail to launch a browser take a while to timeout instead of failing quickly. TEST-Run the integration tests on a system without Firefox installed. Review URL: http://codereview.chromium.org/303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29439 0039d316-1c4b-4281-b951-d872f2087c98
* When Chrome hands off a URL to be opened by the external host by the ↵ananta@chromium.org2009-10-1913-24/+160
| | | | | | | | | | | | | | | | | | | | | | | ViewHostMsg_OpenURL IPC, it needs to pass the referrer as well. The Chrome fixes in this CL are mostly related to passing the HTTP referer off to the browser and from there to the ExternalTabContainer to ChromeFrame and back. The ChromeFrame changes are basically around the same lines with one exception. When we handle the AutomationMsg_OpenURL IPC in the activex and the active document we pass the referer if applicable to the WebBrowser2::Navigate2 interface, which is then read by the BHO in BeforeNavigate2. We then save away an AddRef'ed BHO pointer in TLS which is then referenced by the Active document for reading the referer and passing it off to Chrome in the NavigateInExternalTab message. Added a unit test in ChromeFrame which tests this case. This fixes http://code.google.com/p/chromium/issues/detail?id=22994 Bug=22994 Review URL: http://codereview.chromium.org/274071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29420 0039d316-1c4b-4281-b951-d872f2087c98
* Simplification, generalization (and perhaps additional mystification) of ↵stoyan@google.com2009-10-192-460/+495
| | | | | | | | | | | | | gmock helpers. Leak fixed - when gmock call is not satisfied, the callback that was set was leaked. Suggestion for better names here and there are very welcome (though MF seems nice to me). TEST=mocked tests runs Review URL: http://codereview.chromium.org/285007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29402 0039d316-1c4b-4281-b951-d872f2087c98
* Adding files containing archive paths for Chrome Frame.robertshield@chromium.org2009-10-193-0/+8
| | | | | | Review URL: http://codereview.chromium.org/288006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29385 0039d316-1c4b-4281-b951-d872f2087c98
* Add the chromeframe tag to the user agent header at runtime instead of ↵tommi@chromium.org2009-10-1714-817/+1500
| | | | | | | | statically in the registry.TEST=Try disabling GCF and see if the chromeframe tag in the user agent is still set. It should not be. Also make sure you don't have an older version installed... the chromeframe tag should not be in the registry - if it is, you've got an older version still registered. This should fix the issue with going to wave.google.com after disabling chrome frame and seeing the white page of death.R=amitBUG=22760 Review URL: http://codereview.chromium.org/259025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29370 0039d316-1c4b-4281-b951-d872f2087c98
* Pick up version number from resources for crash dumps.stoyan@google.com2009-10-162-7/+22
| | | | | | | | TEST=dumps uploaded to crashserver has correct version info. BUG=24900 Review URL: http://codereview.chromium.org/283019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29344 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame perf tests should use the reference builds checked in under ↵ananta@chromium.org2009-10-161-2/+2
| | | | | | | | | | | | | | | chrome\tools\test\reference_builds. This CL updates the chrome frame tests to register the chrome frame dll from the correct path and deletes the reference build used by ChromeFrame. Fixes http://code.google.com/p/chromium/issues/detail?id=23382 Bug=23382 Review URL: http://codereview.chromium.org/284016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29342 0039d316-1c4b-4281-b951-d872f2087c98
* Committing for Steven who got LGTM from here:mad@chromium.org2009-10-1513-358/+455
| | | | | | | | | | http://codereview.chromium.org/264068 BUG=none TEST=none Review URL: http://codereview.chromium.org/276050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29196 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a tiny bit of silliness in chrome_frame_automation.cc.robertshield@chromium.org2009-10-151-2/+1
| | | | | | Review URL: http://codereview.chromium.org/271097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29114 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try r29078: Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-156-20/+26
| | | | | | | | | | | | | With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced). Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705 mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491 linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466 I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet. Review URL: http://codereview.chromium.org/271099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
* Revert wstring patch (r29078 and follow up commits). It is causing failures ↵estade@chromium.org2009-10-155-23/+19
| | | | | | | | | | on the buildbots. TBR=nsylvain Review URL: http://codereview.chromium.org/280004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix chrome frame build again.estade@chromium.org2009-10-152-8/+11
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/276040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29083 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome frame build, take 3.estade@chromium.org2009-10-151-0/+2
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/280003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29082 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 10:49:50 +0000