summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* base::Bind: Remove includes of base.bind in header files.jhawkins@chromium.org2011-12-213-32/+53
| | | | | | | | | | BUG=none TEST=none R=ajwong Review URL: http://codereview.chromium.org/8956019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115398 0039d316-1c4b-4281-b951-d872f2087c98
* Rename PluginService to PluginServiceImpl.jam@chromium.org2011-12-211-1/+0
| | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/9019004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115279 0039d316-1c4b-4281-b951-d872f2087c98
* Remove remaining references to CEEE.rogerta@chromium.org2011-12-2010-55/+31
| | | | | | | | | BUG=107739 TEST=No visible code changes. Removing constants and code related to CEEE. Review URL: http://codereview.chromium.org/8909009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115183 0039d316-1c4b-4281-b951-d872f2087c98
* Move general UiPerfTest code to shared area in preparation for performance ↵jbates@chromium.org2011-12-201-17/+14
| | | | | | | | | | | browser tests. BUG=107745 Review URL: http://codereview.chromium.org/8971004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115052 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-192-3/+7
| | | | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114944 Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114993 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114944 - Standardize StringToInt{,64} interface.battre@chromium.org2011-12-182-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Revert due to compile breakage on ChromeOS. These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Review URL: http://codereview.chromium.org/8921006 TBR=tedvessenes@gmail.com Review URL: http://codereview.chromium.org/8990002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114945 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-182-3/+7
| | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114944 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114929 - Standardize StringToInt{,64} interface.rsleevi@chromium.org2011-12-172-7/+3
| | | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Review URL: http://codereview.chromium.org/8921006 TBR=tedvessenes@gmail.com Review URL: http://codereview.chromium.org/8984007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114930 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-172-3/+7
| | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114929 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Chrome Frame crash when automation server dies.grt@chromium.org2011-12-172-4/+5
| | | | | | | | | | | | GCF was crashing if the automation server dies while there are outstanding sub-resource requests being serviced on the new bg thread. The reason was that AutomationServerDied posts a task to InitializeComplete(AUTOMATION_SERVER_CRASHED) and then a task to Uninitialize(). The former will call ReleaseAutomationServer() without first joining on the bg resource thread. The fix is to wait and release the server in Uninitialize. BUG=107811 TEST=Prior to fix, the following would usually trigger the crash: chrome_frame_tests.exe --gtest_repeat=20 --gtest_filter=CF/FullTabUITest.TabCrashReload/0 Review URL: http://codereview.chromium.org/8965031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114906 0039d316-1c4b-4281-b951-d872f2087c98
* chrome_frame: Include notification_service.h instead of ↵tfarina@chromium.org2011-12-161-1/+1
| | | | | | | | | | | notification_service_impl.h. BUG=98716 R=jam@chromium.org Review URL: http://codereview.chromium.org/8949017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114796 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid including gtest file directly, and go through base insteadjar@chromium.org2011-12-151-1/+1
| | | | | | | | | | | | | | | | | | We should consistently: #include "base/gtest_prod_util.h" which does the gtest include (from the right place, in a second repo, hidden in our tree). This is critical to being able to supplant the FRIEND_TEST macro, which we're experimenting with to optimize builds. r=brettw TBR=other owners (this is a trivial change) BUG=107727 Review URL: http://codereview.chromium.org/8954017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114685 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ChromeFrame net tests for IE versions 8 and below. Changes include ↵ananta@chromium.org2011-12-151-20/+8
| | | | | | | | | | | | | | | | | | | the following:- 1. Get rid of the dummy AtlModule registration in the chrome frame net test suite. This is no longer needed as there is an Atlmodule instance instantiated by the content code. 2. The TestSuite and NetTestSuite classes now provide special protected constructors which allow test instances to control whether an AtExitManager instance is created for the duration of the test. The ChromeFrame net test suite reuses the AtExitManager instance created in BrowserMain. Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435 BUG=105435 TEST=ChromeFrame net tests should now run on the builders. Review URL: http://codereview.chromium.org/8907054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114559 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114320 (broke chrome_frame_tests) - Enable ChromeFrame net tests for ↵willchan@chromium.org2011-12-141-7/+19
| | | | | | | | | | | | | | | | | | | | | | IE versions 8 and below. Changes include the following:- 1. Get rid of the dummy AtlModule registration in the net test suite. This is no longer needed as there is a module instance instantiated by the content code. 2. The test suite class now instantiates the ShadowAtExitManager class which allows nesting of AtExitManager instances. This is needed because the ChromeFrame net tests suite now calls into ContentMain which also instantiates an AtExitManager instance. Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435 BUG=105435 TEST=ChromeFrame net tests should now run on the builders. Review URL: http://codereview.chromium.org/8898026 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/8937020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114341 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ChromeFrame net tests for IE versions 8 and below. Changes include ↵ananta@chromium.org2011-12-141-19/+7
| | | | | | | | | | | | | | | | | | | the following:- 1. Get rid of the dummy AtlModule registration in the net test suite. This is no longer needed as there is a module instance instantiated by the content code. 2. The test suite class now instantiates the ShadowAtExitManager class which allows nesting of AtExitManager instances. This is needed because the ChromeFrame net tests suite now calls into ContentMain which also instantiates an AtExitManager instance. Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435 BUG=105435 TEST=ChromeFrame net tests should now run on the builders. Review URL: http://codereview.chromium.org/8898026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114320 0039d316-1c4b-4281-b951-d872f2087c98
* This goes most of the way to re-enabling chrome_frame_net_tests by making it ↵joi@chromium.org2011-12-125-224/+372
| | | | | | | | | | | | | | a content::BrowserMainParts. The tests are still disabled until we are able to test them on IE8 and older; on IE9 all tests currently pass except for a few that hang. Additionally, this makes chrome_frame_net_tests determine protocol version using the exact same version information as npchrome_frame.dll does, so that version mismatch due to the RC dependency problems we have sometimes seen should not happen any more with this test suite. While in there, I also updated the poor_mans_trybot.bat script. BUG=105435 Review URL: http://codereview.chromium.org/8894008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114080 0039d316-1c4b-4281-b951-d872f2087c98
* Removing MessageLoop::QuitTask() from chrome_frame/dcheng@chromium.org2011-12-106-10/+10
| | | | | | | | | | | | | base/task.h is going away and being replaced by base/bind.h and base/callback.h. This CL was automatically generated by sed. BUG=none TEST=none Review URL: http://codereview.chromium.org/8879033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113920 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts a commit that caused ASAN failures, and 2 dependent commits.joi@chromium.org2011-12-071-1/+1
| | | | | | | | | | | | | The primary commit was 113249, the dependents were 113261, 113263. This is a speculative revert, r113249 is by far the likeliest culprit in the blamelist of build http://build.chromium.org/p/chromium.memory/builders/ASAN%20Tests%20%282%29/builds/2325 which is where we started seeing the ASAN failures in question, will un-revert if it does not fix the problem. TBR=jhawkins@chromium.org BUG=none Review URL: http://codereview.chromium.org/8832006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113387 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome Frame test fixes for Vista/IE7.grt@chromium.org2011-12-0614-165/+258
| | | | | | | | | | | | | Write the ActiveX control from an external script in all test documents. This works around a "feature" of IE versions released between April, 2006 and April, 2008 that required the user to click on an ActiveX control to "activate" it. See http://msdn.microsoft.com/en-us/library/ms537508.aspx. I also added asserts for the copying of CFInstance and CFInstall so that the whole test aborts if the files can't be copied, since otherwise test results are bogus. BUG=60987 TEST=no manual testing needed; chrome_frame_tests.exe will either become better or worse. Review URL: http://codereview.chromium.org/8777002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113291 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert disk_cache_based_ssl_host_info.jhawkins@chromium.org2011-12-061-1/+1
| | | | | | | | | | | BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8794003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113249 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression of ContextMenuTest.CFTxtFieldPastevsevik@chromium.org2011-12-021-1/+1
| | | | | | | | TBR=kkania Review URL: http://codereview.chromium.org/8769033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112666 0039d316-1c4b-4281-b951-d872f2087c98
* Added recommended pref store on Windows.joaodasilva@chromium.org2011-12-012-5/+5
| | | | | | | | | BUG=49941 TEST=Set policies for Chromium/Chrome in a registry subkey named "Recommended". Those policies become the default values and can be overridden by the user. Review URL: http://codereview.chromium.org/8551010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112456 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in poor man's trybot.joi@chromium.org2011-11-301-1/+1
| | | | | | | | | TBR=grt@chromium.org BUG=none Review URL: http://codereview.chromium.org/8754002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112272 0039d316-1c4b-4281-b951-d872f2087c98
* Use callback_forward.h instead of callback.h where possible.erikwright@chromium.org2011-11-301-2/+1
| | | | | | | | | | | | | | | callback_forward.h will be committed separately, before this commit, and is included here only to assist in running try jobs. It will be removed before the final commit. You are asked to review this as you have OWNERS for these files. BUG=None TEST=Compiles R=ben@chromium.org Review URL: http://codereview.chromium.org/8699008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112243 0039d316-1c4b-4281-b951-d872f2087c98
* ake string_util::WriteInto() DCHECK() that the supplied |length_with_null| > ↵pkasting@chromium.org2011-11-293-3/+5
| | | | | | | | | | | | 1, meaning that the without-'\0' string is non-empty. This replaces the conditional code added recently that makes this case return NULL. It's easier to understand if it's simply an error to call WriteInto() in this case at all. Add DCHECK()s or conditionals as appropriate to callers in order to ensure this assertion holds. BUG=none TEST=none Review URL: http://codereview.chromium.org/8418034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112005 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111910 - Attempt to re-enable ChromeFrame net tests.joi@chromium.org2011-11-291-2/+4
| | | | | | | | | | | | | | Partial revert of r111705. TBR=robertshield@chromium.org BUG=105435 Review URL: http://codereview.chromium.org/8728027 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/8726032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111914 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to re-enable ChromeFrame net tests.joi@chromium.org2011-11-291-4/+2
| | | | | | | | | | | Partial revert of r111705. TBR=robertshield@chromium.org BUG=105435 Review URL: http://codereview.chromium.org/8728027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111910 0039d316-1c4b-4281-b951-d872f2087c98
* Have content/ create and destroy its own threads. (Re-land)joi@chromium.org2011-11-283-12/+44
| | | | | | | | | | | | | | | | | | | Change embedding API and embedders to allow for this. Push inheritance of base::Thread down to content::BrowserThreadImpl so that content::BrowserThread is just a namespace for API functions. This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435. TBR=ben@chromium.org (IWYU change only) BUG=98716,104578,105435 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111695 Reverted (problems on official bot): r111698 Review URL: http://codereview.chromium.org/8477004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111705 0039d316-1c4b-4281-b951-d872f2087c98
* Update poor man's trybot script.joi@chromium.org2011-11-281-11/+20
| | | | | | | | | | | | | | It will now work with new paths, build/Debug etc. An addition of a couple of optional parameters allows for both push and pull modes of operation, i.e. the script may be run on either the VM or the dev machine. BUG=none Review URL: http://codereview.chromium.org/8706001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111700 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111695 - Have content/ create and destroy its own threads.joi@chromium.org2011-11-283-44/+12
| | | | | | | | | | | | | | | | | | | | | Reason: Problems on official builders. Change embedding API and embedders to allow for this. Push inheritance of base::Thread down to content::BrowserThreadImpl so that content::BrowserThread is just a namespace for API functions. This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435. TBR=ben@chromium.org (IWYU change only) BUG=98716,104578,105435 Review URL: http://codereview.chromium.org/8477004 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/8718012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111698 0039d316-1c4b-4281-b951-d872f2087c98
* Have content/ create and destroy its own threads.joi@chromium.org2011-11-283-12/+44
| | | | | | | | | | | | | | | | Change embedding API and embedders to allow for this. Push inheritance of base::Thread down to content::BrowserThreadImpl so that content::BrowserThread is just a namespace for API functions. This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435. TBR=ben@chromium.org (IWYU change only) BUG=98716,104578,105435 Review URL: http://codereview.chromium.org/8477004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111695 0039d316-1c4b-4281-b951-d872f2087c98
* Allow GCF installation on machine with old IE 7 installs.grt@chromium.org2011-11-251-1/+3
| | | | | | | | | | BUG=105386 TEST=install on Vista RTM (IE 7.0.6000.16386). if it fails, the fix doesn't work. R=robertshield@chromium.org Review URL: http://codereview.chromium.org/8702010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111605 0039d316-1c4b-4281-b951-d872f2087c98
* Fix many* python scripts in src/maruel@chromium.org2011-11-233-9/+17
| | | | | | | | | | | | | | | | | | | | Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. * Do not fix them all at once otherwise the CL would be too large. TBR=jamiewalch@chromium.org BUG=105108 TEST= Review URL: http://codereview.chromium.org/8665013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111427 0039d316-1c4b-4281-b951-d872f2087c98
* Fix python scripts src/chrome_frame/tools/test/page_cycler/cf_cycler.pymaruel@chromium.org2011-11-231-99/+100
| | | | | | | | | | | | | | | | | | | Make sure that: - shebang is only present for executable files - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. * Doing it separately since the CQ cannot process it. TBR=robertshield@chromium.org BUG=105108 TEST= Review URL: http://codereview.chromium.org/8662025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111399 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling chrome frame net tests on IE9 as they are flaky.ananta@chromium.org2011-11-231-0/+10
| | | | | | | | | TBR=robertshield BUG=none TEST=chrome frame net tests should not run on IE9 Review URL: http://codereview.chromium.org/8679012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111372 0039d316-1c4b-4281-b951-d872f2087c98
* Remove other mentions of renderer_glue.ccpiman@chromium.org2011-11-221-3/+0
| | | | | | | | | BUG=broken build TEST=fixes build Review URL: http://codereview.chromium.org/8633005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111103 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert chrome_frame/.jhawkins@chromium.org2011-11-1819-198/+224
| | | | | | | | | | | BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8555001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110744 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove forward declarations in various directories.thestig@chromium.org2011-11-184-19/+12
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8567022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110631 0039d316-1c4b-4281-b951-d872f2087c98
* Define the public interface for content browser RenderProcessHost. This ↵ananta@chromium.org2011-11-181-2/+2
| | | | | | | | | | | | | | | interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes. The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h. Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now. Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL. BUG=98716 TEST=No change in functionality. Hopefully it all compiles and works. Review URL: http://codereview.chromium.org/8515027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame: Convert TaskMarshallerThroughMessageQueue to new Callback system.jhawkins@chromium.org2011-11-175-124/+109
| | | | | | | | | | | BUG=none TEST=none R=willchan@chromium.org,stoyan@chromium.org Review URL: http://codereview.chromium.org/8591009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110595 0039d316-1c4b-4281-b951-d872f2087c98
* Add arguments in macros where requiredjar@chromium.org2011-11-171-20/+26
| | | | | | | | | | | This was breaking a variant of the current macro, so I defined a no-op for the "code" values. r=slightlyoff BUG=103830 Review URL: http://codereview.chromium.org/8511083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110585 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move UnescapeRule into the net namespace.tfarina@chromium.org2011-11-151-1/+1
| | | | | | | | | | | BUG=64263 TEST=None R=willchan@chromium.org Review URL: http://codereview.chromium.org/8552002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110085 0039d316-1c4b-4281-b951-d872f2087c98
* Allow linker initialization of lazy instancejoth@chromium.org2011-11-158-12/+12
| | | | | | | | | | | | | | Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a DCHECK on stopping_ from StartRequestHelper. Since ↵robertshield@chromium.org2011-11-141-1/+0
| | | | | | | | | | | | | StartRequestHelper is now called on a background thread, it does not make sense to DCHECK on a piece of state set on the main thread; stopping_ may well be set by the time the StartRequestHelper task is run. On teardown, we do block until pending background requests are handled, so it looks safe to remove the DCHECK. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8564026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109967 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Low-hanging fruit conversions of NewRunnableFunction.jhawkins@chromium.org2011-11-126-21/+32
| | | | | | | | | | | BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8536037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109803 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ↵thakis@chromium.org2011-11-051-0/+4
| | | | | | | | | | | | URLRequestTestHTTP.NetworkDelegateRedirectRequest/MultipleRedirectTest in chromeframe tests. BUG=103097 TEST=none Review URL: http://codereview.chromium.org/8480024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108793 0039d316-1c4b-4281-b951-d872f2087c98
* Resolve check-perms failures.csilv@chromium.org2011-11-044-0/+0
| | | | | | | | TBR=csilv BUG=none Review URL: http://codereview.chromium.org/8481006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108699 0039d316-1c4b-4281-b951-d872f2087c98
* Publish the source for CFInstall.min.js .erikwright@chromium.org2011-11-0420-0/+1411
| | | | | | | | | BUG=None TEST=./build.sh and then load file:///path/to/local_testing.html in IE (without CF). Click the "This site requires Chrome Frame" link and observe the dialog that pops up. Review URL: http://codereview.chromium.org/8467005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108675 0039d316-1c4b-4281-b951-d872f2087c98
* Introduces chromium_resources.gyp to factor out Chrome resource generationdhollowa@chromium.org2011-11-031-5/+5
| | | | | | | | | | | | | | | | | | | | 1. Factors out Chrome/Chromium resource generation into a separate chrome_resources.gyp file. 2. Eliminates repetition between Mac and other platforms. 3. Breaks long "repack" actions out into separate files for greater readability. 4. Eliminates circular dependencies in the Aura shell, the Views components, and the compositor when utilizing Chrome resources. BUG=none TEST=try bots run gyps and build correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108466 Review URL: http://codereview.chromium.org/8425002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108517 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 108466 - Introduces chromium_resources.gyp to factor out Chrome ↵dhollowa@chromium.org2011-11-031-5/+5
| | | | | | | | | | | | | | | | | | | | | | | resource generation 1. Factors out Chrome/Chromium resource generation into a separate chrome_resources.gyp file. 2. Eliminates repetition between Mac and other platforms. 3. Breaks long "repack" actions out into separate files for greater readability. 4. Eliminates circular dependencies in the Aura shell, the Views components, and the compositor when utilizing Chrome resources. BUG=none TEST=try bots run gyps and build correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107967 Review URL: http://codereview.chromium.org/8425002 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/8448001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108468 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 07:35:55 +0000