summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Disabling the URLRequestTestHTTP.GetTest_NoCache test for ChromeFrame as ↵ananta@chromium.org2009-12-301-0/+4
| | | | | | | | | | | | this has been consistently failing on the chrome frame builder. TBR=tommi Review URL: http://codereview.chromium.org/515071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35395 0039d316-1c4b-4281-b951-d872f2087c98
* Authorization headers set using XHR with ChromeFrame were stripped in the ↵ananta@chromium.org2009-12-283-1/+70
| | | | | | | | | | | | | | | | | | | outgoing HTTP requests sent via the host network stack. Fix is to remove the authorization header from the list of filtered headers. Added a unit test for this. Fixes bug http://code.google.com/p/chromium/issues/detail?id=23103 Bug=23103 Test=Covered by unit test. Review URL: http://codereview.chromium.org/519013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35319 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a ChromeFrame crash in IE full tab mode. The crash ↵ananta@chromium.org2009-12-282-3/+6
| | | | | | | | | | | | | | | | | | occurs while processing an accelerator message and based on the callstack it looks like QueryService call for the SID_STopLevelBrowser interface returns S_OK with a NULL interface pointer. Added checks in the DoQueryService helper function to return a failure if the QueryService call returns a NULL service pointer. Fixes http://code.google.com/p/chromium/issues/detail?id=25457 Bug=25457 Review URL: http://codereview.chromium.org/523008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35315 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable the HTML renderer type detection in our ↵ananta@chromium.org2009-12-231-2/+0
| | | | | | | | | | | | IInternerProtocolSink::ReportProgress implementation as this causes the chrome frame tests to break. TBR=stoyan Review URL: http://codereview.chromium.org/515022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35244 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame net tests broken by the change to determine the renderer ↵ananta@chromium.org2009-12-232-1/+15
| | | | | | | | | | | | | | | | | type in our IInternetProtocolSink::ReportProgress implementation. To determine the renderer type we try to read the data from the IInternetProtocol interface which in turn tries to determine the renderer type. Fix is to check if we are in the context of determining the renderer and bail. TBR=stoyan Bug=31031 Review URL: http://codereview.chromium.org/518012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35234 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame in IE full tab mode would not render pages if Adblock Pro was ↵ananta@chromium.org2009-12-232-29/+58
| | | | | | | | | | | | | | | | | | | | | installed on the machine. Based on my debugging it looks like AdBlock gets confused because we report the mime type initally as text/html and then swich to application/chromepage. Fix is to attempt to determine the mime type in our IInternetProtocolSink::ReportProgress implementation. If we fail we continue to determine the mime type in IInternetProtocolSink::ReportData. Added a helper function CheckAndReportChromeMimeTypeForRequest which is invoked from both places. Fixes http://code.google.com/p/chromium/issues/detail?id=31031 Bug=31031 Review URL: http://codereview.chromium.org/501181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35227 0039d316-1c4b-4281-b951-d872f2087c98
* Enable UMA data upload in ChromeFramejar@chromium.org2009-12-231-6/+0
| | | | | | | | BUG=30508 r=ananta Review URL: http://codereview.chromium.org/502019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35223 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-221-1/+1
| | | | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35012 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35129 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame unit tests which use gmock exit with unexpected mock calls ↵ananta@chromium.org2009-12-212-4/+10
| | | | | | | | | | | | | warnings, which seem to be harmless at this point. Updated the relevant tests to expect these calls and ignore them. The changes to chrome_frame_automation_mock.cc are based on the review comments to the previous CL from phajdan. Review URL: http://codereview.chromium.org/504078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35115 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrameAutomationClient::InitiateNavigation method saves the passed ↵ananta@chromium.org2009-12-211-5/+6
| | | | | | | | | | | | in url to its member even if it disallows the navigation. Fixed. Review URL: http://codereview.chromium.org/501128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35113 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35012 - Rearrange build configurations make it clearer and allow ↵gregoryd@google.com2009-12-191-1/+1
| | | | | | | | | | | | | | better support for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/500149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35016 0039d316-1c4b-4281-b951-d872f2087c98
* Rearrange build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-191-1/+1
| | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35012 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame test failures on the builder caused by my CL to change the ↵ananta@chromium.org2009-12-183-19/+28
| | | | | | | | | | | | | | | | | | way the automation launch parameters are propagated to the ChromeFrameAutomationClient object. I also fixed the ChromeFrame automation mock tests which don't use gmock and instead relied on an incorrect behavior in ChromeFrame where we would deny the navigation from the automation client and still navigate in Chrome when the external tab is created. Will work on changing these tests to gmock in a subsequent CL. TBR=stoyan and thanks to him for helping debug the gmock failures. Review URL: http://codereview.chromium.org/500143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34996 0039d316-1c4b-4281-b951-d872f2087c98
* Multiple chrome frame activex controls should instantiate and navigate ↵ananta@chromium.org2009-12-185-45/+188
| | | | | | | | | | | | | | | | | | | | | | | correctly in IE. This was not the case due to a race condition between put_src getting called for subsequent activex instances and the external tab to hold the chrome frame instance getting created. Fix is to pass in the URL if we have it when the automation client is initialized to launch the chrome automation server. If not we navigate when the external tab is created. To achieve this we stuff in all relevant parameters into a structure which is populated when the automation client is initialized. I also changed the CreateExternalTab message to carry the referrer for the initial navigation. Fixes http://code.google.com/p/chromium/issues/detail?id=28236 Test=added unit tests for the same. The firefox one is not working at this point. Disabled this test for now while I debug it. Bug=28236 Review URL: http://codereview.chromium.org/500123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34985 0039d316-1c4b-4281-b951-d872f2087c98
* Handle right-click->"Save Link As" in the host browser.tommi@chromium.org2009-12-1610-14/+56
| | | | | | | | | TEST=Right click on a link in CF and select "save link as". You should immediately get the host browser's download UI. Before there could be a significant wait before this happened. BUG=23561 Review URL: http://codereview.chromium.org/506042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34783 0039d316-1c4b-4281-b951-d872f2087c98
* Marking flaky test flaky.slightlyoff@chromium.org2009-12-161-1/+2
| | | | | | | | | | TBR=ananta BUG=30622 TEST=None Review URL: http://codereview.chromium.org/502040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34774 0039d316-1c4b-4281-b951-d872f2087c98
* Tommi, please review everything. jam please review changes to ↵ananta@chromium.org2009-12-162-0/+63
| | | | | | | | | | | | | | | | | | | | | | resource_dispatcher_host.cc XMLHttpRequests issued by ChromeFrame instances would not use the host network stack at times. HTTP requests issued by these chrome instances are sent over automation to the host browser. This relies on the request having a renderer process id and a routing id for us to be able to intercept these requests. XHR requests are sent over to the browser via the ViewHostMsg_SyncLoad. This message has the routing id. However we always passed 0 down to the ResourceDispatcherHost::BeginRequest function which caused this to fail. Added a chrome frame specific unit test for this. Fixes bug http://code.google.com/p/chromium/issues/detail?id=30355 Bug=30355 Review URL: http://codereview.chromium.org/501040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34750 0039d316-1c4b-4281-b951-d872f2087c98
* Minor change to less confusing variable name in IsSubFrameRequest in ↵robertshield@chromium.org2009-12-161-4/+4
| | | | | | | | | | ChromeFrame utils. TBR=tommi Review URL: http://codereview.chromium.org/474001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34737 0039d316-1c4b-4281-b951-d872f2087c98
* The chrome_frame_unittests firefox unit tests have been randomly failing on ↵ananta@chromium.org2009-12-151-1/+4
| | | | | | | | | | | | | | the builder due to Firefox crashing in our npapi plugin while sending out a message via the host network stack. Based on the callstack it appears that the automation client is NULL. This is a purely speculative fix to get the builder green again. TBR=stoyan Review URL: http://codereview.chromium.org/503021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34622 0039d316-1c4b-4281-b951-d872f2087c98
* HTTPs sessions don't get established at times in ChromeFrame IE full tab ↵ananta@chromium.org2009-12-141-0/+18
| | | | | | | | | | | | | | | | | | | | | | mode. This typically happens when the initial logon redirects to an intermediate page which we try and abort in IE to ensure that Chrome follows the redirect. We try and abort the redirect in IE by returning E_ABORT from our IBindStatusCallback::OnProgress implementation and also aborting the binding. However at times urlmon continues to follow the redirect and attempts to establish a connection to the redirected url. Fix is to check for a NULL binding in our IHttpNegotiate::BeginningTransaction implementation and abort the same. Added traces in BeginningTransaction to indicate the same. Bug=30203 Test=As described in the bug. Review URL: http://codereview.chromium.org/487034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34467 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a stupid bug introduced by my previous change to fix the chrome frame ↵ananta@chromium.org2009-12-121-2/+3
| | | | | | | | | | | | | network tests, which causes the HTTP post redirect test to fail. TBR=tommi Bug=30118 Review URL: http://codereview.chromium.org/494007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34414 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame redirect network tests don't complete at times as we receive ↵ananta@chromium.org2009-12-121-2/+4
| | | | | | | | | | | | | | | invalid redirect response codes in our bind status callback implementation. Fix is to default to 302 in this case. This is an attempt to get the network tests up on the builder. TBR=tommi Bug=30118 Review URL: http://codereview.chromium.org/494006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34405 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame's host network stack implementation for IE should ensure that ↵ananta@chromium.org2009-12-121-2/+14
| | | | | | | | | | | | | | | | | | HTTP requests issued by Chrome which terminate without any data complete correctly, i.e. we send over the request end notification to Chrome. This ensures that Chrome does not wait forever for the request to complete. This fixes http://code.google.com/p/chromium/issues/detail?id=30149, which shows up on certain sites where the throbber continues to spin at times and at times pages show up blank. Bug=30149 Test=Launch ChromeFrame in IE and navigate to cf:http://www.tennisballcricket.org. We should not see a blank page. Will look into a unit test for this. Review URL: http://codereview.chromium.org/491057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34400 0039d316-1c4b-4281-b951-d872f2087c98
* Use the OnHttpEquiv notification to switch to CF when the http-equiv meta ↵tommi@chromium.org2009-12-118-204/+210
| | | | | | | | | | | | | | | | tag is detected. This implementation is still behind the registry switch (set PatchProtocols to 0 in the registry). I will switch over to it wholesale in a separate patch. We use the same mechanism for re-initiating the navigation we use to transfer downloads over to the host, so I moved the common code to utils.cc and added NavigateBrowserToMoniker. When we see a browser instance attempting to load a CF document, we raise a TLS flag that we catch in HttpNegotiatePatch::ReportProgress when the mime type is being reported. This is the same place where we examine http headers and report the mime type. BUG=n/a TEST=Set PatchProtocols (REG_DWORD) to 0 in the CF HKCU config key and make sure we detect and handle the meta tag as well or better than before. Review URL: http://codereview.chromium.org/489004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34366 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame net tests randomly crash in the url request redirect tests ↵ananta@chromium.org2009-12-111-0/+7
| | | | | | | | | | | | | | | | | | | | | | on the chrome frame builder. Some debugging revealed that we send over two redirect responses from the IE host network stack implementation to Chrome, which causes a crash in the url request automation job while dereferencing a NULL request. Two redirect responses are sent in the following scenario:- 1. We received a redirect notification in our bind status callback. We abort the binding and return E_ABORT. 2. Eventually we receive a call in our bind status callback implementation of OnResponse even after the binding was aborted. This causes the response to be sent twice. Added a check for a NULL binding and a trace in the IE host network stack implementation. I also added a NOTREACHED in the url request automation job if we ever receive a message for an automation job which has a NULL request. Bug=30118 Review URL: http://codereview.chromium.org/487028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34360 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix failing tests on the chrome frame builder.ananta@chromium.org2009-12-101-3/+4
| | | | | | | | | | The function to set keyboard focus to the chrome renderer window in a chrome frame instance was sending the mouse click to the ancestor window, which is not correct. The ancestor window is only needed to bring the whole hierarchy to the foreground. Review URL: http://codereview.chromium.org/491026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34304 0039d316-1c4b-4281-b951-d872f2087c98
* Allow privileged mode to navigate Chrome Frame to data: URLs. siggi@chromium.org2009-12-101-1/+3
| | | | | | | | | | | For Joi: http://codereview.chromium.org/434121 BUG=none TEST=In privileged mode, set the src attribute to something like "data:text/html,Hello World". Review URL: http://codereview.chromium.org/487009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34252 0039d316-1c4b-4281-b951-d872f2087c98
* Putting version file in intermediate dir, so it gets regenerated on a clobberbradnelson@google.com2009-12-101-1/+1
| | | | | | | | | | | | build reliably. BUG=None TEST=None TBR=tommi Review URL: http://codereview.chromium.org/484004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34217 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame crash reporting code should not depend on chrome frame as it ↵ananta@chromium.org2009-12-093-25/+45
| | | | | | | | | | | | | is also linked in by toolbar. This CL gets rid of this dependency and also ensures that full crash dumps are gathered during chrome frame reliability test runs. Review URL: http://codereview.chromium.org/481003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34180 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for running reliability tests for ChromeFrame on similar lines ↵ananta@chromium.org2009-12-0913-391/+1283
| | | | | | | | | | | | | | | | | | | | | | | | | as Chrome. We only run these tests for IE at this point. The reliability test code for Chrome has been copied and modified accordingly. Other related changes in this CL include the following:- 1. If ChromeFrame is running in headless mode determined by a registry value in HKCU\Software\Google\ChromeFrame we initialize ChromeFrame crash reporting and connect to the Chrome crash server. This would enable us to gather crash dumps from the reliability test runs and report the same. 2. The LowIntegrity fixes for the WebBrowser which Stoyan had done a while back are only needed for IE7 on Vista. For this CL though we just do the requisite hacks if the OS is Vista. For Windows7 the returned IWebBrowser interface pointer works fine. 3. I moved the WebBrowserEventSink to chrome_frame_test_utils as this class is now shared. Fixes portions of http://code.google.com/p/chromium/issues/detail?id=29451 Bug=29451 Review URL: http://codereview.chromium.org/465074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34119 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CFInstance to use a longer Deferred standard timeout. Short timeouts ↵slightlyoff@chromium.org2009-12-091-13/+8
| | | | | | | | | | | | caused cancellation of listeners and therefore backlogged RPC callback failure. The API requires that we use a timeout, but upping the default to 10s should accomidate nearly all CF startup delays. BUG=None TEST=run all the CFInstance tests in a Debug build. TBR=ananta Review URL: http://codereview.chromium.org/464077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34116 0039d316-1c4b-4281-b951-d872f2087c98
* The cache object used by the UrlmonUrlRequest class in ChromeFrame creates ↵ananta@chromium.org2009-12-082-85/+24
| | | | | | | | | | | | | | | | | | | | an in memory stream, which is used to hold data received from Urlmon until Chrome reads it. At times attempts to write to this stream fail with E_OUTOFMEMORY. We don't really need the complexity of an in memory stream for our cache. A vector of bytes would do just fine. This fixes bug http://code.google.com/p/chromium/issues/detail?id=28658 I verified that it actually fixes this issue. Bug=28648 Test=covered by existing net tests. Review URL: http://codereview.chromium.org/469014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34086 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes incorrect test against OS version instead of browser versionslightlyoff@chromium.org2009-12-072-12/+6
| | | | | | | | | BUG=28038,29193 TEST=on any XP box this should pass: chrome_frame_test.exe --gtest_filter=*CFInstall* Review URL: http://codereview.chromium.org/469012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34020 0039d316-1c4b-4281-b951-d872f2087c98
* Kill all browser instances at test start up in addition to at tear down ↵robertshield@chromium.org2009-12-074-8/+192
| | | | | | | | | | | | | which should improve test reliability. Make running the Chrome Frame integration tests slightly less onerous by not killing non-ChromeFrame instances of Chrome. BUG=All chrome.exe instances would die when running these tests, which made them annoying to run. TEST=Only Chrome Frame instances of Chrome will be killed when running the integration tests. Review URL: http://codereview.chromium.org/467036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33991 0039d316-1c4b-4281-b951-d872f2087c98
* The following tests have been marked FLAKY as they fail on the chrome frame ↵ananta@chromium.org2009-12-061-4/+10
| | | | | | | | | | | | | | | | | | | | buildbot 1. FullTabIE_CFInstallBasic / 2. FullTabIE_CFInstallPlace / 3. FullTabIE_CFInstallOverlay 4. FullTabIE_CFInstallDismiss Bug=29193 TBR=slightlyoff Review URL: http://codereview.chromium.org/464056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33943 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeFrame build bot redness caused by us incorrectly wrapping ↵ananta@chromium.org2009-12-061-0/+2
| | | | | | | | | | | | protocol sinks which don't have an associated IWebBrowser. TBR=robertshield Review URL: http://codereview.chromium.org/469003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33942 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable CFInstall tests after buildbot restart. Clobbering window open ↵slightlyoff@chromium.org2009-12-061-12/+5
| | | | | | | | | | | | test that currently borks the bot. TBR iyengar. BUG=29193 TEST=None TBR=ananta Review URL: http://codereview.chromium.org/462041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33934 0039d316-1c4b-4281-b951-d872f2087c98
* Limit the X-UA-Compatible HTTP header-based altering of the mime type ↵robertshield@chromium.org2009-12-044-65/+88
| | | | | | | | | | | performed by Chrome Frame to top-level requests only in IE. BUG=having an iframe that requests a resource that includes the X-UA-Compatible header in the response will trigger CF taking over the page. TEST=BUG doesn't happen anymore. Review URL: http://codereview.chromium.org/465036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33849 0039d316-1c4b-4281-b951-d872f2087c98
* Added new IPC message class for CommandBuffer.apatrick@google.com2009-12-041-2/+2
| | | | | | | | | | Increased IPC message header type from 16 bits to 32 bits so it can accomodate more message classes. TEST=none BUG=none Review URL: http://codereview.chromium.org/399013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33832 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to the string MatchPattern functions:tony@chromium.org2009-12-031-1/+1
| | | | | | | | | | | | | | | 1) Make it explicit that it only supports ASCII (since it iterates character by character). 2) Limit the recursion to 16 levels. We could allow more, but in the case of a ?, it has exponential complexity, so I figured 16 was a good stopping point. It seems rare that someone would have more than 16 '?' and '*'s. BUG=28645 Review URL: http://codereview.chromium.org/460047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33748 0039d316-1c4b-4281-b951-d872f2087c98
* Remove erroneous DCHECK that is reached when loading pages that don't call ↵robertshield@chromium.org2009-12-032-11/+21
| | | | | | | | | | | | | | | out to wininet like about:blank. Altering constant name pulled in from latest platform SDK to avoid naming conflicts for those with said SDK. Add slightly more logging to error messages. BUG=DCHECK hit when loading about:blank. TEST=Load about:blank in a debug build and no DCHECK is seen. Review URL: http://codereview.chromium.org/465030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33706 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for Chrome Frame to be loaded via the presence of an ↵robertshield@chromium.org2009-12-036-23/+180
| | | | | | | | | | | | | X-UA-Compatible HTTP header (in addition to the meta tag support). Also pins the CF module into the process such that it won't get unloaded. Doing this to work around how we can get unloaded without unpatching properly. BUG=22802 TEST=Navigate to a web site whose server sends the X-UA-Compatible: chrome=1 HTTP header and ensure that the page is loaded in CF. Review URL: http://codereview.chromium.org/465009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33629 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the following tests as they consistently fail on the chrome frame ↵ananta@chromium.org2009-12-021-4/+11
| | | | | | | | | | | | | | | | builder. 1. FullTabIE_CFInstallBasic 2. FullTabIE_CFInstallDismiss 3. FullTabIE_CFInstallOverlay 4. FullTabIE_CFInstallPlace Bug=29193 TBR=slightlyoff Review URL: http://codereview.chromium.org/465008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33578 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to get the chrome frame network tests up and running on the chrome ↵ananta@chromium.org2009-12-021-2/+10
| | | | | | | | | | | | | | | | | frame builder. Fixes as below:- 1. Instantiate the SystemMonitor object as it is needed to instantiate the profile. 2. Adds the single-process command line to the chrome_frame_net_tests executable to ensure that the webkit thread gets initialized correctly. 3. Register additional prefs in the profile to get around some DCHECKS which fire in debug mode TBR=tommi Review URL: http://codereview.chromium.org/464001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33570 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash caused by a race condition between the time the ↵ananta@chromium.org2009-12-022-10/+17
| | | | | | | | | | | | | | | | | | UrlmonUrlRequest::EndRequestInternal task executing and the OnStopBinding function getting called by Urlmon. If our task executes first we essentially operate on an invalid object. Fixes http://code.google.com/p/chromium/issues/detail?id=29033 Added a comment to the EndRequest function indicating that it is invalid to access any members after it is called. Added a helper function to release the bindings and revoke the bind status callback. Bug=29033 Review URL: http://codereview.chromium.org/456013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33551 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-302-0/+3
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-302-3/+0
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-302-0/+3
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Make SystemMonitor not a Singleton and move it out of basephajdan.jr@chromium.org2009-11-261-1/+1
| | | | | | | | | | | | | SystemMonitor makes an assumption that through its lifetime a MessageLoop exists and stays the same. It is difficult and error-prone to satisfy that when it is a Singleton. It has caused problems in the past. Additionally, extract HighResoltionTimerManager out of time_win.cc, eliminating yet another Singleton. TEST=none BUG=none Review URL: http://codereview.chromium.org/431008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33214 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ETW logging in Chrome Frame.siggi@chromium.org2009-11-251-0/+9
| | | | | | | | | BUG=0 TEST=none Review URL: http://codereview.chromium.org/437064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33122 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 21:24:46 +0000