| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
uses redirects. We were not correctly marking the navigation as completed (when it was).
Fix the description of the timeout setting in the chrome frame reliability tests.
BUG=53875
TEST=Use an URL list that includes a URL that navigates to a site that uses redirects (e.g. www.google.com outside of the US). See that no error appears in the log for that site.
Review URL: http://codereview.chromium.org/3239008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
navigation sequence missing for the second URL loaded as part of the test. We were not firing the BeforeNavigate event for IE6 for navigations initiated by Webkit. This should also fix the Form post back forward tests which were failing on IE6.
TBR=amit
Review URL: http://codereview.chromium.org/3266011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3162047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
installs. The helper process registers a hook dll that performs the necessary BHO injection instead of registering it in HKLM.
BUG=53127
TEST=Non-admin CF installs work.
Review URL: http://codereview.chromium.org/3158036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allow navigations
from the automation client in the initialized state.
The NPAPI implementation attempts to navigate once we initialize Chrome over automation for
historical reasons. This results in requesting navigations to the same URL, once when the
plugin is initialized and once when the server is launched.
Fix is to have a flag which indicates if we received a navigation request before initalization
and only navigate in automation server ready notification if yes.
TBR=amit
Review URL: http://codereview.chromium.org/3281002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame.
Should fix bug http://code.google.com/p/chromium/issues/detail?id=53648
Bug=53648
Review URL: http://codereview.chromium.org/3273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is NULL are
always reported back to the host browser as top level navigations. The other change
is to always send over navigation requests from the automation client even if the
url remains the same if the client is already initialized, i.e this is treated as a new
navigation.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=38456
Bug=38456
Test=The ChromeFrame side of the change is covered by a new chrome frame mock test.
Will add a test for the render view change in a subsequent CL.
Review URL: http://codereview.chromium.org/3235001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3276001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3176026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was trying to replace wstring usage in base::FileVersionInfo, but
that class is rather Windows-specific with strange fields like
"private_build()" where the value and encoding aren't clear. 95%
of the users of FileVersionInfo actually just care about the current
Chrome version, so we can provide a much simpler interface for them.
We still use FileVersionInfo for retrieving information from e.g.
plugin DLLs, but in those cases the usage is clearer.
Review URL: http://codereview.chromium.org/3135028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It did two things:
1) built two source files -- this is moved into the "common" target
2) on Linux, generated some data used by those source files -- this is moved into an action on the "common" target
Review URL: http://codereview.chromium.org/3152052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Other callbacks can fire in the context of ReadStream and
OnStopBinding might happen in that context. In this case
the delegate_ is cleaned up and this results in a crash
when ReadStream returns.
BUG=53460
TEST=none
Review URL: http://codereview.chromium.org/3159045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(http://codereview.chromium.org/3167040/show)
In IE8, on Vista, when the user deletes their browsing data, the IDeleteBrowsingHistory interface is invoked twice - once in a low integrity process and once in a medium integrity process.
Only the medium integrity process may succeed, but the low integrity process will restart the automation server after failing to connect to it.
Upon invocation by IE, check the integrity level of the current process - if it is low, exit. GetProcessIntegrityLevel was adapted from rlz. A follow-up changeset will modify rlz to use this implementation.
During editing, some unnecessary headers were removed from win_util.h and correspondingly added to win_util.cc and certain clients who were depending on transient includes.
BUG=56212
TEST=Load some pages using Chrome Frame. Close IE. Verify that the Chrome Frame cache has grown and that the accessed domains appear in the history files. Launch IE, load a page using Chrome Frame. Delete Browsing Data. Note that the tab does not crash, that the on-disk cache files shrink, and that the accessed domains no longer appear in the history file
Review URL: http://codereview.chromium.org/3171033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In the future this may even be used to tune some settings/behaviors
(like timeouts) for performance tests.
TEST=ui_tests, page_cycler_*, etc
BUG=none
Review URL: http://codereview.chromium.org/3137040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=See bug.
BUG=52894
Review URL: http://codereview.chromium.org/3122041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename includes, resort header include order in places where the rename
changed the order.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3203008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=n/a
BUG=44463
Review URL: http://codereview.chromium.org/3117040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
desktop is locked.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3191022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Differences over the reverted version (http://codereview.chromium.org/3080034/show - reverted http://codereview.chromium.org/3137022/show ):
* Jobs never log anything in their destructor, as the HostResolverImpl randomly outlives the NetLog, at least in some unit tests.
* Removed the extra log entries for when a DNS lookup starts/completes. Instead, the job's event is ended in OnLookupComplete().
* Slight modification of the CanceledAsynchronousLookup unit test, as the Job is now closed before posting any events to the Request. For actual lookups, this behavior means the Job's duration more accurately reflects the time the DNS lookup takes itself.
BUG=46844
TEST=Look at the net-internals screen.
Review URL: http://codereview.chromium.org/3119027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reported back
to the host browser. We no longer have a counter which tracks the last page id.
Top level navigations are reported back if the current frame does not have an opener
or if the origins don't match. The other conditions remain the same i.e reloads/back forwards
and posts don't make it to the host browser and are treated as internal navigations.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=52931
Disabled the navigate out chrome frame test as this needs to be fixed to propertly detect
navigations coming out of chrome frame.
Bug=52931
Review URL: http://codereview.chromium.org/3174027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
some reason
the test shows up as succeeded even though it is failing.
The test fails when the automation client instance is reused, i.e the new page loads in
the same tab. We need to set the ready state of the active document instance to ready
when we reuse the automation client instance.
TBR=amit
Review URL: http://codereview.chromium.org/3117032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on the python server
returns an error
TBR=amit
Review URL: http://codereview.chromium.org/3162028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which fail post
the /kill switch to the python server. It appears that at times this does not work causing
the test to timeout. The result file is correctly return though. We don't ASSERT anymore
on the wait for the python server.
The other change is to reduce the long timeout from 60 seconds to 15 seconds and the short
timeout to 5 seconds.
TBR=amit
Review URL: http://codereview.chromium.org/3181031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3156026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
last error
code from the net::TestServer::WaitToFinish helper function.
TBR=amit
Review URL: http://codereview.chromium.org/3156039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If IPC send fails, further automation calls are extremely likely to fail.
Avoid wasting a lot of time on further timeouts by closing the channel
immediately on the first error.
TEST=ui_tests
BUG=51346
Review URL: http://codereview.chromium.org/3131020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
hardcoding the
xhr url as localhost:1337 which does not work after the recent http test server reorg.
We now use the GetBaseUrlPath helper function to form the url used for XHR requests.
Review URL: http://codereview.chromium.org/3106025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3093013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes all IPC Log methods from wstring to string. All static logging debug
data changed from wchar[] to char[].
Various string conversion/numeric headers no longer need to be included in
ipc_message_utils.h and have been removed (and added in all implementation
files that require them).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3159013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ConnectJobs point to the requests, Requests point back to ConnectJobs and to the DNS lookup they were attached to, if any.
Also CONNECT_JOBs are now identified by their host/port on the Requests list.
BUG= 46844
TEST= Look at the net-internals screen.
Review URL: http://codereview.chromium.org/3080034
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/3137022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ConnectJobs point to the requests, Requests point back to ConnectJobs and to the DNS lookup they were attached to, if any.
Also CONNECT_JOBs are now identified by their host/port on the Requests list.
BUG= 46844
TEST= Look at the net-internals screen.
Review URL: http://codereview.chromium.org/3080034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3162016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessibility stuff that we pull in depends on having a module.
BUG=Chrome Frame net tests crashed at startup.
TEST=Now they don't.
Review URL: http://codereview.chromium.org/3195001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- reduce the number of different classes
- clean up the internal code
- modify the interface to expose less internal details
(this will allow more flexibility with port numbers)
TEST=many
BUG=49680
Review URL: http://codereview.chromium.org/3080029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.cc file.
Cleanup in base. This moves the implementation (and a bunch of header file
dependencies) from the multiprocess test and the test_suite headers to .cc
files. Moves multiprocess_test to the test directory, and all of this stuff to
the existing base_test_support project. I also used the base namespace.
Previously other projects included this functionality just by #include because
it was all inline, so I had to add dependencies on base_test_support in a few
places.
Moves and renames the command line switch this was using to base_switches. Move
the base switch for process type to chrome switches.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3026055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
request is [application/xhtml+xml, image/svg, image/svg+xml, video/ogg, video/webm,video/mp4] or text/html
BUG=51982
Review URL: http://codereview.chromium.org/3107019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
selecting/focusing elements. Change context menu tests to use this approach.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3115002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reduce the amount of false positive crash reports - when exception is swallowed
and is almost always not a problem due ChromeFrame code.
BUG=51830
TBR=amit@chromium.org
Review URL: http://codereview.chromium.org/3148015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to reduce the amount of false positive crash reports - when exception is swallowed and is almost always not a problem due ChromeFrame code.
BUG=51830
Review URL: http://codereview.chromium.org/3171011
TBR=stoyan@chromium.org
Review URL: http://codereview.chromium.org/3191003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window class to checking for IChromeFrame.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3137010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
amount of false positive crash reports - when exception is swallowed and is almost always not a problem due ChromeFrame code.
BUG=51830
Review URL: http://codereview.chromium.org/3171011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
base test files dependent on test_support_base.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the default arguments from the constructor.
- Add a empty constructor to handle the case of the default arguments were used.
BUG=44644
TEST=trybots
Review URL: http://codereview.chromium.org/3172009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Instead use AppendArg variants which accept a FilePath or an ASCII string.
Review URL: http://codereview.chromium.org/3134008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Further tighten down what URLs can be loaded in Chrome Frame.
Based on the feedback from the security review and code
inspection, restrict about: scheme only to about:blank
and about:version by default. Factor out logic blocking logic
including for URL zone checking so that all ActiveX, ActiveDoc
and NPAPI will follow the same path. As a result we now block
restricted URL zones in NPAPI instance as well.
Another side effect of this refactoring is that the registry
flag, EnableGcfProtocol, is replaced by AllowUnsafeURLs. If
If this flag is set, then all the security related checking
is turned off.
BUG=50741
TEST=By default gcf: works only for about:blank, about:version and
view-source of http and https. Setting AllowUnsafeURLs to a non
zero value should allow any URL be loaded via gcf:
Review URL: http://codereview.chromium.org/3159006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make use of Environment::SetVar API to replace the calls to the
Windows function SetEnvironmentVariable.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3076042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Bug=51638
Review URL: http://codereview.chromium.org/3119009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
versions of chrome
frame may get loaded in IE at the same time. We have code to fallback to the old version in
case this happens. However a small overight in declaring a local variable twice in different
scopes led to these checks to fail.
BUG=51620
TEST=test upgrade from 5.0.375.125 to 6.0.472.XXX while IE is running and try 'Open in New window' etc..
Review URL: http://codereview.chromium.org/3136009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when ProxyCache singleton
object is being torn down with valid AutomationProxyCache entries. These objects in turn try to take
down the AutomationProxy which causes a crash in the sync channel while dereferencing a NULL message loop.
This appears to be a sideeffect of the changes to display a sad tab in ChromeFrame when chrome crashes.
Proposed hack/fix is to leak the automation proxy in this case, which basically falls back to the old behavior.
The correct fix would be to refactor/fix the AutomationProxy code to avoid the use of the sync channel if possible.
TBR=tommi
Review URL: http://codereview.chromium.org/3159009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame and Chrome need to
be able to measure time between specific events.
Added support for measuring and displaying these times on the dashboard.
Bug=51638
Review URL: http://codereview.chromium.org/3173007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55816 0039d316-1c4b-4281-b951-d872f2087c98
|