| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=99261
TEST=none
Review URL: http://codereview.chromium.org/8207004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=99317
Review URL: http://codereview.chromium.org/8177014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=99317
Review URL: http://codereview.chromium.org/8178002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SUB_FRAME in a background worker thread.
We have a new request map in ChromeFrame to keep track of these requests. We synchronize access to this map as it is accessed from multiple threads.
This is an attempt to verify if the performance issues seen on CF are related to handling all HTTP requests on the
IE UI thread.
This is configurable via a registry DWORD value "BackgroundHTTPWorkerThread" under HKCU\Software\Google\ChromeFrame
Defaults to true.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=98510
BUG=98510
Review URL: http://codereview.chromium.org/8115018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the
foreground.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=99063
BUG=99063
Review URL: http://codereview.chromium.org/8136012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also includes changes to a few gypi's to specify dependencies that
are otherwise getting implicitly pulled in.
R=jam@chromium.org
BUG=90442
TEST=
Review URL: http://codereview.chromium.org/8113014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
taking no action.
BUG=32056
TEST=net_unittests
Review URL: http://codereview.chromium.org/8100001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=None
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/8109004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cancel, in addition to observing.
TBR=ananta@chromium.org
BUG=32056
TEST=net_unittests
Review URL: http://codereview.chromium.org/8037038
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/8082010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
addition to observing.
TBR=ananta@chromium.org
BUG=32056
TEST=net_unittests
Review URL: http://codereview.chromium.org/8037038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=robertshield@chromium.org
Review URL: http://codereview.chromium.org/8079001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This factors the details of the log transitions between current, staged (previously called pending; renamed for clarity), and unsent (i.e., to-be-stored) log, and all the encoding/compression involved in those transitions, into a helper class: MetricsLogManager. Also simplifies the state machine slightly by combining two states (SEND_OLD_INITIAL_LOGS and SENDING_OLD_LOGS) that behaved the same, moving the logic for deciding which log to send first into the new helper so that the behavior of prioritizing initial logs is unchanged).
In order to allow this to continue to be shared with ChromeFrame, the serialization details are factored into a secondary helper; this isn't necessarily ideal, but it does have the benefit of making unit-testing the components easier.
This is primarily to facilitate a second change that will add more cases where log serialization/deserialization happens, but even on its own it should be helpful since it moves a discrete chunk out of the overly-large MetricsService+MetricsServiceBase, increasing testability, readability, and maintainability.
BUG=None
TEST=Metrics should continue to work.
Review URL: http://codereview.chromium.org/7237057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doing so is broken in at least a few ways:
- in-use updates don't work as desired (must quit IE for 6h)
- there's no UX for quitting Chrome
Since extensions aren't really supported in GCF anyway, I don't see a problem with disallowing background mode.
BUG=97740
TEST=the easy way: fire up IE and visit gcf:about:version, confirm that --disable-background-mode is on the command line. the hard way: install a background extension via the registry mechanism then launch IE and visit gcf:about:version. now check to see if you have an extension process. if so, see that quitting IE makes all chrome.exe processes disappear.
Review URL: http://codereview.chromium.org/8070019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=look for "METRICS LOG: " in Sawbuck 30 seconds after GCF starts and see what is sent for ChromeFrame.IEVersion.
Review URL: http://codereview.chromium.org/8038071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98449
TEST=set usagestats=DWORD1 in GCF's ClientState key, run GCF, use sawbuck to watch for the METRICS LOG message and confirm that it's not just an empty <log .../> element.
Review URL: http://codereview.chromium.org/8071008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
r102780.
BUG=NONE
TEST=Archive scripts using FILES and SYMBOLS files find all the Chrome Frame binaries.
Review URL: http://codereview.chromium.org/8071005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the root output folder next to chrome.exe et al.
Also add a more helpful error message when failing to register the Chrome Frame dll.
Review URL: http://codereview.chromium.org/8013001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove webkit_glue::BuildUserAgent(), change the contract in webkit_glue so
that SetUserAgent() must be called before GetUserAgent().
This was causing a dependency inversion between webkit_support and its clients,
and was needed for the content component build.
For content users, calling SetContentClient() will automatically initialize the
user agent (retrieved from client->GetUserAgent()).
As a bonus, fixing this allowed me to re-test the "mimic_windows" code path and
it looks like we no longer need it.
R=jam@chromium.org,rsesek@chromium.org
BUG=11136, 90442
TEST=visit yahoo! mail using Chromium on Linux, ensure that we don't get an "unsupported browser" warning.
Review URL: http://codereview.chromium.org/8045005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On in-use updates, make a copy of the old chrome launcher's IE low rights elevation policy prior to registering the new npchrome_frame.dll so that running instances of IE can still launch Chrome.
In so doing, I also removed elevation policy addition/removal code from the installer so that npchrome_frame.dll's {un,}registration code is the one and only place where this is done.
BUG=95810
TEST=Install a previous version of GCF, run IE and visit some page that activates GCF, update to a version of GCF containing this fix, then try to visit another page that will activate GCF. If all goes well, you won't see an IE security prompt.
Review URL: http://codereview.chromium.org/7976045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit_glue"
TBR=jam@chromium.org
BUG=90442
TEST=none
Review URL: http://codereview.chromium.org/8002003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that SetUserAgent() must be called before GetUserAgent().
This was causing a dependency inversion between webkit_support and its clients, and was needed for the content component build.
For content users, calling SetContentClient() will automatically initialize the user agent (retrieved from client->GetUserAgent()).
As a bonus, fixing this allowed me to re-test the "mimic_windows" code path and it looks like we no longer need it.
R=jam@chromium.org,tony@chromium.org
BUG=11136,90442
TEST=visit yahoo! mail using Chromium on Linux, ensure that we don't get an "unsupported browser" warning.
Review URL: http://codereview.chromium.org/7922023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97186
TEST=none
Review URL: http://codereview.chromium.org/7971008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Birth/Death tracking of tasks has been moved out-of-band into MessageLoop's PendingTask structure.
Thus, Task no longer needs to inherit from Tracked. Since Task was the only child of Tracked, delete the Tracked class and move Location to its own file.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/7879006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AtExitManager instance.
The AtExitManager instance is initialized by the NetTestSuite class constructor. The dchecks fire
because the NotificationService constructor uses the lazy instance class which relies on the AtExitManager
instance being initialized.
The fix is to initialize the NotificationService instance after the NetTestSuite constructor has done its job.
BUG=none
TEST=chrome frame net tests should pass in debug builds.
TBR=jam
Review URL: http://codereview.chromium.org/7981011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Inserted a new field in the header that specifies which encoding is to be used for the text resources.
I also upped file format to version 4.
BUG=76281
TEST=unit_tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101213
Review URL: http://codereview.chromium.org/7744017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a circular relationship between BrowserProcessImpl and AutomationProvider. To clean this up and eliminate a shutdown crash:
1. Eliminate the AutomationProviderList singleton instance; it is already clearly owned by BrowserProcessImpl
2. Eliminate the calls to g_browser_process->Add/ReleaseModule in AutomationProvider since BrowserProcessImpl already owns AutomationProviderList (which owns any AutomationProvider instances). This could possibly have side effects if AutomationProvider attempts to access the message loop after the last call to BrowserProcessImpl::ReleaseModule exits the message loop, but that shouldn't be happening.
BUG=96030
TEST=./run_remote_tests.sh --remote=localhost --ssh_port 9222 --use_emerged suite_Smoke and ensure no crashes occur in ~AutomationProvider
Review URL: http://codereview.chromium.org/7790031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
including the body of the request.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=95534
BUG=95334
Review URL: http://codereview.chromium.org/7906012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NotficiationService getting created in BrowserProcessImpl.
TBR=ananta
Review URL: http://codereview.chromium.org/7918004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See this link for the failure list:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&tests=fast/dom/HTMLTextAreaElement/reset-textarea.html,fast/dom/isindex-001.html,fast/dom/isindex-002.html,fast/forms/blankbuttons.html,fast/forms/box-shadow-override.html,fast/forms/button-default-title.html,fast/forms/file-input-direction.html,fast/forms/hidden-input-file.html,fast/forms/input-appearance-height.html,fast/forms/input-file-re-render.html,fast/forms/input-first-letter.html,fast/forms/isindex-placeholder.html,fast/forms/text-style-color.html,fast/forms/validation-message-appearance.html,fast/html/details-no-summary1.html,fast/html/details-no-summary2.html,fast/html/details-no-summary3.html,fast/html/details-no-summary4.html,fast/html/details-remove-summary-1-and-click.html,fast/html/details-remove-summary-1.html,fast/html/details-remove-summary-4-and-click.html,fast/html/details-remove-summary-4.html,fast/html/keygen.html,tables/mozilla/bugs/bug39209.html,tables/mozilla/bugs/bug4429.html,fast/forms/005.html,fast/forms/input-file-label.html,fast/invalid/residual-style.html,fast/parser/fragment-parser.html,fast/replaced/table-percent-height-text-controls.html,html5lib/runner.html,http/tests/misc/isindex-with-no-form-base-href.html,http/tests/misc/isindex-with-no-form.html
Revert 101213 - Updated *.pak file format to support both UTF8 and UTF16
Inserted a new field in the header that specifies which encoding is to be used for the text resources.
I also upped file format to version 4.
BUG=76281
TEST=unit_tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973
Review URL: http://codereview.chromium.org/7744017
TBR=adriansc@chromium.org
Review URL: http://codereview.chromium.org/7890060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Inserted a new field in the header that specifies which encoding is to be used for the text resources.
I also upped file format to version 4.
BUG=76281
TEST=unit_tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973
Review URL: http://codereview.chromium.org/7744017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=96449
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/7886016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to look up the first module in. This prevents a bug that can cause user-level Chrome Frame to redirect to itself when a system-level Chrome Frame is present.
BUG=96016
TEST=Upgrade a user-level CF install to a system-level CF install while user-level CF is rendering. Observe that the current explorer instance does not hang when new CF tabs are created.
Review URL: http://codereview.chromium.org/7866043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Items of note:
- predictor_api is gone. Most functions in predictor_api.cc have moved into the chrome_browser_net::Predictor class or the Profile class.
- The predictor state is cleaned up in the Profile dtor.
- Predictor is owned by the ProfileIOData of the profile.
- InitialObserver class is gone since each profile keeps their own info, the non-OTR don't care if anyone is OTR.
- Predictor is created by the profile and then passed to the ProfileIOData. Then its initialization is finished on the IOThread.
- ConnectInterceptor now subclasses off of UrlRequestJobFactory::Interceptor.
- Updated Profile to create a SimpleShutdownPredictor with limited functionality when in unittests.
BUG=89937,90114
TEST=passes existing
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97446
Review URL: http://codereview.chromium.org/7467012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
test suite.
This will make it easier to further reorganize chrome/test
BUG=90905
Review URL: http://codereview.chromium.org/7859009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
return extra information in the failure code.
Specifically, there are a series of registration changes made by Chrome Frame at registration and unregistration time. Previously, if any of those changes failed, the previous changes were left and subsequent changes were not made.
During registration this could result in partial registration data being left if one of the items failed which is bad but wasn't a problem in practice, because if ever registration failed, unregistration would then be performed by the installer. Also the most likely step to fail happens first.
During unregistration, if any of the steps fail, the remaining unregistration steps will not be taken. This is bad, as uninstallation is a best effort, "clean up everything you can" type thing.
Changed this to for registration roll back the previous N-1 steps of step N fails and for unregistration to attempt to perform all N steps disregarding failures.
Updated installer logging.
BUG=94848
TEST=Unregistration of e.g. the user-agent modification should always be performed even if an earlier step fails.
Review URL: http://codereview.chromium.org/7824010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=92264
TEST=None
R=willchan@chromium.org
Review URL: http://codereview.chromium.org/7846007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is not a third party file.
On my machine, this speeds up a full recompile of the 'chrome' target
in Debug mode by about 18%.
BUG=none
TEST=it builds, existing tests pass
Review URL: http://codereview.chromium.org/7706011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
REMOVE_LSO_DATA).
There's no case in the current codebase when we want to remove _only_ LSO data, and no case where we want to remove cookies, but _not_ LSO data. There are many instances of building removal masks that binary-OR REMOVE_LSO_DATA and REMOVE_COOKIES together; this CL formalizes that by dropping the extra enum value.
Moreover, we talk about "cookies" differently when targeting users on the one hand, and developers on the other. REMOVE_COOKIES is a developer-facing name with a user-facing value, which is confusing. Renaming the current functionality to REMOVE_SITE_DATA is much more explicit, and will enable us to _just_ remove cookies at some point in the future via a REMOVE_COOKIES that actually means cookies.
REMOVE_SITE_DATA has exactly the same semantics that REMOVE_COOKIES used to, with one exception: REMOVE_COOKIES included deleting cached strict transport security values. This functionality has been moved to REMOVE_CACHE.
As a drive-by, this CL also moves a check against the kClearPluginLSODataEnabled pref out of webui (ClearBrowsingDataHandler) and into the BrowsingDataRemover itself, where it seems more likely to be effective.
BUG=92628, 94334
TEST=Nothing but removal cached transport-security values should change.
Review URL: http://codereview.chromium.org/7717023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Any file which uses <iostream> gains a static initializer, which is both
disallowed by our style guide and also harms startup performance.
Note that Chrome's logging.h uses <ostream> (note missing "i"), which includes
the << operators for logging but does *not* use cin/cout. This is fine.
BUG=94794
Review URL: http://codereview.chromium.org/7811002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates TestingProfileManager to handle setting up the structures needed to
test multi-profiles in unit_tests. It requires there to be a TestingBrowserProcess
in place. This also adds a second constructor to TestingProfile for multi-profiles
testing.
BUG=none
TEST=unit_tests
Review URL: http://codereview.chromium.org/7748002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This avoids us having 50 copies of the same icon (once per locale dll).
In practice, this wasn't so bad because they probably zipped well in the
7z file.
Review URL: http://codereview.chromium.org/7790011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and instead use the associated profile's proxy service. I proxy the IPC through the renderer first, as that makes it easy to get to the associated profile.
BUG=92361,64339
Review URL: http://codereview.chromium.org/7791005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
frame) in the mini installer package.
BUG=94362
TEST=In a chrome frame page, press ctrl+f. A find dialog should appear and it
should be localized.
Review URL: http://codereview.chromium.org/7761010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome Frame needs 2 dialogs and an icon in the locale dlls. The
rest of the strings and resources can be pulled from the locale
pak files.
This also removes the icon from the pak files and moves them into the
dlls.
BUG=94362
Review URL: http://codereview.chromium.org/7766007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
localized strings
in the language pack and the other resources like dialogs in the dll. The latter part is done
automatically by ATL.
BUG=94362
TEST=No change in behavior. The resources should continue to load as before.
Review URL: http://codereview.chromium.org/7763006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TopLevelPostReissueFromChromeFramePage
as the resource dll issues affecting these tests have now been fixed.
BUG=94362
TBR=grt
Review URL: http://codereview.chromium.org/7767003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome frame has dialogs in generated_resources.grd that are
not included in the pak files. They should continue to use the
locale dlls.
BUG=94362
Review URL: http://codereview.chromium.org/7760002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TopLevelPostReissueFromChromeFramePage
tests as these tests rely on resource dlls being present in the locales folder.
After revision 98103 it looks like chrome uses resource packs internally.
We need to fix ChromeFrame to not use resource dlls and use the packs instead.
BUG=94362
Review URL: http://codereview.chromium.org/7740045
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/7745050
TBR=battre@chromium.org
Review URL: http://codereview.chromium.org/7753037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows.
We were using .dlls, but the .pak files are smaller and this will
allow us to share more code across platforms.
- Remove app/locales.gyp (used on win to generate the locale
dlls) and references to it in other gyp(i) files.
- Update various packaging scripts.
- Move functions from resource_bundle_posix.cc to
resource_bundle.cc (LoadResourcesDataPak, UnloadLocaleResources,
GetLocalizedString, LoadLocaleResources) and delete the
corresponding functions from resource_bundle_win.cc.
Fixes from previous patch:
- Made dependencies of packed_resources explicit (MSVS can't figure
it out from the inputs).
- Removed a couple cases where we were looking for dlls on Windows
(in l10n_util.cc and l10n_util_unittest.cc).
BUG=92724
TBR=cpu
Review URL: http://codereview.chromium.org/7714028
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/7744053
TBR=battre@chromium.org
Review URL: http://codereview.chromium.org/7759001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were using .dlls, but the .pak files are smaller and this will
allow us to share more code across platforms.
- Remove app/locales.gyp (used on win to generate the locale
dlls) and references to it in other gyp(i) files.
- Update various packaging scripts.
- Move functions from resource_bundle_posix.cc to
resource_bundle.cc (LoadResourcesDataPak, UnloadLocaleResources,
GetLocalizedString, LoadLocaleResources) and delete the
corresponding functions from resource_bundle_win.cc.
Fixes from previous patch:
- Made dependencies of packed_resources explicit (MSVS can't figure
it out from the inputs).
- Removed a couple cases where we were looking for dlls on Windows
(in l10n_util.cc and l10n_util_unittest.cc).
BUG=92724
TBR=cpu
Review URL: http://codereview.chromium.org/7714028
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/7744053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98426 0039d316-1c4b-4281-b951-d872f2087c98
|