summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Adds an automation message to retrieve the list of enabled extensions, and ↵joi@chromium.org2010-03-169-1/+201
| | | | | | | | | | | CF bindings for it. TEST=unit test to follow BUG=none Review URL: http://codereview.chromium.org/901002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41667 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeFrame back forward test failures on the builder by reverting ↵ananta@chromium.org2010-03-161-6/+6
| | | | | | | | | | | | | to the original mock specifications. These test still fail on my machine. Will debug that and submit a fix in a subsequent CL. TBR=amit Review URL: http://codereview.chromium.org/1027001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41665 0039d316-1c4b-4281-b951-d872f2087c98
* When ChromeFrame switches to IE on receiving the OnHttpEquiv notification ↵ananta@chromium.org2010-03-153-11/+128
| | | | | | | | | | | | | | | | | | | | | | | | | | indicating the presence of a meta tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end up assuming that a top level navigation is actually an embedded frame. Attempting another approach to detect the dummy IWebBrowser2 iframe instances which mshtml creates for top level navigations which results in the IE to Chrome switch not working reliably. The location for these dummy browsers is set to about:blank. We now check for the same and ignore these. I have added comments in the code indicating why we are doing this and the cases where it could break. It should be fine for most common cases as this code is only hit when the page has a meta tag. Will revisit this. This fixes http://code.google.com/p/chromium/issues/detail?id=36825 Bug=36825 Test=Covered by unit test. Review URL: http://codereview.chromium.org/911003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41645 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the referrer test as flaky again. It's failing on the build bot but ↵tommi@chromium.org2010-03-151-4/+5
| | | | | | | | | | | I can't repro it locally :-( TBR=ananta BUG=none Review URL: http://codereview.chromium.org/999001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41611 0039d316-1c4b-4281-b951-d872f2087c98
* More integration with host (InternetExplorer) popup blocker.stoyan@chromium.org2010-03-152-4/+35
| | | | | | | BUG=34823 Review URL: http://codereview.chromium.org/907005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41595 0039d316-1c4b-4281-b951-d872f2087c98
* Fix #1 for multiple request issue (both POST and GET) after activating the ↵tommi@chromium.org2010-03-1224-263/+2534
| | | | | | | | | | | | | | | | | | | | | onhttpequiv approach. There's a ton going on here. Brief summary: I'm introducing a caching layer for top level page requests that we then use again when switching the document from mshtml to cf. Also in this change list: * Removing the previous way of shifting the document moniker over to the worker thread when a new chrome document is created. Instead we use a request cache object. * Refactoring the part of the Bho class that offered access to it via TLS. This was needed for better testability but also makes (imho) the separation clearer and will possibly help in the future if we don't have a Bho object. * Added a bit of logging that I'd prefer to keep in there until we're confident enough with onhttpequiv. * Enabling two previously disabled tests (the ones I added for multiple requests) * Adding several more unit tests for the new code. Review URL: http://codereview.chromium.org/668187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41495 0039d316-1c4b-4281-b951-d872f2087c98
* Move metrics api to the experimental name space.rogerta@chromium.org2010-03-121-1/+0
| | | | | | | | | BUG=0 TEST=n/a Review URL: http://codereview.chromium.org/899003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41487 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting due to two broken tests: FullTabModeIE_SubIFram and ↵ericu@google.com2010-03-124-140/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | FullTabModeIE_UnloadEventTest. Revert 41463 - When ChromeFrame switches to IE on receiving the OnHttpEquiv notification indicating the presence of a meta tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end up assuming that a top level navigation is actually an embedded frame. To work around this we now maintain a pending navigation count in BeforeNavigate2, which is decremented in NavigateComplete2 and NavigateError. We perform the check for an embedded document only if the pending navigation count is greater than 1. This fixes http://code.google.com/p/chromium/issues/detail?id=36825 The other change made is to add a delay of 100ms in SendString between each character to better reflect actual timing for real user input. Bug=36825 Review URL: http://codereview.chromium.org/837008 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/877009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41477 0039d316-1c4b-4281-b951-d872f2087c98
* When ChromeFrame switches to IE on receiving the OnHttpEquiv notification ↵ananta@chromium.org2010-03-124-10/+140
| | | | | | | | | | | | | | | | | | | | | | | indicating the presence of a meta tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end up assuming that a top level navigation is actually an embedded frame. To work around this we now maintain a pending navigation count in BeforeNavigate2, which is decremented in NavigateComplete2 and NavigateError. We perform the check for an embedded document only if the pending navigation count is greater than 1. This fixes http://code.google.com/p/chromium/issues/detail?id=36825 The other change made is to add a delay of 100ms in SendString between each character to better reflect actual timing for real user input. Bug=36825 Review URL: http://codereview.chromium.org/837008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41463 0039d316-1c4b-4281-b951-d872f2087c98
* Heuristically avoid reporting crashes during DLL loading.siggi@chromium.org2010-03-125-18/+117
| | | | | | | | | | | Cleanup white space as requested by Robert in CL 882001. BUG=31980 TEST=Unittests in this change. Review URL: http://codereview.chromium.org/872004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41367 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-114-6/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
* AddRef ChromeFrameAutomationClient as long as the supporting window exists.stoyan@chromium.org2010-03-114-54/+50
| | | | | | | | | | | | Crash was due the final Release() called from inside message handler. Additionally prevent invoking member functions of invalid/old chrome_frame_delegate_. Still have a race acessing url_fetcher_ though. BUG=35556 Review URL: http://codereview.chromium.org/825005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41290 0039d316-1c4b-4281-b951-d872f2087c98
* Utility functions to interact with the NT loader's data structures and ↵siggi@chromium.org2010-03-116-0/+587
| | | | | | | | | | | | | associated tests. This is in preparation for squelching false positive crash reports during DLL load. BUG=31980 TEST=Unittests in this change. Review URL: http://codereview.chromium.org/882001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41289 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash reported in ChromeFrame on the crash server, which occurs ↵ananta@chromium.org2010-03-101-10/+15
| | | | | | | | | | | | | | | | because the VARIANT representing the URL has a NULL bstrVal. Fix is to check for the same. Fixes bug http://code.google.com/p/chromium/issues/detail?id=37872 Bug=37872 Review URL: http://codereview.chromium.org/822005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41208 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary dependencies from webkit/glue and webkit/appcache.tony@chromium.org2010-03-101-1/+2
| | | | | | | | | | | | | | We want to build these targets from an upstream checkout, so remove a circular dependency (WebKit.gyp) and remove inspector_resources which we don't need to generate for DRT (inspector was also disabled in test_shell a long long time ago). inspector_resources are pulled in explicitly by chrome, so we don't need a dependency here. Review URL: http://codereview.chromium.org/718001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41134 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome Frame tests for keyboard acceleratorsamit@chromium.org2010-03-098-460/+375
| | | | | | | | | | | | | | | | Added tests for commonly used accelerator keys Ctrl+N - New window Ctrl+W - Close Window Ctrl+R - Reload page Also added test for saving current web page using: Alt-F, A BUG=34675 TEST=new tests added Review URL: http://codereview.chromium.org/689002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41055 0039d316-1c4b-4281-b951-d872f2087c98
* Move wtl from chrome/third_party to third_party/. Thistony@chromium.org2010-03-091-2/+2
| | | | | | | | | | | breaks dependencies on chrome from webkit, app, views and base. BUG=37649 TEST=compiles Review URL: http://codereview.chromium.org/699001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41001 0039d316-1c4b-4281-b951-d872f2087c98
* svn prop fixes. Applied to all files not in third_party.pkasting@chromium.org2010-03-091-165/+165
| | | | | | | | | | | | * Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type. * Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF. TBR=evanm BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame now uses host provided popup blocker.stoyan@chromium.org2010-03-087-109/+149
| | | | | | | | | | | It does not work in all scenarions since from Chrome side an empty string is passed as target url. Note in IE6 "Tools/Popup Blocker" menu is not visible if ChromeFrame is the activedocument. Have to support some IOleCommandTarget command.. BUG=34823 Review URL: http://codereview.chromium.org/668168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40897 0039d316-1c4b-4281-b951-d872f2087c98
* Next part of removing the dependency of chrome/common on chrome/browserphajdan.jr@chromium.org2010-03-061-1/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/669184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40834 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame's host network stack implementation for NPAPI would not get and ↵ananta@chromium.org2010-03-052-20/+126
| | | | | | | | | | | | | | | | | | set cookies correctly if the browser did not support the NPN_GetValue/NPN_SetValue mechanisms for getting and setting cookies. The fallback was to set/get cookies on the document url which was broken. We now fallback to using the XPCOM cookie service for getting and setting cookies. Fixes bug http://code.google.com/p/chromium/issues/detail?id=37561 Bug=37561 Review URL: http://codereview.chromium.org/669212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40799 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ChromeFrame crash which occured in the Histogram code while adding a ↵ananta@chromium.org2010-03-054-19/+44
| | | | | | | | | | | | | | | | | | histogram. The histogram macros basically instantiate a static Histogram instance which is then tracked. The static initialization is not thread safe and thus could cause a crash if there is a race between multiple threads trying to access the object at the same time. Fix based on a discussion with Jim is to add thread safe versions of the macros we use for ChromeFrame. Fixes bug http://code.google.com/p/chromium/issues/detail?id=37470 Bug=37470 Review URL: http://codereview.chromium.org/669135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40757 0039d316-1c4b-4281-b951-d872f2087c98
* window.open calls in ChromeFrame cause IE to navigate to a dummy URL which ↵ananta@chromium.org2010-03-041-0/+7
| | | | | | | | | | | | | | | | | | has a prefix like gcf:attach_external_tab&. When the ExternalTabContainer receives an updated navigation state it passes this off to IE, where we look for the IWebBrowserEventSvc interface to fire navigation events which cause IE to update the address bar, etc. However this interface does not exist on IE6. The IDocObjectservice interface is available on IE6 which provides the functionality we need. This fixes bug http://code.google.com/p/chromium/issues/detail?id=33381 Bug=33381 Review URL: http://codereview.chromium.org/668033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40667 0039d316-1c4b-4281-b951-d872f2087c98
* More context menu testsamit@chromium.org2010-03-0412-284/+580
| | | | | | | | | | | | | Refactored code to monitor windows so that it could be used with our mock to watch for dialogs and chrome windows. Added new tests for 'Page Info', 'Dev Tools' and 'Save As' menu options. BUG=34673 TESTS=newly added Review URL: http://codereview.chromium.org/667005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40654 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in ChromeFrame which would occur if we clicked both mouse ↵ananta@chromium.org2010-03-032-12/+25
| | | | | | | | | | | | | | | | | | | | | | | buttons on a link. The right click would run the TrackPopupMenuEx API which runs a system modal loop and the left click would cause the current document to be destroyed causing a crash on return while accessing member variables on a destroyed object. Fix is to grab a reference on the current active document while handling the context menu event to protect against us getting destroyed in the context of the TrackPopupMenuEx call. We also need to NULL check the automation_client_ member in ChromeFramePlugin as this could be detached from the existing active document and attached to the new active document instance which comes up to handle the link navigation. Fixes bug http://code.google.com/p/chromium/issues/detail?id=37220 Bug=37220 Review URL: http://codereview.chromium.org/664009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40547 0039d316-1c4b-4281-b951-d872f2087c98
* Another try at fixing include soupamit@chromium.org2010-03-031-1/+0
| | | | | | | | | | TBR=ananta BUG=none TEST=none Review URL: http://codereview.chromium.org/661465 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40513 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build breakage due to includeamit@chromium.org2010-03-031-1/+1
| | | | | | | | | | TBR=ananta BUG=none TEST=none Review URL: http://codereview.chromium.org/661464 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40512 0039d316-1c4b-4281-b951-d872f2087c98
* More compact mock testsamit@chromium.org2010-03-034-511/+181
| | | | | | | | | | | | | | | Factor out the common expectations for navigations in macros so as to avoid code duplication and make tests more readable. Next step is probably to create a testing::ExpectionSet and use functions instead of macros. BUG=none TEST=all the modified tests Review URL: http://codereview.chromium.org/661390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40511 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an inset border on GCF ActiveDocument instances to match IE styles.slightlyoff@chromium.org2010-03-031-1/+1
| | | | | | | | | BUG=24184 TEST=open page with GCF and with Trident, note same 2px inset border on content in both cases. Review URL: http://codereview.chromium.org/661330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40478 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the FullTabModeIE_UnloadEventTest as it consistently fails while I ↵ananta@chromium.org2010-03-021-1/+2
| | | | | | | | | | | debug it. Bug=37231 TBR=amit Review URL: http://codereview.chromium.org/660401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the full tab mode unload event test by moving the FileDownload ↵ananta@chromium.org2010-03-021-12/+4
| | | | | | | | | | | | expectation before the testing::InSequence specification and getting rid of the duplicate FileDownload expectations. TBR=amit Review URL: http://codereview.chromium.org/661385 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40409 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame should honor the host browser's cookie policy. To achieve this ↵ananta@chromium.org2010-03-0216-140/+147
| | | | | | | | | | | | | | | | we always read the cookies from the host browser when the renderer requests them. This also cleans up the mess with the host network stack code parsing cookies from the host looking for persistent cookies. Fixes bug http://code.google.com/p/chromium/issues/detail?id=34151 Bug=34151 Test=Covered by existing host network stack tests and chrome frame cookie tests. Review URL: http://codereview.chromium.org/661290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40402 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the WidgetModeFF_CFInstanceRPCInternal as flaky.ananta@chromium.org2010-03-021-1/+2
| | | | | | | | | Bug=37204 TBR=amit Review URL: http://codereview.chromium.org/660386 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40392 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix the case where the browser livelocks if we cannot open a file."agl@chromium.org2010-03-011-0/+37
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40291 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a little utility function to make logging guids easiertommi@chromium.org2010-03-013-0/+21
| | | | | | | | | | | and a dlog to see when we decide that a request is a subframe request. TEST=Unit test is provided. BUG=none Review URL: http://codereview.chromium.org/660289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40288 0039d316-1c4b-4281-b951-d872f2087c98
* Marking some more tests as flaky since they fail randomly on waterfall.amit@chromium.org2010-03-011-3/+6
| | | | | | | | | TBR=iyengar TEST=none Review URL: http://codereview.chromium.org/660285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40281 0039d316-1c4b-4281-b951-d872f2087c98
* Marking WidgetModeFF_InHead as flaky as it randomly fails on buildbotsamit@chromium.org2010-02-281-1/+2
| | | | | | | | TBR=ananta Review URL: http://codereview.chromium.org/661258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40236 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in ChromeActiveDocument::IOleObject_SetClientSite.amit@chromium.org2010-02-281-1/+3
| | | | | | | | | | | | | Check validity of existing document soite before QI for doc host handler. BUG=37008 TEST=none TBR=ananta Review URL: http://codereview.chromium.org/660255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40235 0039d316-1c4b-4281-b951-d872f2087c98
* Do not attempt to parse NULL headers.tommi@chromium.org2010-02-281-0/+2
| | | | | | | | | | TBR=amit TEST=fixes one of the top crashes in the lastest release. BUG=36985 Review URL: http://codereview.chromium.org/661256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40234 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the case where the browser livelocks if we cannot open a file.agl@chromium.org2010-02-261-37/+0
| | | | | | | | | | | | | | | | | | | | If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. (Land attempt three: first in r39446, reverted in r39448. Second in r39899, reverted in r39901.) http://codereview.chromium.org/541022 BUG=30850 TEST=Try to upload a file that isn't readable (i.e. /etc/shadow). The resulting upload should be a 0 byte file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40146 0039d316-1c4b-4281-b951-d872f2087c98
* Releasing the IBindStatusCallback_PatchInfo patch after we've applied the ↵tommi@chromium.org2010-02-261-0/+6
| | | | | | | | | | | IInternetProtocolSink_PatchInfo one. TEST=Should be no change. If there is a regression because of this, it would be in the form of failing to switch to CF for pages that have the CF meta tag. BUG=none Review URL: http://codereview.chromium.org/660032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40144 0039d316-1c4b-4281-b951-d872f2087c98
* Make minidump test deterministic by explicitly loading and unloading a ↵siggi@chromium.org2010-02-262-5/+14
| | | | | | | | | | | | | | specific DLL, instead of relying on CoInitialize/CoUninitialize to load and unload at least one DLL. Add minidump_test as a dependency to make sure it's always built. BUG=none TEST=none Review URL: http://codereview.chromium.org/661081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40142 0039d316-1c4b-4281-b951-d872f2087c98
* Add a metrics extensions API.rogerta@chromium.org2010-02-261-0/+1
| | | | | | | | | | | See http://docs.google.com/View?id=dd4ngnpz_0dpsb8n96 for API proposal. BUG=0 TEST=See unit tests as part of this CL Review URL: http://codereview.chromium.org/657037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40130 0039d316-1c4b-4281-b951-d872f2087c98
* Destroy pending tasks marshaled through windows messages avoiding possible ↵stoyan@chromium.org2010-02-261-0/+37
| | | | | | | | | | | crashes when object is destroyed and there is tasks in the queue. BUG=none TEST=none Review URL: http://codereview.chromium.org/661145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40125 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ui test crashes on Linux. There is a race condition between the ↵ananta@chromium.org2010-02-261-1/+1
| | | | | | | | | | | | | | channel getting destroyed and it being referenced in the background thread. Fix is to use the underlying IPC::Channel pointer passed to the message filter when the filter gets Added to send and receive messages. This ensures that the SyncChannel is not used across threads. Review URL: http://codereview.chromium.org/661109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40076 0039d316-1c4b-4281-b951-d872f2087c98
* Fix double-quoting issue that caused base_noicu not to build correctly on ↵pkasting@chromium.org2010-02-251-1/+1
| | | | | | | | | | cygwin. BUG=none TEST=none Review URL: http://codereview.chromium.org/661016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40042 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test for the multiple request issues we've been seeing.tommi@chromium.org2010-02-256-35/+178
| | | | | | | | | | | The test is disabled until we fix the actual problem. TEST=n/a BUG=33332 Review URL: http://codereview.chromium.org/661017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39954 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome_frame_reliability_tests.exe to the set of archived CF tests. ↵robertshield@chromium.org2010-02-241-1/+2
| | | | | | | | | | | | | (Needed for the CF reliability builder) Remove the now-unused chrome_frame_builder target in all.gyp. BUG=29451 TEST=chrome_frame_reliability_tests.exe shows up at http://chrome-web/buildbot/snapshots/chromium-rel-xp/ Review URL: http://codereview.chromium.org/658007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39915 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a hang in ChromeFrame while tearing down pending url requests during ↵ananta@chromium.org2010-02-241-1/+10
| | | | | | | | | | | | | | | | | | | | | | shutdown. This would occur when we received a redirect notification on an aborted request. We would end up aborting the request twice which would cause the UrlmonUrlRequest object to be destroyed twice by IE, thus resulting in a junk reference in the request map. Fix is to bail out in the IBindStatusCallback::OnProgress callback if it is invoked for an aborted request. Part of the fix for http://code.google.com/p/chromium/issues/detail?id=34687 The other issue being fixed is a crash in ChromeFrame caused if the UrlmonUrlRequest object gets destroyed in the context of UrlmonUrlRequest::StartAsyncDownload. The crash would occur while accessing members of the object on return from this function. Fix is to grab a reference on this object in the context of the call. Bug=34687 Review URL: http://codereview.chromium.org/652202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39909 0039d316-1c4b-4281-b951-d872f2087c98
* Update Chrome Frame's reliability tests to allow them to register a given CF ↵robertshield@chromium.org2010-02-244-6/+58
| | | | | | | | | | | dll. BUG=29451 TEST=Reliability tests can be staged more easily on the vm tests. Review URL: http://codereview.chromium.org/656021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39903 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-08 02:20:23 +0000