summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Refactor automation messages.erg@google.com2010-11-0118-33/+36
| | | | | | | | | | | | | | | | | automation_messages used to live in chrome/test/automation, when it's needed by browser and chrome_frame. When I started lifting code out of headers and into implementation files, I was getting link errors and temporarily solved the problem by compiling the cc files manually into libbrowser.a. Now this is part of chrome/common/ which is included by all targets needed. While doing this, discover that automation IPC redefines the ContextMenuParams struct. Rename it to MiniContextMenuParams. BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4200007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64637 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this to see if this fixes ChromeFrame tests. Please reland with ↵ananta@chromium.org2010-10-2813-92/+35
| | | | | | | | | | | | | the tests fixed. Revert 64252 - The ChromeFrame objects now provides an unfrozen interface called IChromeFramePrivate. This interface provides a GetSessionId() which returns the ID used by Chrome in its Tab javascript object. Review URL: http://codereview.chromium.org/3541017 TBR=hansl@google.com Review URL: http://codereview.chromium.org/4134008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64287 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for built-in DNS resolver/cache.agayev@chromium.org2010-10-282-2/+2
| | | | | | | | | BUG=60149 TEST=None Review URL: http://codereview.chromium.org/4216001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64271 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of FLAKY_ tests to match current realitystuartmorgan@chromium.org2010-10-281-3/+1
| | | | | | | | | | | Mostly this is removing FLAKY_ where the bug was fixed but the label never removed, but also switches some FLAKY_ to platform-specific FAILS_. BUG=28372,32048,32070,35341,45561,48544,48562,52858 TEST=N/A Review URL: http://codereview.chromium.org/4087009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64264 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame objects now provides an unfrozen interface called ↵hansl@google.com2010-10-2813-35/+92
| | | | | | | | IChromeFramePrivate. This interface provides a GetSessionId() which returns the ID used by Chrome in its Tab javascript object. Review URL: http://codereview.chromium.org/3541017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64252 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64202 - Initial support for built-in DNS resolver/cache.yusukes@chromium.org2010-10-282-2/+2
| | | | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3693001 TBR=agayev@chromium.org Review URL: http://codereview.chromium.org/4208002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64204 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for built-in DNS resolver/cache.agayev@chromium.org2010-10-282-2/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3693001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64202 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the FullTabModeIE_WindowClose ChromeFrame test as it causes ↵ananta@chromium.org2010-10-271-9/+5
| | | | | | | | | | | | | IE7/IE8 to put a security warning infobar. Bug=61011 TBR=amit Review URL: http://codereview.chromium.org/4168005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64173 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a number of failing chrome frame tests on Vista with IE7. Most of ↵ananta@chromium.org2010-10-273-0/+76
| | | | | | | | | | | | | | | these failures appear related to WebBrowser2::Navigate for the new window disposition opening up the popup in a new tab thus causing the tests to fail. A couple of failures are unrelated and need investigation. Bug=60987 TBR=amit Review URL: http://codereview.chromium.org/4143004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64153 0039d316-1c4b-4281-b951-d872f2087c98
* Pass Chrome's UA with chromeframe appended at the end in the user agent ↵ananta@chromium.org2010-10-271-6/+9
| | | | | | | | | | | | | | passed in ChromeFrame requests initiated in IE. Fixes bug http://b/issue?id=3022937 Bug=3022937 Review URL: http://codereview.chromium.org/4202003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64102 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for OnClose event in ActiveX and NPAPIamit@chromium.org2010-10-278-2/+124
| | | | | | | | | | | | | | | Provide event notification for window.close called within ActiveX and NPAPI. Currently this is handled in ActiveDocument to close the popups. In ActiveX and NPAPI plugin we just fire an event as it is upto the container to decide what's the right thing to do. BUG=59664 TEST=New tests ChromeFrameTestWithWebServer.FullTabModeIE_WindowClose, ChromeFrameTestWithWebServer.FullTabModeFF_WindowClose Review URL: http://codereview.chromium.org/4152005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64092 0039d316-1c4b-4281-b951-d872f2087c98
* Change miscellaneous LOG(INFO)s to VLOG()s that I missed the first time ↵pkasting@chromium.org2010-10-276-11/+12
| | | | | | | | | | | | through, either because they were LOG_IF() (which I didn't search for) or they were added during the week I was changing things. Plus a few misc. cleanup bits. BUG=none TEST=none Review URL: http://codereview.chromium.org/4111002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63998 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in ChromeFrame if chrome launch timeouts.stoyan@chromium.org2010-10-261-2/+3
| | | | | | | BUG=60550 Review URL: http://codereview.chromium.org/4096003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63958 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the parsing of X-UA-COMPATIBLE header (and meta tag) to allow comma ↵erikwright@chromium.org2010-10-263-11/+31
| | | | | | | | | | or semi-colon as delimiter for backwards compatibility. BUG=52601 TEST=chrome_frame_unittests / UtilTests.XUaCompatibleDirectiveTest Review URL: http://codereview.chromium.org/4103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63937 0039d316-1c4b-4281-b951-d872f2087c98
* Add metrics tracking how many times users are bugged with "version mismatch, ↵robertshield@chromium.org2010-10-262-0/+2
| | | | | | | | | | | please restart your browser" dialogs during CF udpates. If this number gets high, we should do something better. BUG=none TEST=none Review URL: http://codereview.chromium.org/4110001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63936 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame network tests were broken since the change to honor the ↵ananta@chromium.org2010-10-262-1/+20
| | | | | | | | | | | | | | | | | | | | | | automation protocol version in ChromeFrame which basically breaks the automation connection if the protocols don't match. While this is fine when chrome is the automation client, it breaks chrome frame net tests because when the automation channel is established the automation provider sends over the version of the current module in the hello message. In the case when the current module is chrome the version goes over correctly. For chrome frame net tests there is no version string. Hence the channel never gets established. Fix is to retrieve the protocol version via a virtual protected function in the automation provider. The testing automation provider overrides this function in the network tests and returns the version of chrome.dll TBR=amit,robertshield Review URL: http://codereview.chromium.org/4160002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63860 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-266-11/+12
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crasher observed in ChromeFrame stable build 7.0.517.43. Crash occurs ↵ananta@chromium.org2010-10-253-11/+33
| | | | | | | | | | | | | | | | | | | | when we attempt to terminate the urlmon transaction with a spurious BindToObject call which is supposed to fail but release the transaction. While this works mostly it causes a crash in urlmon at times on IE7. To workaround this we now save away the IInternetProtocol interface which represents the transaction object in our bind context info structure which is maintained per bind context and terminate the protocol when we want the transaction to be destroyed. Fixes bug http://code.google.com/p/chromium/issues/detail?id=60370 Bug=60370 Review URL: http://codereview.chromium.org/3984006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63769 0039d316-1c4b-4281-b951-d872f2087c98
* Enable developers to conditionally activate Chrome Frame, depending on the ↵erikwright@chromium.org2010-10-256-33/+366
| | | | | | | | | | version of the host IE browser. BUG=52601 TEST=[chrome_frame_unittests / UtilTests.XUaCompatibleDirectiveTest], [chrome_frame_tests / HeaderTest.*] Review URL: http://codereview.chromium.org/3978001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63728 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Const-ify RefCountedThreadSafe::AddRef and Release.""mpcomplete@chromium.org2010-10-221-2/+2
| | | | | | | | | chrome_frame failed to compile last time. I needed to add a "mutable" to a member variable in chrome_frame/metrics_service.cc. Review URL: http://codereview.chromium.org/3971004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63574 0039d316-1c4b-4281-b951-d872f2087c98
* Support whatever HTTP verbs Chrome uses in Chrome Frammeamit@chromium.org2010-10-221-7/+1
| | | | | | | | | | | | | | | | Earlier we restricted support explicitly to HEAD and DELETE. This restriction is unnecessary and we should just pass whatever verb Chrome asks for. This will work only on IE since NPAPI does not have support for anything other than GET and POST. BUG=59658 TEST=none Review URL: http://codereview.chromium.org/4014003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63573 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a high frequency chrome frame crasher which occurs while uploading UMA ↵ananta@chromium.org2010-10-221-5/+1
| | | | | | | | | | | | | | | | | | | data. The crash occcurs while processing a proxy change request and specifically occurs while invoking on the NetLog instance maintained by a chrome frame url request context instantiated specifically to upload data. The proxy service is a ref counted object and the net log instance is not which leads to a race condition if the netlog instance is destroyed before the proxy service. Fix is to not create a netlog instance for chrome frame uma requests. Fixes bug http://code.google.com/p/chromium/issues/detail?id=60203 Bug=60203 Review URL: http://codereview.chromium.org/3985006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63571 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a build break due to r63514.erikwright@chromium.org2010-10-221-2/+2
| | | | | | | | BUG=52601 TEST=chrome_frame_tests / FullTabDownloadTest.CF_DownloadFileFromPost TBR=stoyan@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63521 0039d316-1c4b-4281-b951-d872f2087c98
* Update code that previously constructed strings from string iterators only ↵erikwright@chromium.org2010-10-221-1/+3
| | | | | | | | | | to use StringToInt. These usages now pass the iterators directly to the new StringToInt overloads. BUG=None TEST=All Review URL: http://codereview.chromium.org/3968001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63515 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent displaying of automation protocol version mismatch errors for ↵robertshield@chromium.org2010-10-222-2/+4
| | | | | | | | | | | | privileged instances of Chrome Frame. BUG=None TEST=None Review URL: http://codereview.chromium.org/4031003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63508 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Const-ify RefCountedThreadSafe::AddRef and Release."levin@chromium.org2010-10-221-1/+1
| | | | | | This reverts commit b7ce919957536ceb0cfac1709bc779fd086b6ce8. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63459 0039d316-1c4b-4281-b951-d872f2087c98
* Const-ify RefCountedThreadSafe::AddRef and Release.mpcomplete@chromium.org2010-10-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3869003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63457 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame in full tab mode at times the address bar would display the ↵ananta@chromium.org2010-10-212-3/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | old URL. This would typically occur during redirects or performing back forward operations when the current and the target URLs were both rendered in ChromeFrame. A scenario where this would occur is as below:- 1. Navigation to a URL in chrome frame. 2. Clicking on a link which would navigate the current tab to a chrome frame URL. 3. Now hitting back in IE would navigate back. however the address bar would still display the URL in step 2. The reason this occurs is step 2 causes a top level navigation in IE via webbrowser::Navigate. This initiates a navigation sequence which updates the address bar to the URL in step 2. Eventually we receive navigation updates from chrome where the navigation index is changed due to a new navigation from step 1 to 2. We end up firing internal navigation events which cause the IE history to get messed up leading to the problem. Fix is to only fire internal navigation events if the following are true. 1. navigation indexes are different. 2. urls are different. 3. referrer differs. 4. navigation type is different. Fixes bug http://code.google.com/p/chromium/issues/detail?id=57207 Bug=57207 Test=Will send out a test in a separate CL. Need to brush up on using accessibility for link clicks, etc. Review URL: http://codereview.chromium.org/3988004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63414 0039d316-1c4b-4281-b951-d872f2087c98
* Refreshing pages in ChromeFrame would basically always fetch the pages from ↵ananta@chromium.org2010-10-216-9/+69
| | | | | | | | | | | | | | | | | | the cache. We need to emulate Chrome and MSHTML where in the cache is resynchronized, i.e. new content is fetched from the server if it has been modified. To achieve this we now pass the load flags from Chrome when we initiate a HTTP request and basically or in the BINDF_RESYNCHRONIZE and BINDF_GETNEWESTVERSION flags based on the value of the load flags. Fixes bug http://code.google.com/p/chromium/issues/detail?id=41508 Test=Covered by new ChromeFrame test. Review URL: http://codereview.chromium.org/4000001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63389 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of a revert of a patch that re-enabled automation protocol version ↵robertshield@chromium.org2010-10-212-0/+6
| | | | | | | | | | | | | | mismatch checking in CF. Original revision: r63211 Revert revision: r63239 Previously, our version information wasn't getting updated properly through incremental builds which made the test builders unhappy. That was fixed in r63355. This should now be safe to commit. Review URL: http://codereview.chromium.org/4034004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63364 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the tangled ball of poo that was our resource scripts. We previously had ↵robertshield@chromium.org2010-10-212-35/+7
| | | | | | | | | | | two version info resources, one of which got updated correctly during incremental builds, the other of which was used. Bring this down to the conventional one and make sure it gets updated. BUG=Version information didn't get updated through incremental builds. TEST=Now it does. Review URL: http://codereview.chromium.org/3974001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63355 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ExternalTabProxy.CancelledCreateTab test.stoyan@chromium.org2010-10-201-0/+6
| | | | | | | TEST=ExternalTabProxy.CancelledCreateTab Review URL: http://codereview.chromium.org/4022001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63289 0039d316-1c4b-4281-b951-d872f2087c98
* Fill some gaps.stoyan@chromium.org2010-10-206-29/+249
| | | | | | | Tests for ExternalTabProxy. Review URL: http://codereview.chromium.org/3888005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63262 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this as this causes a message box to show up on the builders ↵ananta@chromium.org2010-10-202-6/+0
| | | | | | | | | | | | | | | | | | | | | indicating that the chrome and chrome frame versions are different which they are. Perhaps the version resource in chrome frame is just wrong and needs a clobber. Robert please investigate and reland Revert 63211 - Re-add the version mismatch checking which was removed at some point. Also add version information to chrome_frame_tests.exe. This will be needed for subsequent tests. Review URL: http://codereview.chromium.org/3879001 TBR=robertshield@chromium.org Review URL: http://codereview.chromium.org/3939002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63239 0039d316-1c4b-4281-b951-d872f2087c98
* Remove scoped_bstr_win, fix all callers to use the new location.brettw@chromium.org2010-10-2014-79/+86
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3748012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63216 0039d316-1c4b-4281-b951-d872f2087c98
* Re-add the version mismatch checking which was removed at some point. Also ↵robertshield@chromium.org2010-10-202-0/+6
| | | | | | | | add version information to chrome_frame_tests.exe. This will be needed for subsequent tests. Review URL: http://codereview.chromium.org/3879001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63211 0039d316-1c4b-4281-b951-d872f2087c98
* Various changes to make GCF nicer for the non-en-US world:grt@chromium.org2010-10-2015-146/+521
| | | | | | | | | | | | | - Chrome Frame now uses MUI on Vista+ to detect IE's UX language. - Chrome Frame now tells Chrome (via the --lang command-line option) what the current langauge is. - Chrome Frame now respects Chrome's "ApplicationLocaleValue" group policy setting. BUG=56435,59582 TEST=chrome_frame_unittests and chrome_frame_tests updated Review URL: http://codereview.chromium.org/3757007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63208 0039d316-1c4b-4281-b951-d872f2087c98
* Remove usage of the old page info dialogs in ChromeFrame and use the new ↵ananta@chromium.org2010-10-199-26/+58
| | | | | | | | | | | | | | | | | | page info bubble instead. Changed the expectations of the corresponding chrome frame ui test to look for this window. Added support in ChromeFrame tests window watcher class to allow specifying window class names as well. Fixes bug http://code.google.com/p/chromium/issues/detail?id=59030 Bug=59030 Review URL: http://codereview.chromium.org/3864001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63138 0039d316-1c4b-4281-b951-d872f2087c98
* GCF activation for alternate content typesamit@chromium.org2010-10-191-0/+63
| | | | | | | | | | | | Added a few tests to test GCF activation for content types other than text/html using HTTP header. BUG=56269 TEST=new tests added. Review URL: http://codereview.chromium.org/3528020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63133 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - chrome_frame/.pkasting@chromium.org2010-10-1938-359/+358
| | | | | | | | | | Plus a couple misc. cleanups. BUG=none TEST=none Review URL: http://codereview.chromium.org/3850002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63095 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revert 62918 - net: clean up SSLHostInfo construction."agl@chromium.org2010-10-192-1/+3
| | | | | | | Was reverted in r62922 due to a change landing between the try run and the commit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63046 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62918 - net: clean up SSLHostInfo construction.agl@chromium.org2010-10-182-3/+1
| | | | | | | | | | | | | | | | Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 TBR=agl@chromium.org Review URL: http://codereview.chromium.org/3846005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62922 0039d316-1c4b-4281-b951-d872f2087c98
* net: clean up SSLHostInfo construction.agl@chromium.org2010-10-182-1/+3
| | | | | | | | | | | | | Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62918 0039d316-1c4b-4281-b951-d872f2087c98
* Move pe_image and registry from base to base/win and use the namespace. It ↵brettw@chromium.org2010-10-178-19/+29
| | | | | | | | | | | | removes windows_message_list which isn't used. This keeps a stub for registry in the old location until we can update that. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3836005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the flakiness with the newly added CF_DownloadFileFromPost ↵ananta@chromium.org2010-10-161-1/+2
| | | | | | | | | | | | chrome frame test. TBR=stoyan Review URL: http://codereview.chromium.org/3779009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62850 0039d316-1c4b-4281-b951-d872f2087c98
* Resurrecting Tommi's attachment download test in response to a FORM post ↵ananta@chromium.org2010-10-165-3/+283
| | | | | | | | | | | | | | | | | request. This test was incorrectly deleted during the test reorganization. Added expectations to this test to look for the File download dialog box and close it when we see this. Added an end to end download attachment test with a lot of help from Stoyan about the intricacies of gmock which saves the file and verifies that the content matches that being sent from the server. Bug=36694 Review URL: http://codereview.chromium.org/3833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62846 0039d316-1c4b-4281-b951-d872f2087c98
* Really fix ChromeFrame compile for scoped changes.brettw@chromium.org2010-10-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62845 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two cases I missed when renaming/moving Windows-related scoped stuff.brettw@chromium.org2010-10-161-4/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62844 0039d316-1c4b-4281-b951-d872f2087c98
* Move the windows-specific scoped_* stuff from base to base/win and in the ↵brettw@chromium.org2010-10-161-15/+17
| | | | | | | | | | | | | | | | base::win namespace. This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch. This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there. I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3781009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98
* Move windows version-related stuff out of base/win_util and into ↵brettw@chromium.org2010-10-156-15/+16
| | | | | | | | | | | | | | base/win/windows_version. Many files now only need to include this instead of all of win_util. Remove a bunch of unused code from base/win_util. There was a surprising amount. Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 01:38:48 +0000