| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
TBR=eroman
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1051004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
net_test_support build target.
R=eroman
BUG=none
TEST=no build errors
Review URL: http://codereview.chromium.org/1047003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
file in preparation for localizing Chrome Frame.
BUG=24305
TEST=none
Review URL: http://codereview.chromium.org/1055002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
an anchor. This is presumably
because from IE6's perspecive nothing changed. To workaround this issue, we stash the complete url away in the
navigation manager and remove it from the URL being navigated to. When the Chrome active document loads
we read the actual url from the navigation manager and initiate a navigation to this URL.
There is one issue with this approach though. The actual URL in the address bar in IE6 does not contain the
anchor tag. Will address that in a follow up CL.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=38265
Bug=38265
Test=Covered by existing ChromeFrame anchor URL navigation tests.
Review URL: http://codereview.chromium.org/1022003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
parent of the plugin, since this is more compatible. Also, "parentElement" no
longer works in FF3.6.
BUG=0
TEST=n/a
Review URL: http://codereview.chromium.org/1033001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CF bindings for it.
TEST=unit test to follow
BUG=none
Review URL: http://codereview.chromium.org/901002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the original mock
specifications. These test still fail on my machine. Will debug that and submit a fix in a subsequent
CL.
TBR=amit
Review URL: http://codereview.chromium.org/1027001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
indicating the presence of a meta
tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a
site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end
up assuming that a top level navigation is actually an embedded frame.
Attempting another approach to detect the dummy IWebBrowser2 iframe instances which mshtml creates for top level
navigations which results in the IE to Chrome switch not working reliably.
The location for these dummy browsers is set to about:blank. We now check for the same and ignore these.
I have added comments in the code indicating why we are doing this and the cases where it could break.
It should be fine for most common cases as this code is only hit when the page has a meta tag. Will revisit
this.
This fixes http://code.google.com/p/chromium/issues/detail?id=36825
Bug=36825
Test=Covered by unit test.
Review URL: http://codereview.chromium.org/911003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I can't repro it locally :-(
TBR=ananta
BUG=none
Review URL: http://codereview.chromium.org/999001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=34823
Review URL: http://codereview.chromium.org/907005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
onhttpequiv approach.
There's a ton going on here. Brief summary: I'm introducing a caching layer for top level page requests that we then use again when switching the document from mshtml to cf.
Also in this change list:
* Removing the previous way of shifting the document moniker
over to the worker thread when a new chrome document is
created. Instead we use a request cache object.
* Refactoring the part of the Bho class that offered access
to it via TLS. This was needed for better testability but
also makes (imho) the separation clearer and will possibly
help in the future if we don't have a Bho object.
* Added a bit of logging that I'd prefer to keep in there until we're confident enough with onhttpequiv.
* Enabling two previously disabled tests (the ones I added for multiple requests)
* Adding several more unit tests for the new code.
Review URL: http://codereview.chromium.org/668187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=0
TEST=n/a
Review URL: http://codereview.chromium.org/899003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FullTabModeIE_UnloadEventTest.
Revert 41463 - When ChromeFrame switches to IE on receiving the OnHttpEquiv notification indicating the presence of a meta
tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a
site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end
up assuming that a top level navigation is actually an embedded frame.
To work around this we now maintain a pending navigation count in BeforeNavigate2, which is decremented in
NavigateComplete2 and NavigateError. We perform the check for an embedded document only if the pending navigation
count is greater than 1.
This fixes http://code.google.com/p/chromium/issues/detail?id=36825
The other change made is to add a delay of 100ms in SendString between each character to better reflect actual
timing for real user input.
Bug=36825
Review URL: http://codereview.chromium.org/837008
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/877009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
indicating the presence of a meta
tag indicating that the page is to be rendered in Chrome, we check if the notification is received for a
site rendered in an IFrame to ensure that we don't switch in this case. This code is not reliable and we end
up assuming that a top level navigation is actually an embedded frame.
To work around this we now maintain a pending navigation count in BeforeNavigate2, which is decremented in
NavigateComplete2 and NavigateError. We perform the check for an embedded document only if the pending navigation
count is greater than 1.
This fixes http://code.google.com/p/chromium/issues/detail?id=36825
The other change made is to add a delay of 100ms in SendString between each character to better reflect actual
timing for real user input.
Bug=36825
Review URL: http://codereview.chromium.org/837008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Cleanup white space as requested by Robert in CL 882001.
BUG=31980
TEST=Unittests in this change.
Review URL: http://codereview.chromium.org/872004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/830002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Crash was due the final Release() called from inside message handler.
Additionally prevent invoking member functions of invalid/old chrome_frame_delegate_.
Still have a race acessing url_fetcher_ though.
BUG=35556
Review URL: http://codereview.chromium.org/825005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
associated tests.
This is in preparation for squelching false positive crash reports during DLL load.
BUG=31980
TEST=Unittests in this change.
Review URL: http://codereview.chromium.org/882001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
because the VARIANT representing
the URL has a NULL bstrVal.
Fix is to check for the same.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=37872
Bug=37872
Review URL: http://codereview.chromium.org/822005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want to build these targets from an upstream checkout, so remove
a circular dependency (WebKit.gyp) and remove inspector_resources which
we don't need to generate for DRT (inspector was also disabled in
test_shell a long long time ago).
inspector_resources are pulled in explicitly by chrome, so we don't need
a dependency here.
Review URL: http://codereview.chromium.org/718001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added tests for commonly used accelerator keys
Ctrl+N - New window
Ctrl+W - Close Window
Ctrl+R - Reload page
Also added test for saving current web page using: Alt-F, A
BUG=34675
TEST=new tests added
Review URL: http://codereview.chromium.org/689002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
breaks dependencies on chrome from webkit, app, views
and base.
BUG=37649
TEST=compiles
Review URL: http://codereview.chromium.org/699001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type.
* Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF.
TBR=evanm
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It does not work in all scenarions since from Chrome side an empty string is passed as target url.
Note in IE6 "Tools/Popup Blocker" menu is not visible if ChromeFrame is the activedocument. Have to support some IOleCommandTarget command..
BUG=34823
Review URL: http://codereview.chromium.org/668168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/669184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
set cookies correctly
if the browser did not support the NPN_GetValue/NPN_SetValue mechanisms for getting and setting cookies.
The fallback was to set/get cookies on the document url which was broken.
We now fallback to using the XPCOM cookie service for getting and setting cookies.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=37561
Bug=37561
Review URL: http://codereview.chromium.org/669212
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
histogram. The histogram
macros basically instantiate a static Histogram instance which is then tracked. The static initialization
is not thread safe and thus could cause a crash if there is a race between multiple threads trying
to access the object at the same time.
Fix based on a discussion with Jim is to add thread safe versions of the macros we use for ChromeFrame.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=37470
Bug=37470
Review URL: http://codereview.chromium.org/669135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
has a prefix like
gcf:attach_external_tab&. When the ExternalTabContainer receives an updated navigation state
it passes this off to IE, where we look for the IWebBrowserEventSvc interface to fire navigation events
which cause IE to update the address bar, etc. However this interface does not exist on IE6.
The IDocObjectservice interface is available on IE6 which provides the functionality we need.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=33381
Bug=33381
Review URL: http://codereview.chromium.org/668033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored code to monitor windows so that it could be used with
our mock to watch for dialogs and chrome windows. Added new tests
for 'Page Info', 'Dev Tools' and 'Save As' menu options.
BUG=34673
TESTS=newly added
Review URL: http://codereview.chromium.org/667005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buttons on a link.
The right click would run the TrackPopupMenuEx API which runs a system modal loop and the left click
would cause the current document to be destroyed causing a crash on return while accessing member
variables on a destroyed object.
Fix is to grab a reference on the current active document while handling the context menu event to protect
against us getting destroyed in the context of the TrackPopupMenuEx call.
We also need to NULL check the automation_client_ member in ChromeFramePlugin as this could be detached
from the existing active document and attached to the new active document instance which comes up to
handle the link navigation.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=37220
Bug=37220
Review URL: http://codereview.chromium.org/664009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661464
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Factor out the common expectations for navigations in macros so as
to avoid code duplication and make tests more readable.
Next step is probably to create a testing::ExpectionSet and use
functions instead of macros.
BUG=none
TEST=all the modified tests
Review URL: http://codereview.chromium.org/661390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24184
TEST=open page with GCF and with Trident, note same 2px inset border on content in both cases.
Review URL: http://codereview.chromium.org/661330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
debug it.
Bug=37231
TBR=amit
Review URL: http://codereview.chromium.org/660401
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
expectation before the
testing::InSequence specification and getting rid of the duplicate FileDownload expectations.
TBR=amit
Review URL: http://codereview.chromium.org/661385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we always read the cookies from
the host browser when the renderer requests them. This also cleans up the mess with the host network stack
code parsing cookies from the host looking for persistent cookies.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=34151
Bug=34151
Test=Covered by existing host network stack tests and chrome frame cookie tests.
Review URL: http://codereview.chromium.org/661290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=37204
TBR=amit
Review URL: http://codereview.chromium.org/660386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and a dlog to see when we decide that a request is a subframe request.
TEST=Unit test is provided.
BUG=none
Review URL: http://codereview.chromium.org/660289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=iyengar
TEST=none
Review URL: http://codereview.chromium.org/660285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ananta
Review URL: http://codereview.chromium.org/661258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check validity of existing document soite before QI for
doc host handler.
BUG=37008
TEST=none
TBR=ananta
Review URL: http://codereview.chromium.org/660255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=amit
TEST=fixes one of the top crashes in the lastest release.
BUG=36985
Review URL: http://codereview.chromium.org/661256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If one tries to upload a file that one doesn't have read access to,
the browser livelocks. It tries to read from the file, gets nothing
but spins forever because it knows that it hasn't finished reading.
To address this, firstly we add a check at stat() time to make sure
that we can read the file. However, this doesn't take care of the case
where the access() call was incorrect, or the permissions have changed
under us. In this case, we replace the missing file with NULs.
(Land attempt three: first in r39446, reverted in r39448. Second in
r39899, reverted in r39901.)
http://codereview.chromium.org/541022
BUG=30850
TEST=Try to upload a file that isn't readable (i.e. /etc/shadow). The resulting upload should be a 0 byte file.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
IInternetProtocolSink_PatchInfo one.
TEST=Should be no change. If there is a regression because of this, it would be in the form of failing to switch to CF for pages that have the CF meta tag.
BUG=none
Review URL: http://codereview.chromium.org/660032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specific DLL,
instead of relying on CoInitialize/CoUninitialize to load and unload at least one DLL.
Add minidump_test as a dependency to make sure it's always built.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://docs.google.com/View?id=dd4ngnpz_0dpsb8n96 for API proposal.
BUG=0
TEST=See unit tests as part of this CL
Review URL: http://codereview.chromium.org/657037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crashes when object is destroyed and there is tasks in the queue.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
channel getting destroyed
and it being referenced in the background thread.
Fix is to use the underlying IPC::Channel pointer passed to the message filter when the
filter gets Added to send and receive messages. This ensures that the SyncChannel is not used across
threads.
Review URL: http://codereview.chromium.org/661109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40076 0039d316-1c4b-4281-b951-d872f2087c98
|