| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TBR=slightlyoff
Review URL: http://codereview.chromium.org/245031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation for certificate errors
to be displayed in IE6. This is because on IE6 the default IBindStatusCallback implementation in MSHTML
implements the IWindowForBindingUI interface only thus resulting in the error dialog being displayed.
We emulate this by returning S_FALSE in OnSecurityProblem for IE6.
This should fix the IE6 issue reported in bug http://b/issue?id=2059540
Bug=2059540
Review URL: http://codereview.chromium.org/220041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/248021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cross-thread NewRunnableMethod.
This assertion caught such an error in VisitedLinkMaster!
My approach, modify RunnableMethodTraits<T> to assert that
when ReleaseCallee happens on a different thread from
RetainCallee that the type supports thread-safe reference
counting. I do this by adding a static method to both
RefCounted<T> and RefCountedThreadSafe<T>.
This results in a little ugliness in cases where people
implement AddRef and Release by hand (to make the no-ops).
There may be a nicer way to deal with those few cases.
R=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/251012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fixes that by returning URLZONE_INTERNET for most of the URLs, as we cannot directly map them to internal/external URLs. The reason being Chrome would need to honor the security settings from IE based on the zone.
We also disallow navigation in ChromeFrame for restricted URLs.
This fixes bug http://b/issue?id=2059403
This CL also fixes the stray issues with cf:attach_external_tab being visible in the tab title at times.
This can be easily reproduced if the tabs being opened are background tabs. To set the title we call
Exec on the IOleCommandTarget exposed by the frame. This is queried off the IOleInPlaceSite interface which
is maintained by the m_spInPlaceSite member variable in CComControlBase. This member is not set when the tab
is opened as a background tab and only gets set when it is activated. The fix is to query the IOleInPlaceSite
interface from the IOleClientSite interface if the m_spInPlaceSite is not set.
This fixes http://b/issue?id=2119243
Bug=2059403,2119243
Review URL: http://codereview.chromium.org/220042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrameAutomationClient::InitiateNavigation
method as this is a central chokepoint.
Should fix http://b/issue?id=1934996
Bug=1934996
Review URL: http://codereview.chromium.org/235017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=robertshield
Review URL: http://codereview.chromium.org/242008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/222027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame VTable patches the IInternetProtocol interface for the CLSID_HttpProtocol
and CLSID_HttpSProtocol handlers. However we were using the same VTable information to patch both
the handlers essentially overwriting the first one. While this all worked purely by chance, it
exposed a bug in IE8 where every new tab initially goes into a new process and if the chromeframe
is unloaded we would leave behind an IInternetProtocol interface in urlmon patched, which would
crash when dereferenced.
Added a check in the VTable patching code for this case.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=22768
Bug=22768
Review URL: http://codereview.chromium.org/244002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove the unused chrome_frame\DEPS file.
Review URL: http://codereview.chromium.org/243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/223023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
coming in a separate CL.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/218019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98
|