summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Relanding this.ananta@chromium.org2011-10-311-2/+2
| | | | | | | | | | | | | | | | | | | | Fix a ChromeFrame crash which occurs in the background worker thread while dereferencing a NULL automation client. This crash occurs when the active document is in the process of shutting down while there are active background requests still pending. Fix is to ensure that the background thread has been stopped before returning from the UrlmonUrlRequestManager::StopAll function which gets called during CF shutdown. Fixes bug http://code.google.com/p/chromium/issues/detail?id=102393 BUG=102393 TBR=robertshield Review URL: http://codereview.chromium.org/8384019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108010 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107995 - Fix a ChromeFrame crash which occurs in the background ↵ananta@chromium.org2011-10-311-2/+0
| | | | | | | | | | | | | | | | | | | | worker thread while dereferencing a NULL automation client. This crash occurs when the active document is in the process of shutting down while there are active background requests still pending. Fix is to ensure that the background thread has been stopped before returning from the UrlmonUrlRequestManager::StopAll function which gets called during CF shutdown. Fixes bug http://code.google.com/p/chromium/issues/detail?id=102393 BUG=102393 Review URL: http://codereview.chromium.org/8429011 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/8431011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107997 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ChromeFrame crash which occurs in the background worker thread while ↵ananta@chromium.org2011-10-311-0/+2
| | | | | | | | | | | | | | | | | dereferencing a NULL automation client. This crash occurs when the active document is in the process of shutting down while there are active background requests still pending. Fix is to ensure that the background thread has been stopped before returning from the UrlmonUrlRequestManager::StopAll function which gets called during CF shutdown. Fixes bug http://code.google.com/p/chromium/issues/detail?id=102393 BUG=102393 Review URL: http://codereview.chromium.org/8429011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107995 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107967 - Introduces chromium_resources.gyp to factor out Chrome ↵dhollowa@chromium.org2011-10-311-5/+5
| | | | | | | | | | | | | | | | | | | | | resource generation 1. Factors out Chrome/Chromium resource generation into a separate chrome_resources.gyp file. 2. Eliminates repetition between Mac and other platforms. 3. Breaks long "repack" actions out into separate files for greater readability. 4. Eliminates circular dependencies in the Aura shell, the Views components, and the compositor when utilizing Chrome resources. BUG=none TEST=try bots run gyps and build correctly. Review URL: http://codereview.chromium.org/8425002 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/8430011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107984 0039d316-1c4b-4281-b951-d872f2087c98
* Introduces chromium_resources.gyp to factor out Chrome resource generationdhollowa@chromium.org2011-10-311-5/+5
| | | | | | | | | | | | | | | | 1. Factors out Chrome/Chromium resource generation into a separate chrome_resources.gyp file. 2. Eliminates repetition between Mac and other platforms. 3. Breaks long "repack" actions out into separate files for greater readability. 4. Eliminates circular dependencies in the Aura shell, the Views components, and the compositor when utilizing Chrome resources. BUG=none TEST=try bots run gyps and build correctly. Review URL: http://codereview.chromium.org/8425002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107967 0039d316-1c4b-4281-b951-d872f2087c98
* Move PageZoom enum into content/public/common and into the content ↵jam@chromium.org2011-10-289-14/+14
| | | | | | | | | namespace. Also move content_costants to content/public/common. BUG=98716 Review URL: http://codereview.chromium.org/8413051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107804 0039d316-1c4b-4281-b951-d872f2087c98
* Split BrowserThread into public API and private implementation, step 1.joi@chromium.org2011-10-283-8/+8
| | | | | | | | | | | | | | | | | | | | | Only content/ now has the ability to create BrowserThread objects, with the exception that tests can create the content::TestBrowserThread subclass, and (temporarily) code in chrome/ can create the DeprecatedBrowserThread subclass. A follow-up change will make content/ take care of its own thread creation, remove DeprecatedBrowserThread, and move all state and non-trivial constructors from BrowserThread down to BrowserThreadImpl. Also moved BrowserProcessSubThread into content/ namespace. As part of follow-up cleanup, chrome/ will stop using this class. BUG=98716 TEST=existing Review URL: http://codereview.chromium.org/8392042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
* rename Run in MessageLoopForUI to RunWithDispatcheroshima@google.com2011-10-241-4/+4
| | | | | | | | | BUG=99471 TEST=none Review URL: http://codereview.chromium.org/8343023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106896 0039d316-1c4b-4281-b951-d872f2087c98
* Move content_paths.h to content/public/common.jam@chromium.org2011-10-211-1/+1
| | | | | | | | BUG=98716 TBR=avi Review URL: http://codereview.chromium.org/8375007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106795 0039d316-1c4b-4281-b951-d872f2087c98
* Update automation messages to use the new way of declaring message structs, ↵jam@chromium.org2011-10-213-28/+31
| | | | | | | | to cut back on unnecessary code. Review URL: http://codereview.chromium.org/8356020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106734 0039d316-1c4b-4281-b951-d872f2087c98
* Move SecurityStyle enum into content/public/common and put it into the ↵jam@chromium.org2011-10-211-1/+1
| | | | | | | | content namespace.BUG=98716 Review URL: http://codereview.chromium.org/8361019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106642 0039d316-1c4b-4281-b951-d872f2087c98
* Make NotificationService an interface in the content namespace, and switch ↵jam@chromium.org2011-10-192-4/+7
| | | | | | | | | callers to use it. Move the implementation to content/browser. Stop creating it in all child processes since it's only used in the browser. BUG=98716 Review URL: http://codereview.chromium.org/8342048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106403 0039d316-1c4b-4281-b951-d872f2087c98
* Have Chrome Frame build its .idl artifacts into a sub-folder of ↵robertshield@chromium.org2011-10-1923-104/+46
| | | | | | | | | | | | SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98
* Move content_client.h into content/public.joi@chromium.org2011-10-181-1/+1
| | | | | | | | | | TBR=jam@chromium.org BUG=98716 TEST=it builds Review URL: http://codereview.chromium.org/8336007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106167 0039d316-1c4b-4281-b951-d872f2087c98
* base/win: small improvement to RegKey API.tfarina@chromium.org2011-10-181-1/+1
| | | | | | | | | | | | - Rename ValueExists() to HasValue(). - Rename ValueCount() to GetValueCount(). - Rename ReadName() to GetValueNameAt(). R=maruel@chromium.org,willchan@chromium.org Review URL: http://codereview.chromium.org/8337006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106074 0039d316-1c4b-4281-b951-d872f2087c98
* Move navigation_types.h from content/common to content/public/browser, and ↵jam@chromium.org2011-10-181-1/+0
| | | | | | | | | | | put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API. BUG=98716 TBR=joi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106029 Review URL: http://codereview.chromium.org/8339006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106070 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 106029nkostylev@chromium.org2011-10-181-0/+1
| | | | | | | | | | | | | | | Broke http://build.chromium.org/p/chromium.perf/console Move navigation_types.h from content/common to content/public/browser, and put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8339006 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/8333018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106054 0039d316-1c4b-4281-b951-d872f2087c98
* Move navigation_types.h from content/common to content/public/browser, and ↵jam@chromium.org2011-10-181-1/+0
| | | | | | | | | | put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8339006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106029 0039d316-1c4b-4281-b951-d872f2087c98
* Remove toolstrips from Chrome.aa@chromium.org2011-10-171-7/+7
| | | | | | | | | | BUG=100488 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/8315005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105959 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 105803 - Have Chrome Frame build its .idl artifacts into a sub-folder ↵robertshield@chromium.org2011-10-1713-34/+66
| | | | | | | | | | | | | | | | | | | of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8150002 TBR=robertshield@chromium.org Review URL: http://codereview.chromium.org/8318013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105823 0039d316-1c4b-4281-b951-d872f2087c98
* Have Chrome Frame build its .idl artifacts into a sub-folder of ↵robertshield@chromium.org2011-10-1713-66/+34
| | | | | | | | | | | SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8150002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105803 0039d316-1c4b-4281-b951-d872f2087c98
* scoped_ptr and new[] don't mix.thakis@chromium.org2011-10-071-3/+3
| | | | | | | | | | BUG=99261 TEST=none Review URL: http://codereview.chromium.org/8207004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104592 0039d316-1c4b-4281-b951-d872f2087c98
* Marking FullTabUITest.TabCrashRefresh as disabled.rdsmith@chromium.org2011-10-061-2/+3
| | | | | | | | | BUG=99317 Review URL: http://codereview.chromium.org/8177014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104354 0039d316-1c4b-4281-b951-d872f2087c98
* Mark CF/FullTabUITest.TabCrashRefresh chrome frame test as flaky.rdsmith@chromium.org2011-10-061-1/+2
| | | | | | | | | BUG=99317 Review URL: http://codereview.chromium.org/8178002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104316 0039d316-1c4b-4281-b951-d872f2087c98
* Handle UrlRequests in ChromeFrame for resource types except MAIN_FRAME and ↵ananta@chromium.org2011-10-055-44/+238
| | | | | | | | | | | | | | | | | | | | SUB_FRAME in a background worker thread. We have a new request map in ChromeFrame to keep track of these requests. We synchronize access to this map as it is accessed from multiple threads. This is an attempt to verify if the performance issues seen on CF are related to handling all HTTP requests on the IE UI thread. This is configurable via a registry DWORD value "BackgroundHTTPWorkerThread" under HKCU\Software\Google\ChromeFrame Defaults to true. Fixes bug http://code.google.com/p/chromium/issues/detail?id=98510 BUG=98510 Review URL: http://codereview.chromium.org/8115018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104168 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that foreground tabs which are opened up as new windows in IE6 come ↵ananta@chromium.org2011-10-052-23/+42
| | | | | | | | | | | | | | | | | to the foreground. Fixes bug http://code.google.com/p/chromium/issues/detail?id=99063 BUG=99063 Review URL: http://codereview.chromium.org/8136012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104151 0039d316-1c4b-4281-b951-d872f2087c98
* yet another batch of symbols to export from content.dpranke@chromium.org2011-10-041-0/+1
| | | | | | | | | | | | | Also includes changes to a few gypi's to specify dependencies that are otherwise getting implicitly pulled in. R=jam@chromium.org BUG=90442 TEST= Review URL: http://codereview.chromium.org/8113014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103830 0039d316-1c4b-4281-b951-d872f2087c98
* NetworkDelegate::OnAuthRequired can set or cancel auth, in addition to ↵cbentzel@chromium.org2011-10-031-0/+9
| | | | | | | | | | | | taking no action. BUG=32056 TEST=net_unittests Review URL: http://codereview.chromium.org/8100001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103801 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move UnescapeURLComponent() functions into net namespace.tfarina@chromium.org2011-10-021-1/+1
| | | | | | | | | | | BUG=64263 TEST=None R=willchan@chromium.org Review URL: http://codereview.chromium.org/8109004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103677 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 103360 - NetworkDelegate::OnAuthRequired can set authentication or ↵ddorwin@chromium.org2011-09-291-9/+0
| | | | | | | | | | | | | | | | cancel, in addition to observing. TBR=ananta@chromium.org BUG=32056 TEST=net_unittests Review URL: http://codereview.chromium.org/8037038 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/8082010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103372 0039d316-1c4b-4281-b951-d872f2087c98
* NetworkDelegate::OnAuthRequired can set authentication or cancel, in ↵cbentzel@chromium.org2011-09-291-0/+9
| | | | | | | | | | | | | addition to observing. TBR=ananta@chromium.org BUG=32056 TEST=net_unittests Review URL: http://codereview.chromium.org/8037038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103360 0039d316-1c4b-4281-b951-d872f2087c98
* Two test-related stragglers related to IE10 detection.grt@chromium.org2011-09-292-1/+5
| | | | | | | | | | | BUG=none TEST=none R=robertshield@chromium.org Review URL: http://codereview.chromium.org/8079001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103310 0039d316-1c4b-4281-b951-d872f2087c98
* Factor a log management helper out of MetricsServicestuartmorgan@chromium.org2011-09-292-46/+17
| | | | | | | | | | | | | | | This factors the details of the log transitions between current, staged (previously called pending; renamed for clarity), and unsent (i.e., to-be-stored) log, and all the encoding/compression involved in those transitions, into a helper class: MetricsLogManager. Also simplifies the state machine slightly by combining two states (SEND_OLD_INITIAL_LOGS and SENDING_OLD_LOGS) that behaved the same, moving the logic for deciding which log to send first into the new helper so that the behavior of prioritizing initial logs is unchanged). In order to allow this to continue to be shared with ChromeFrame, the serialization details are factored into a secondary helper; this isn't necessarily ideal, but it does have the benefit of making unit-testing the components easier. This is primarily to facilitate a second change that will add more cases where log serialization/deserialization happens, but even on its own it should be helpful since it moves a discrete chunk out of the overly-large MetricsService+MetricsServiceBase, increasing testability, readability, and maintainability. BUG=None TEST=Metrics should continue to work. Review URL: http://codereview.chromium.org/7237057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103280 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow Chrome to go into background mode when launched by GCF.grt@chromium.org2011-09-293-4/+11
| | | | | | | | | | | | | | | | Doing so is broken in at least a few ways: - in-use updates don't work as desired (must quit IE for 6h) - there's no UX for quitting Chrome Since extensions aren't really supported in GCF anyway, I don't see a problem with disallowing background mode. BUG=97740 TEST=the easy way: fire up IE and visit gcf:about:version, confirm that --disable-background-mode is on the command line. the hard way: install a background extension via the registry mechanism then launch IE and visit gcf:about:version. now check to see if you have an extension process. if so, see that quitting IE makes all chrome.exe processes disappear. Review URL: http://codereview.chromium.org/8070019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103277 0039d316-1c4b-4281-b951-d872f2087c98
* Report IE 10 in histograms.grt@chromium.org2011-09-293-4/+8
| | | | | | | | | | BUG=none TEST=look for "METRICS LOG: " in Sawbuck 30 seconds after GCF starts and see what is sent for ChromeFrame.IEVersion. Review URL: http://codereview.chromium.org/8038071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103239 0039d316-1c4b-4281-b951-d872f2087c98
* Fix stats collection in npchrome_frame.dll.grt@chromium.org2011-09-291-0/+5
| | | | | | | | | | BUG=98449 TEST=set usagestats=DWORD1 in GCF's ClientState key, run GCF, use sawbuck to watch for the METRICS LOG message and confirm that it's not just an empty <log .../> element. Review URL: http://codereview.chromium.org/8071008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103226 0039d316-1c4b-4281-b951-d872f2087c98
* Update paths to chrome frame binaries used by the archive scripts following ↵robertshield@chromium.org2011-09-282-4/+4
| | | | | | | | | | r102780. BUG=NONE TEST=Archive scripts using FILES and SYMBOLS files find all the Chrome Frame binaries. Review URL: http://codereview.chromium.org/8071005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103166 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the \servers build output directory and place Chrome Frame parts into ↵robertshield@chromium.org2011-09-2611-115/+130
| | | | | | | | | the root output folder next to chrome.exe et al. Also add a more helpful error message when failing to register the Chrome Frame dll. Review URL: http://codereview.chromium.org/8013001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102780 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r102336 (remove webkit_glue::BuildUserAgent) w/ fix.dpranke@chromium.org2011-09-263-20/+13
| | | | | | | | | | | | | | | | | | | | | | Remove webkit_glue::BuildUserAgent(), change the contract in webkit_glue so that SetUserAgent() must be called before GetUserAgent(). This was causing a dependency inversion between webkit_support and its clients, and was needed for the content component build. For content users, calling SetContentClient() will automatically initialize the user agent (retrieved from client->GetUserAgent()). As a bonus, fixing this allowed me to re-test the "mimic_windows" code path and it looks like we no longer need it. R=jam@chromium.org,rsesek@chromium.org BUG=11136, 90442 TEST=visit yahoo! mail using Chromium on Linux, ensure that we don't get an "unsupported browser" warning. Review URL: http://codereview.chromium.org/8045005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102763 0039d316-1c4b-4281-b951-d872f2087c98
* Fix in-use updates for Chrome Frame.grt@chromium.org2011-09-233-12/+17
| | | | | | | | | | | | | On in-use updates, make a copy of the old chrome launcher's IE low rights elevation policy prior to registering the new npchrome_frame.dll so that running instances of IE can still launch Chrome. In so doing, I also removed elevation policy addition/removal code from the installer so that npchrome_frame.dll's {un,}registration code is the one and only place where this is done. BUG=95810 TEST=Install a previous version of GCF, run IE and visit some page that activates GCF, update to a version of GCF containing this fix, then try to visit another page that will activate GCF. If all goes well, you won't see an IE security prompt. Review URL: http://codereview.chromium.org/7976045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102569 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove webkit_glue::BuildUserAgent(), change the contract in ↵dpranke@chromium.org2011-09-223-13/+20
| | | | | | | | | | | | webkit_glue" TBR=jam@chromium.org BUG=90442 TEST=none Review URL: http://codereview.chromium.org/8002003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102353 0039d316-1c4b-4281-b951-d872f2087c98
* Remove webkit_glue::BuildUserAgent(), change the contract in webkit_glue so ↵dpranke@chromium.org2011-09-223-20/+13
| | | | | | | | | | | | | | | | | | that SetUserAgent() must be called before GetUserAgent(). This was causing a dependency inversion between webkit_support and its clients, and was needed for the content component build. For content users, calling SetContentClient() will automatically initialize the user agent (retrieved from client->GetUserAgent()). As a bonus, fixing this allowed me to re-test the "mimic_windows" code path and it looks like we no longer need it. R=jam@chromium.org,tony@chromium.org BUG=11136,90442 TEST=visit yahoo! mail using Chromium on Linux, ensure that we don't get an "unsupported browser" warning. Review URL: http://codereview.chromium.org/7922023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102336 0039d316-1c4b-4281-b951-d872f2087c98
* Make iaccessible2 write shared generated files to SHARED_INTERMEDIATE_DIRrsleevi@chromium.org2011-09-221-1/+1
| | | | | | | | | | BUG=97186 TEST=none Review URL: http://codereview.chromium.org/7971008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102247 0039d316-1c4b-4281-b951-d872f2087c98
* Delete Tracked, and move Location to its own file.ajwong@chromium.org2011-09-214-7/+6
| | | | | | | | | | | | | The Birth/Death tracking of tasks has been moved out-of-band into MessageLoop's PendingTask structure. Thus, Task no longer needs to inherit from Tracked. Since Task was the only child of Tracked, delete the Tracked class and move Location to its own file. BUG=none TEST=builds Review URL: http://codereview.chromium.org/7879006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeFrame net tests dchecks in debug builds due to a missing ↵ananta@chromium.org2011-09-202-2/+5
| | | | | | | | | | | | | | | | | AtExitManager instance. The AtExitManager instance is initialized by the NetTestSuite class constructor. The dchecks fire because the NotificationService constructor uses the lazy instance class which relies on the AtExitManager instance being initialized. The fix is to initialize the NotificationService instance after the NetTestSuite constructor has done its job. BUG=none TEST=chrome frame net tests should pass in debug builds. TBR=jam Review URL: http://codereview.chromium.org/7981011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101994 0039d316-1c4b-4281-b951-d872f2087c98
* Updated *.pak file format to support both UTF8 and UTF16adriansc@chromium.org2011-09-191-4/+8
| | | | | | | | | | | | | | | | | Inserted a new field in the header that specifies which encoding is to be used for the text resources. I also upped file format to version 4. BUG=76281 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101213 Review URL: http://codereview.chromium.org/7744017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101846 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup AutomationProviderList to fix shutdown crashes on ChromeOS auto testsstevenjb@google.com2011-09-161-4/+3
| | | | | | | | | | | | | | There is a circular relationship between BrowserProcessImpl and AutomationProvider. To clean this up and eliminate a shutdown crash: 1. Eliminate the AutomationProviderList singleton instance; it is already clearly owned by BrowserProcessImpl 2. Eliminate the calls to g_browser_process->Add/ReleaseModule in AutomationProvider since BrowserProcessImpl already owns AutomationProviderList (which owns any AutomationProvider instances). This could possibly have side effects if AutomationProvider attempts to access the message loop after the last call to BrowserProcessImpl::ReleaseModule exits the message loop, but that shouldn't be happening. BUG=96030 TEST=./run_remote_tests.sh --remote=localhost --ssh_port 9222 --use_emerged suite_Smoke and ensure no crashes occur in ~AutomationProvider Review URL: http://codereview.chromium.org/7790031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101582 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression in ChromeFrame which resulted in PROPFIND requests not ↵ananta@chromium.org2011-09-161-1/+2
| | | | | | | | | | | including the body of the request. Fixes bug http://code.google.com/p/chromium/issues/detail?id=95534 BUG=95334 Review URL: http://codereview.chromium.org/7906012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101525 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in chrome_frame_net_tests since there was no more ↵jam@chromium.org2011-09-151-0/+2
| | | | | | | | | NotficiationService getting created in BrowserProcessImpl. TBR=ananta Review URL: http://codereview.chromium.org/7918004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101416 0039d316-1c4b-4281-b951-d872f2087c98
* This broke lots of layout tests on OSX.levin@chromium.org2011-09-151-8/+4
| | | | | | | | | | | | | | | | | | | | | | | | See this link for the failure list: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&tests=fast/dom/HTMLTextAreaElement/reset-textarea.html,fast/dom/isindex-001.html,fast/dom/isindex-002.html,fast/forms/blankbuttons.html,fast/forms/box-shadow-override.html,fast/forms/button-default-title.html,fast/forms/file-input-direction.html,fast/forms/hidden-input-file.html,fast/forms/input-appearance-height.html,fast/forms/input-file-re-render.html,fast/forms/input-first-letter.html,fast/forms/isindex-placeholder.html,fast/forms/text-style-color.html,fast/forms/validation-message-appearance.html,fast/html/details-no-summary1.html,fast/html/details-no-summary2.html,fast/html/details-no-summary3.html,fast/html/details-no-summary4.html,fast/html/details-remove-summary-1-and-click.html,fast/html/details-remove-summary-1.html,fast/html/details-remove-summary-4-and-click.html,fast/html/details-remove-summary-4.html,fast/html/keygen.html,tables/mozilla/bugs/bug39209.html,tables/mozilla/bugs/bug4429.html,fast/forms/005.html,fast/forms/input-file-label.html,fast/invalid/residual-style.html,fast/parser/fragment-parser.html,fast/replaced/table-percent-height-text-controls.html,html5lib/runner.html,http/tests/misc/isindex-with-no-form-base-href.html,http/tests/misc/isindex-with-no-form.html Revert 101213 - Updated *.pak file format to support both UTF8 and UTF16 Inserted a new field in the header that specifies which encoding is to be used for the text resources. I also upped file format to version 4. BUG=76281 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973 Review URL: http://codereview.chromium.org/7744017 TBR=adriansc@chromium.org Review URL: http://codereview.chromium.org/7890060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101224 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 07:17:14 +0000