| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add send and receive times to HttpNetworkTransaction.
Add LoadTimingInfo accessors to Http*Transaction,
URLRequestJob, and URLRequest classes.
Proxy resolution times still need to be added.
BUG=77446
Review URL: https://chromiumcodereview.appspot.com/11929017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
migrating WebDB data.
BUG=100845
TBR=robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11821044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I will do a second pass when I fix GetDefaultProfileDir.
BUG=83792
Review URL: https://chromiumcodereview.appspot.com/11571089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first two (PrefServiceSimple is a subclass of PrefService) know
nothing about sync or any Chrome or content concepts.
The third (PrefServiceSyncable, a separate subclass of PrefService)
knows about sync and requires users to choose whether each individual
preference is syncable or not when it is registered.
BrowserProcess::local_state() is a PrefServiceSimple after this
change, and Profile::prefs() is a PrefServiceSyncable.
COLLABORATOR=kaiwang@chromium.org
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11570009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Please note that FLAKY_ tests have been ignored anyway. When tests started
crashing, people just flipped that to DISABLED_ . Why not go straight to
DISABLED_ then, so that we avoid wasting time on stupid test prefix games?
With DISABLED_ it is clear to everyone that there is no coverage from given
test. FLAKY_ creates an illusion of coverage, while in fact the test is still
ignored.
If a FLAKY_ test fails and nobody notices, does it still make a sound? ;-)
Finally, note that gtest has a --gtest_also_run_disabled_tests if you need
to run tests manually.
TBR=jam
BUG=none
Review URL: https://codereview.chromium.org/11664013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add UploadFileElementReaderSync and use it from Chrome Frame.
Remove UploadDataStream::InitSync/ReadSync
Remove UploadElementReader::InitSync/ReadSync
Allow passing null callbacks for Init/Read when callers can be confident that the operation finishes synchronously.
BUG=None
TEST=net_unittests, chrome_frame_net_tests
TBR=ananta@chromium.org for chrome_frame/urlmon_upload_data_stream.cc
Review URL: https://chromiumcodereview.appspot.com/11587007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
deleting arrays.
This is based on the modifications by "Geoffrey Romer"
<gromer@google.com> to Google's internal version of scoped_ptr<>. All cleaver tricks are his, not mine. :)
It brings most of the features of C++11's unique_ptr<> into this class and should eliminate the need for scoped_array<>, scoped_malloc_free<>, and possibly a few other scopers. Please refer to the unique_ptr<> API for documentation.
Divergence from unique_ptr<>:
1) DefaultDeleter<T[n]> (sized-arrays) is explicitly disabled because this construct would cause the single-object delete to be called on a pointer to a T[n]. It is impossible to construct a single-object new expression that returns a T[n]*. You can only get this with new[] which should correspond to DefaultDeleter<T[n][]>. This issue has been raised with the C++ LWG as it is possible a unique_ptr<> spec defect.
2) Reference types for Deleters are not supported. This simplifies implementation significantly because there is no need to distinguish between the converting constructor + converting assignment operator and their move constructor + move assignment operator.
4) Move-only Deleters are not supported. Avoids the need to emulate std::forward().
BUG=109874
TBR=dhollowa,kinuko,ananta,hans,scherkus
Review URL: https://codereview.chromium.org/11149006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change extracts a non-test PrefServiceBuilder from
PrefServiceMockBuilder, and extracts the Chrome-specific logic
previously in pref_service.cc that was used to put together a
PrefService for Chrome into a ChromePrefServiceBuilder subclass
thereof.
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11570007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the first-request failures.
BUG=143699
TEST=chrome_frame_tests
Review URL: https://chromiumcodereview.appspot.com/11316280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=144664
TBR=robertshield@chromium.org
Review URL: https://codereview.chromium.org/11547030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change argument of UploadDataStream's ctor from UploadData to ScopedVector<UploadElementReader>
Move chunk related logic from UploadData to UploadDataStream.
Move UploadElementReader creation code from UploadElementReader::Create to URLRequest::set_upload. (this code will soon be moved again to src/webkit/glue/resource_request_body.cc)
BUG=156574
TEST=net_unittests
TBR=jam@chromium.org for chrome/browser/automation (already reviewed by ananta@)
Review URL: https://chromiumcodereview.appspot.com/11419220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
actually disabled.
BUG=163728
TBR=robertshield
Review URL: https://codereview.chromium.org/11411359
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/11308333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
refactoring of ProcessSingleton on Windows requires that only NotifyOtherProcessOrCreate() be callable from the public interface.
This doesn't change any code logic, just moves things around.
BUG=None
Review URL: https://codereview.chromium.org/11415237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=163728
TBR=robertshield@chromium.org
Review URL: https://codereview.chromium.org/11411303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/11316120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on upgrade to https.
URLRequestRedirectJobs now take a status code on construction,
to reduce the change of regressions, and the status code can
no longer be changed after construction.
TBR=jhawkins@chromium.org
BUG=159343
Review URL: https://chromiumcodereview.appspot.com/11420013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RunAllPending() is deprecated and we should switch to RunUntilIdle().
BUG=131220
TBR=erikwright@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11299168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new naming scheme simply appends .pdb to the target (e.g. foo.dll.pdb and
foo.exe.pdb). This is beneficial for a couple reasons:
* no more chrome_dll.pdb and chrome_exe.pdb silliness
* also avoids this issue if we end up with similarly named targets in the
future (target.dll and target.exe)
* ninja already does this, and, by extension, either ninja needs to be broken
to use the old scheme, or the we fix the broken in the existing system.
One less difference between msvs and ninja.
Fixes for chrome-internal stuff: https://chromereviews.googleplex.com/5681015
BUG=
Review URL: https://codereview.chromium.org/11384003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also add to base namespace.
BUG=
Review URL: https://codereview.chromium.org/11359217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using std::vector to hold UploadElement is bad for two reasons:
1. It results in a lot of unnecessary copy of uploaded data.
2. Appending new chunks may result in invalidating the pointer held by UploadBytesElementReader.
BUG=160028
TEST=git try
TBR=ananta@chromium.org, tony@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11275223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dependencies
One of the long term goals of the sync team is to pull sync code out of
chrome.dll and into its own component. As of today, several chrome tests
depend on various sync targets as defined in sync.gyp.
This is the first in a series of CLs to achieve the above goal.
This patch does the following:
- Renames / reorganizes several of the targets in sync.gyp
- Updates the declarations in various chrome gyp files by depending on
the smallest sync target possible to reflect the actual dependency.
- Takes a step closer toward the ideal IWYU guideline.
TBR=erikwright@chromium.org
BUG=136928
TEST=all chrome targets build on all platforms; all tests pass.
Review URL: https://chromiumcodereview.appspot.com/11348052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't create an extensions gyp target, or a module with a public API.
It does set of DEPS rules and seems like it will make it easier for people to
write correctly layered code today, while we are in transition.
BUG=159265
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11410015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This file contains some rather generic names like "TestDelegate". Move it to the
net namespace to avoid collisions
BUG=none
TBR=wtc@chromium.org,darin@chromium.org
Original Review URL: https://codereview.chromium.org/11369179
Review URL: https://chromiumcodereview.appspot.com/11365227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This file contains some rather generic names like "TestDelegate". Move it to the
net namespace to avoid collisions
BUG=none
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/11369179
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/11410066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This file contains some rather generic names like "TestDelegate". Move it to the
net namespace to avoid collisions
BUG=none
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/11369179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 0ed667765967ffa7ab1bfa455e7aa570f433eb07.
Reverted deletion of TestWithWebServer from chrome_frame_tests.
BUG=160497
TBR=grt@chromium.org
Review URL: https://codereview.chromium.org/11275258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=160497
TBR=grt@chromium.org
Review URL: https://codereview.chromium.org/11275256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Following tests: FullTabModeIE_XHRTest FullTabModeIE_MetaTag FullTabModeIE_TestMultipleGet
WidgetModeIE_CFInstanceNoSrc
WidgetModeIE_Version
WidgetModeIE_NavigateURLRelative
WidgetModeIE_iframeBasic
Are marked as FLAKY.
BUG=160497
TBR=grt@chromium.org
Review URL: https://codereview.chromium.org/11275254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also replaces the StackWString with StackString16 and adds a char traits definition to the string16 header file to make this possible without ifdefs.
BUG=
Review URL: https://codereview.chromium.org/11360174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pool also ensures that the same file requests are written in order received and that they block on shutdown.
BUG=153367
TEST=existing unit/browser tests
Review URL: https://codereview.chromium.org/11027070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Create a pure-virtual interface called HttpUserAgentSettings that provides access to the Accept-Language, Accept-Charset, and User-Agent HTTP headers. Each UrlRequestContext should have a HttpUserAgentSettings implementation attached via set_http_user_agent_settings().
BUG=146596
Review URL: https://chromiumcodereview.appspot.com/10918279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original description:
Moved JsonPrefStore to use SequencedWorkerPool instead of FILE thread. The pool also ensures that the same file requests are written in order received and that they block on shutdown.
BUG=153367
TEST=existing unit/browser tests
Review URL: https://codereview.chromium.org/11027070
TBR=zelidrag@chromium.org
Review URL: https://codereview.chromium.org/11312046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/handling-a-failing-test
and https://groups.google.com/a/chromium.org/d/topic/chromium-dev/_OwJ_GWfOaY/discussion
BUG=none
Review URL: https://codereview.chromium.org/11293028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When setting a cookie's expiration time in the cookie store we need
to take into account any difference between the HTTP server and the
host machine's real time clock. This reverts 159685 which reverted 146616.
BUG=135131
TEST=net_unittests --gtest_filter=CookieMonster/CookieStoreTest/0.TestCookieDeletion
Review URL: https://chromiumcodereview.appspot.com/11339032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pool also ensures that the same file requests are written in order received and that they block on shutdown.
BUG=153367
TEST=existing unit/browser tests
Review URL: https://codereview.chromium.org/11027070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
In accordance with the specification.
BUG=156147
Review URL: https://chromiumcodereview.appspot.com/11192045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
include the --lang flag
The renderers expect this flag to be present, and WebKit expects a non-empty default language
BUG=154539
TEST=no assert about missing default locale when running a debug build of chrome or content_shell in single process mode
TBR=erikwright
Review URL: https://chromiumcodereview.appspot.com/11231055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recording
This is necessary for Android and iOS, where there is a preference to record
without uploading while on 3G, with the logs being stored for later uploading
over WiFi.
(Also updates the overview comment at the top of the file to reflect an earlier change to the state machine behavior that wasn't documented, and adds the foregrounding/backgrounding methods on iOS)
TBR=thakis,ananta
BUG=136984
Review URL: https://chromiumcodereview.appspot.com/11033023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
intialized on the Thread.
This makes one functional change: when COM is initialized in STA mode, the Thread is forced to use a TYPE_UI message loop. Most of the modified consumers here didn't previously do that, but after discussion with cpu and siggi, it seems safest, even though it's more heavyweight.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11048029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is take 2; the original patch ( http://crrev.com/159815 ), which only dealt with OLE, broke a few tests. The OneClickSignIn tests were skipping the RenderViewHostTestHarness SetUp() method, while the Accessibility tests directly muck with Widgets and thus have to manually init OLE.
BUG=none
TEST=Fewer "Multiple OleInitialize..." messages in tests
Review URL: https://codereview.chromium.org/11031059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to break dependencies back to Chrome.
This leaves the following in chrome/ for now, which will move later:
- PrefService, to move once sync dependencies and dependencies on
Chrome-specific pref stores are externalized.
- PrefNotifierImpl and PrefObserverMock, to move once
NotificationSource dependency is broken.
- PrefValueStore, to move once PrefModelAssociatior dependency is
externalized.
- ScopedUserPrefUpdate, to move once PrefService moves.
TBR=ben@chromium.org
BUG=155525
Review URL: https://chromiumcodereview.appspot.com/11243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ffmpeg from C99 to C89 syntax and compile through MSVC++! This is
awesome for many reasons:
- Better performance! MSVC compiled code is as fast as some of the
hand rolled assembly in certain cases (per rbultje).
- Debugging symbols! (!!!) Crash dumps will now be symbolized with
all symbols instead of the missing symbols traces we get in crash
reports today.
- No more hand rolling binaries every time ffmpeg needs a security
fix or someone wants to make a change!
- Greatly reduced binary size, the Chrome DLLs are ~3.2mb smaller
and the Chromium DLLs ~2.3mb smaller: Chrome: 5205049 -> 1817600,
Chromium: 3587185 -> 1147904.
This change also cleans up the media library initialization code
and gets rid of the old dll names in various places. There is
still one other locations which need to be updated separately:
http://src.chromium.org/viewvc/chrome/trunk/tools/build/site_config/config.py
The downside is this will add ~3minutes of compile time (on T3500)
for non-GOMA users and ~30 seconds for GOMA users (-j 256).
More information available here:
https://gerrit.chromium.org/gerrit/#/c/34728/
BUG=39887
TEST=Manual testing. Unit tests. It actually compiles!
Review URL: https://codereview.chromium.org/11036039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome itself.
Including generated files from within .rc files doesn't work since there's no dependency tracking going on.
BUG=155714
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11147012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=155501
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11149009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename existing Read() to ReadSync()
Change type of |buf| from char* to scoped_refptr<IOBuffer> so that async operation is always performed safely
Add an asynchronous implementation, Read()
The newly added Read() is not used yet, all users still use the old version ReadSync()
BUG=72001
TEST=net_unittests
Review URL: https://chromiumcodereview.appspot.com/10910268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=143646
TEST= mini_installer (with branding=chrome) builds
Here is the error:
t0\src>ninja -C out\Debug mini_installer
[1/9] CXX obj\chrome_frame\npchrome_frame.chrome_tab.obj
FAILED: ninja -t msvc -r . -o obj\chrome_frame\npchrome_frame.chrome_tab.obj -e environment.x86 -- cl.exe ...
.. microsoft visual studio 11.0\vc\atlmfc\include\atlbase.h(2845) : error C2338: 'CAtlDllModuleT<T>'
must be used with either _WINDLL or _USRDLL defined
..\microsoft visual studio 11.0\vc\atlmfc\include\atlbase.h(3298) :
see reference to class template instantiation 'ATL::CAtlValidateModuleConfiguration<isDllModule,T>' being compiled
with
[
isDllModule=true,
T=`anonymous-namespace'::ChromeTabModule
]
t0\src\chrome_frame\chrome_tab.cc(98) : see reference to class template instantiation 'ATL::CAtlDllModuleT<T>' being compiled
with
[
T=`anonymous-namespace'::ChromeTabModule
]
Review URL: https://codereview.chromium.org/11189018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=155501
TEST=none
Review URL: https://codereview.chromium.org/11048053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
code, it does mean we do consistent logging and error-checking at all these sites.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11050009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ScopedCOMInitializer, pulled out separately to make review easier.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/10991052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159526 0039d316-1c4b-4281-b951-d872f2087c98
|