summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Disable CF web server tests temporarily on IE9 while we hunt down the cause ↵robertshield@chromium.org2012-12-141-0/+6
| | | | | | | | | | | | of the first-request failures. BUG=143699 TEST=chrome_frame_tests Review URL: https://chromiumcodereview.appspot.com/11316280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173124 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ContextMenuTest.CFTxtFieldSelectAlldgrogan@chromium.org2012-12-121-1/+2
| | | | | | | | | BUG=144664 TBR=robertshield@chromium.org Review URL: https://codereview.chromium.org/11547030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172679 0039d316-1c4b-4281-b951-d872f2087c98
* net: Make UploadDataStream independent from UploadDatahashimoto@chromium.org2012-12-111-3/+54
| | | | | | | | | | | | | | Change argument of UploadDataStream's ctor from UploadData to ScopedVector<UploadElementReader> Move chunk related logic from UploadData to UploadDataStream. Move UploadElementReader creation code from UploadElementReader::Create to URLRequest::set_upload. (this code will soon be moved again to src/webkit/glue/resource_request_body.cc) BUG=156574 TEST=net_unittests TBR=jam@chromium.org for chrome/browser/automation (already reviewed by ananta@) Review URL: https://chromiumcodereview.appspot.com/11419220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172295 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo so that ChromeFrameTestWithWebServer.FullTabModeIE_SubFrame is ↵dmazzoni@chromium.org2012-12-041-1/+1
| | | | | | | | | | | actually disabled. BUG=163728 TBR=robertshield Review URL: https://codereview.chromium.org/11411359 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170979 0039d316-1c4b-4281-b951-d872f2087c98
* build fix attemptthakis@chromium.org2012-12-031-1/+1
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11308333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170818 0039d316-1c4b-4281-b951-d872f2087c98
* Move many ProcessSingleton methods to "protected" visibility as an upcoming ↵gab@chromium.org2012-12-031-0/+2
| | | | | | | | | | | | refactoring of ProcessSingleton on Windows requires that only NotifyOtherProcessOrCreate() be callable from the public interface. This doesn't change any code logic, just moves things around. BUG=None Review URL: https://codereview.chromium.org/11415237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170805 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ChromeFrame tests that flakily time out.isherman@chromium.org2012-12-011-5/+8
| | | | | | | | | BUG=163728 TBR=robertshield@chromium.org Review URL: https://codereview.chromium.org/11411303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170616 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make chrome_frame_tests faster.phajdan.jr@chromium.org2012-11-281-2/+2
| | | | | | | BUG=none Review URL: https://codereview.chromium.org/11316120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170089 0039d316-1c4b-4281-b951-d872f2087c98
* POSTs to HSTS domains are no longer converted to GETs mmenke@chromium.org2012-11-281-1/+2
| | | | | | | | | | | | | | | on upgrade to https. URLRequestRedirectJobs now take a status code on construction, to reduce the change of regressions, and the status code can no longer be changed after construction. TBR=jhawkins@chromium.org BUG=159343 Review URL: https://chromiumcodereview.appspot.com/11420013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170029 0039d316-1c4b-4281-b951-d872f2087c98
* chrome_frame: Update the remaining calls from RunAllPending() to RunUntilIdle().tfarina@chromium.org2012-11-263-4/+4
| | | | | | | | | | | | RunAllPending() is deprecated and we should switch to RunUntilIdle(). BUG=131220 TBR=erikwright@chromium.org Review URL: https://chromiumcodereview.appspot.com/11299168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169401 0039d316-1c4b-4281-b951-d872f2087c98
* Make all pdb file names follow the same naming convention.iannucci@chromium.org2012-11-171-1/+0
| | | | | | | | | | | | | | | | | | | The new naming scheme simply appends .pdb to the target (e.g. foo.dll.pdb and foo.exe.pdb). This is beneficial for a couple reasons: * no more chrome_dll.pdb and chrome_exe.pdb silliness * also avoids this issue if we end up with similarly named targets in the future (target.dll and target.exe) * ninja already does this, and, by extension, either ninja needs to be broken to use the old scheme, or the we fix the broken in the existing system. One less difference between msvs and ninja. Fixes for chrome-internal stuff: https://chromereviews.googleplex.com/5681015 BUG= Review URL: https://codereview.chromium.org/11384003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168341 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_temp_dir from base to base/filesbrettw@chromium.org2012-11-164-9/+10
| | | | | | | | | | Also add to base namespace. BUG= Review URL: https://codereview.chromium.org/11359217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168281 0039d316-1c4b-4281-b951-d872f2087c98
* net: Change type of UploadData::elements from std::vector to ScopedVectorhashimoto@chromium.org2012-11-141-2/+2
| | | | | | | | | | | | | | Using std::vector to hold UploadElement is bad for two reasons: 1. It results in a lot of unnecessary copy of uploaded data. 2. Appending new chunks may result in invalidating the pointer held by UploadBytesElementReader. BUG=160028 TEST=git try TBR=ananta@chromium.org, tony@chromium.org Review URL: https://chromiumcodereview.appspot.com/11275223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167611 0039d316-1c4b-4281-b951-d872f2087c98
* [sync] Componentize sync: Part 1: Clean up sync.gyp and update chrome / test ↵rsimha@chromium.org2012-11-141-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | dependencies One of the long term goals of the sync team is to pull sync code out of chrome.dll and into its own component. As of today, several chrome tests depend on various sync targets as defined in sync.gyp. This is the first in a series of CLs to achieve the above goal. This patch does the following: - Renames / reorganizes several of the targets in sync.gyp - Updates the declarations in various chrome gyp files by depending on the smallest sync target possible to reflect the actual dependency. - Takes a step closer toward the ideal IWYU guideline. TBR=erikwright@chromium.org BUG=136928 TEST=all chrome targets build on all platforms; all tests pass. Review URL: https://chromiumcodereview.appspot.com/11348052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167558 0039d316-1c4b-4281-b951-d872f2087c98
* Establish /extensions directory and move URLPattern there.aa@chromium.org2012-11-133-2/+5
| | | | | | | | | | | | | This doesn't create an extensions gyp target, or a module with a public API. It does set of DEPS rules and seems like it will make it easier for people to write correctly layered code today, while we are in transition. BUG=159265 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/11410015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167454 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 167337 - Move url_request_test_util into net namespacejochen@chromium.org2012-11-133-5/+8
| | | | | | | | | | | | | | | This file contains some rather generic names like "TestDelegate". Move it to the net namespace to avoid collisions BUG=none TBR=wtc@chromium.org,darin@chromium.org Original Review URL: https://codereview.chromium.org/11369179 Review URL: https://chromiumcodereview.appspot.com/11365227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167413 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 167337 - Move url_request_test_util into net namespacejochen@chromium.org2012-11-133-8/+5
| | | | | | | | | | | | | | | This file contains some rather generic names like "TestDelegate". Move it to the net namespace to avoid collisions BUG=none TBR=darin@chromium.org Review URL: https://codereview.chromium.org/11369179 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/11410066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167356 0039d316-1c4b-4281-b951-d872f2087c98
* Move url_request_test_util into net namespacejochen@chromium.org2012-11-133-5/+8
| | | | | | | | | | | | This file contains some rather generic names like "TestDelegate". Move it to the net namespace to avoid collisions BUG=none TBR=darin@chromium.org Review URL: https://codereview.chromium.org/11369179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167337 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Deleted TestWithWebServer from chrome_frame_tests."ygorshenin@chromium.org2012-11-121-0/+2
| | | | | | | | | | | | | This reverts commit 0ed667765967ffa7ab1bfa455e7aa570f433eb07. Reverted deletion of TestWithWebServer from chrome_frame_tests. BUG=160497 TBR=grt@chromium.org Review URL: https://codereview.chromium.org/11275258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167170 0039d316-1c4b-4281-b951-d872f2087c98
* Deleted TestWithWebServer from chrome_frame_tests.ygorshenin@chromium.org2012-11-121-2/+0
| | | | | | | | | BUG=160497 TBR=grt@chromium.org Review URL: https://codereview.chromium.org/11275256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167169 0039d316-1c4b-4281-b951-d872f2087c98
* Some chrome frame tests are marked as flaky.ygorshenin@chromium.org2012-11-121-7/+15
| | | | | | | | | | | | | | | | | | Following tests: FullTabModeIE_XHRTest FullTabModeIE_MetaTag FullTabModeIE_TestMultipleGet WidgetModeIE_CFInstanceNoSrc WidgetModeIE_Version WidgetModeIE_NavigateURLRelative WidgetModeIE_iframeBasic Are marked as FLAKY. BUG=160497 TBR=grt@chromium.org Review URL: https://codereview.chromium.org/11275254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167150 0039d316-1c4b-4281-b951-d872f2087c98
* Move stack_container and linked_list to the new containers subdirectory.brettw@chromium.org2012-11-101-2/+2
| | | | | | | | | | This also replaces the StackWString with StackString16 and adds a char traits definition to the string16 header file to make this possible without ifdefs. BUG= Review URL: https://codereview.chromium.org/11360174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167022 0039d316-1c4b-4281-b951-d872f2087c98
* Moved JsonPrefStore to use SequencedWorkerPool instead of FILE thread. The ↵zelidrag@chromium.org2012-11-081-3/+11
| | | | | | | | | | | pool also ensures that the same file requests are written in order received and that they block on shutdown. BUG=153367 TEST=existing unit/browser tests Review URL: https://codereview.chromium.org/11027070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166603 0039d316-1c4b-4281-b951-d872f2087c98
* Provide mutable members of UrlRequestContext via pure-virtual interface. ↵pauljensen@chromium.org2012-11-072-2/+5
| | | | | | | | | | Create a pure-virtual interface called HttpUserAgentSettings that provides access to the Accept-Language, Accept-Charset, and User-Agent HTTP headers. Each UrlRequestContext should have a HttpUserAgentSettings implementation attached via set_http_user_agent_settings(). BUG=146596 Review URL: https://chromiumcodereview.appspot.com/10918279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166425 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 165062 - We believe this change broke startup_testsnsylvain@chromium.org2012-11-011-11/+3
| | | | | | | | | | | | | | | | Original description: Moved JsonPrefStore to use SequencedWorkerPool instead of FILE thread. The pool also ensures that the same file requests are written in order received and that they block on shutdown. BUG=153367 TEST=existing unit/browser tests Review URL: https://codereview.chromium.org/11027070 TBR=zelidrag@chromium.org Review URL: https://codereview.chromium.org/11312046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165492 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: remove FAILS_ prefix, part 1phajdan.jr@chromium.org2012-11-011-1/+1
| | | | | | | | | | | See http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/handling-a-failing-test and https://groups.google.com/a/chromium.org/d/topic/chromium-dev/_OwJ_GWfOaY/discussion BUG=none Review URL: https://codereview.chromium.org/11293028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165415 0039d316-1c4b-4281-b951-d872f2087c98
* Account for server vs host clock skew in cookie expiration times.pauljensen@chromium.org2012-11-011-0/+1
| | | | | | | | | | | | | When setting a cookie's expiration time in the cookie store we need to take into account any difference between the HTTP server and the host machine's real time clock. This reverts 159685 which reverted 146616. BUG=135131 TEST=net_unittests --gtest_filter=CookieMonster/CookieStoreTest/0.TestCookieDeletion Review URL: https://chromiumcodereview.appspot.com/11339032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165323 0039d316-1c4b-4281-b951-d872f2087c98
* Moved JsonPrefStore to use SequencedWorkerPool instead of FILE thread. The ↵zelidrag@chromium.org2012-10-301-3/+11
| | | | | | | | | | | pool also ensures that the same file requests are written in order received and that they block on shutdown. BUG=153367 TEST=existing unit/browser tests Review URL: https://codereview.chromium.org/11027070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165062 0039d316-1c4b-4281-b951-d872f2087c98
* Process only the first Strict-Transport-Security header.palmer@chromium.org2012-10-301-0/+7
| | | | | | | | | | In accordance with the specification. BUG=156147 Review URL: https://chromiumcodereview.appspot.com/11192045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165013 0039d316-1c4b-4281-b951-d872f2087c98
* when running in single process mode, modify the browser's command line to ↵jochen@chromium.org2012-10-251-1/+1
| | | | | | | | | | | | | | | include the --lang flag The renderers expect this flag to be present, and WebKit expects a non-empty default language BUG=154539 TEST=no assert about missing default locale when running a debug build of chrome or content_shell in single process mode TBR=erikwright Review URL: https://chromiumcodereview.appspot.com/11231055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163967 0039d316-1c4b-4281-b951-d872f2087c98
* Make it possible to enable and disable metrics reporting separately from ↵stuartmorgan@chromium.org2012-10-241-2/+0
| | | | | | | | | | | | | | | | | | | recording This is necessary for Android and iOS, where there is a preference to record without uploading while on 3G, with the logs being stored for later uploading over WiFi. (Also updates the overview comment at the top of the file to reflect an earlier change to the state machine behavior that wasn't documented, and adds the foregrounding/backgrounding methods on iOS) TBR=thakis,ananta BUG=136984 Review URL: https://chromiumcodereview.appspot.com/11033023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163841 0039d316-1c4b-4281-b951-d872f2087c98
* Add methods to base::Thread to allow Windows consumers to ask for COM to be ↵pkasting@chromium.org2012-10-234-67/+7
| | | | | | | | | | | | intialized on the Thread. This makes one functional change: when COM is initialized in STA mode, the Thread is forced to use a TYPE_UI message loop. Most of the modified consumers here didn't previously do that, but after discussion with cpu and siggi, it seems safest, even though it's more heavyweight. BUG=none TEST=none Review URL: https://codereview.chromium.org/11048029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163503 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate duplicate COM and OLE initializations.pkasting@chromium.org2012-10-234-23/+14
| | | | | | | | | | This is take 2; the original patch ( http://crrev.com/159815 ), which only dealt with OLE, broke a few tests. The OneClickSignIn tests were skipping the RenderViewHostTestHarness SetUp() method, while the Accessibility tests directly muck with Widgets and thus have to manually init OLE. BUG=none TEST=Fewer "Multiple OleInitialize..." messages in tests Review URL: https://codereview.chromium.org/11031059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163470 0039d316-1c4b-4281-b951-d872f2087c98
* Move the bits of Prefs where production code has only trivially easyjoi@chromium.org2012-10-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | to break dependencies back to Chrome. This leaves the following in chrome/ for now, which will move later: - PrefService, to move once sync dependencies and dependencies on Chrome-specific pref stores are externalized. - PrefNotifierImpl and PrefObserverMock, to move once NotificationSource dependency is broken. - PrefValueStore, to move once PrefModelAssociatior dependency is externalized. - ScopedUserPrefUpdate, to move once PrefService moves. TBR=ben@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163354 0039d316-1c4b-4281-b951-d872f2087c98
* Using Ronald's libclang based converter, we're able to translatedalecurtis@google.com2012-10-211-10/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ffmpeg from C99 to C89 syntax and compile through MSVC++! This is awesome for many reasons: - Better performance! MSVC compiled code is as fast as some of the hand rolled assembly in certain cases (per rbultje). - Debugging symbols! (!!!) Crash dumps will now be symbolized with all symbols instead of the missing symbols traces we get in crash reports today. - No more hand rolling binaries every time ffmpeg needs a security fix or someone wants to make a change! - Greatly reduced binary size, the Chrome DLLs are ~3.2mb smaller and the Chromium DLLs ~2.3mb smaller: Chrome: 5205049 -> 1817600, Chromium: 3587185 -> 1147904. This change also cleans up the media library initialization code and gets rid of the old dll names in various places. There is still one other locations which need to be updated separately: http://src.chromium.org/viewvc/chrome/trunk/tools/build/site_config/config.py The downside is this will add ~3minutes of compile time (on T3500) for non-GOMA users and ~30 seconds for GOMA users (-j 256). More information available here: https://gerrit.chromium.org/gerrit/#/c/34728/ BUG=39887 TEST=Manual testing. Unit tests. It actually compiles! Review URL: https://codereview.chromium.org/11036039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163213 0039d316-1c4b-4281-b951-d872f2087c98
* Generate version resources for Chrome Frame using the same machinery as ↵grt@chromium.org2012-10-1713-181/+196
| | | | | | | | | | | | | | Chrome itself. Including generated files from within .rc files doesn't work since there's no dependency tracking going on. BUG=155714 TEST=none Review URL: https://chromiumcodereview.appspot.com/11147012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162494 0039d316-1c4b-4281-b951-d872f2087c98
* Configure IE 10 for the various Chrome Frame tests.grt@chromium.org2012-10-171-27/+80
| | | | | | | | | BUG=155501 TEST=none Review URL: https://chromiumcodereview.appspot.com/11149009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162416 0039d316-1c4b-4281-b951-d872f2087c98
* net: Make UploadDataStream::Read() asynchronoushashimoto@chromium.org2012-10-171-1/+1
| | | | | | | | | | | | | | Rename existing Read() to ReadSync() Change type of |buf| from char* to scoped_refptr<IOBuffer> so that async operation is always performed safely Add an asynchronous implementation, Read() The newly added Read() is not used yet, all users still use the old version ReadSync() BUG=72001 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10910268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162343 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build of mini_installer with VS2012cpu@chromium.org2012-10-171-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | BUG=143646 TEST= mini_installer (with branding=chrome) builds Here is the error: t0\src>ninja -C out\Debug mini_installer [1/9] CXX obj\chrome_frame\npchrome_frame.chrome_tab.obj FAILED: ninja -t msvc -r . -o obj\chrome_frame\npchrome_frame.chrome_tab.obj -e environment.x86 -- cl.exe ... .. microsoft visual studio 11.0\vc\atlmfc\include\atlbase.h(2845) : error C2338: 'CAtlDllModuleT<T>' must be used with either _WINDLL or _USRDLL defined ..\microsoft visual studio 11.0\vc\atlmfc\include\atlbase.h(3298) : see reference to class template instantiation 'ATL::CAtlValidateModuleConfiguration<isDllModule,T>' being compiled with [ isDllModule=true, T=`anonymous-namespace'::ChromeTabModule ] t0\src\chrome_frame\chrome_tab.cc(98) : see reference to class template instantiation 'ATL::CAtlDllModuleT<T>' being compiled with [ T=`anonymous-namespace'::ChromeTabModule ] Review URL: https://codereview.chromium.org/11189018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162291 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IE version check.grt@chromium.org2012-10-121-9/+19
| | | | | | | | | BUG=155501 TEST=none Review URL: https://codereview.chromium.org/11048053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161568 0039d316-1c4b-4281-b951-d872f2087c98
* Use ScopedCOMInitializer in more places. While this doesn't always simplify ↵pkasting@chromium.org2012-10-035-25/+43
| | | | | | | | | | code, it does mean we do consistent logging and error-checking at all these sites. BUG=none TEST=none Review URL: https://codereview.chromium.org/11050009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159908 0039d316-1c4b-4281-b951-d872f2087c98
* Miscellaneous tiny cleanups done while converting files to use ↵pkasting@chromium.org2012-10-011-7/+3
| | | | | | | | | | ScopedCOMInitializer, pulled out separately to make review easier. BUG=none TEST=none Review URL: https://codereview.chromium.org/10991052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159526 0039d316-1c4b-4281-b951-d872f2087c98
* URLRequestHttpJob::StartTransaction should honour network delegate.vabr@chromium.org2012-09-271-0/+7
| | | | | | | | | | | If a network delegate returns net::ERR_BLOCKED_BY_CLIENT inside URLRequestHttpJob::StartTransaction() the job is not cancelled. This does not happen, e.g., when ERR_BLOCKED_BY_CLIENT is returned within URLRequestHttpJob::OnStartCompleted(). This CL attempts to change the behaviour of StartTransaction() to cancel the job on the error signal from the delegate. BUG=146816 TEST=This is not testable in the browser without custom code changes yet. Review URL: https://chromiumcodereview.appspot.com/10911151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158984 0039d316-1c4b-4281-b951-d872f2087c98
* There are two blocking network delegates in url_request_unittest:vabr@chromium.org2012-09-261-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BlockingNetworkDelegate and BlockingNetworkDelegateWithManualCallback They provide various functions: * blocking in various stages of the request * three ways of responding in blocked stages: synchronous, automatic callback, and user-triggered callback * redirection But not all combinations are available (e.g. synchronous blocking after headers are sent), because the user has to chose only one of the delegates. This CL aims at allowing to combine those functions without code duplication, by joining the two classes into one. BUG=146816 TEST=N/A (this is only in unittests, also no change in behaviour of any unit-test, and no new added) Historical description for this issue, remove once the current plan stabilises: ------------------------------------------------------ Adding a base class for the blocking network delegates There are two blocking network delegates in url_request_unittest: BlockingNetworkDelegate and BlockingNetworkDelegateWithManualCallback They were independent until now, but for http://codereview.chromium.org/10911151/ BlockingNetworkDelegate needs to be able to block in various stages of the request, such as BlockingNetworkDelegateWithManualCallback does. To avoid code duplication, the common functionality is here moved to a common base class BlockingNetworkDelegateBase from which the original two inherit. This adds no new functions, nor changes it the behaviour of the current tests. ------------------------------------------------------ Review URL: https://chromiumcodereview.appspot.com/10905259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158724 0039d316-1c4b-4281-b951-d872f2087c98
* SampleSet -> HistogramSamples which can be reused by SparseHistogramkaiwang@chromium.org2012-09-221-3/+0
| | | | | | | | BUG=139612 Review URL: https://chromiumcodereview.appspot.com/10829466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158166 0039d316-1c4b-4281-b951-d872f2087c98
* net: Make UploadDataStream::Init() asynchronous.hashimoto@chromium.org2012-09-181-2/+2
| | | | | | | | | | | | | | Rename the existing synchronous version to InitSync() and add a new asynchronous version, Init(). However, the new asynchronous version is not used yet. The existing code is changed to use the synchronous version. BUG=72001 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10913179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157344 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing missed deallocation of pointer from ↵huangs@chromium.org2012-09-151-4/+3
| | | | | | | | | | | | FileVersionInfo::CreateFileVersionInfoForCurrentModule(). BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10910257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156952 0039d316-1c4b-4281-b951-d872f2087c98
* Wire up Chrome's resources to the CF net tests' ResourceBundle.grt@chromium.org2012-09-131-0/+4
| | | | | | | | | | | | The resources aren't compiled into chrome_frame_net_tests.exe, so read them out of chrome.dll (which has already been loaded, how convenient!). BUG=144649 TEST=chrome_frame_net_tests runs in debug builds again Review URL: https://chromiumcodereview.appspot.com/10911284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156621 0039d316-1c4b-4281-b951-d872f2087c98
* Try 2 - Change how ui::Clipboard is accessed so there's only one per thread.erg@chromium.org2012-09-111-8/+6
| | | | | | | | | | | | | | | Currently, there can be any number of Clipboard objects, which can be massively simplified. This removes interfaces for fetching the Clipboard and makes everyone go through a single static ui::Clipboard::GetForCurrentThread() access point. [Differences from the first patch: this may fix the pdf tests, but since I have no way to run them locally or on a trybot, this is going in blind.] BUG=130805 R=jam@chromium.org TBR=tc,ben,dcheng,kaiwang First Review URL: https://chromiumcodereview.appspot.com/10911074 Review URL: https://chromiumcodereview.appspot.com/10916214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156027 0039d316-1c4b-4281-b951-d872f2087c98
* Split user agent code out of the 'glue' targetstuartmorgan@chromium.org2012-09-104-4/+3
| | | | | | | | | | | | This creates a new user_agent component target for the user agent handling code. This makes it straightforward for iOS to build only the user-agent part of glue. It should also make incremental dismantling of webkit/ easier, since the dependencies on user agent code are now explicit. The code that was in user_agent.cc/h (the webkit_user_agent target) has been moved to user_agent_util.cc/h, and folded into the user_agent component target. All user-agent related code has been moved to a new webkit/user_agent/ directory. BUG=None Review URL: https://chromiumcodereview.appspot.com/10869073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155695 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 06:51:14 +0000