| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
set to 0x9999 in a recent CL. Correcting this
to get the IE8 builder green.
TBR=amit
Review URL: http://codereview.chromium.org/1545039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
OSes where IE can't run with differing integrities.
BUG=41572
TEST=None
Review URL: http://codereview.chromium.org/1638013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
active document is loaded. The crash occurs while dereferencing a
NULL delegate which is the case in the pending request object created by the active document to handle the initial load.
Fix for this is to maintain a pending state in the request object. We ignore all OnProgress notifications in this state. When Chrome requests
data for the top level url this state is cleared.
Consolidated the number of bind context information structures into one which contains everything we need in ChromeFrame, i.e. to decide to
switch to Chrome, indicating whether the request came from Chrome, etc.
Review URL: http://codereview.chromium.org/1654012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doing this allows us to make an determination of the
renderer type at the right time in case of the server
breaking connection unexpectedly without proper end
of data notification.
TEST=automated tests using sub_frame1.html
BUG=none
Review URL: http://codereview.chromium.org/1594031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add multi-version delegation to Chrome Frame such that CF will scan for older versions on load and delegate to them. This is to support clean upgrade scenarios whereby a new version is registered while IE is running.
BUG=40117
TEST=Register a new CF version while an old one is loaded in IE. Open a few new tabs and observe nothing bad happening.
TBR=tommi
Review URL: http://codereview.chromium.org/1585037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
test to get it to work on IE6. It appears that on IE6
we don't receive the BeforeNavigate notifications for the anchor URLs.
Review URL: http://codereview.chromium.org/1568032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome Frame such that CF will scan for older versions on load and delegate to them. This is to support clean upgrade scenarios whereby a new version is registered while IE is running.
BUG=40117
TEST=Register a new CF version while an old one is loaded in IE. Open a few new tabs and observe nothing bad happening.
Review URL: http://codereview.chromium.org/1562018
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/1604035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
older versions on load and delegate to them. This is to support clean upgrade scenarios whereby a new version is registered while IE is running.
BUG=40117
TEST=Register a new CF version while an old one is loaded in IE. Open a few new tabs and observe nothing bad happening.
Review URL: http://codereview.chromium.org/1562018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to move the chrome specific version informaton used by
Linux into src/chrome.
Add a GetChromeVersionInfo() for Linux in src/chrome/app/ and make sure to use this in src/chrome.
In src/webkit/glue, add a new glue method for getting the product version. When compiling chrome, use an implementation in src/chrome/renderer (which uses GetChromeVersionInfo()) and a stub implementation for test_shell.
Review URL: http://codereview.chromium.org/1560027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
IMoniker patch is enabled.
TBR=amit
Review URL: http://codereview.chromium.org/1575039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes things so that they now work 'naturally', i.e switch
to chrome frame looks just like switching to pdf. The same bind context
and underlying network transaction objects are used and requests aren't
sent multiple times. Finally the TestPostReissue test is happy!
This patch fixes two issues with earlier scheme:
Issue 1: data can be read only once from a given bind context. Mshtml
looks at the mime type in the FORMATETC but never issues a read. So when
it switches, the new active document can read from start. Since we are
reading the data for switching, when we actually switch, we have to
transfer over the data read so far to our UrlmonUrlRequest.
Issue 2: The very first UrlmomUrlRequest has to start binding right away,
in the context of BindToStorage or network transcations associated with
the bind context are gone (due to OnStopBinding for BindToObject).
TEST=covered by existing tests
BUG=33332
Review URL: http://codereview.chromium.org/1508033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builder. This test creates a temporary file name and feeds
the path to the SaveAs dialog put up by Chrome. If the file already existed the test fails. The other problem was that Chrome appends
the .htm extension to the path passed in which caused the subsequent GetFileAttributes expectation to fail.
Fix is to replace the .tmp extension in the temporary file name with .htm and to delete the file initially before starting the test.
This test is still marked as flaky as it expects programmatic keyboard input.
Review URL: http://codereview.chromium.org/1613015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on IE8. It appears that the OnUpdateTargetUrl
notification is not received at times on IE8.
TBR=amit
Review URL: http://codereview.chromium.org/1612015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
background thread.
Review URL: http://codereview.chromium.org/1520033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Should be no feature change but if anything this could clear up false positives where we report the status of a menu item as being enabled instead of not available.
BUG=none
Review URL: http://codereview.chromium.org/1589029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
anchor. The IsTopLevelUrl function exposed by the navigation manager
would compare the URL received in the BHO which has the anchor and the URL received from the anchor which does not have the anchor. As a result
we would not wrap the bind status callback which caused this issue.
The IsTopLevelUrl function now compares the URLs after stripping the anchor portion in the URL.
Should fix bug http://code.google.com/p/chromium/issues/detail?id=38265.
This only works if the moniker patch is enabled.
Bug=38265
Test=Covered by unit test.
Review URL: http://codereview.chromium.org/1559027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
TEST=covered by existing tests.
Review URL: http://codereview.chromium.org/1600022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Manually loading active document in IMoniker::BindToObject does
not work in IE6. The binding is not initialized and directly calling
BindToStorage on it just does not return the data.
The solution is to register ActiveDoc's CLSID as handler for 'text/html'
mime type in the bind context marked for switching. Urlmon will correctly
instantiate it them
BUG=none
TEST=covered by existing tests.
Review URL: http://codereview.chromium.org/1595021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
end of chrome frame test runs. This is to get around
extract build failures on the IE6 builder as chrome launcher does not shutdown at times.
TBR=amit
Review URL: http://codereview.chromium.org/1646001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=No code change but the version table of npchrome_frame.dll should now contain the proper company name, copyright and the last revision number.
BUG=none
Review URL: http://codereview.chromium.org/1528026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original change: http://codereview.chromium.org/1613010
Description: Fixed extra headers and message passing for post requests in NPAPIUrlRequest.
TEST=none
BUG=none
TBR=robertshield
Review URL: http://codereview.chromium.org/1549032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes for issues with new moniker patch.
BUG=none
TEST=covered by existing tests
Review URL: http://codereview.chromium.org/1625010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I have to rewrite those tests anyway.
TBR=ananta
Review URL: http://codereview.chromium.org/1626008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Step one of the changes. Inspect data and cause a switch
in the moniker patch.
Review URL: http://codereview.chromium.org/1589013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that the OnQuit notification is received correctly
on IE6.
Review URL: http://codereview.chromium.org/1574020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Unittest added.
Review URL: http://codereview.chromium.org/1611012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test expectations a bit because the OnQuit
notification does not seem to show up on IE6 for some reason. We can debug that later. The sideeffect of this would
be that the relevant tests which rely on the OnQuit notification would run for the duration of the loop.
We also needed to check in the ConnectToChromeFrame helper if we are already connected. This is for the AttachExternalTab
case where we could receive the NavigateComplete event twice.
While debugging this on my local IE6 VM I found that the calls to register/unregister chrome frame would take for ever
on the VM. This was because the ExceptionHandler would try to setup and unwind. This only works correctly for official
builds. To workaround this we launch the crash server for the duration of the test and run the chrome frame tests under
headless mode.
The FullTabModeIE_BackForwardAnchor test still fails on IE6. This is marked as FLAKY anyway. I will send out a separate CL
addressing this issue.
Review URL: http://codereview.chromium.org/1564018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(perhaps caused by http://src.chromium.org/viewvc/chrome?view=rev&revision=43953)
TBR=amit
Review URL: http://codereview.chromium.org/1525019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
context (and already fetched data) via INET_E_TERMINATED_BIND error code.
Make caching of data more sensible, so the UI does not freeze (the reason why url request have been moved to a background thread).
Always return INET_E_TERMINATED_BIND on OnDataAvailable when BSCF_LASTDATANOTIFICATION flag is detected, so if a subsequent DownloadToHost request comes from Chrome, bind context and already fetched data can be reused.
BUG=36694
Review URL: http://codereview.chromium.org/1523014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1599007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
profile path used varies across these browsers.
This changed in the recent fixes for privacy where on IE6 and IE7 the profile is in temporary internet files. The ChromeFrame
net tests assumed the profile would always be in the default path which caused the tests to not work.
Added a helper function in chrome_Frame_test_utils.cc/.h to retrieve the correct profile path based on IE version and use this.
This should get the net tests up and running on the FYI IE6 builder.
Review URL: http://codereview.chromium.org/1553015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
only runs if the moniker patch is enabled.
The moniker patch is turned off by setting its default value to PATCH_METHOD_IBROWSER.
The NavigationToRestrictedSite test is also dependent on the moniker patch for some reason. Added code to turn this test
off if this patch is disabled.
The FullTabModeIE_ReferrerTest test was incorrectly being turned off if the moniker patch was disabled. This test
does not rely on the moniker patch.
Review URL: http://codereview.chromium.org/1520021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crash occurs when the ChromeFrame active document instance is torn
down. This takes down the automation client instance which handles communication with Chrome. When the automation client instance is torn
down it tries to stop pending chrome requests which causes a crash because of an invalid url fetcher object. This could only happen if the
url fetcher object belongs to a deleted active document instance, which could occur if the automation client instance was reused during a
Reinitialize operation which failed.
Fix is to tear down the pending url requests at the top of the Reinitialize function before checking for failure cases.
Should fix bug http://code.google.com/p/chromium/issues/detail?id=40590
Bug=40590
Review URL: http://codereview.chromium.org/1524015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
not be freeing the relative pidl. It is
a pointer into the absolute pidl. Thanks to Tommi for pointing this out.
Bug=none
Review URL: http://codereview.chromium.org/1568017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amit
Review URL: http://codereview.chromium.org/1562012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
some reason on the moniker patch to be around.
Bug=40266
TBR=amit
Review URL: http://codereview.chromium.org/1568014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the fallout of the IMoniker patch.
Bug=40266
TBR=amit
Review URL: http://codereview.chromium.org/1625001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
switch to ChromeFrame, even when they don't
specify the meta tag or the HTTP header indicating the same.
Fixes bug http://code.google.com/p/chromium/issues/list?cursor=40124
Bug=40124
Review URL: http://codereview.chromium.org/1623001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
function to return the path
to the IE temporary internet files folder. The crash occurs because of dereferencing a NULL parent IShellFolder
interface. Fix is to bail out and use the SHGetFolderPath function if the SHGetFolderLocation and the SHBindToParent APIs fail for some reason. The SHGetFolderPath function has a limit of MAX_PATH characters.
Added a unit test for the GetIETemporaryFilesFolder helper function.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=40266
Bug=40266
Review URL: http://codereview.chromium.org/1523010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notification from Chrome. This crash
happens while attempting to dereference a NULL IWebBrowser2 interface pointer, which could occur if
the client site is NULL, i.e. chrome frame is in the process of being torn down.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=40174
Bug=40174
Review URL: http://codereview.chromium.org/1585014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we fail to cocreate our
active document object which was most likely unregistered. Added a check to bail here.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=40169
Bug=40169
Review URL: http://codereview.chromium.org/1564008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NULL delegate pointer
being dereferenced. It appears that there are cases where the IMoniker::BindToObject function
is called with a bind context without a registered callback. In this case we should not do anything.
Fix is to revoke our callback if we don't find a previous callback.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=40153
Bug=40153
Review URL: http://codereview.chromium.org/1589010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1527010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to cache the data received
in the OnDataAvailable notification. The crash occurs because we receive a STGMEDIUM structure indicating
that the medium type is a file and we attempt to dereference it as a stream.
Fix is to call the original delegate and bail if we receive anything but a stream.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=40152
Bug=40152
Review URL: http://codereview.chromium.org/1576014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
needs to be
updated since it currently depends on APIs that have been deprecated. The
new method for determining if CF is running in privilege mode is to verify that
the URL of the page that instantiates CF is a "chrome:" URL.
An advantage to this change is the code should now work in all version of
Firefox. Previously, the code was different for each of versions 3.0, 3.5, and
now 3.6.
Note that the API change to npapi::GetStringIdentifiers() was necessary to get
around a problem where xpcom defines the same typedefs as chrome base, but with
different types. If there is a better solution, please let me know.
TEST=see existing unit tests
BUG=none
Review URL: http://codereview.chromium.org/1535002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
override current page encoding in Chrome Frame via clicking IE's encoding menu.
Unfortunately this change does not work on IE8 since the encoding menu is off on IE8.
This change was from http://codereview.chromium.org/460036/show, which was on a temporary machine which I can not access from China now. I will re-create the patch, make some modifications according to previous reviewers' comments. now I send to you for review.
BUG=24040
TEST=none
Review URL: http://codereview.chromium.org/1530012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
between threads. This patch does this by wrapping the UploadData structure in a thread-safe container for use between threads.
BUG=39453
TEST=none
Review URL: http://codereview.chromium.org/1508012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new code was added in:
http://src.chromium.org/viewvc/chrome?view=rev&revision=42810
More tests are comming.
BUG=0
TEST=none
Review URL: http://codereview.chromium.org/1571005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1571004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43163 0039d316-1c4b-4281-b951-d872f2087c98
|