summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Committing for jeffbailey.mad@google.com2010-05-073-92/+54
| | | | | | | | | | | | | | | | | Excerpt from: http://codereview.chromium.org/1991004/show ---------------- Put version information into header file for easy consumption by RC files. RC files can use an #include to pull in this header, rather than being each dynamically generated. BUG=none TEST=none ---------------- Review URL: http://codereview.chromium.org/2020003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46736 0039d316-1c4b-4281-b951-d872f2087c98
* Cache progress notifications only if necessaryamit@chromium.org2010-05-072-8/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | We cache and suppress sending progress notifications till we get the first OnDataAvailable. This is to prevent mshtml from making up its mind about the mime type. However, this is the invasive part of the patch and could trip other software that's due to mistimed progress notifications. It is probably not good to hide redirect and some cookie notifications. We only need to suppress data notifications like BINDSTATUS_MIMETYPEAVAILABLE, BINDSTATUS_CACHEFILENAMEAVAILABLE etc. This is an atempt to reduce the exposure by starting to cache only when we receive one of the interesting progress notification. BUG=42611 TEST=none Review URL: http://codereview.chromium.org/2046003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46715 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame builder at times hang if the security dialog brought up by ↵ananta@chromium.org2010-05-071-1/+1
| | | | | | | | | | | | | | | the NavigateToRestrictedSite test is behind the console window. Fix is to not attempt to close the dialog by clicking on it. We now close the window by the DoClosewindow helper which posts the WM_CLOSE message to it. TBR=amit Review URL: http://codereview.chromium.org/2041003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46688 0039d316-1c4b-4281-b951-d872f2087c98
* Add ExceptionBarrier to module scanning in the hope of reducing some false ↵robertshield@chromium.org2010-05-071-10/+22
| | | | | | | | | | positives. BUG=43343 Review URL: http://codereview.chromium.org/2024003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46683 0039d316-1c4b-4281-b951-d872f2087c98
* Remove/update a bunch of references to the Google-internal bug tracker.evan@chromium.org2010-05-071-1/+2
| | | | | | | | | | Many of our references turn out to just be context for a given workaround, e.g. "Set the foobar here because the destructor dereferences it, see http://private-bug-url". Review URL: http://codereview.chromium.org/2004004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46645 0039d316-1c4b-4281-b951-d872f2087c98
* Opening new chrome frame tabs would fail randomly. This was because of a ↵ananta@chromium.org2010-05-071-0/+3
| | | | | | | | | | | | | | | | | | | race condition between processing the connect external tab ack in chrome frame and receiving requests for the tab. As a result the new tabs would not render anything. Fix is to resume the pending views in the OnReinitialize task in the ExternalTabContainer. I also added a NOTREACHED when we fail to find the TabProxy for a tab handle in the chrome frame automation code to help catch future instances of this issue. Fixes bug http://code.google.com/p/chromium/issues/detail?id=43376 Bug=43376 Review URL: http://codereview.chromium.org/2011006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46643 0039d316-1c4b-4281-b951-d872f2087c98
* Do not wrap the original callback if we can;t initialize sniffing cacheamit@chromium.org2010-05-053-16/+20
| | | | | | | | | | | | | | | | CreateStreamOnHGlobal may fail if the underlying GlobalAlloc fails. It has a strange behavaior where if we pass in an HGlobal, it can create more streams per process. So the fix is to: 1. not register us as a bind status callback if we cannot create a stream for sniffing data and 2. When initializing the data sniffing stream pre-create a HGlobal BUG=To be filed TEST=none Review URL: http://codereview.chromium.org/1983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46525 0039d316-1c4b-4281-b951-d872f2087c98
* Cookies would not get set correctly in ChromeFrame in full tab mode. The ↵ananta@chromium.org2010-05-054-26/+85
| | | | | | | | | | | | | | | code to set cookies in IE incorrectly parses the cookies into name value pairs. In this scenario we end up with an empty name string which causes cookies to not get set correctly. It appears that an empty name string is not treated on the same lines as NULL. In any case we should not be doing any parsing and should just set the cookie as is. This fixes bug http://code.google.com/p/chromium/issues/detail?id=42818. Added a unit test to validate this case. Bug=42818 Review URL: http://codereview.chromium.org/1917005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46523 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a chrome frame crash reported on the crash server. This occurs while ↵ananta@chromium.org2010-05-051-1/+1
| | | | | | | | | | | | | | | | | attempting to reuse an existing automation client from a cached document. It appears that there are cases where the automation client in the cached document can be NULL. Will work on a better way to cache automation client on trunk. Fixes bug http://code.google.com/p/chromium/issues/detail?id=43255 Bug=43255 Review URL: http://codereview.chromium.org/1964002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46499 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a chrome frame crash reported on the crash server. The crash occurs in ↵ananta@chromium.org2010-05-051-5/+1
| | | | | | | | | | | | | | the call to the UrlMkSetSessionOption API to refresh the user agent from the registry. This is not needed anymore as we set the user agent in the outgoing http requests anyway. This fixes bug http://code.google.com/p/chromium/issues/detail?id=43340 Bug=43340 Review URL: http://codereview.chromium.org/1968004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46498 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up suppressing error dialogs for buildbots.phajdan.jr@chromium.org2010-05-041-1/+3
| | | | | | | | | | | | - also suppress dialogs caused by __debugbreak on Windows - avoid bad interactions with gtest (they cause odd problems, really) TEST=none BUG=29997 Review URL: http://codereview.chromium.org/1867001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46343 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to fix the IE6 builder redness. Please continue debugging this and ↵ananta@chromium.org2010-05-043-163/+329
| | | | | | | | | | | | | | | | | resubmit. Revert 46188 - Not using an intermediate cache between urlmon and chrome reads. Instead we hang on to stream objects from urlmon and read from them when chrome asks for data. TEST=Run all tests verify that sites like wave and vimeo work correctly etc. BUG=none Review URL: http://codereview.chromium.org/1718025 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/1928001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46324 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to fix the IE6 builder redness. Please continue debugging this and ↵ananta@chromium.org2010-05-042-3/+4
| | | | | | | | | | | | | | | | resubmit. Revert 46189 - Temporarily disable the Head test. TBR=amit BUG=none Review URL: http://codereview.chromium.org/1828001 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/1927001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46323 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to fix the IE6 builder redness. Please continue debugging this and ↵ananta@chromium.org2010-05-042-13/+8
| | | | | | | | | | | | | | | | | resubmit. Revert 46190 - Reenable the Head test. TEST=Fixes the UrlRequest Head test BUG=none TBR=amit Review URL: http://codereview.chromium.org/1829001 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/1901002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46321 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the flakiness associated with the ChromeFrame ↵ananta@chromium.org2010-05-032-9/+28
| | | | | | | | | | | | | FullTabModeIE_TestMultipleGet and FullTabModeIE_TestPostReissue tests. These tests expect the last request received to be /quit?OK. However at times it appears that we receive an additional accept request which ends up failing this test. Fix is to add a custom function which returns the request associated with a path. Changed the expectations accordingly. Review URL: http://codereview.chromium.org/1903001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46298 0039d316-1c4b-4281-b951-d872f2087c98
* Add a delay load specifier for prntvpt.dll for chrome_frame_net_tests.ananta@chromium.org2010-05-031-0/+5
| | | | | | | | TBR=tommi Review URL: http://codereview.chromium.org/1850002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46255 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to address code review comments from tommi from CL ↵ananta@chromium.org2010-05-025-20/+7
| | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/1823001/show Changes include the following:- 1. Removing the IObjectWithSite::SetSite implementation from the chrome frame activex. 2. Removing the site_ member and using the ATL m_spUnkSite member. 3. Renaming the RegisterBHOIfNeeded member function to registerBhoIfNeeded to be consistent with the other methods in the IChromeFrame interface. Fixes bug http://code.google.com/p/chromium/issues/detail?id=42790 Bug=42790 TBR=tommi Review URL: http://codereview.chromium.org/1831001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46200 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the Head test.tommi@chromium.org2010-05-022-8/+13
| | | | | | | | | | TEST=Fixes the UrlRequest Head test BUG=none TBR=amit Review URL: http://codereview.chromium.org/1829001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46190 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable the Head test.tommi@chromium.org2010-05-022-4/+3
| | | | | | | | | TBR=amit BUG=none Review URL: http://codereview.chromium.org/1828001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46189 0039d316-1c4b-4281-b951-d872f2087c98
* Not using an intermediate cache between urlmon and chrome reads.tommi@chromium.org2010-05-023-329/+163
| | | | | | | | | | | Instead we hang on to stream objects from urlmon and read from them when chrome asks for data. TEST=Run all tests verify that sites like wave and vimeo work correctly etc. BUG=none Review URL: http://codereview.chromium.org/1718025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46188 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid reporting crashes for exceptions that hit our SEH from calls to the ↵robertshield@chromium.org2010-05-018-142/+301
| | | | | | | | | | | | original implementation of BindToStorage() when we do not wrap the bind status callback. BUG=42660 TEST=Induce exception in code called under original IMoniker::BindToStorage implementation when we don't wrap the callback and notice that no crash is reported. Review URL: http://codereview.chromium.org/1748016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46176 0039d316-1c4b-4281-b951-d872f2087c98
* Fix types that reached into WebCore and busted deps roll.slightlyoff@chromium.org2010-05-014-7/+7
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/1727021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46175 0039d316-1c4b-4281-b951-d872f2087c98
* Test for GCF install flow auto-patching.slightlyoff@chromium.org2010-05-015-5/+124
| | | | | | | | | BUG=42790 TEST=run chrome_frame_tests.exe --gtest_filter=*InstallFlow* Review URL: http://codereview.chromium.org/1727018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46172 0039d316-1c4b-4281-b951-d872f2087c98
* The chrome frame install script instantiates the chrome frame activex via ↵ananta@chromium.org2010-05-015-14/+33
| | | | | | | | | | | | | | | | the new ActiveXObject call, which causes it to not receive the IOleObject_SetClientSite call. We now bootstrap our BHO in an explicit method call RegisterBHOIfNeeded Fixes bug http://code.google.com/p/chromium/issues/detail?id=42790 Bug=42790 Review URL: http://codereview.chromium.org/1823001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46165 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing line ending which breaks the trybots..robertshield@chromium.org2010-04-301-1/+1
| | | | | | TBR=tommi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46107 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore EndRequest() for a urlmon urlrequest from Chrome, if terminate_bind ↵stoyan@chromium.org2010-04-301-0/+5
| | | | | | | | | | (i.e. DownloadInHost) request is already received. BUG=42104 Review URL: http://codereview.chromium.org/1705018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46072 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated things from net test suite:phajdan.jr@chromium.org2010-04-301-1/+5
| | | | | | | | | | | | - URLRequestTestContext (from now on use TestURLRequestContext) - TestServerPageW (use TestServerPage). TEST=none BUG=none Review URL: http://codereview.chromium.org/1814002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46044 0039d316-1c4b-4281-b951-d872f2087c98
* Fresh ChromeFrame installs triggered via wave required IE to be restarted ↵ananta@chromium.org2010-04-293-1/+68
| | | | | | | | | | | | | | | | | for wave to switch to Chrome in the current page/tab. The ChromeFrame install flow instantiates the ChromeFrame ActiveX which ensures that the IMoniker patches are in place for switching to work. However ChromeFrame relies on the BHO to be loaded in order to determine that a URL is a top level URL. The ChromeFrame ActiveX now attempts to load the BHO dynamically and registers it with the top level IWebBrowser for the page. This fixes bug http://code.google.com/p/chromium/issues/detail?id=42790 Bug=42790 Review URL: http://codereview.chromium.org/1789007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45969 0039d316-1c4b-4281-b951-d872f2087c98
* Move common code into process_util.cc.maruel@chromium.org2010-04-291-2/+2
| | | | | | | | | | | | | Fix namespace usage. Change ProcessEntry to have a common interface accross platforms and change ProcessFilter::Includes() to make use of it. Split NamedProcessIterator in two. BUG=none TEST=none Review URL: http://codereview.chromium.org/1689012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45953 0039d316-1c4b-4281-b951-d872f2087c98
* Nicely steal moniker and bind context from the urlmon url request.stoyan@chromium.org2010-04-283-19/+49
| | | | | | | BUG=42104 Review URL: http://codereview.chromium.org/1811001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45860 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup regarding Siggi's comments on ↵robertshield@chromium.org2010-04-285-7/+370
| | | | | | | | | | | | http://codereview.chromium.org/1733021/show BUG=42660 TEST=none Review URL: http://codereview.chromium.org/1703015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45859 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ChromeFrame crash reported on the crash server while processing an ↵ananta@chromium.org2010-04-281-3/+8
| | | | | | | | | | | | | | | | accelerator message. The crash happens while invoking the IBrowserService2::v_MayTranslateAccelerator function. It appears from the dump that there are cases in IE8 where this interface is actually implemented, but this function entry is NULL in the vtable. In any case from the comments in the code this interface is only implemented till IE7. Fixes bug http://code.google.com/p/chromium/issues/detail?id=25457 Bug=25457 Review URL: http://codereview.chromium.org/1718019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45831 0039d316-1c4b-4281-b951-d872f2087c98
* Add an ExceptionBarrier around outbound calls to patched methods in IE. In ↵robertshield@chromium.org2010-04-288-14/+276
| | | | | | | | | | | | so doing, we have an SEH present in the SEH chain and so the VEH won't erroneously report crashes that occur in other modules when we happen to be on the stack. BUG=42660 TEST=Less false positives in the crash reports. Review URL: http://codereview.chromium.org/1733021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45764 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a chrome frame crasher reported on the crash server. It occurs while ↵ananta@chromium.org2010-04-271-4/+14
| | | | | | | | | | | | | | processing a call to SetPositionCookie while dereferencing a NULL automation client pointer. Fixes bug http://code.google.com/p/chromium/issues/detail?id=42598 Bug=42598 Review URL: http://codereview.chromium.org/1763011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45646 0039d316-1c4b-4281-b951-d872f2087c98
* Some more chrome frame test pure virtual function call crash fixes. There is ↵ananta@chromium.org2010-04-263-2/+15
| | | | | | | | | | | | | | | | | | another crash which occurs when the remote COM apartment running in Ie shuts down and tries to free references to the web browser event sink. We unsubscribe from the event sink in the destructor of the ComStackObjectWithUninitialize object. The call to DispEventUnadvise fails every time. Unsubscribing and call CoDisconnectObject to release the server side stub references in the OnQuit notification fixes the crash. To aid debugging this issue in the future we now override the purecall handler in chrome frame tests. Bug=41980 TBR=amit Review URL: http://codereview.chromium.org/1695015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45569 0039d316-1c4b-4281-b951-d872f2087c98
* More chrome frame test crash fixes. At times we fail to create the HTTP ↵ananta@chromium.org2010-04-241-2/+7
| | | | | | | | | | | | | server and end up crashing while dereferencing a NULL server pointer. Added expectations and checks to handle this gracefully. Bug=41980 TBR=amit Review URL: http://codereview.chromium.org/1706011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45526 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the flakiness with the ChromeFrame FullTabModeIE_KeyboardTest ↵ananta@chromium.org2010-04-233-6/+11
| | | | | | | | | | and the FullTabModeIE_WindowOpenInChrome test. We need to set focus to the Chrome renderer window. Review URL: http://codereview.chromium.org/1736014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45515 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing fixes for chrome frame test pure virtual function call crashes. ↵ananta@chromium.org2010-04-232-5/+10
| | | | | | | | | | | | | | | One of these fixes is in the ChromeFrame ActiveX where we were invoking the onload/onmessage handlers on a NULL interface pointer. The other fix is in the chrome frame test code where we need to protect against reentrancy while in the context of an outgoing COM interface call. Fixes http://code.google.com/p/chromium/issues/detail?id=41980 Bug=41980 Review URL: http://codereview.chromium.org/1691012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45481 0039d316-1c4b-4281-b951-d872f2087c98
* Check if the url is a top level url before clearing the referrer header.tommi@chromium.org2010-04-232-16/+16
| | | | | | | | | TEST=n/a BUG=none Review URL: http://codereview.chromium.org/1745007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45391 0039d316-1c4b-4281-b951-d872f2087c98
* Continuing attempt to fix chrome frame tests crashes. Moving the ↵ananta@chromium.org2010-04-231-4/+4
| | | | | | | | | | | | ComObjectstackEx instances which handle new IE windows to before the message loop to ensure that they remain valid when the message loop is destroyed. Bug=41980 Review URL: http://codereview.chromium.org/1761005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45387 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt to fix the pure virtual function call crash in chrome frame ↵ananta@chromium.org2010-04-221-25/+25
| | | | | | | | | | | | | | | | | tests. This crash happens because the timed message loop object attempts to destroy pending tasks, which point to a deleted CComObjectStackEx instance in its destructor. Fix is to ensure that the CComObjectStackEx instance which holds chrome frame mocks outlives the message loop. Fixes http://code.google.com/p/chromium/issues/detail?id=41980 Bug=41980 TBR=stoyan Review URL: http://codereview.chromium.org/1772001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45342 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Factor out reading and writing of preferences into |PrefStore|."bauerb@chromium.org2010-04-221-1/+2
| | | | | | | | | | | | | | | | | | | The CL now applies after r45225 (Throw out preferences files that are corrupt rather than keeping them in read-only mode), which means that the changes in that commit moved to JsonPrefStore. I updated JsonPrefStoreTest.InvalidFile to test the new behavior. *** In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests. Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|. BUG=40259 TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.* Review URL: http://codereview.chromium.org/1717007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45309 0039d316-1c4b-4281-b951-d872f2087c98
* The HttpNegotiateTest.ReportProgress test fails on IE6 as we fail to ↵ananta@chromium.org2010-04-224-5/+45
| | | | | | | | | | retrieve the IBrowserService interface. Disabling this test for IE6 for now. Review URL: http://codereview.chromium.org/1731003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45277 0039d316-1c4b-4281-b951-d872f2087c98
* Attempting to fix the pure virtual function call crash in chrome frame test ↵ananta@chromium.org2010-04-211-3/+16
| | | | | | | | | | | | | | | | runs. It appears to be caused by a race condition during disconnecting from chrome frame and receiving a callback from IE (Chrome Frame). Added checks to detect and work around this issue. Should fix http://code.google.com/p/chromium/issues/detail?id=41980 Bug=41980 Review URL: http://codereview.chromium.org/1703003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45233 0039d316-1c4b-4281-b951-d872f2087c98
* Only switch to cf for text/html. With opt-in URLs we could mark a URL to be ↵tommi@chromium.org2010-04-2110-44/+242
| | | | | | | | | | | loaded in CF regardless of the target mime type. If CF turns around and wants to download the target, we would hit an infinite loop. TEST=Verify that issue 40046 is resolved. OptIn urls should work with the moniker patch and downloads should not cause an infinite loop. BUG=40046 Review URL: http://codereview.chromium.org/1715004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45226 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45168 - Reland r45028: Factor out reading and writing of preferences ↵erikkay@chromium.org2010-04-211-2/+1
| | | | | | | | | | | | | | | | | | into |PrefStore|. In order to implement platformspecific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests. Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|. BUG=40259 TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.* Review URL: http://codereview.chromium.org/1687001 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/1688004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45200 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r45028: Factor out reading and writing of preferences into |PrefStore|.bauerb@chromium.org2010-04-211-1/+2
| | | | | | | | | | | | | In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests. Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|. BUG=40259 TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.* Review URL: http://codereview.chromium.org/1687001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45168 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame with the moniker patch enabled we should not process optin ↵ananta@chromium.org2010-04-205-16/+25
| | | | | | | | | | | | urls in the BHO. Fixes bug http://code.google.com/p/chromium/issues/detail?id=42155 Bug=42155 Review URL: http://codereview.chromium.org/1706003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45117 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame with the IMoniker patch on, we should save away the redirect ↵ananta@chromium.org2010-04-204-19/+55
| | | | | | | | | | | | | | | | information received for the initial pending request. This is to ensure that we inform Chrome about this redirect which can then be followed correctly from Chrome. The other change is to save away the URL being navigated to in the bind context context object. This is also updated if we receive a redirect notification in our callback wrapper. The active document refers this URL if it is available and falls back to the old mechanism of retrieving the URL from the moniker if not. This ensures that optin urls continue to work correctly if the initial page is redirected. Review URL: http://codereview.chromium.org/1523028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45114 0039d316-1c4b-4281-b951-d872f2087c98
* Handle cookie requests in BackgroundThread.stoyan@chromium.org2010-04-203-2/+6
| | | | | | | | | Enable the unload event test. BUG=40814 TEST=unload event test Review URL: http://codereview.chromium.org/1629027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45042 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 00:42:23 +0000