summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Re-enables CFInstance RPC tests for Firefox that were previously timing out ↵slightlyoff@chromium.org2010-01-292-4/+2
| | | | | | | | | | | | | due to insufficient windows for allowing plugin startup. We now assume that startup/loading will succeed in 5 seconds (reasonable for a debug build or slow bots) and that we should wait no longer than 1 seconds to send the ack messages. This puts us well inside the 10s initialization window of CFInstall.js, upped from a previous 1s window in: http://codereview.chromium.org/464077 BUG=24100 TEST=chrome_frame_tests.exe --gtest_filter=*WidgetModeFF_CFInstanceRPCInternal* Review URL: http://codereview.chromium.org/551199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37550 0039d316-1c4b-4281-b951-d872f2087c98
* Window.open calls issued by pages within ChromeFrame which use the ↵ananta@chromium.org2010-01-285-17/+41
| | | | | | | | | | | | | | | | | | | NEW_WINDOW/NEW_POPUP dispositions open up as regular Chrome windows, which results in them not using the host network stack, which means that HTTP sessions/cookies, etc established by the main page will not work for the popup. Fix is to ensure that these dispositions also get routed back to the host browser where a new tab would be created which would attach itself to the newly created ExternalTabContainer instance. Fixes bug http://code.google.com/p/chromium/issues/detail?id=33324 Bug=33324 Test=Covered by ChromeFrame unit test. Review URL: http://codereview.chromium.org/549183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37425 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up dangling changes: remove dead code in fake_external_tab.cc.robertshield@chromium.org2010-01-271-51/+0
| | | | | | Review URL: http://codereview.chromium.org/553118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37269 0039d316-1c4b-4281-b951-d872f2087c98
* Unload and BeforeUnload handlers would not get invoked within pages inside ↵ananta@chromium.org2010-01-273-0/+133
| | | | | | | | | | | | | | | | | | | | | | | | ChromeFrame. This was because the ExternalTabContainer would close the underlying tab contents in its OnDestroy handler without invoking unload handlers on the page if any. In Chrome the TabStripModel invokes the RunUnloadListenerBeforeClosing on the delegate which is implemented by the browser. We need to mimic this in the external tab container. To achieve this we now have a static helper function RunUnloadListenerBeforeClosingHelper in the browser class which is called by the ExternalTabContainer and the Browser::RunUnloadListenerBeforeClosing function. The ExternalTabContainer also needs to wait for the unload handlers on the page to return before it returns control back to the host browser. To achieve this we enter a nested modal loop which is exited when the underlying tab is closed. Fixes bug http://code.google.com/p/chromium/issues/detail?id=31853 Bug=31853 Test=Covered by ChromeFrame unit test. Review URL: http://codereview.chromium.org/543183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37197 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid a DCHECK. Check if the interface is already patched before patching.tommi@chromium.org2010-01-251-2/+4
| | | | | | | | | | TEST=This avoids a DCHECK that could happen when viewing the source of an html page. BUG=none TBR=robertshield Review URL: http://codereview.chromium.org/553073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37044 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for an issue we were seeing with wave.tommi@chromium.org2010-01-231-12/+14
| | | | | | | | | | | | | | | After switching over to using the onhttpequiv notification from mshtml we can expect to see sub frames being created even before the owning document has completed loading. In particular frames whose source is about:blank. TEST=Google Wave should work. BUG=32904 Review URL: http://codereview.chromium.org/543180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36945 0039d316-1c4b-4281-b951-d872f2087c98
* Disable incremental linking for chrome_frame_net_tests and ↵maruel@chromium.org2010-01-221-2/+20
| | | | | | | | | | | | chrome_frame_unittests on 32 bits OS. Chromium XP Wine Valgrind Builder wasn't able to link these binaries anymore. TEST=links BUG=none Review URL: http://codereview.chromium.org/548115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36909 0039d316-1c4b-4281-b951-d872f2087c98
* Include the full version number in the user agent.tommi@chromium.org2010-01-222-17/+19
| | | | | | | | | TEST=Run unit tests. This change will make the request user agent have a more detailed version number for chrome frame (chromeframe/a.b.c.d instead of chromeframe/a.b) BUG=29258 Review URL: http://codereview.chromium.org/546117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36898 0039d316-1c4b-4281-b951-d872f2087c98
* Implement OptInUrls using the same mechanism we use in the onhttpequiv ↵tommi@chromium.org2010-01-223-20/+11
| | | | | | | | | | | | | notification. A noteworthy change here is that OptInUrls doesn't rely on cf: anymore. TEST=The OptInUrls registry key should start working properly again. BUG=32660 Review URL: http://codereview.chromium.org/549129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36874 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for FullTabModeIE_ChromeFrameDeleteCookieTest and issues with deleting ↵tommi@chromium.org2010-01-222-3/+21
| | | | | | | | | | | persistent cookies as reported in bug 30786. TEST=Run FullTabModeIE_ChromeFrameDeleteCookieTest. BUG=32546,30786 Review URL: http://codereview.chromium.org/551101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36831 0039d316-1c4b-4281-b951-d872f2087c98
* If we navigate to a URL which has an anchor in IE, which eventually ends up ↵ananta@chromium.org2010-01-228-13/+115
| | | | | | | | | | | | | | | | | | | | | in ChromeFrame, the actual URL queried from the moniker passed in to our implementation of IPersistStream::Load does not have the anchor. It looks like there are some private interfaces exposed by MSHTML and invoked by IEFrame to pass this information over. Our fix is to save away the url received in our Bho BeforeNavigate2 notification and use this URL if available before querying the moniker for the URL. This needs to be done in IPersistStream::Load and in the OnHttpEquiv patch when we initiate a navigation to the actual URL using the moniker. Fixes bug http://code.google.com/p/chromium/issues/detail?id=27270 Bug=27270 Test=Covered by unit test. Review URL: http://codereview.chromium.org/542096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36814 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disabling FullTabModeIE_ChromeFrameDeleteCookieTest while I ↵tommi@chromium.org2010-01-211-1/+3
| | | | | | | | | | | figure out why it's failing on the builder. TEST=n/a BUG=none TBR=ananta git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36752 0039d316-1c4b-4281-b951-d872f2087c98
* Add integration tests for validating the X-UA-Compatible HTTP header code in ↵robertshield@chromium.org2010-01-2110-2/+192
| | | | | | | | | | | Chrome Frame. BUG=22802 TEST=None Review URL: http://codereview.chromium.org/555010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36751 0039d316-1c4b-4281-b951-d872f2087c98
* Fix FullTabModeIE_ChromeFrameDeleteCookieTest. The problem was that a ↵tommi@chromium.org2010-01-214-15/+16
| | | | | | | | | | | | | | | domain cookie was being set twice although only set once by the server. The test itself needed fixing as well as an extra check for domain cookies set by a different url than the current url. There's one other problem remaining however which was initially reported in bug 30786 and I'll get on that next (bug reopened). TEST=Run the FullTabModeIE_ChromeFrameDeleteCookieTest test. BUG=32546, 30786 Review URL: http://codereview.chromium.org/546104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36749 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for back/forward issue with httpequiv patch.tommi@chromium.org2010-01-203-20/+124
| | | | | | | | | | | | After reissuing a cf navigation we now remove the previous entry from the travellog to preserve the correct navigation history. Also updating the BackForward unit tests to expect two pairs of BeforeNavigate/NavigateComplete notification when we transition from IE to CF. TEST=Run *BackForward* unit tests BUG=32550 Review URL: http://codereview.chromium.org/549092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36594 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a secondary mini_installer target for Chrome Frame. This will remove ↵robertshield@chromium.org2010-01-192-32/+2
| | | | | | | | | | | | | | the need to have different build scripts to build either Chrome or Chrome Frame. Also remove the now-unneeded gyp variables 'chrome_frame_define' and 'google_update_appid'. BUG=Both Chrome and Chrome Frame products should be buildable from a single solution file - we shouldn't need to run GYP with different settings to get a CF solution. TEST=none Review URL: http://codereview.chromium.org/542078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36546 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling the onhttpequiv detection and temporarily disabling a few tests ↵tommi@chromium.org2010-01-192-5/+15
| | | | | | | | | | | that will fail for a day or two while we adapt. TEST=Run all unit tests. BUG=none Review URL: http://codereview.chromium.org/552038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36507 0039d316-1c4b-4281-b951-d872f2087c98
* Updates for onhttpequiv. Preserving the referrer header, zapping the ↵tommi@chromium.org2010-01-165-16/+102
| | | | | | | | | | | | | currently loading document to prevent small documents from executing code. I'm not enabling httpequiv just yet as there are a couple of things I'm working on related to tests that will break once I make the switch. TEST=There should be no change since the code isn't still active but run all tests just to be safe. BUG=none Review URL: http://codereview.chromium.org/545096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36436 0039d316-1c4b-4281-b951-d872f2087c98
* Changing DLOG to LOG for tests so that we'll get the errors in the test run ↵tommi@chromium.org2010-01-152-16/+21
| | | | | | | | | | | logs. TEST=n/a BUG=none Review URL: http://codereview.chromium.org/552018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36420 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress crash dump generation due to IsBadXXX functions.amit@chromium.org2010-01-156-44/+127
| | | | | | | | | | | | | IsBad[Read/Write]Ptr etc functions cause access violations which we catch and take crash dump if we are on stack. Adding code to suppress these false positives. BUG=none TEST=added new tests cases to ChromeFrame.ExceptionReport Review URL: http://codereview.chromium.org/536073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36403 0039d316-1c4b-4281-b951-d872f2087c98
* Mark WidgetModeIE_CFInstancefrPost and WidgetModeIE_PriviligedApis as flakyjshin@chromium.org2010-01-151-2/+4
| | | | | | | | BUG=32321 TBR=ananta Review URL: http://codereview.chromium.org/543071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36317 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome_frame build by updating build files.phajdan.jr@chromium.org2010-01-132-7/+0
| | | | | | | | | BUG=10840 TBR=maruel Review URL: http://codereview.chromium.org/536044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36120 0039d316-1c4b-4281-b951-d872f2087c98
* Make running chrome process detection in ui tests more reliable.phajdan.jr@chromium.org2010-01-131-24/+7
| | | | | | | | | | | Also drops fragile code. TEST=Covered by ui_tests. BUG=10840 Review URL: http://codereview.chromium.org/545006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36119 0039d316-1c4b-4281-b951-d872f2087c98
* Flick the switch back to PATCH_PROTOCOL while sorting out a few failing unit ↵tommi@chromium.org2010-01-121-1/+1
| | | | | | | | | tests on the builder. TBR=robertshield git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36010 0039d316-1c4b-4281-b951-d872f2087c98
* Querying for one more interface to handle IE8 on XP case. This is what we ↵tommi@chromium.org2010-01-123-39/+32
| | | | | | | | | | | | were hitting on the builder. R=ananta BUG=none TEST=Run all unit tests. This is a second attempt to switch to onhttpequiv. Review URL: http://codereview.chromium.org/543017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36009 0039d316-1c4b-4281-b951-d872f2087c98
* Support the PUT HTTP verb in ChromeFrame in the IE host network stack ↵ananta@chromium.org2010-01-111-10/+20
| | | | | | | | | | | | | | | | | | implementation. This verb is supported in the Chrome network stack. Added a urlrequest test for the HTTP PUT verb and corresponding support in the HTTP test server. Fixes bug http://code.google.com/p/chromium/issues/detail?id=31629 Bug=31629 Test=Covered by net tests. Review URL: http://codereview.chromium.org/538012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35922 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the following tests as flaky.ananta@chromium.org2010-01-081-2/+6
| | | | | | | | | | | | 1. FullTabModeIE_ChromeFrameKeyboardTest 2. FullTabModeIE_BackForwardAnchor Bug=26549 TBR=amit Review URL: http://codereview.chromium.org/533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35849 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome frame net tests that were failing on some machines. Checking in ↵tommi@chromium.org2010-01-081-1/+7
| | | | | | | | | | | straight away as per Robert's request. TEST=run the net tests for chrome frame. BUG=none TBR=robertshield Review URL: http://codereview.chromium.org/527034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35794 0039d316-1c4b-4281-b951-d872f2087c98
* Correct Chrome Frame dependencies such that a) CF tests depend on the CF DLL ↵robertshield@chromium.org2010-01-081-6/+3
| | | | | | | | | | | b) all.gyp:chromium_builder will build CF stuff. BUG=CF dll and chrome_launcher.exe were not getting built on the chromium-rel builder. TEST=No more BUG. Review URL: http://codereview.chromium.org/517065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35788 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing this.ananta@chromium.org2010-01-089-166/+311
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame with the host network stack enabled. When we receive a response in the host browser (IE) we send over the response headers which include the Set-Cookie header and a list of cookies retreived via the InternetGetCookie API. We call this API to retrieve the persistent cookies and send them over to Chrome. However this API returns session cookies as well as persistent cookies. There is no documented way to return only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused this issu.e. To workaround this issue when we receive the response in the url request automation job which handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie. When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well. Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786 The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they conflict with similar functions in NACL. Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight. Bug=30786 Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added URLRequestAutomationJob::IsCookiePresentInCookieHeader function TBR=amit Review URL: http://codereview.chromium.org/521072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35778 0039d316-1c4b-4281-b951-d872f2087c98
* Reason:tyoshino@chromium.org2010-01-089-311/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Linux Builder (ChromiumOS) failed. http://chrome-buildbot.corp.google.com:8010/builders/Linux%20Builder%20(ChromiumOS)/builds/2050/steps/compile/logs/stdio Please add changes to external_cookie_handler_unittest.cc no to break compilation and reland? ---- Revert 35769 - Deleting cookies by setting the expires attribute on them with an empty value would not work in ChromeFrame with the host network stack enabled. When we receive a response in the host browser (IE) we send over the response headers which include the SetCookie header and a list of cookies retreived via the InternetGetCookie API. We call this API to retrieve the persistent cookies and send them over to Chrome. However this API returns session cookies as well as persistent cookies. There is no documented way to return only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused this issu.e. To workaround this issue when we receive the response in the url request automation job which handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie. When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well. Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786 The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they conflict with similar functions in NACL. Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight. Bug=30786 Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added URLRequestAutomationJob::IsCookiePresentInCookieHeader function Review URL: http://codereview.chromium.org/518054 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/517070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35771 0039d316-1c4b-4281-b951-d872f2087c98
* Deleting cookies by setting the expires attribute on them with an empty ↵ananta@chromium.org2010-01-089-166/+311
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | value would not work in ChromeFrame with the host network stack enabled. When we receive a response in the host browser (IE) we send over the response headers which include the Set-Cookie header and a list of cookies retreived via the InternetGetCookie API. We call this API to retrieve the persistent cookies and send them over to Chrome. However this API returns session cookies as well as persistent cookies. There is no documented way to return only persistent cookies from IE. As a result we would end up setting duplicate cookies in Chrome, which caused this issu.e. To workaround this issue when we receive the response in the url request automation job which handles ChromeFrame network requests, we strip out duplicate cookies sent via InternetGetCookie. When a script deletes a cookie we now handle it correctly in IE and set the data to an empty string. However this does not delete the cookie. When such cookies show up in Chrome, we strip them out as well. Fixes bug http://code.google.com/p/chromium/issues/detail?id=30786 The changes to chrome_frame_npapi.cc/.h are to move the NPAPI functions to the chrome_frame namespace as they conflict with similar functions in NACL. Added the DeleteCookie function to the CookieStore interface, which I think missed out by oversight. Bug=30786 Test=Covered by ChromeFrame unit tests. I also added a unit test to test the newly added URLRequestAutomationJob::IsCookiePresentInCookieHeader function Review URL: http://codereview.chromium.org/518054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35769 0039d316-1c4b-4281-b951-d872f2087c98
* Histograms sent out to Chrome need to have the kIPCSerializationSourceFlag ↵ananta@chromium.org2010-01-071-0/+1
| | | | | | | | | | flag set. Not having this flag causes a DCHECK to fire. Review URL: http://codereview.chromium.org/519077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35739 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting back to patching the protocol handlers to get the builder green again.ananta@chromium.org2010-01-071-1/+1
| | | | | | | | TBR=tommi Review URL: http://codereview.chromium.org/527020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35724 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the HTTP Equiv patch by default and disable the InternetProtocol patches.tommi@chromium.org2010-01-071-1/+1
| | | | | | | | | TEST=Run all unit tests. BUG=none Review URL: http://codereview.chromium.org/519070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35705 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a ChromeFrame crasher reported by go/crash. The crash ↵ananta@chromium.org2010-01-052-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | occurs while tearing down the ChromeFrameAutomationClient instance, which only gets called from the destructor of the ChromeFramePlugin class which is a base class of the ChromeFrame ActiveX. When this executes the worker thread which is used for handling urlmon requests has been destroyed. The crash occurs in the UrlmonUrlRequest::Stop function while posting a task back to an invalid message loop. We already clean up the requests in the WM_DESTROY handler, meaning that there seems to be a scenario where we don't receive a WM_DESTROY. It is unclear what that is. The fix is to call Uninitialize on the ChromeFramePlugin object in the destructor of the ActiveX which ensures that it executes while the thread is still valid. Added checks for the message loop in the relevant functions in the UrlmonUrlRequest class. Fixes bug http://code.google.com/p/chromium/issues/detail?id=31557 Bug=31557 Review URL: http://codereview.chromium.org/518034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35561 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the WidgetModeFF_CFInstanceSingleton ChromeFrame test to the list of ↵ananta@chromium.org2010-01-051-1/+3
| | | | | | | | | | | flaky tests. TBR=amit Bug=31532 Review URL: http://codereview.chromium.org/524035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35544 0039d316-1c4b-4281-b951-d872f2087c98
* Some Chrome Frame cleanup:robertshield@chromium.org2010-01-0520-257/+173
| | | | | | | | | | | | | | | | | | 1) Rearrange the chrome_frame.gyp file to: a) Split out most of CF into a static lib to make writing unit tests easier (not having to re-include source files). b) Remove most of the un-needed xulrunner-sdk includes. 2) Move all OBJECT_ENTRY_AUTO macros to chrome_tab.cc since they don't work without extra work when residing in a lib. 3) Rename npchrome_tab.dll to npchrome_frame.dll. BUG=none TEST=none Review URL: http://codereview.chromium.org/523040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35543 0039d316-1c4b-4281-b951-d872f2087c98
* Marking the WidgetModeFF_CFInstanceRPC and WidgetModeFF_CFInstancePost tests ↵ananta@chromium.org2010-01-041-2/+6
| | | | | | | | | | | as flaky. Bug=31532 TBR=amit Review URL: http://codereview.chromium.org/525007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35468 0039d316-1c4b-4281-b951-d872f2087c98
* Links opened in ChromeFrame via the Open in New window operation would not ↵ananta@chromium.org2010-01-042-4/+237
| | | | | | | | | | | | | | | | | | | | | render if the target also was rendered in ChromeFrame. This was because we were not marshaling the IMoniker and IBindCtx interfaces over to the ChromeFrame worker thread. The problem would only occur when we reused the existing IMoniker. Fixes bug http://code.google.com/p/chromium/issues/detail?id=30013 We need to post the OnWorkerStop message after we finish stopping the urlmon request object to prevent a race condition. We also need to pump messages in OnDestroy to ensure that CoUninitialize and calls like IBinding::Abort which callback into this thread complete correctly. Bug=30013 Review URL: http://codereview.chromium.org/523018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35466 0039d316-1c4b-4281-b951-d872f2087c98
* The function to check whether the page is running in Chrome was incorrectly ↵ananta@chromium.org2010-01-021-0/+3
| | | | | | | | | | | | | | | | | flagging pages running in IE as running in Chrome. This was because the function was checking for the presence of the string chrome in the user agent. In ChromeFrame with host networking enabled the IE user agent contains the string chromeframe, which causes this function to fail. This caused the chromeframe unit tests to fail randomly on my machine. TBR=slightlyoff Review URL: http://codereview.chromium.org/519027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35439 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the URLRequestTestHTTP.GetTest_NoCache test for ChromeFrame as ↵ananta@chromium.org2009-12-301-0/+4
| | | | | | | | | | | | this has been consistently failing on the chrome frame builder. TBR=tommi Review URL: http://codereview.chromium.org/515071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35395 0039d316-1c4b-4281-b951-d872f2087c98
* Authorization headers set using XHR with ChromeFrame were stripped in the ↵ananta@chromium.org2009-12-283-1/+70
| | | | | | | | | | | | | | | | | | | outgoing HTTP requests sent via the host network stack. Fix is to remove the authorization header from the list of filtered headers. Added a unit test for this. Fixes bug http://code.google.com/p/chromium/issues/detail?id=23103 Bug=23103 Test=Covered by unit test. Review URL: http://codereview.chromium.org/519013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35319 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a ChromeFrame crash in IE full tab mode. The crash ↵ananta@chromium.org2009-12-282-3/+6
| | | | | | | | | | | | | | | | | | occurs while processing an accelerator message and based on the callstack it looks like QueryService call for the SID_STopLevelBrowser interface returns S_OK with a NULL interface pointer. Added checks in the DoQueryService helper function to return a failure if the QueryService call returns a NULL service pointer. Fixes http://code.google.com/p/chromium/issues/detail?id=25457 Bug=25457 Review URL: http://codereview.chromium.org/523008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35315 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable the HTML renderer type detection in our ↵ananta@chromium.org2009-12-231-2/+0
| | | | | | | | | | | | IInternerProtocolSink::ReportProgress implementation as this causes the chrome frame tests to break. TBR=stoyan Review URL: http://codereview.chromium.org/515022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35244 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame net tests broken by the change to determine the renderer ↵ananta@chromium.org2009-12-232-1/+15
| | | | | | | | | | | | | | | | | type in our IInternetProtocolSink::ReportProgress implementation. To determine the renderer type we try to read the data from the IInternetProtocol interface which in turn tries to determine the renderer type. Fix is to check if we are in the context of determining the renderer and bail. TBR=stoyan Bug=31031 Review URL: http://codereview.chromium.org/518012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35234 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame in IE full tab mode would not render pages if Adblock Pro was ↵ananta@chromium.org2009-12-232-29/+58
| | | | | | | | | | | | | | | | | | | | | installed on the machine. Based on my debugging it looks like AdBlock gets confused because we report the mime type initally as text/html and then swich to application/chromepage. Fix is to attempt to determine the mime type in our IInternetProtocolSink::ReportProgress implementation. If we fail we continue to determine the mime type in IInternetProtocolSink::ReportData. Added a helper function CheckAndReportChromeMimeTypeForRequest which is invoked from both places. Fixes http://code.google.com/p/chromium/issues/detail?id=31031 Bug=31031 Review URL: http://codereview.chromium.org/501181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35227 0039d316-1c4b-4281-b951-d872f2087c98
* Enable UMA data upload in ChromeFramejar@chromium.org2009-12-231-6/+0
| | | | | | | | BUG=30508 r=ananta Review URL: http://codereview.chromium.org/502019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35223 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-221-1/+1
| | | | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35012 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35129 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame unit tests which use gmock exit with unexpected mock calls ↵ananta@chromium.org2009-12-212-4/+10
| | | | | | | | | | | | | warnings, which seem to be harmless at this point. Updated the relevant tests to expect these calls and ignore them. The changes to chrome_frame_automation_mock.cc are based on the review comments to the previous CL from phajdan. Review URL: http://codereview.chromium.org/504078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35115 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 20:49:36 +0000