summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Add a call to SetLastError before calling SetClassLongPtr. It turns out that ↵robertshield@chromium.org2010-05-261-0/+2
| | | | | | | | | | | | SetClasSLongPtr doesn't reset the error code on success and yet said code must be used to check for failure. BUG=45041 TEST=none Review URL: http://codereview.chromium.org/2229003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48277 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame there are cases when the ↵ananta@chromium.org2010-05-261-5/+7
| | | | | | | | | | | ChromeFrameAutomationProxy::SendAsAsync function can be passed a NULL callback. The dispatcher needs to check for the same and ignore the returned callback message. We currently crash on trunk. Review URL: http://codereview.chromium.org/2227001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48256 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Another dependency the bbot missed!!!"rafaelw@chromium.org2010-05-2611-37/+36
| | | | | | | | | | | | | | | | | | This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98. Revert "Missed a file as part of checkin for r48186" This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b. Revert "Enable warning 4389 as an error on windows builds. This will make" This reverts commit c78936bcfc65b98edf288191d927a495b0364621. TBR=mbelshe Review URL: http://codereview.chromium.org/2253001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling the ChromeFrame unload event test which validates that unload ↵ananta@chromium.org2010-05-253-6/+4
| | | | | | | | | | | | | | | handlers on the page are invoked correctly. To flag success or failure we now set the state in the localStorage object instead of setting this via cookies as the cookies are set in IE on the UI thread causing this test to fail. Fixes bug http://code.google.com/p/chromium/issues/detail?id=40814 Bug=40814 Review URL: http://codereview.chromium.org/2215001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48218 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will makembelshe@chromium.org2010-05-2511-36/+37
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
* Another try at correcting VTable pointer checkamit@chromium.org2010-05-251-1/+1
| | | | | | | | | BUG==25457 Review URL: http://codereview.chromium.org/2152004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48177 0039d316-1c4b-4281-b951-d872f2087c98
* Tear off windows opened in ChromeFrame in IE6 would result in the new window ↵ananta@chromium.org2010-05-251-1/+0
| | | | | | | | | | | | | | | | | being minimized by default. This was because of a call to IWebBrowser2::put_visible after initiating the navigation. The put_visible call eventually calls SetForegroundWindow setting focus back to the current document thus causing focus to switch away from the new window. Fix is to remove call to put_visible. Fixes bug http://b/issue?id=2692416 Bug=2692416 Review URL: http://codereview.chromium.org/2153006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48167 0039d316-1c4b-4281-b951-d872f2087c98
* Break gyp cycles on Linux.tony@chromium.org2010-05-241-9/+8
| | | | | | | | | | The cycle is between installer.gyp and chrome.gyp. The fix is to switch installer.gyp into installer.gypi and include it into chrome.gyp BUG=35308 Review URL: http://codereview.chromium.org/2067018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48007 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame in the IInternetProtocolRoot::ReportProgress patch use the ↵ananta@chromium.org2010-05-212-19/+15
| | | | | | | | | | | | | | | | | | | exception barrier version which only reports crashes in ChromeFrame while calling the original function. We also use the other version of the ExceptionBarrier when we switch the mime type from text/html. This is to prevent the vectored exception handler from handling this exception and reporting a false positive if any stack based exception handler actually handles this exception. The other change is to remove the IHttpNegotiate::OnResponse patch as it did not do anything useful and some crashes were being reported while invoking the original function. Fixes bugs http://code.google.com/p/chromium/issues/detail?id=44767 and http://code.google.com/p/chromium/issues/detail?id=44765 Bug=44767,44765 Review URL: http://codereview.chromium.org/2078030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47957 0039d316-1c4b-4281-b951-d872f2087c98
* Removed dependency on ChromeThread from JsonPrefStore and moved ↵sanjeevr@chromium.org2010-05-211-2/+6
| | | | | | | | | | | JsonPrefStore and PrefStore to chrome/common. This is because JsonPrefStore is needed in the service process BUG=None. TEST=Updated unit-tests Review URL: http://codereview.chromium.org/2066015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47915 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize the ChromeFrame request manager with the container interface in ↵ananta@chromium.org2010-05-211-1/+2
| | | | | | | | | | | | the constructor instead of FinalConstruct as there are codepaths in which the base FinalConstruct is not called. Bug=44465 Review URL: http://codereview.chromium.org/2093011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47890 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ChromeFrame crash caused when the cookie policy is set to prompt and ↵ananta@chromium.org2010-05-204-6/+25
| | | | | | | | | | | | | | | | | | | | | the active document is released before the prompt is clicked on. This only happens on IE6 where the prompt dialog is modeless in the context of the InternetSetCookieEx call. To ensure that the active document remains valid for the duration of the call we maintain a reference on the container for the duration of the InternetSetCookie call. The cookie calls in IE are now handled on the UI thread as we cannot block the IPC thread in case the set cookie calls result in a prompt. This fixes bug http://code.google.com/p/chromium/issues/detail?id=44465 The FullTabModeIE_UnloadEventTest has been disabled as the change to execute the cookie calls on the UI thread would break it. Bug=44465, 40814 Review URL: http://codereview.chromium.org/2091015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47846 0039d316-1c4b-4281-b951-d872f2087c98
* Check the container for NULLness before dereferencing.tommi@chromium.org2010-05-201-3/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2117021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47826 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid wrapping callbacks for network requests not coming from MSHTML.stoyan@chromium.org2010-05-201-0/+19
| | | | | | | | | This is a tentative fix, since I was unable to reproduce crash in AcroPDF.dll Review URL: http://codereview.chromium.org/2087017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47813 0039d316-1c4b-4281-b951-d872f2087c98
* Check correct offset to avoid crashamit@chromium.org2010-05-191-2/+3
| | | | | | | | | | | | This change corrects the offset and the condition to avoid crash in IBrowserService2::v_MayTranslateAccelerator. BUG=25457 Review URL: http://codereview.chromium.org/2109010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47744 0039d316-1c4b-4281-b951-d872f2087c98
* Fix false positive reporting of exceptions picked up during calls to ↵robertshield@chromium.org2010-05-191-0/+8
| | | | | | | | | | | LoadLibrary during DllRegisterServer. BUG=44468 Review URL: http://codereview.chromium.org/2089016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47696 0039d316-1c4b-4281-b951-d872f2087c98
* Addressing review comment from Stoyan (remove one dlog statement).tommi@chromium.org2010-05-191-3/+0
| | | | | | | | | | TEST=none BUG=none TBR=stoyan Review URL: http://codereview.chromium.org/2102010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47691 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a bit of logging to track down the reason for recent ↵tommi@chromium.org2010-05-191-9/+19
| | | | | | | | | | | | "LaunchBrowser(browser, page)" failures on the build bots. TEST=n/a BUG=none Review URL: http://codereview.chromium.org/2099005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47690 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeFrame MockCreateTabOk test by returning the launch result from ↵ananta@chromium.org2010-05-193-8/+12
| | | | | | | | | | | | | | the CreateExternalTabComplete helper and passing the same to the InitializeComplete function which eventually gets passed down to the mock delegate which expects a failure. Bug=44245 TBR=stoyan Review URL: http://codereview.chromium.org/2114009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47617 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeFrame new window popup test by ensuring that ↵ananta@chromium.org2010-05-193-13/+12
| | | | | | | | | | | | | | | | | CreateExternalTabComplete executes on the IPC thread as before and InitializeComplete executes as a task on the UI thread. The test failed because we receive IPCs for the new tab before we have a tab proxy for it. To fix the crash in bug http://code.google.com/p/chromium/issues/detail?id=44245, we set the automation_server_ member to NULL after ReleaseAutomationServer returns. There are a number of races related to the automation server being released which should hopefully go away if we remove dependency on the AutomationProxy object. Added a TODO to that effect in the code. Bug=44245 Review URL: http://codereview.chromium.org/2079012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47612 0039d316-1c4b-4281-b951-d872f2087c98
* Rename "mixed content" to "insecure content" in as many places as possible, ↵pkasting@chromium.org2010-05-182-8/+8
| | | | | | | | | | to standardize on a consistent naming scheme. BUG=none TEST=none Review URL: http://codereview.chromium.org/2069005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47531 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this fix with the fixes to get chrome frame tests to pass.ananta@chromium.org2010-05-188-153/+254
| | | | | | | | | | | | | | | | | | | | | | | | | | | In ChromeFrame the ChromeFrameAutomationProxy object is created on the background proxy channel thread and is accessed from the UI thread, the proxy channel thread and the IPC thread. This leads to a race condition when ChromeFrame is being torn down which occurs because the ChromeFrameAutomationProxy pointer is being set to NULL in the UI thread/deleted in the proxy background thread while it could be accessed while processing a callback in the IPC thread thus causing a crash. Fix is to ensure that the IPC thread does not access the ChromeFrameAutomationProxy pointer. To achieve this the callbacks are now individual context objects which when invoked forward the actions to the ChromeFrameAutomationClient object. The CreateExternalTab and ConnectExternalTab callbacks now complete their actions on the UI thread. While at this based on a discussion and lot of help from Stoyan we decided to clean up the sync message dispatching code used by ChromeFrame by having callbacks now derive from a SyncMessageCallContext class to ensure that these get cleaned up correctly in all cases. For e.g. if we don't receive a response for a message, etc and thus enable them to present a consistent interface to be invoked when we receive a response for a IPc message. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44245 Bug=44245 TBR=stoyan Review URL: http://codereview.chromium.org/2119004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47494 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47453 - In ChromeFrame the ChromeFrameAutomationProxy object is ↵ananta@chromium.org2010-05-175-219/+145
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | created on the background proxy channel thread and is accessed from the UI thread, the proxy channel thread and the IPC thread. This leads to a race condition when ChromeFrame is being torn down which occurs because the ChromeFrameAutomationProxy pointer is being set to NULL in the UI thread/deleted in the proxy background thread while it could be accessed while processing a callback in the IPC thread thus causing a crash. Fix is to ensure that the IPC thread does not access the ChromeFrameAutomationProxy pointer. To achieve this the callbacks are now individual context objects which when invoked forward the actions to the ChromeFrameAutomationClient object. The CreateExternalTab and ConnectExternalTab callbacks now complete their actions on the UI thread. While at this based on a discussion and lot of help from Stoyan we decided to clean up the sync message dispatching code used by ChromeFrame by having callbacks now derive from a SyncMessageCallContext class to ensure that these get cleaned up correctly in all cases. For e.g. if we don't receive a response for a message, etc and thus enable them to present a consistent interface to be invoked when we receive a response for a IPc message. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44245 Bug=44245 Review URL: http://codereview.chromium.org/2073007 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/2110006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47461 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame the ChromeFrameAutomationProxy object is created on the ↵ananta@chromium.org2010-05-175-145/+219
| | | | | | | | | | | | | | | | | | | | | | | | | | background proxy channel thread and is accessed from the UI thread, the proxy channel thread and the IPC thread. This leads to a race condition when ChromeFrame is being torn down which occurs because the ChromeFrameAutomationProxy pointer is being set to NULL in the UI thread/deleted in the proxy background thread while it could be accessed while processing a callback in the IPC thread thus causing a crash. Fix is to ensure that the IPC thread does not access the ChromeFrameAutomationProxy pointer. To achieve this the callbacks are now individual context objects which when invoked forward the actions to the ChromeFrameAutomationClient object. The CreateExternalTab and ConnectExternalTab callbacks now complete their actions on the UI thread. While at this based on a discussion and lot of help from Stoyan we decided to clean up the sync message dispatching code used by ChromeFrame by having callbacks now derive from a SyncMessageCallContext class to ensure that these get cleaned up correctly in all cases. For e.g. if we don't receive a response for a message, etc and thus enable them to present a consistent interface to be invoked when we receive a response for a IPc message. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44245 Bug=44245 Review URL: http://codereview.chromium.org/2073007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47453 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r47347 [was reverted in r47357], this time without re-enabling a ↵pkasting@chromium.org2010-05-171-4/+6
| | | | | | | | | | | | | | | | | | | | | DISABLED test that times out on Mac. (Original patch reviewed at http://codereview.chromium.org/2067003 ) Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken". Make the "display" state only affect the current tab (not the entire host). Fix an SSL browser test by supplying the appropriate SiteInstance*. Move a test from "disabled" to "flaky" since it at least passes for me. Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner. BUG=15072, 18626, 40932, 42758 TEST=Covered by browser tests Review URL: http://codereview.chromium.org/2063008 Review URL: http://codereview.chromium.org/2126005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47428 0039d316-1c4b-4281-b951-d872f2087c98
* Perform breakpad shutdown when returning from the chrome launcher entry ↵robertshield@chromium.org2010-05-172-5/+12
| | | | | | | | | | | point. This is a to avoid the deadlock that occurs when shutting it down in DllMain in chrome_launcher.exe. BUG=44212 TEST=chrome_launcher.exe stops hanging Review URL: http://codereview.chromium.org/2094006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47422 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47347 - (Original patch reviewed at ↵rvargas@google.com2010-05-151-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/2067003 ) Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken". Make the "display" state only affect the current tab (not the entire host). Fix an SSL browser test by supplying the appropriate SiteInstance*. Move a test from "disabled" to "flaky" since it at least passes for me. Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner. Falied TestGoodFrameNavigation on Mac 10.5 browser tests among other things: /b/slave/chromium-rel-mac-builder/build/src/chrome/browser/ssl/ssl_browser_tests.cc:43: Failure Value of: entry->ssl().displayed_mixed_content() Actual: false Expected: displayed_mixed_content Which is: true BUG=15072, 18626, 40932, 42758 TEST=Covered by browser tests Review URL: http://codereview.chromium.org/2063008 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/2095006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47357 0039d316-1c4b-4281-b951-d872f2087c98
* (Original patch reviewed at http://codereview.chromium.org/2067003 )pkasting@chromium.org2010-05-151-4/+6
| | | | | | | | | | | | | | | | | | Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken". Make the "display" state only affect the current tab (not the entire host). Fix an SSL browser test by supplying the appropriate SiteInstance*. Move a test from "disabled" to "flaky" since it at least passes for me. Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner. BUG=15072, 18626, 40932, 42758 TEST=Covered by browser tests Review URL: http://codereview.chromium.org/2063008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47347 0039d316-1c4b-4281-b951-d872f2087c98
* Create first tests for verifying that Chrome Frame does not interfere with ↵kkania@chromium.org2010-05-148-69/+256
| | | | | | | | | | normal IE operation. BUG=none TEST=none Review URL: http://codereview.chromium.org/1992018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47336 0039d316-1c4b-4281-b951-d872f2087c98
* Candidate fix for bug 44108. The FromBindContext function was inherently ↵tommi@chromium.org2010-05-149-54/+89
| | | | | | | | | | | | | racy as it returned a pointer to a non-addrefed pointer and the AddRef/Release implementation in the BindContextInfo was not thread safe. Also fixed BSCBStorageBind object leak. TEST=See bug description BUG=44108 Review URL: http://codereview.chromium.org/2080005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47306 0039d316-1c4b-4281-b951-d872f2087c98
* Not using std::wstring to store progress status text because mshtml is ↵tommi@chromium.org2010-05-142-14/+65
| | | | | | | | | | | sensitive to NULL vs L"". TEST=see bug BUG=44103 Review URL: http://codereview.chromium.org/2118001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47232 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the chrome frame context menu back forward test which regressed in ↵ananta@chromium.org2010-05-144-15/+34
| | | | | | | | | | | | | | | | | revision 47187 due to a change in the context menu resource ids. Solution is to include the chrome_dll_resources.h file in a way to reduce conflicts with existing chrome frame resources. We have two new files chrome_imported_resources.cc/.h to achieve that. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44134 Bug=44134 Review URL: http://codereview.chromium.org/2067006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47223 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit test breakage in last change.amit@chromium.org2010-05-132-3/+5
| | | | | | | | | | | | | | | Instead of returning E_FAIL from IStream::Read when there is no valid cache to serve content from, confirm tp the IStream Read contract and return S_FALSE with 0 bytes. TBR=stoyan TEST=MonikerPatchTest.CacheStream Review URL: http://codereview.chromium.org/2114001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47189 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in CacheStream::Readamit@chromium.org2010-05-132-10/+23
| | | | | | | | | | | | Fix incorrect assumption that the Read of CacheStream will happen in the context of IBindStatusCallback::OnDataAvailable notification. TEST=none BUG=43949 Review URL: http://codereview.chromium.org/2007009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47184 0039d316-1c4b-4281-b951-d872f2087c98
* Use an interface to get to the C++ object pointer instead of casting directly.tommi@chromium.org2010-05-132-9/+68
| | | | | | | | | | | The object was being marshalled so, we were casting an ole32 proxy object to our implementation. To avoid marshalling altogether I'm also using the FTM. So, yeah, we're going belt and suspenders. TEST=See bug. BUG=43988 Review URL: http://codereview.chromium.org/2011016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47160 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ChromeFrame regression introduced by the fix for bug ↵ananta@chromium.org2010-05-131-0/+4
| | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=43922. The active document url was not being updated when we receive the navigation state from chrome. This caused a couple of chrome frame tests to fail. Bug=43922 TBR=amit Review URL: http://codereview.chromium.org/2052011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47113 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this as a number of tests have been failing on all builders ever ↵ananta@chromium.org2010-05-134-109/+5
| | | | | | | | | | | | | | | | since. Please look into this and resubmit. Revert 47065 - An attempt to catch unexpected script errors in html test pages in a more generic way. TEST=This is meant to help track down flakiness of a few tests. BUG=none Review URL: http://codereview.chromium.org/2052006 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/2011017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47099 0039d316-1c4b-4281-b951-d872f2087c98
* The chrome frame net tests would not complete at times on the IE6 builder. ↵ananta@chromium.org2010-05-121-1/+11
| | | | | | | | | | | | | | This was due to a regression introduced recently where we removed the chrome frame stream cache from the urlmon request object and instead cached the stream passed in. While this was all fine, we failed to handle the case where an attempt to read from this stream in response to a read request from chrome returned S_FALSE which means end of data, in which case we should release the stream. Not doing this caused us to not send over the end request notification to chrome, thus causing the tests to indefinitely wait. Review URL: http://codereview.chromium.org/2001019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47093 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame's bind status callback functions we should always return ↵ananta@chromium.org2010-05-121-1/+6
| | | | | | | | | | | | success regardless of whether we have a valid delegate or not. Bug=43927 Review URL: http://codereview.chromium.org/2030009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47088 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame would not switch to Chrome at times. The navigation manager in ↵ananta@chromium.org2010-05-123-12/+2
| | | | | | | | | | | | | | | | | | | | | | ChromeFrame maintains the current top level URL which is used by the moniker patch to decide whether to wrap the callback. This url is typically set in the Bho in the BeforeNavigate callback. We also had code to update this url when we receive a navigation update from Chrome. The reason we would not switch is because of a race condition between receiving a top level navigation request from chrome and receiving a navigation update for the previous operation which caused us to not wrap the bind status callback. Fix is to not update the url in the callback when we receive a navigation status update. In any case it is Chrome's responsibility to inform ChromeFrame about top level url navigations. We should fix the bug if any in Chrome which caused this hack to go in. Fixes bug http://code.google.com/p/chromium/issues/detail?id=43922 Other changes are to replace the NOTREACHED in the chrome frame automation proxy code with a DLOG as this fires during chrome frame test runs. Bug=43922 Review URL: http://codereview.chromium.org/1991008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47086 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a chrome frame crash reported on the crash server in our bind status ↵ananta@chromium.org2010-05-121-0/+5
| | | | | | | | | | | | | | | | callback OnResponse implementation. Crash occurs while dereferencing a NULL delegate. Fix is to add a check for the same. This could happen if the binding was stopped before receiving the OnResponse notification. Fixes bug http://code.google.com/p/chromium/issues/detail?id=43927 Bug=43927 Review URL: http://codereview.chromium.org/2060002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47085 0039d316-1c4b-4281-b951-d872f2087c98
* An attempt to catch unexpected script errors in html test pages in a more ↵tommi@chromium.org2010-05-124-5/+109
| | | | | | | | | | | generic way. TEST=This is meant to help track down flakiness of a few tests. BUG=none Review URL: http://codereview.chromium.org/2052006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47065 0039d316-1c4b-4281-b951-d872f2087c98
* Http Cache: Add a backend factory class so that the callerrvargas@google.com2010-05-121-1/+1
| | | | | | | | | | | | has more control about the backend instantiation. BUG=none TEST=current unit tests. Review URL: http://codereview.chromium.org/2000011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47050 0039d316-1c4b-4281-b951-d872f2087c98
* Catch and report an exception that I saw in the ↵tommi@chromium.org2010-05-101-3/+9
| | | | | | | | | | | | WidgetModeIE_InitializeHidden test on the IE6 bot to avoid a hang issue. Alex is already working on a proper fix. TEST=n/a BUG=none TBR=slightlyoff Review URL: http://codereview.chromium.org/2013014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46857 0039d316-1c4b-4281-b951-d872f2087c98
* Adding error handling to DeleteCookie test.tommi@chromium.org2010-05-101-13/+16
| | | | | | | | | | TEST=none TBR=ananta BUG=none Review URL: http://codereview.chromium.org/2000007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46851 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Add a bunch of missing includes.thestig@chromium.org2010-05-102-3/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2018001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46850 0039d316-1c4b-4281-b951-d872f2087c98
* Add more diagnostics to the SrcProperty test.tommi@chromium.org2010-05-101-23/+27
| | | | | | | | | | TEST=none BUG=none TBR=slightlyoff Review URL: http://codereview.chromium.org/1997012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46835 0039d316-1c4b-4281-b951-d872f2087c98
* Instrument Chrome and Chrome Frame for some perf measurements.siggi@chromium.org2010-05-103-0/+17
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1989005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46812 0039d316-1c4b-4281-b951-d872f2087c98
* Utility bat file to make it easy to build and run smoke tests.siggi@chromium.org2010-05-102-0/+107
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46811 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare the default profile and turn off some services before initializing ↵tommi@chromium.org2010-05-101-3/+4
| | | | | | | | | | | | extensions. TEST=This is an attempt to reduce flakiness of Chrome Frame net tests. BUG=none TBR=ananta Review URL: http://codereview.chromium.org/2051004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46807 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-04-22 23:11:59 +0000