summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* GTTF: Do not use the new test launcher for ash_unittests and chrome_frame_testsphajdan.jr@chromium.org2013-12-051-34/+18
| | | | | | | | | | | | | | | This reverts parts of the following CLs committed ~week ago: https://codereview.chromium.org/85503004 https://codereview.chromium.org/86773003 TBR=sky,erikwright BUG=236893 Review URL: https://codereview.chromium.org/105803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238895 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetFileSize, NormalizeFilePath to base namespacebrettw@chromium.org2013-12-041-1/+1
| | | | | | | | | BUG= R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/102873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238722 0039d316-1c4b-4281-b951-d872f2087c98
* Move directory creation functions to base namespace.brettw@chromium.org2013-12-031-2/+2
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/100573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98
* Move temp file functions to base namespace.brettw@chromium.org2013-12-035-5/+5
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/99923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238427 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize ICU early in npchrome_frame.dll's lifetime.grt@chromium.org2013-12-021-2/+16
| | | | | | | | | | | | This fixes a crash when navigating to an URL containing an internationalized domain name. BUG=324855 R=robertshield@chromium.org Review URL: https://codereview.chromium.org/99623003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238226 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more file utils to the base namespace.brettw@chromium.org2013-12-021-1/+1
| | | | | | | | | This also swaps the order of the parameters to GetShmemTempDir so the out parameter is last, and enhances some documentation. Review URL: https://codereview.chromium.org/93263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238144 0039d316-1c4b-4281-b951-d872f2087c98
* Move EmptyString, kWhitespace and the BOM to base.brettw@chromium.org2013-12-023-5/+4
| | | | | | | | | | | | | | | This moves EmptyString*, kWhitespace*, and the UTF 8 Byte Order Marker to the base:: namespace. Many of them just got changed to a default-constructed string when a reference was not required. I qualified some string16s with base:: when I was changing adjacent code. I need to do another pass to finish these up. BUG= TBR=sky@chromium.org Review URL: https://codereview.chromium.org/89243003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238032 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Remove Receive() from ScopedHandle.rvargas@chromium.org2013-11-283-10/+9
| | | | | | | | | | | | | | | | | | In general, the OS API contract doesn't guarantee that output variables are not modified on failure, so a Reeceive pattern is fundamentally insecure. BUG=318531 TEST=current tests tbr'ing owners for the consumers. TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237459 Review URL: https://codereview.chromium.org/71013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237675 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: enable brave new test launcher for chrome_frame_tests and ↵phajdan.jr@chromium.org2013-11-272-25/+58
| | | | | | | | | | | | | chrome_frame_unittests This is still behind --brave-new-test-launcher command-line flag. BUG=236893 R=erikwright@chromium.org Review URL: https://codereview.chromium.org/86773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237621 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/71013004/hashimoto@chromium.org2013-11-273-9/+10
| | | | | | | | | | | | Reason for revert: Causing compile failure in chrome_util.cc on "Google Chrome Win" http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/21803 TBR=cpu@chromium.org,jvoung@chromium.org,thakis@chromium.org,sergeyu@chromium.org,grt@chromium.org,gene@chromium.org,youngki@chromium.org,rvargas@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/90963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237541 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Remove Receive() from ScopedHandle.rvargas@chromium.org2013-11-273-10/+9
| | | | | | | | | | | | | | | | In general, the OS API contract doesn't guarantee that output variables are not modified on failure, so a Reeceive pattern is fundamentally insecure. BUG=318531 TEST=current tests tbr'ing owners for the consumers. TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org Review URL: https://codereview.chromium.org/71013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237459 0039d316-1c4b-4281-b951-d872f2087c98
* Small refactor to MetricsLog stability functionality.asvitkine@chromium.org2013-11-211-2/+2
| | | | | | | | | | | | | | | | | | | | | This CL simplifies some MetricsLog APIs, consolidating RecordEnvironment and RecordEnvironmentProto as well as RecordIncrementalStabilityElements and WriteStabilityElement. This reduces the MetricsLog API surface, simplifying things for some upcoming changes I'm planning to make (recording startup stability stats separately from startup histograms and profiler data). No changes to logic/functionality. BUG=312733, 109818 TEST=Existing unit tests. TBR=grt@chromium.org Review URL: https://codereview.chromium.org/69603003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236551 0039d316-1c4b-4281-b951-d872f2087c98
* Remove second layer of lazy loading from base_feature_provider.meacer@chromium.org2013-11-201-0/+5
| | | | | | | | | | | LazyFeatureProvider is not thread safe and can cause crashes. This CL removes LazyFeatureProvider altogether. BUG=313743 Review URL: https://codereview.chromium.org/57863004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236272 0039d316-1c4b-4281-b951-d872f2087c98
* Dissociate ui_resources target from ui.gyp.tfarina@chromium.org2013-11-201-1/+1
| | | | | | | | | | | | | | | | | | This is the first step for moving ui.gyp into ui/base/ After this lands, Blink will be updated to reference the new file under ui/resources. Then the by-pass target will be removed from ui.gyp. And then we can move it to its finall location. BUG=299841 TEST=None R=ben@chromium.org Review URL: https://codereview.chromium.org/74853003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236099 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up PrefServiceBuilderisherman@chromium.org2013-11-191-4/+4
| | | | | | | | | | | | | | | | | * Use simple setters rather than With* methods. * Explicitly transfer memory ownership. * Rename "Builder" to "Factory" * Eliminate the side-effect of resetting the builder from the Create* methods. Along the way, fix a memory leak in the Android WebView. BUG=315499 TEST=none (code should continue to compile and tests should continue to pass) R=joi@chromium.org Review URL: https://codereview.chromium.org/64193003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235913 0039d316-1c4b-4281-b951-d872f2087c98
* Sniff out IE11 version properly.grt@chromium.org2013-11-152-1/+5
| | | | | | | | | | BUG=264800 R=robertshield@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/59883014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235357 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 234367 "Base: Make RegistryOverrideManager support sharde...""tommycli@chromium.org2013-11-153-12/+0
| | | | | | | | | | | | | This reverts commit 98ee7dd64463c42a076782c923330107e60b8fad. Reapply of https://codereview.chromium.org/57423008 now that a blocking issue has been fixed. BUG=314800 TBR=grt,owners Review URL: https://codereview.chromium.org/68743005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235284 0039d316-1c4b-4281-b951-d872f2087c98
* Remove linux coverage scripts.thakis@chromium.org2013-11-141-151/+1
| | | | | | | | | BUG=318423 TBR=owners Review URL: https://codereview.chromium.org/68193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235208 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilation on 2013 debug due to ATL changesscottmg@chromium.org2013-11-141-1/+1
| | | | | | | | | | | Fixes http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20VS2013%20%28dbg%29/builds/101/steps/compile/logs/stdio R=robertshield@chromium.org BUG=309197 Review URL: https://codereview.chromium.org/71963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234981 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 234367 "Base: Make RegistryOverrideManager support sharde..."tommycli@chromium.org2013-11-123-0/+12
| | | | | | | | | | | | | | | > Base: Make RegistryOverrideManager support sharded/parallel tests. > > BUG=314800 > TBR=ajwong@chromium.org > > Review URL: https://codereview.chromium.org/57423008 TBR=tommycli@chromium.org Review URL: https://codereview.chromium.org/69793004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234627 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use UpdateRegistryFromResourceS as it's not in 2013scottmg@chromium.org2013-11-121-0/+6
| | | | | | | | | | | | | | | | | | | ATL version that ships with 2013 doesn't have a suffix. UpdateRegistryFromResource used to select either an S or a D suffix based on the value of _ATL_STATIC_REGISTRY, however in ATL 12 (vs2013), UpdateRegistryFromResource now just means UpdateRegistryFromResourceS, and UpdateRegistryFromResourceD is separate. We want to keep building with 2010 and 2013, so #if based on _ATL_VER. R=ananta@chromium.org, robertshield@chromium.org BUG=309197 Review URL: https://codereview.chromium.org/66583008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234439 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Fix error handling on wrong file in UploadDatatzik@chromium.org2013-11-124-7/+10
| | | | | | | | | | | * Handle file error as a failure rather than handling it as empty file. * Change Chrome Frame error handling for URLRequest failure, from DCHECK hit to ignoring failing input file. BUG=310548, 317432 Review URL: https://codereview.chromium.org/39203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234436 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unused includes of webkit/glue/webkit_glue.htfarina@chromium.org2013-11-121-4/+0
| | | | | | | | | | | | | | | | | This patch was generated by: $ git grep -l webkit/glue/webkit_glue.h > list.txt $ for f in $(cat list.txt); do if ! grep -q 'PlatformFileInfoToWebFileInfo' $f ; then echo $f; fi; done $ for f in $(cat list.txt); do if ! grep -q 'SetJavaScript' $f ; then echo $f; fi; done BUG=None TEST=unit_tests, content_unittests R=thestig@chromium.org TBR=joth,avi,jamesr Review URL: https://codereview.chromium.org/59323005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234409 0039d316-1c4b-4281-b951-d872f2087c98
* Do not load Chrome Frame into IE11+.grt@chromium.org2013-11-121-0/+5
| | | | | | | | | BUG=264800 R=robertshield@chromium.org Review URL: https://codereview.chromium.org/67893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234398 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Make RegistryOverrideManager support sharded/parallel tests.tommycli@chromium.org2013-11-123-12/+0
| | | | | | | | | BUG=314800 TBR=ajwong@chromium.org Review URL: https://codereview.chromium.org/57423008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234367 0039d316-1c4b-4281-b951-d872f2087c98
* Use the large pdb workaround on more unittests.sebmarchand@chromium.org2013-11-091-0/+1
| | | | | | | | | | If we don't do this we can't compile these targets in Debug with component='static_library'. BUG= Review URL: https://codereview.chromium.org/67223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234100 0039d316-1c4b-4281-b951-d872f2087c98
* Use the large pdb workaround on chrome_frame_reliability_tests.sebmarchand@chromium.org2013-11-081-0/+1
| | | | | | | | | | If we don't do this we can't compile this target in Debug with component='static_library'. BUG= Review URL: https://codereview.chromium.org/61913005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233803 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the chrome namespace around ChromeContent[Renderer]Client.wez@chromium.org2013-11-061-2/+2
| | | | | | Review URL: https://codereview.chromium.org/24544004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233373 0039d316-1c4b-4281-b951-d872f2087c98
* Fix spelling: "supress" -> "suppress"mseaborn@chromium.org2013-11-022-2/+2
| | | | | | | | | | BUG=165339 TEST=none TBR=bulach@chromium.org,pkasting@chromium.org Review URL: https://codereview.chromium.org/49693005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232557 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Add a priority parameter to URLRequest's constructorakalin@chromium.org2013-10-311-4/+5
| | | | | | | | | | | | | | | | | | | This is so that it is clearer what the intended initial priority of a URLRequest is. It is also needed so that we can later enforce that if a URLRequest is set to ignore limits, it has MAXIMUM_PRIORITY; otherwise, we'd have to mandate that SetPriority() is called before set_load_flags(), which is fiddly. Also standardize on a single URLRequest constructor. BUG=166689 R=jam@chromium.org, jamesr@chromium.org, joth@chromium.org, mmenke@chromium.org, scottbyer@chromium.org, sky@chromium.org, tommi@chromium.org Review URL: https://codereview.chromium.org/51953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232219 0039d316-1c4b-4281-b951-d872f2087c98
* Remove trailing "." from message lines.thakis@chromium.org2013-10-311-2/+2
| | | | | | | | | | | | | | | | | cs.chromium.org has way fewer hits for 'message'.*\.',?$ file:gyp than for 'message'.*[^\.]',?$ file:gyp so standardize on the latter. BUG=none TEST=less ocd when watching build output NOTRY=true Review URL: https://codereview.chromium.org/51843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232166 0039d316-1c4b-4281-b951-d872f2087c98
* Always show the Chrome Frame turndown prompt.grt@chromium.org2013-10-317-188/+2
| | | | | | | | | | | This change removes the dismiss button (reverting r213426 and r213521) as well as the reshow delta (effectively making the delta 0). BUG=none Review URL: https://codereview.chromium.org/52583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232064 0039d316-1c4b-4281-b951-d872f2087c98
* Track execution phase of browser process and track it asrtenneti@chromium.org2013-10-281-0/+4
| | | | | | | | | | | | | | | | | | | | a UMA histogram. As a first attempt, tracked the following - Before starting metrics service, - Before creating profile - Before starting startup time bomb - Before starting thread watcher - Before starting main message loop - Before starting shutdown time bomb - clean shutdown. R=jar@chromium.org Review URL: https://codereview.chromium.org/28283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231334 0039d316-1c4b-4281-b951-d872f2087c98
* net: Rework how blocking delegates are logged.mmenke@chromium.org2013-10-251-1/+7
| | | | | | | | | | | | | | | | | | | | Switch to logging an event before calling into delegates, and after they return instead of only in the case that they block. This allows delegates to log events as they take turns blocking a network request. Also allows delegates to log events when delaying the start of a request, and when delaying the start of reading the body of a request (But not between normal body reads). Also allows delegates to log delegate information that will not be displayed to the user. BUG=294920 Review URL: https://codereview.chromium.org/25097004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231084 0039d316-1c4b-4281-b951-d872f2087c98
* Preparing to support fragment resolution against non-hierarchical schemeskristianm@chromium.org2013-10-242-2/+2
| | | | | | | | | | | | | Adds a new GURL::GetContent() to retrieve the text after scheme: specifically intended for use in non-hierarchical schemes (data: etc). Doing the first part of https://codereview.chromium.org/23835019/ in a preparation CL. BUG=291747 Review URL: https://codereview.chromium.org/23549039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230781 0039d316-1c4b-4281-b951-d872f2087c98
* Show the Chrome Frame turndown prompt daily.grt@chromium.org2013-10-241-1/+1
| | | | | | | | | BUG=310806 R=robertshield@chromium.org Review URL: https://codereview.chromium.org/37173006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230642 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce a separate gyp file for content shell and testsjochen@chromium.org2013-10-191-1/+1
| | | | | | | | | | | | This will make it possible to depend on components from content shell BUG=247431 R=jam@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/28123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229620 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 229469 "Disables ChromeFrameTestWithWebServer.WidgetModeI..."sky@chromium.org2013-10-181-3/+1
| | | | | | | | | | | | | | | | | > Disables ChromeFrameTestWithWebServer.WidgetModeIE_ObjectFocus > > BUG=308847 > TEST=none > R=grt@chromium.org > TBR=grt@chromium.org > > Review URL: https://codereview.chromium.org/29863002 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/30103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229488 0039d316-1c4b-4281-b951-d872f2087c98
* Disables ChromeFrameTestWithWebServer.WidgetModeIE_ObjectFocussky@chromium.org2013-10-181-1/+3
| | | | | | | | | | | BUG=308847 TEST=none R=grt@chromium.org TBR=grt@chromium.org Review URL: https://codereview.chromium.org/29863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229469 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 229320 "Disable ChromeFrameTestWithWebServer.WidgetModeIE..."grt@chromium.org2013-10-181-3/+1
| | | | | | | | | | | | | | | | The revert of r229285 at r229410 shoud resolve this for now. > Disable ChromeFrameTestWithWebServer.WidgetModeIE_ObjectFocus. It regressed in [229275:229286] > > BUG=308847 > > Review URL: https://codereview.chromium.org/28223004 TBR=pfeldman@chromium.org Review URL: https://codereview.chromium.org/29313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229427 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ChromeFrameTestWithWebServer.WidgetModeIE_ObjectFocus. It regressed ↵pfeldman@chromium.org2013-10-181-1/+3
| | | | | | | | | | in [229275:229286] BUG=308847 Review URL: https://codereview.chromium.org/28223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229320 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Remove Mac specific function from BookmarkNodeData.tfarina@chromium.org2013-10-121-2/+2
| | | | | | | | | | | | | | | | This removes another ifdef, which should be avoided in general. This is a follow up to the clean up started in crrev.com/225862. See discussion from https://codereview.chromium.org/25022004/ BUG=None TEST=None, no behavior changed. R=sky@chromium.org,asvitkine@chromium.org TBR=darin # for trivial changes in content/ Review URL: https://codereview.chromium.org/25435002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228347 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to sconsbuild.thakis@chromium.org2013-10-121-1/+1
| | | | | | | | | | | scons hasn't been used in a long time. BUG=305702 NOTRY=true Review URL: https://codereview.chromium.org/26718002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228308 0039d316-1c4b-4281-b951-d872f2087c98
* Explicit initialization of aura::Env for browser shell.dnicoara@chromium.org2013-10-091-0/+2
| | | | | | | | | | | | | | | | | | Most implementations (x11 aura with and without chromeos) do not explicitly call aura::Env::GetInstance() to initialize it. These build work as is because the call is done when performing other operations, such as adding observers. In OZONE there are no such calls, so the OZONE build fails when trying to create a compositor since the Compositor::Initialize hasn't been called. This patch adds an explicit initialization for aura based builds to fix this issue. BUG= Review URL: https://codereview.chromium.org/23882007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227745 0039d316-1c4b-4281-b951-d872f2087c98
* Canonical encoding name : windows-949 => EUC-KRjshin@chromium.org2013-10-081-1/+1
| | | | | | | | | | | | | | | | | | This is the chromium side of a blink change at https://codereview.chromium.org/25870005 Until the corresponding blink CL above is re-landed (it's landed but reverted), disable EUC-KR-related test temporarily. This is a copy of https://codereview.chromium.org/25769005/ (lgtm'd and approved). BUG=277027, 95963 TEST=browser test: BrowserEncodingTest.* and EncodingAlias*. TBR=thakis,robertshield Review URL: https://codereview.chromium.org/26439002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227506 0039d316-1c4b-4281-b951-d872f2087c98
* Don't modify Secure Mime Handlers if there's no need.grt@chromium.org2013-10-031-16/+43
| | | | | | | | | | | | | | | | | | | When Chrome creates Google Update's OnDemandMachineAppsClass by way of the elevation moniker, the eventual setup.exe's process security token doesn't have the SeSecurityPrivilege. This prevents Chrome Frame from reading and/or modifying the security descriptor on the Secure Mime Handlers registry key. This had been resulting in error 7 when trying to manually update a Chrome that shared binaries with Chrome Frame. With this change, the values are probed before trying to modify them. Chances are that they will already hold the correct data, so the update should succeed. BUG=224043 TEST=see comment #3 in bug Review URL: https://codereview.chromium.org/25738003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226810 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move PerfTimer out of test/ directory.tfarina@chromium.org2013-09-291-1/+0
| | | | | | | | | | | | | | | | | | Reason: PerfTimer is used by production code, so it doesn't make sense to have it as test only. - Rename it to ElapsedTimer. - Move into base namespace. - Move into timer/ directory. BUG=None TEST=None, no functional change R=brettw@chromium.org TBR=grt@chromium.org # for chrome_frame Review URL: https://codereview.chromium.org/24265005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225898 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove some FromWStringHack() calls in chrome/installer.thestig@chromium.org2013-09-261-1/+1
| | | | | | | | | BUG=76112 R=grt@chromium.org Review URL: https://codereview.chromium.org/23645012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225291 0039d316-1c4b-4281-b951-d872f2087c98
* net: Use ScopedVector::Pass() to pass element readers for UploadDataStream's ↵hashimoto@chromium.org2013-09-241-1/+1
| | | | | | | | | | | | | | | ctor ScopedVector supports Pass() method. Use of Pass() makes it clear that the ownership of the readers moves to the newly created UploadDataStream. BUG=None TEST=git cl try TBR=sky@chromium.org for content/browser, mpcomplete@chromium.org for chrome/browser/extensions/api/web_request Review URL: https://chromiumcodereview.appspot.com/23929005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224960 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 224269 "Don't persist HPKP if PrivacyMode is enabled."tkent@chromium.org2013-09-201-1/+0
| | | | | | | | | | | | | | | | | | | | | | | It broke Google Chrome ChromeOS bot. http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/58548/steps/compile/logs/stdio#error1 FAILED: g++ ... -c ../../net/socket/ssl_client_socket_nss.cc -o obj/net/socket/net.ssl_client_socket_nss.o ../../net/socket/ssl_client_socket_nss.cc: In member function 'int net::SSLClientSocketNSS::DoVerifyCertComplete(int)': ../../net/socket/ssl_client_socket_nss.cc:3445:64:error: no matching function for call to 'net::TransportSecurityState::GetDomainState(const string&, bool&, net::TransportSecurityState::DomainState*)' ../../net/socket/ssl_client_socket_nss.cc:3445:64: note: candidate is: ../../net/http/transport_security_state.h:212:8: note: bool net::TransportSecurityState::GetDomainState(const string&, bool, bool, net::TransportSecurityState::DomainState*) ../../net/http/transport_security_state.h:212:8: note: candidate expects 4 arguments, 3 provided > Don't persist HPKP if PrivacyMode is enabled. > > BUG=258667 > > Review URL: https://chromiumcodereview.appspot.com/19269012 TBR=mef@chromium.org Review URL: https://codereview.chromium.org/24251011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224275 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 23:30:31 +0000