summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Fix DCHECKs in the UMA histogram code in ChromeFrame. These started firing ↵ananta@chromium.org2012-01-121-2/+2
| | | | | | | | | | | | due to recent histogram parameter validations. Changes based on a discussion with Jim. BUG=none TEST=ChromeFrame should load in IE in debug builds. Review URL: http://codereview.chromium.org/9139036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117454 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome/common/metrics* files into a shared subdirectory.isherman@chromium.org2012-01-122-4/+4
| | | | | | | | | | BUG=109817 TEST=none Review URL: http://codereview.chromium.org/9168032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117401 0039d316-1c4b-4281-b951-d872f2087c98
* Convert use of int ms to TimeDelta in files owned by ananta.tedvessenes@gmail.com2012-01-121-3/+3
| | | | | | | | | | | R=ananta@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9187024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117333 0039d316-1c4b-4281-b951-d872f2087c98
* Synchronize access to TestAutomationResourceMessageFilter's requests_ map. ↵robertshield@chromium.org2012-01-112-2/+25
| | | | | | | | | | This fixes a race condition in Chrome Frame's net tests that could cause URLRequestJobs to be created and destroyed on different threads. This in turn leaks PowerObservers from SystemMonitor's observer list, resulting in an observer list full of dangling pointers. In debug mode this may eventually dcheck if heap addresses are reused. BUG=109733 TEST=chrome_frame_net_tests.exe does not DCHECK. Review URL: http://codereview.chromium.org/9158012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117263 0039d316-1c4b-4281-b951-d872f2087c98
* Move creation and ownership of ResourceDispatcherHost and PluginService to ↵jam@chromium.org2012-01-112-23/+2
| | | | | | | | | | | | | | | | content. This gives a few benefits: -avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads) -avoid having to tell embedders about specifics of BrowserThread startup/shutdown -move ResourceDispatcherHost's getter to content where it belongs I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117078 Review URL: http://codereview.chromium.org/9150016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117171 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 117078 - Move creation and ownership of ResourceDispatcherHost and ↵jam@chromium.org2012-01-102-0/+24
| | | | | | | | | | | | | | | | | | | PluginService to content. This gives a few benefits: -avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads) -avoid having to tell embedders about specifics of BrowserThread startup/shutdown -move ResourceDispatcherHost's getter to content where it belongs Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead. I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure. BUG=98716 Review URL: http://codereview.chromium.org/9150016 TBR=jam@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117096 0039d316-1c4b-4281-b951-d872f2087c98
* Move creation and ownership of ResourceDispatcherHost and PluginService to ↵jam@chromium.org2012-01-102-24/+0
| | | | | | | | | | | | | | | | | content. This gives a few benefits: -avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads) -avoid having to tell embedders about specifics of BrowserThread startup/shutdown -move ResourceDispatcherHost's getter to content where it belongs Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead. I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure. BUG=98716 Review URL: http://codereview.chromium.org/9150016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117078 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Chrome Frame test to run on Vista/IE7 at high integrity.grt@chromium.org2012-01-091-3/+11
| | | | | | | | | | | | Bypass tricks to run IE in special ways if the tests are running at high integrity. Otherwise, the medium-integrity broker exits and low-integrity IE is therefore unable to get chrome_launcher running at medium integrity. BUG=60987 TEST=no manual testing needed; chrome_frame_tests.exe will either become better or worse. Review URL: http://codereview.chromium.org/9133001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116865 0039d316-1c4b-4281-b951-d872f2087c98
* Remove task.h and finish base::Bind() migration.ajwong@chromium.org2012-01-067-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Review URL: http://codereview.chromium.org/9114020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98
* Allow crash reporting for GCF integration tests to be suppressed via command ↵grt@chromium.org2012-01-061-4/+9
| | | | | | | | | | | | | | line. This makes debugging easier for developers, since crashes will start the postmortem debugger. BUG=none TEST=none Review URL: http://codereview.chromium.org/9123008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116735 0039d316-1c4b-4281-b951-d872f2087c98
* Empty XHR posts requests fail in ChromeFrame with status code 0. The POST ↵ananta@chromium.org2012-01-061-7/+21
| | | | | | | | | | | | | | | | requests makes it across to the server which responds with a status code of 204 indicating no content. However the underlying urlmon layer calls the OnStopBinding method on the bind status callback with the E_ABORT status code. We should be reading the response codes off the binding. Fixes bug http://code.google.com/p/chromium/issues/detail?id=109335 BUG=109335 Review URL: http://codereview.chromium.org/9114022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116721 0039d316-1c4b-4281-b951-d872f2087c98
* Change over IgnoreReturn to IgnoreResult. remove IgnoreReturn.ajwong@chromium.org2012-01-066-22/+21
| | | | | | | | | BUG=98919 TEST=existing Review URL: http://codereview.chromium.org/9111032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116631 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of TabContentsWrapper::tab_contents. Also make it use WebContents ↵jam@chromium.org2012-01-061-4/+5
| | | | | | | | | exclusively. This allows updating all the creaters of TCW to not include tab_contents.h as well, and use WebContents::Create instead. BUG=98716 Review URL: http://codereview.chromium.org/9108025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116600 0039d316-1c4b-4281-b951-d872f2087c98
* Merge Chrome Frame file lists into common file lists.mmoss@chromium.org2012-01-053-14/+0
| | | | | | | | | | | | Chrome Frame is no longer a separate build configuration, so there's no need to support separate handling of the CF build output. BUG=none TEST=Buildbots still archive/process the Chrome Frame files. Review URL: http://codereview.chromium.org/9109021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116549 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FullTabSeleniumTest.Core, crashes flakily.mnissler@chromium.org2012-01-041-2/+3
| | | | | | | | | | BUG=chromium:109114 TEST=flakes go away. TBR=amit@chromium.org Review URL: http://codereview.chromium.org/9088007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116298 0039d316-1c4b-4281-b951-d872f2087c98
* And now NewRunnableMethod(), you die.ajwong@chromium.org2012-01-041-6/+1
| | | | | | | | | | | Kill off NewRunnableMethod() and remove silly declarations of unused ScopedRunnableMethodFactory(s). BUG=none TEST=existing. Review URL: http://codereview.chromium.org/9034032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116250 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling the following ChromeFrame tests which were failing because of a ↵ananta@chromium.org2012-01-043-10/+5
| | | | | | | | | | | | | | | | | crash in the Chrome renderer process in the WebKit accessibility code. The WebKit bug https://bugs.webkit.org/show_bug.cgi?id=75279 was fixed last week. KeyboardInput WidgetModeIE_InitializeHidden WidgetModeIE_ObjectFocus FormPostBackForward Core TBR=robertshield Review URL: http://codereview.chromium.org/9084001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116233 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Remove callback_old.h.jhawkins@chromium.org2012-01-031-2/+1
| | | | | | | | | | BUG=none TEST=none R=groby,awong,csilv Review URL: http://codereview.chromium.org/9028009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116169 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing Chrome Frame tests following WebKit roll, for rniwajsbell@chromium.org2011-12-233-5/+10
| | | | | | | | | BUG=108508 TEST= Review URL: http://codereview.chromium.org/9007039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115648 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Remove includes of base.bind in header files.jhawkins@chromium.org2011-12-213-32/+53
| | | | | | | | | | BUG=none TEST=none R=ajwong Review URL: http://codereview.chromium.org/8956019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115398 0039d316-1c4b-4281-b951-d872f2087c98
* Rename PluginService to PluginServiceImpl.jam@chromium.org2011-12-211-1/+0
| | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/9019004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115279 0039d316-1c4b-4281-b951-d872f2087c98
* Remove remaining references to CEEE.rogerta@chromium.org2011-12-2010-55/+31
| | | | | | | | | BUG=107739 TEST=No visible code changes. Removing constants and code related to CEEE. Review URL: http://codereview.chromium.org/8909009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115183 0039d316-1c4b-4281-b951-d872f2087c98
* Move general UiPerfTest code to shared area in preparation for performance ↵jbates@chromium.org2011-12-201-17/+14
| | | | | | | | | | | browser tests. BUG=107745 Review URL: http://codereview.chromium.org/8971004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115052 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-192-3/+7
| | | | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114944 Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114993 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114944 - Standardize StringToInt{,64} interface.battre@chromium.org2011-12-182-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Revert due to compile breakage on ChromeOS. These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Review URL: http://codereview.chromium.org/8921006 TBR=tedvessenes@gmail.com Review URL: http://codereview.chromium.org/8990002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114945 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-182-3/+7
| | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929 Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114944 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114929 - Standardize StringToInt{,64} interface.rsleevi@chromium.org2011-12-172-7/+3
| | | | | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Review URL: http://codereview.chromium.org/8921006 TBR=tedvessenes@gmail.com Review URL: http://codereview.chromium.org/8984007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114930 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize StringToInt{,64} interface.tedvessenes@gmail.com2011-12-172-3/+7
| | | | | | | | | | | | | | | | | | | These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Review URL: http://codereview.chromium.org/8921006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114929 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Chrome Frame crash when automation server dies.grt@chromium.org2011-12-172-4/+5
| | | | | | | | | | | | GCF was crashing if the automation server dies while there are outstanding sub-resource requests being serviced on the new bg thread. The reason was that AutomationServerDied posts a task to InitializeComplete(AUTOMATION_SERVER_CRASHED) and then a task to Uninitialize(). The former will call ReleaseAutomationServer() without first joining on the bg resource thread. The fix is to wait and release the server in Uninitialize. BUG=107811 TEST=Prior to fix, the following would usually trigger the crash: chrome_frame_tests.exe --gtest_repeat=20 --gtest_filter=CF/FullTabUITest.TabCrashReload/0 Review URL: http://codereview.chromium.org/8965031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114906 0039d316-1c4b-4281-b951-d872f2087c98
* chrome_frame: Include notification_service.h instead of ↵tfarina@chromium.org2011-12-161-1/+1
| | | | | | | | | | | notification_service_impl.h. BUG=98716 R=jam@chromium.org Review URL: http://codereview.chromium.org/8949017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114796 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid including gtest file directly, and go through base insteadjar@chromium.org2011-12-151-1/+1
| | | | | | | | | | | | | | | | | | We should consistently: #include "base/gtest_prod_util.h" which does the gtest include (from the right place, in a second repo, hidden in our tree). This is critical to being able to supplant the FRIEND_TEST macro, which we're experimenting with to optimize builds. r=brettw TBR=other owners (this is a trivial change) BUG=107727 Review URL: http://codereview.chromium.org/8954017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114685 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ChromeFrame net tests for IE versions 8 and below. Changes include ↵ananta@chromium.org2011-12-151-20/+8
| | | | | | | | | | | | | | | | | | | the following:- 1. Get rid of the dummy AtlModule registration in the chrome frame net test suite. This is no longer needed as there is an Atlmodule instance instantiated by the content code. 2. The TestSuite and NetTestSuite classes now provide special protected constructors which allow test instances to control whether an AtExitManager instance is created for the duration of the test. The ChromeFrame net test suite reuses the AtExitManager instance created in BrowserMain. Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435 BUG=105435 TEST=ChromeFrame net tests should now run on the builders. Review URL: http://codereview.chromium.org/8907054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114559 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114320 (broke chrome_frame_tests) - Enable ChromeFrame net tests for ↵willchan@chromium.org2011-12-141-7/+19
| | | | | | | | | | | | | | | | | | | | | | IE versions 8 and below. Changes include the following:- 1. Get rid of the dummy AtlModule registration in the net test suite. This is no longer needed as there is a module instance instantiated by the content code. 2. The test suite class now instantiates the ShadowAtExitManager class which allows nesting of AtExitManager instances. This is needed because the ChromeFrame net tests suite now calls into ContentMain which also instantiates an AtExitManager instance. Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435 BUG=105435 TEST=ChromeFrame net tests should now run on the builders. Review URL: http://codereview.chromium.org/8898026 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/8937020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114341 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ChromeFrame net tests for IE versions 8 and below. Changes include ↵ananta@chromium.org2011-12-141-19/+7
| | | | | | | | | | | | | | | | | | | the following:- 1. Get rid of the dummy AtlModule registration in the net test suite. This is no longer needed as there is a module instance instantiated by the content code. 2. The test suite class now instantiates the ShadowAtExitManager class which allows nesting of AtExitManager instances. This is needed because the ChromeFrame net tests suite now calls into ContentMain which also instantiates an AtExitManager instance. Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435 BUG=105435 TEST=ChromeFrame net tests should now run on the builders. Review URL: http://codereview.chromium.org/8898026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114320 0039d316-1c4b-4281-b951-d872f2087c98
* This goes most of the way to re-enabling chrome_frame_net_tests by making it ↵joi@chromium.org2011-12-125-224/+372
| | | | | | | | | | | | | | a content::BrowserMainParts. The tests are still disabled until we are able to test them on IE8 and older; on IE9 all tests currently pass except for a few that hang. Additionally, this makes chrome_frame_net_tests determine protocol version using the exact same version information as npchrome_frame.dll does, so that version mismatch due to the RC dependency problems we have sometimes seen should not happen any more with this test suite. While in there, I also updated the poor_mans_trybot.bat script. BUG=105435 Review URL: http://codereview.chromium.org/8894008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114080 0039d316-1c4b-4281-b951-d872f2087c98
* Removing MessageLoop::QuitTask() from chrome_frame/dcheng@chromium.org2011-12-106-10/+10
| | | | | | | | | | | | | base/task.h is going away and being replaced by base/bind.h and base/callback.h. This CL was automatically generated by sed. BUG=none TEST=none Review URL: http://codereview.chromium.org/8879033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113920 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts a commit that caused ASAN failures, and 2 dependent commits.joi@chromium.org2011-12-071-1/+1
| | | | | | | | | | | | | The primary commit was 113249, the dependents were 113261, 113263. This is a speculative revert, r113249 is by far the likeliest culprit in the blamelist of build http://build.chromium.org/p/chromium.memory/builders/ASAN%20Tests%20%282%29/builds/2325 which is where we started seeing the ASAN failures in question, will un-revert if it does not fix the problem. TBR=jhawkins@chromium.org BUG=none Review URL: http://codereview.chromium.org/8832006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113387 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome Frame test fixes for Vista/IE7.grt@chromium.org2011-12-0614-165/+258
| | | | | | | | | | | | | Write the ActiveX control from an external script in all test documents. This works around a "feature" of IE versions released between April, 2006 and April, 2008 that required the user to click on an ActiveX control to "activate" it. See http://msdn.microsoft.com/en-us/library/ms537508.aspx. I also added asserts for the copying of CFInstance and CFInstall so that the whole test aborts if the files can't be copied, since otherwise test results are bogus. BUG=60987 TEST=no manual testing needed; chrome_frame_tests.exe will either become better or worse. Review URL: http://codereview.chromium.org/8777002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113291 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert disk_cache_based_ssl_host_info.jhawkins@chromium.org2011-12-061-1/+1
| | | | | | | | | | | BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8794003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113249 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression of ContextMenuTest.CFTxtFieldPastevsevik@chromium.org2011-12-021-1/+1
| | | | | | | | TBR=kkania Review URL: http://codereview.chromium.org/8769033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112666 0039d316-1c4b-4281-b951-d872f2087c98
* Added recommended pref store on Windows.joaodasilva@chromium.org2011-12-012-5/+5
| | | | | | | | | BUG=49941 TEST=Set policies for Chromium/Chrome in a registry subkey named "Recommended". Those policies become the default values and can be overridden by the user. Review URL: http://codereview.chromium.org/8551010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112456 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in poor man's trybot.joi@chromium.org2011-11-301-1/+1
| | | | | | | | | TBR=grt@chromium.org BUG=none Review URL: http://codereview.chromium.org/8754002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112272 0039d316-1c4b-4281-b951-d872f2087c98
* Use callback_forward.h instead of callback.h where possible.erikwright@chromium.org2011-11-301-2/+1
| | | | | | | | | | | | | | | callback_forward.h will be committed separately, before this commit, and is included here only to assist in running try jobs. It will be removed before the final commit. You are asked to review this as you have OWNERS for these files. BUG=None TEST=Compiles R=ben@chromium.org Review URL: http://codereview.chromium.org/8699008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112243 0039d316-1c4b-4281-b951-d872f2087c98
* ake string_util::WriteInto() DCHECK() that the supplied |length_with_null| > ↵pkasting@chromium.org2011-11-293-3/+5
| | | | | | | | | | | | 1, meaning that the without-'\0' string is non-empty. This replaces the conditional code added recently that makes this case return NULL. It's easier to understand if it's simply an error to call WriteInto() in this case at all. Add DCHECK()s or conditionals as appropriate to callers in order to ensure this assertion holds. BUG=none TEST=none Review URL: http://codereview.chromium.org/8418034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112005 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111910 - Attempt to re-enable ChromeFrame net tests.joi@chromium.org2011-11-291-2/+4
| | | | | | | | | | | | | | Partial revert of r111705. TBR=robertshield@chromium.org BUG=105435 Review URL: http://codereview.chromium.org/8728027 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/8726032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111914 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to re-enable ChromeFrame net tests.joi@chromium.org2011-11-291-4/+2
| | | | | | | | | | | Partial revert of r111705. TBR=robertshield@chromium.org BUG=105435 Review URL: http://codereview.chromium.org/8728027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111910 0039d316-1c4b-4281-b951-d872f2087c98
* Have content/ create and destroy its own threads. (Re-land)joi@chromium.org2011-11-283-12/+44
| | | | | | | | | | | | | | | | | | | Change embedding API and embedders to allow for this. Push inheritance of base::Thread down to content::BrowserThreadImpl so that content::BrowserThread is just a namespace for API functions. This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435. TBR=ben@chromium.org (IWYU change only) BUG=98716,104578,105435 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111695 Reverted (problems on official bot): r111698 Review URL: http://codereview.chromium.org/8477004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111705 0039d316-1c4b-4281-b951-d872f2087c98
* Update poor man's trybot script.joi@chromium.org2011-11-281-11/+20
| | | | | | | | | | | | | | It will now work with new paths, build/Debug etc. An addition of a couple of optional parameters allows for both push and pull modes of operation, i.e. the script may be run on either the VM or the dev machine. BUG=none Review URL: http://codereview.chromium.org/8706001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111700 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111695 - Have content/ create and destroy its own threads.joi@chromium.org2011-11-283-44/+12
| | | | | | | | | | | | | | | | | | | | | Reason: Problems on official builders. Change embedding API and embedders to allow for this. Push inheritance of base::Thread down to content::BrowserThreadImpl so that content::BrowserThread is just a namespace for API functions. This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435. TBR=ben@chromium.org (IWYU change only) BUG=98716,104578,105435 Review URL: http://codereview.chromium.org/8477004 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/8718012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111698 0039d316-1c4b-4281-b951-d872f2087c98
* Have content/ create and destroy its own threads.joi@chromium.org2011-11-283-12/+44
| | | | | | | | | | | | | | | | Change embedding API and embedders to allow for this. Push inheritance of base::Thread down to content::BrowserThreadImpl so that content::BrowserThread is just a namespace for API functions. This change temporarily disables chrome_frame_net_tests as agreed by the CF lead, see bug 105435. TBR=ben@chromium.org (IWYU change only) BUG=98716,104578,105435 Review URL: http://codereview.chromium.org/8477004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111695 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 06:37:00 +0000