summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Rename "mixed content" to "insecure content" in as many places as possible, ↵pkasting@chromium.org2010-05-182-8/+8
| | | | | | | | | | to standardize on a consistent naming scheme. BUG=none TEST=none Review URL: http://codereview.chromium.org/2069005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47531 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this fix with the fixes to get chrome frame tests to pass.ananta@chromium.org2010-05-188-153/+254
| | | | | | | | | | | | | | | | | | | | | | | | | | | In ChromeFrame the ChromeFrameAutomationProxy object is created on the background proxy channel thread and is accessed from the UI thread, the proxy channel thread and the IPC thread. This leads to a race condition when ChromeFrame is being torn down which occurs because the ChromeFrameAutomationProxy pointer is being set to NULL in the UI thread/deleted in the proxy background thread while it could be accessed while processing a callback in the IPC thread thus causing a crash. Fix is to ensure that the IPC thread does not access the ChromeFrameAutomationProxy pointer. To achieve this the callbacks are now individual context objects which when invoked forward the actions to the ChromeFrameAutomationClient object. The CreateExternalTab and ConnectExternalTab callbacks now complete their actions on the UI thread. While at this based on a discussion and lot of help from Stoyan we decided to clean up the sync message dispatching code used by ChromeFrame by having callbacks now derive from a SyncMessageCallContext class to ensure that these get cleaned up correctly in all cases. For e.g. if we don't receive a response for a message, etc and thus enable them to present a consistent interface to be invoked when we receive a response for a IPc message. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44245 Bug=44245 TBR=stoyan Review URL: http://codereview.chromium.org/2119004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47494 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47453 - In ChromeFrame the ChromeFrameAutomationProxy object is ↵ananta@chromium.org2010-05-175-219/+145
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | created on the background proxy channel thread and is accessed from the UI thread, the proxy channel thread and the IPC thread. This leads to a race condition when ChromeFrame is being torn down which occurs because the ChromeFrameAutomationProxy pointer is being set to NULL in the UI thread/deleted in the proxy background thread while it could be accessed while processing a callback in the IPC thread thus causing a crash. Fix is to ensure that the IPC thread does not access the ChromeFrameAutomationProxy pointer. To achieve this the callbacks are now individual context objects which when invoked forward the actions to the ChromeFrameAutomationClient object. The CreateExternalTab and ConnectExternalTab callbacks now complete their actions on the UI thread. While at this based on a discussion and lot of help from Stoyan we decided to clean up the sync message dispatching code used by ChromeFrame by having callbacks now derive from a SyncMessageCallContext class to ensure that these get cleaned up correctly in all cases. For e.g. if we don't receive a response for a message, etc and thus enable them to present a consistent interface to be invoked when we receive a response for a IPc message. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44245 Bug=44245 Review URL: http://codereview.chromium.org/2073007 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/2110006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47461 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame the ChromeFrameAutomationProxy object is created on the ↵ananta@chromium.org2010-05-175-145/+219
| | | | | | | | | | | | | | | | | | | | | | | | | | background proxy channel thread and is accessed from the UI thread, the proxy channel thread and the IPC thread. This leads to a race condition when ChromeFrame is being torn down which occurs because the ChromeFrameAutomationProxy pointer is being set to NULL in the UI thread/deleted in the proxy background thread while it could be accessed while processing a callback in the IPC thread thus causing a crash. Fix is to ensure that the IPC thread does not access the ChromeFrameAutomationProxy pointer. To achieve this the callbacks are now individual context objects which when invoked forward the actions to the ChromeFrameAutomationClient object. The CreateExternalTab and ConnectExternalTab callbacks now complete their actions on the UI thread. While at this based on a discussion and lot of help from Stoyan we decided to clean up the sync message dispatching code used by ChromeFrame by having callbacks now derive from a SyncMessageCallContext class to ensure that these get cleaned up correctly in all cases. For e.g. if we don't receive a response for a message, etc and thus enable them to present a consistent interface to be invoked when we receive a response for a IPc message. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44245 Bug=44245 Review URL: http://codereview.chromium.org/2073007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47453 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r47347 [was reverted in r47357], this time without re-enabling a ↵pkasting@chromium.org2010-05-171-4/+6
| | | | | | | | | | | | | | | | | | | | | DISABLED test that times out on Mac. (Original patch reviewed at http://codereview.chromium.org/2067003 ) Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken". Make the "display" state only affect the current tab (not the entire host). Fix an SSL browser test by supplying the appropriate SiteInstance*. Move a test from "disabled" to "flaky" since it at least passes for me. Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner. BUG=15072, 18626, 40932, 42758 TEST=Covered by browser tests Review URL: http://codereview.chromium.org/2063008 Review URL: http://codereview.chromium.org/2126005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47428 0039d316-1c4b-4281-b951-d872f2087c98
* Perform breakpad shutdown when returning from the chrome launcher entry ↵robertshield@chromium.org2010-05-172-5/+12
| | | | | | | | | | | point. This is a to avoid the deadlock that occurs when shutting it down in DllMain in chrome_launcher.exe. BUG=44212 TEST=chrome_launcher.exe stops hanging Review URL: http://codereview.chromium.org/2094006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47422 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47347 - (Original patch reviewed at ↵rvargas@google.com2010-05-151-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/2067003 ) Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken". Make the "display" state only affect the current tab (not the entire host). Fix an SSL browser test by supplying the appropriate SiteInstance*. Move a test from "disabled" to "flaky" since it at least passes for me. Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner. Falied TestGoodFrameNavigation on Mac 10.5 browser tests among other things: /b/slave/chromium-rel-mac-builder/build/src/chrome/browser/ssl/ssl_browser_tests.cc:43: Failure Value of: entry->ssl().displayed_mixed_content() Actual: false Expected: displayed_mixed_content Which is: true BUG=15072, 18626, 40932, 42758 TEST=Covered by browser tests Review URL: http://codereview.chromium.org/2063008 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/2095006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47357 0039d316-1c4b-4281-b951-d872f2087c98
* (Original patch reviewed at http://codereview.chromium.org/2067003 )pkasting@chromium.org2010-05-151-4/+6
| | | | | | | | | | | | | | | | | | Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken". Make the "display" state only affect the current tab (not the entire host). Fix an SSL browser test by supplying the appropriate SiteInstance*. Move a test from "disabled" to "flaky" since it at least passes for me. Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner. BUG=15072, 18626, 40932, 42758 TEST=Covered by browser tests Review URL: http://codereview.chromium.org/2063008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47347 0039d316-1c4b-4281-b951-d872f2087c98
* Create first tests for verifying that Chrome Frame does not interfere with ↵kkania@chromium.org2010-05-148-69/+256
| | | | | | | | | | normal IE operation. BUG=none TEST=none Review URL: http://codereview.chromium.org/1992018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47336 0039d316-1c4b-4281-b951-d872f2087c98
* Candidate fix for bug 44108. The FromBindContext function was inherently ↵tommi@chromium.org2010-05-149-54/+89
| | | | | | | | | | | | | racy as it returned a pointer to a non-addrefed pointer and the AddRef/Release implementation in the BindContextInfo was not thread safe. Also fixed BSCBStorageBind object leak. TEST=See bug description BUG=44108 Review URL: http://codereview.chromium.org/2080005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47306 0039d316-1c4b-4281-b951-d872f2087c98
* Not using std::wstring to store progress status text because mshtml is ↵tommi@chromium.org2010-05-142-14/+65
| | | | | | | | | | | sensitive to NULL vs L"". TEST=see bug BUG=44103 Review URL: http://codereview.chromium.org/2118001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47232 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the chrome frame context menu back forward test which regressed in ↵ananta@chromium.org2010-05-144-15/+34
| | | | | | | | | | | | | | | | | revision 47187 due to a change in the context menu resource ids. Solution is to include the chrome_dll_resources.h file in a way to reduce conflicts with existing chrome frame resources. We have two new files chrome_imported_resources.cc/.h to achieve that. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44134 Bug=44134 Review URL: http://codereview.chromium.org/2067006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47223 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit test breakage in last change.amit@chromium.org2010-05-132-3/+5
| | | | | | | | | | | | | | | Instead of returning E_FAIL from IStream::Read when there is no valid cache to serve content from, confirm tp the IStream Read contract and return S_FALSE with 0 bytes. TBR=stoyan TEST=MonikerPatchTest.CacheStream Review URL: http://codereview.chromium.org/2114001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47189 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in CacheStream::Readamit@chromium.org2010-05-132-10/+23
| | | | | | | | | | | | Fix incorrect assumption that the Read of CacheStream will happen in the context of IBindStatusCallback::OnDataAvailable notification. TEST=none BUG=43949 Review URL: http://codereview.chromium.org/2007009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47184 0039d316-1c4b-4281-b951-d872f2087c98
* Use an interface to get to the C++ object pointer instead of casting directly.tommi@chromium.org2010-05-132-9/+68
| | | | | | | | | | | The object was being marshalled so, we were casting an ole32 proxy object to our implementation. To avoid marshalling altogether I'm also using the FTM. So, yeah, we're going belt and suspenders. TEST=See bug. BUG=43988 Review URL: http://codereview.chromium.org/2011016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47160 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ChromeFrame regression introduced by the fix for bug ↵ananta@chromium.org2010-05-131-0/+4
| | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=43922. The active document url was not being updated when we receive the navigation state from chrome. This caused a couple of chrome frame tests to fail. Bug=43922 TBR=amit Review URL: http://codereview.chromium.org/2052011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47113 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this as a number of tests have been failing on all builders ever ↵ananta@chromium.org2010-05-134-109/+5
| | | | | | | | | | | | | | | | since. Please look into this and resubmit. Revert 47065 - An attempt to catch unexpected script errors in html test pages in a more generic way. TEST=This is meant to help track down flakiness of a few tests. BUG=none Review URL: http://codereview.chromium.org/2052006 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/2011017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47099 0039d316-1c4b-4281-b951-d872f2087c98
* The chrome frame net tests would not complete at times on the IE6 builder. ↵ananta@chromium.org2010-05-121-1/+11
| | | | | | | | | | | | | | This was due to a regression introduced recently where we removed the chrome frame stream cache from the urlmon request object and instead cached the stream passed in. While this was all fine, we failed to handle the case where an attempt to read from this stream in response to a read request from chrome returned S_FALSE which means end of data, in which case we should release the stream. Not doing this caused us to not send over the end request notification to chrome, thus causing the tests to indefinitely wait. Review URL: http://codereview.chromium.org/2001019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47093 0039d316-1c4b-4281-b951-d872f2087c98
* In ChromeFrame's bind status callback functions we should always return ↵ananta@chromium.org2010-05-121-1/+6
| | | | | | | | | | | | success regardless of whether we have a valid delegate or not. Bug=43927 Review URL: http://codereview.chromium.org/2030009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47088 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame would not switch to Chrome at times. The navigation manager in ↵ananta@chromium.org2010-05-123-12/+2
| | | | | | | | | | | | | | | | | | | | | | ChromeFrame maintains the current top level URL which is used by the moniker patch to decide whether to wrap the callback. This url is typically set in the Bho in the BeforeNavigate callback. We also had code to update this url when we receive a navigation update from Chrome. The reason we would not switch is because of a race condition between receiving a top level navigation request from chrome and receiving a navigation update for the previous operation which caused us to not wrap the bind status callback. Fix is to not update the url in the callback when we receive a navigation status update. In any case it is Chrome's responsibility to inform ChromeFrame about top level url navigations. We should fix the bug if any in Chrome which caused this hack to go in. Fixes bug http://code.google.com/p/chromium/issues/detail?id=43922 Other changes are to replace the NOTREACHED in the chrome frame automation proxy code with a DLOG as this fires during chrome frame test runs. Bug=43922 Review URL: http://codereview.chromium.org/1991008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47086 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a chrome frame crash reported on the crash server in our bind status ↵ananta@chromium.org2010-05-121-0/+5
| | | | | | | | | | | | | | | | callback OnResponse implementation. Crash occurs while dereferencing a NULL delegate. Fix is to add a check for the same. This could happen if the binding was stopped before receiving the OnResponse notification. Fixes bug http://code.google.com/p/chromium/issues/detail?id=43927 Bug=43927 Review URL: http://codereview.chromium.org/2060002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47085 0039d316-1c4b-4281-b951-d872f2087c98
* An attempt to catch unexpected script errors in html test pages in a more ↵tommi@chromium.org2010-05-124-5/+109
| | | | | | | | | | | generic way. TEST=This is meant to help track down flakiness of a few tests. BUG=none Review URL: http://codereview.chromium.org/2052006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47065 0039d316-1c4b-4281-b951-d872f2087c98
* Http Cache: Add a backend factory class so that the callerrvargas@google.com2010-05-121-1/+1
| | | | | | | | | | | | has more control about the backend instantiation. BUG=none TEST=current unit tests. Review URL: http://codereview.chromium.org/2000011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47050 0039d316-1c4b-4281-b951-d872f2087c98
* Catch and report an exception that I saw in the ↵tommi@chromium.org2010-05-101-3/+9
| | | | | | | | | | | | WidgetModeIE_InitializeHidden test on the IE6 bot to avoid a hang issue. Alex is already working on a proper fix. TEST=n/a BUG=none TBR=slightlyoff Review URL: http://codereview.chromium.org/2013014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46857 0039d316-1c4b-4281-b951-d872f2087c98
* Adding error handling to DeleteCookie test.tommi@chromium.org2010-05-101-13/+16
| | | | | | | | | | TEST=none TBR=ananta BUG=none Review URL: http://codereview.chromium.org/2000007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46851 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Add a bunch of missing includes.thestig@chromium.org2010-05-102-3/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2018001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46850 0039d316-1c4b-4281-b951-d872f2087c98
* Add more diagnostics to the SrcProperty test.tommi@chromium.org2010-05-101-23/+27
| | | | | | | | | | TEST=none BUG=none TBR=slightlyoff Review URL: http://codereview.chromium.org/1997012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46835 0039d316-1c4b-4281-b951-d872f2087c98
* Instrument Chrome and Chrome Frame for some perf measurements.siggi@chromium.org2010-05-103-0/+17
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1989005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46812 0039d316-1c4b-4281-b951-d872f2087c98
* Utility bat file to make it easy to build and run smoke tests.siggi@chromium.org2010-05-102-0/+107
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46811 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare the default profile and turn off some services before initializing ↵tommi@chromium.org2010-05-101-3/+4
| | | | | | | | | | | | extensions. TEST=This is an attempt to reduce flakiness of Chrome Frame net tests. BUG=none TBR=ananta Review URL: http://codereview.chromium.org/2051004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46807 0039d316-1c4b-4281-b951-d872f2087c98
* This change consists of the previous change in addition to a fix for the ↵tommi@chromium.org2010-05-083-336/+191
| | | | | | | | | | | | | | | | | | download issue. See also: http://codereview.chromium.org/1718025 (initial change) http://codereview.chromium.org/1829001 (fix for Head test) http://codereview.chromium.org/1887001 (fix for download issue) TEST=Monitor the Chrome Frame IE6 build bot for flakiness. Particularly the net tests. BUG=none Review URL: http://codereview.chromium.org/1821001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46790 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt to reduce the number of false positive crashes reported in ↵ananta@chromium.org2010-05-072-8/+17
| | | | | | | | | | | | | | | | | | ChromeFrame. There appear to be a number of crashes caused when we wrap the bind status callback and call the underlying IMoniker::BindToStorage function. The crashes occur because of urlmon calling into dlls which have been unloaded. Fix is to use the exception barrier version which only reports crashes which occur directly in chrome frame in our BindtoStorage call and to use the generic ExceptionBarrier in our bind status callback wrapper before calling out to the underlying callback. Fixes bug http://code.google.com/p/chromium/issues/detail?id=43373 Bug=43373 Review URL: http://codereview.chromium.org/2002009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46742 0039d316-1c4b-4281-b951-d872f2087c98
* Change to a simpler upgrade scheme for Chrome Frame whereby we register a ↵robertshield@chromium.org2010-05-075-405/+90
| | | | | | | | | | | window class in DllMain on attach and tag it with our module handle, then unregister said window class on detach. BUG=43343 Review URL: http://codereview.chromium.org/1994007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46738 0039d316-1c4b-4281-b951-d872f2087c98
* Committing for jeffbailey.mad@google.com2010-05-073-92/+54
| | | | | | | | | | | | | | | | | Excerpt from: http://codereview.chromium.org/1991004/show ---------------- Put version information into header file for easy consumption by RC files. RC files can use an #include to pull in this header, rather than being each dynamically generated. BUG=none TEST=none ---------------- Review URL: http://codereview.chromium.org/2020003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46736 0039d316-1c4b-4281-b951-d872f2087c98
* Cache progress notifications only if necessaryamit@chromium.org2010-05-072-8/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | We cache and suppress sending progress notifications till we get the first OnDataAvailable. This is to prevent mshtml from making up its mind about the mime type. However, this is the invasive part of the patch and could trip other software that's due to mistimed progress notifications. It is probably not good to hide redirect and some cookie notifications. We only need to suppress data notifications like BINDSTATUS_MIMETYPEAVAILABLE, BINDSTATUS_CACHEFILENAMEAVAILABLE etc. This is an atempt to reduce the exposure by starting to cache only when we receive one of the interesting progress notification. BUG=42611 TEST=none Review URL: http://codereview.chromium.org/2046003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46715 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame builder at times hang if the security dialog brought up by ↵ananta@chromium.org2010-05-071-1/+1
| | | | | | | | | | | | | | | the NavigateToRestrictedSite test is behind the console window. Fix is to not attempt to close the dialog by clicking on it. We now close the window by the DoClosewindow helper which posts the WM_CLOSE message to it. TBR=amit Review URL: http://codereview.chromium.org/2041003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46688 0039d316-1c4b-4281-b951-d872f2087c98
* Add ExceptionBarrier to module scanning in the hope of reducing some false ↵robertshield@chromium.org2010-05-071-10/+22
| | | | | | | | | | positives. BUG=43343 Review URL: http://codereview.chromium.org/2024003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46683 0039d316-1c4b-4281-b951-d872f2087c98
* Remove/update a bunch of references to the Google-internal bug tracker.evan@chromium.org2010-05-071-1/+2
| | | | | | | | | | Many of our references turn out to just be context for a given workaround, e.g. "Set the foobar here because the destructor dereferences it, see http://private-bug-url". Review URL: http://codereview.chromium.org/2004004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46645 0039d316-1c4b-4281-b951-d872f2087c98
* Opening new chrome frame tabs would fail randomly. This was because of a ↵ananta@chromium.org2010-05-071-0/+3
| | | | | | | | | | | | | | | | | | | race condition between processing the connect external tab ack in chrome frame and receiving requests for the tab. As a result the new tabs would not render anything. Fix is to resume the pending views in the OnReinitialize task in the ExternalTabContainer. I also added a NOTREACHED when we fail to find the TabProxy for a tab handle in the chrome frame automation code to help catch future instances of this issue. Fixes bug http://code.google.com/p/chromium/issues/detail?id=43376 Bug=43376 Review URL: http://codereview.chromium.org/2011006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46643 0039d316-1c4b-4281-b951-d872f2087c98
* Do not wrap the original callback if we can;t initialize sniffing cacheamit@chromium.org2010-05-053-16/+20
| | | | | | | | | | | | | | | | CreateStreamOnHGlobal may fail if the underlying GlobalAlloc fails. It has a strange behavaior where if we pass in an HGlobal, it can create more streams per process. So the fix is to: 1. not register us as a bind status callback if we cannot create a stream for sniffing data and 2. When initializing the data sniffing stream pre-create a HGlobal BUG=To be filed TEST=none Review URL: http://codereview.chromium.org/1983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46525 0039d316-1c4b-4281-b951-d872f2087c98
* Cookies would not get set correctly in ChromeFrame in full tab mode. The ↵ananta@chromium.org2010-05-054-26/+85
| | | | | | | | | | | | | | | code to set cookies in IE incorrectly parses the cookies into name value pairs. In this scenario we end up with an empty name string which causes cookies to not get set correctly. It appears that an empty name string is not treated on the same lines as NULL. In any case we should not be doing any parsing and should just set the cookie as is. This fixes bug http://code.google.com/p/chromium/issues/detail?id=42818. Added a unit test to validate this case. Bug=42818 Review URL: http://codereview.chromium.org/1917005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46523 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a chrome frame crash reported on the crash server. This occurs while ↵ananta@chromium.org2010-05-051-1/+1
| | | | | | | | | | | | | | | | | attempting to reuse an existing automation client from a cached document. It appears that there are cases where the automation client in the cached document can be NULL. Will work on a better way to cache automation client on trunk. Fixes bug http://code.google.com/p/chromium/issues/detail?id=43255 Bug=43255 Review URL: http://codereview.chromium.org/1964002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46499 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a chrome frame crash reported on the crash server. The crash occurs in ↵ananta@chromium.org2010-05-051-5/+1
| | | | | | | | | | | | | | the call to the UrlMkSetSessionOption API to refresh the user agent from the registry. This is not needed anymore as we set the user agent in the outgoing http requests anyway. This fixes bug http://code.google.com/p/chromium/issues/detail?id=43340 Bug=43340 Review URL: http://codereview.chromium.org/1968004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46498 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up suppressing error dialogs for buildbots.phajdan.jr@chromium.org2010-05-041-1/+3
| | | | | | | | | | | | - also suppress dialogs caused by __debugbreak on Windows - avoid bad interactions with gtest (they cause odd problems, really) TEST=none BUG=29997 Review URL: http://codereview.chromium.org/1867001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46343 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to fix the IE6 builder redness. Please continue debugging this and ↵ananta@chromium.org2010-05-043-163/+329
| | | | | | | | | | | | | | | | | resubmit. Revert 46188 - Not using an intermediate cache between urlmon and chrome reads. Instead we hang on to stream objects from urlmon and read from them when chrome asks for data. TEST=Run all tests verify that sites like wave and vimeo work correctly etc. BUG=none Review URL: http://codereview.chromium.org/1718025 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/1928001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46324 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to fix the IE6 builder redness. Please continue debugging this and ↵ananta@chromium.org2010-05-042-3/+4
| | | | | | | | | | | | | | | | resubmit. Revert 46189 - Temporarily disable the Head test. TBR=amit BUG=none Review URL: http://codereview.chromium.org/1828001 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/1927001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46323 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting to fix the IE6 builder redness. Please continue debugging this and ↵ananta@chromium.org2010-05-042-13/+8
| | | | | | | | | | | | | | | | | resubmit. Revert 46190 - Reenable the Head test. TEST=Fixes the UrlRequest Head test BUG=none TBR=amit Review URL: http://codereview.chromium.org/1829001 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/1901002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46321 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the flakiness associated with the ChromeFrame ↵ananta@chromium.org2010-05-032-9/+28
| | | | | | | | | | | | | FullTabModeIE_TestMultipleGet and FullTabModeIE_TestPostReissue tests. These tests expect the last request received to be /quit?OK. However at times it appears that we receive an additional accept request which ends up failing this test. Fix is to add a custom function which returns the request associated with a path. Changed the expectations accordingly. Review URL: http://codereview.chromium.org/1903001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46298 0039d316-1c4b-4281-b951-d872f2087c98
* Add a delay load specifier for prntvpt.dll for chrome_frame_net_tests.ananta@chromium.org2010-05-031-0/+5
| | | | | | | | TBR=tommi Review URL: http://codereview.chromium.org/1850002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46255 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to address code review comments from tommi from CL ↵ananta@chromium.org2010-05-025-20/+7
| | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/1823001/show Changes include the following:- 1. Removing the IObjectWithSite::SetSite implementation from the chrome frame activex. 2. Removing the site_ member and using the ATL m_spUnkSite member. 3. Renaming the RegisterBHOIfNeeded member function to registerBhoIfNeeded to be consistent with the other methods in the IChromeFrame interface. Fixes bug http://code.google.com/p/chromium/issues/detail?id=42790 Bug=42790 TBR=tommi Review URL: http://codereview.chromium.org/1831001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46200 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 20:15:42 +0000