summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Move base/thread.h to base/threading, fix up callers to use the new location.brettw@chromium.org2011-01-0111-19/+21
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6028009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70345 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/win_util to app/win and fix the namespace usage.brettw@google.com2010-12-312-8/+8
| | | | | | | | | | | | | | Split out the two classes: ScopedComInitializer and ScopedCOMem (which I renamed) to separate files. I removed the win_util_path file which had one function in it and moved the function to win_util. Somehow, this was getting picked up by the nacl64 build and the call in sandbox_policy was then not being defined. I just implemented the function in-plcae since it's just a simple wrapper around a Windows API call. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6013009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70343 0039d316-1c4b-4281-b951-d872f2087c98
* Move platform_thread to base/threading and put in the base namespace. I left abrettw@chromium.org2010-12-3110-61/+67
| | | | | | | | | | | stub and "using" declarations in the old location to avoid having to change the entire project at once. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6001010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70342 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/win_util to the base/win directory and use the base::win namespace.brettw@google.com2010-12-316-12/+10
| | | | | | | | | Fix up includes, many files including base/win_util don't actually need it. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70341 0039d316-1c4b-4281-b951-d872f2087c98
* Move thread local stuff from base to base/threading and consistently use thebrettw@chromium.org2010-12-306-10/+9
| | | | | | | | | | | base namespace. This also fixes references to TLSSlot to base::ThreadLocalStorage::Slot. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5986012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70322 0039d316-1c4b-4281-b951-d872f2087c98
* Remove win_util::FormatMessage and FormatLastWin32Error. These were only ↵brettw@google.com2010-12-301-1/+1
| | | | | | | | | | | | | | used in a couple of diagnostic places and one can always use the "Error Lookup" utility. Move window HWND-specific functions from base/win_util.h to a new file app/win/hwnd_util.h. I plan to put some more stuff from app/win_util into this file as well. Move gfx/window_impl.h into app/win TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6019007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70312 0039d316-1c4b-4281-b951-d872f2087c98
* Don't build using GPO for the tests EXEs we build duringnsylvain@chromium.org2010-12-271-0/+11
| | | | | | | | | our official build. BUG=none Review URL: http://codereview.chromium.org/6034011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70195 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for the chrome frame npapi test failures seen on the builders. These ↵ananta@chromium.org2010-12-252-15/+11
| | | | | | | | | | | | | | failures occurred after the change to clean up chrome frame automation code. BUG=none TEST=ChromeFrame firefox tests should pass. TBR=jam Review URL: http://codereview.chromium.org/6055008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70172 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break, againjam@chromium.org2010-12-241-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70147 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70144 and 70145 and add a build fix.jam@chromium.org2010-12-242-6/+8
| | | | | | | TBR=gfeher Review URL: http://codereview.chromium.org/5959006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70146 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70141 - Make a few more places use bool for OnMessageReceived.gfeher@chromium.org2010-12-242-6/+5
| | | | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/6005006 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/6094002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70145 0039d316-1c4b-4281-b951-d872f2087c98
* Make a few more places use bool for OnMessageReceived.jam@chromium.org2010-12-242-5/+6
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/6005006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70141 0039d316-1c4b-4281-b951-d872f2087c98
* Make IPC::Channel::Listener:OnMessageReceived have a return value indicating ↵jam@chromium.org2010-12-2410-17/+23
| | | | | | | | | whether a message was processed or not. TBR=brettw Review URL: http://codereview.chromium.org/5978003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70139 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath::BaseName instead of the deprecated ↵tfarina@chromium.org2010-12-241-1/+1
| | | | | | | | | | | file_util::GetFilenameFromPath. Part 2. BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/6091006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70128 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up Automation and Chrome Frame IPC code.-only use routed messages when ↵jam@chromium.org2010-12-2328-802/+336
| | | | | | | | needed-use routing IDs to avoid manually unpacking messages-remove data structures from IPC namespace (that should only be used for IPC code, and param traits)Note that I temporarily commented out part of a test in external_tab_test.cc because I couldn't figure out how to get the updated gmock macros to compile. Review URL: http://codereview.chromium.org/5998006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70105 0039d316-1c4b-4281-b951-d872f2087c98
* base/version: remove wstring versionevan@chromium.org2010-12-231-1/+2
| | | | | | | | | | | And fix callers. BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/5848005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70098 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68944 - Revert "Add named testing interface."nirnimesh@chromium.org2010-12-235-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting the revert of named interface CL. Followup CL which addresses Pawel's comments is up at http://codereview.chromium.org/5967003/ http://src.chromium.org/viewvc/chrome?view=rev&revision=67300 The change has been approved conditionally, i.e. if the outstanding review comments are handled in a follow-up as the top priority. Two weeks have passed, and I have not seen the follow-up. It is risky to keep this change in the tree, as it is already non-trivial to revert. Conflicts: chrome/browser/automation/automation_provider.cc chrome/test/ui/named_interface_uitest.cc ipc/ipc_channel_posix.cc TBR=nirnimesh BUG=chromium-os:8512 TEST=none Review URL: http://codereview.chromium.org/5707006 TBR=phajdan.jr@chromium.org BUG=chromium-os:8512 TEST=ui_tests --gtest_filter=NamedInterfaceTest.FLAKY_BasicNamedInterface Review URL: http://codereview.chromium.org/6012006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70089 0039d316-1c4b-4281-b951-d872f2087c98
* Update file version info/memory details/process utils to use string16.avi@chromium.org2010-12-233-3/+4
| | | | | | | | | BUG=23581 TEST=everything still works Review URL: http://codereview.chromium.org/5968008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70071 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that chrome frame tests don't hang indefinitely if IE does not ↵ananta@chromium.org2010-12-226-34/+191
| | | | | | | | | | | | | | | | | | | | | respond to outgoing COM calls issued by these tests. These tests hang intermittently on the IE9 builder on the experimental waterfall. To achieve this we register a COM message filter and set a windows timer in the ChromeFrame TimedMsgLoop object. In the message filter we look for a WM_TIMER created by the message loop object and on finding it abort the outgoing COM call. This flag is percolated to the related event sinks which leak the underlying interfaces to prevent the Release calls from hanging too. BUG=none TEST=none Review URL: http://codereview.chromium.org/6051003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69901 0039d316-1c4b-4281-b951-d872f2087c98
* Create a message filter for message port and worker messages. This allows a ↵jam@chromium.org2010-12-211-6/+6
| | | | | | | | nice cleanup of getting rid of the notifications when RenderMessageFilter and WorkerProcessHost go away. SafeBrowsingResourceHandler doesn't need it anymore as well, since it now overrides OnRequestClosed() which does the same thing. Review URL: http://codereview.chromium.org/6055002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69862 0039d316-1c4b-4281-b951-d872f2087c98
* ceee: Include base/win/scope_comptr.h instead of base/scoped_comptr_win.htfarina@chromium.org2010-12-211-2/+3
| | | | | | | | | | | Also add base::win:: to ScopedComPtr where necessary. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6063001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69775 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the chrome frame net test failures on the try server. A ↵ananta@chromium.org2010-12-191-1/+8
| | | | | | | | | | | | | | | | | | DCHECK indicating that the RegisterDragDrop API which registers the drop target as part of the chrome widget initialization fails with E_OUTOFMEMORY. Reason the chrome frame net tests were using CoInitializeEx to initialize the COM apartment. As per docs we need to call OleInitialize. BUG=none TEST=chrome frame net tests should pass on the try server. TBR=amit Review URL: http://codereview.chromium.org/6026003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69688 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69592 - file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-182-13/+18
| | | | | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 TBR=dmaclach@chromium.org Review URL: http://codereview.chromium.org/6017003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69601 0039d316-1c4b-4281-b951-d872f2087c98
* file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-182-18/+13
| | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69592 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeFrame BeginningTransaction unit test failures which validate ↵ananta@chromium.org2010-12-181-1/+1
| | | | | | | | | | | | | | | | | | | the HttpNegotiate patch. On IE6/7/8 the chrome frame user agent is added to the ua section in the registry. This causes the test matcher to fail as the actual UA string contains the string chromeframe followed by the version of the dll. Fix is to reduce the scope of the matcher to just look for the string chromeframe. BUG=none TEST=Covered by existing chrome frame BeginningTransaction test. TBR=amit Review URL: http://codereview.chromium.org/6045001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69591 0039d316-1c4b-4281-b951-d872f2087c98
* Restore the IHttpNegotiate patch in ChromeFrame for IE9 which sends the ↵ananta@chromium.org2010-12-175-3/+300
| | | | | | | | | | | | | | | short UA string by default without the Post Platform values which we rely on. This reverts back to the old behavior for IE9 with the bug that certain top level requests like Refresh on a page rendered in IE will be sent out with the UA string without the chrome frame suffix. BUG=45087 TEST=Covered by old http negotiate unit test. Review URL: http://codereview.chromium.org/5957001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69586 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a false positive crasher in chrome frame in version 8.0.552.224. ↵ananta@chromium.org2010-12-171-0/+6
| | | | | | | | | | | | | The crash happens in the IInternetProtocol::UnlockRequest patch. BUG=67264 TEST=none Review URL: http://codereview.chromium.org/5895004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69582 0039d316-1c4b-4281-b951-d872f2087c98
* Stop upload thread when stopping service. Leaked thread may crash process ↵vitalybuka@chromium.org2010-12-171-4/+10
| | | | | | | | | | | | on exit. BUG=64388 TEST=none Review URL: http://codereview.chromium.org/5845004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69516 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69490 - base/version: remove wstring versionsanjeevr@chromium.org2010-12-171-2/+1
| | | | | | | | | | | | | | And fix callers. BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/5848005 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/5905006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69491 0039d316-1c4b-4281-b951-d872f2087c98
* base/version: remove wstring versionevan@chromium.org2010-12-171-1/+2
| | | | | | | | | | | And fix callers. BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/5848005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69490 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ChromeFrame UA in the post platform section in the IE user agent ↵ananta@chromium.org2010-12-169-308/+116
| | | | | | | | | | | | | | | | | | | | | | | | | | string. To achieve this we need to add the desired value in the registry under the Internet Settings\User Agent\Post Platform key. We add this under the per user or per machine section in the registry depending on whether ChromeFrame is being installed in per user or per machine mode. This fixes the bug where certain top level requests in IE would not have the chrome frame UA appended to the IE UA. Removed the BeginningTransaction vtable patch code, which only existed to add chrome frame to the UA in outgoing requests. The limitation with registering the chrome frame UA in the registry is that it will be sent out even in the ChromeFrame BHO is disabled. Fixes bug http://code.google.com/p/chromium/issues/detail?id=45087 BUG=45087 TESt=Covered by new chrome frame test. Review URL: http://codereview.chromium.org/5831002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69442 0039d316-1c4b-4281-b951-d872f2087c98
* Installer cleanupamit@chromium.org2010-12-161-6/+4
| | | | | | | | | | | | | 1] Remove installer::version and use base::version in installer 2] Use file_util::FileEnumerator instead of calling FindFirstFile directly BUG=none TEST=covered by existing tests Review URL: http://codereview.chromium.org/5687004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69433 0039d316-1c4b-4281-b951-d872f2087c98
* Cache certificate verification results in memory.wtc@google.com2010-12-162-1/+10
| | | | | | | | | R=agl BUG=63357 TEST=none Review URL: http://codereview.chromium.org/5386001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69414 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the dependency of a number of chrome frame projects on the ↵ananta@chromium.org2010-12-161-4/+7
| | | | | | | | | | | | | xulrunner_sdk target which brings in dependency on nspr needlessly. BUG=43461 TEST=it compiles Review URL: http://codereview.chromium.org/5931001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69372 0039d316-1c4b-4281-b951-d872f2087c98
* Keep deinlining stuff.erg@google.com2010-12-153-29/+27
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69273 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a regression introduced with r69101, which now prevents Chrome Framerogerta@chromium.org2010-12-158-84/+96
| | | | | | | | | | | | | | from loading chrome extension URL in privileged mode using the NPAPI plugin. The behaviour that was implemented only for the ActiveX control has been moved into the base class NavigationConstraintsImpl, which both the ActieX and NPAPI plugin derive from. TEST=Added new unit tests for this case BUG=0 Review URL: http://codereview.chromium.org/5814004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69257 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the ChromeFrame Firefox tests on Windows 7 due to a bug in Firefox ↵ananta@chromium.org2010-12-151-7/+17
| | | | | | | | | | | | | | | causing it to crash on startup after the machine has been running for a while. For the curious the crash occurs in the tab preview code in Firefox which only executes on Windows 7 and executes even if we disable tab preview. BUG=none TEST=none Review URL: http://codereview.chromium.org/5745008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69218 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to get rid of chrome_frame_perftests dependency on nspr.lib which ↵ananta@chromium.org2010-12-151-1/+1
| | | | | | | | | | | | | | | causes random build errors. TBR=amit BUG=none TEST=none Review URL: http://codereview.chromium.org/5845002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69213 0039d316-1c4b-4281-b951-d872f2087c98
* Have Chrome Frame "support" IE conditional comment tags (of the ↵robertshield@chromium.org2010-12-143-5/+142
| | | | | | | | | | | | | | downlevel-hidden variety) by ignoring them (rather than treating them as comment start/end) when parsing HTML streams. BUG=65627 TEST=chrome_frame_unittests.exe, also syntax like <!--[if IE]><meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"><![endif]--> will now activate CF. Offtopic: I wonder what happens if I paste HTML into CL comments. Heh. Review URL: http://codereview.chromium.org/5708007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69177 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a ReadyPromptContent that displays a prompt to accept, temporarily ↵erikwright@chromium.org2010-12-1412-2/+1245
| | | | | | | | | | decline, or permanently decline ready mode. Implement a RegistryReadyModeState that manages the state (based on user's decision) in the registry. Interfaces to integrate those with the installer. BUG=None TEST=chrome_frame_unittests --gtest_filter='Ready*' Review URL: http://codereview.chromium.org/5747002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69175 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-142-6/+9
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69107 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame test failures caused by the change to support about:plugins ↵ananta@chromium.org2010-12-141-3/+4
| | | | | | | | | | | | | in full tab mode. BUG=66118 TBR=none Review URL: http://codereview.chromium.org/5707009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69104 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame perf test builder redness by delay loading nspr4.dll. We ↵ananta@chromium.org2010-12-141-1/+5
| | | | | | | | | | | | | | need to investigate where this dependency comes from. TBR=amit TEST=none BUG=none Review URL: http://codereview.chromium.org/5757004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69103 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for gcf:about:plugins in chrome frame full tab mode. The URL ↵ananta@chromium.org2010-12-1417-120/+350
| | | | | | | | | | | | | | | | | | | validation code path in ChromeFrame now takes in an interface NavigationConstraints which allows the delegateslike the ActiveX, ActiveDocument and the NPAPI plugins to control the navigation decisions. We no longer refer to the InternetSecurityManager interface which is IE only for performing zone decisions in the ChromeFrame NPAPI plugin. Fixes bug http://code.google.com/p/chromium/issues/detail?id=66118 BUG=66118 TEST=Covered by additional CanNavigate unit tests. Review URL: http://codereview.chromium.org/5698005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69101 0039d316-1c4b-4281-b951-d872f2087c98
* An attempt to fix the flakiness with the ChromeFrame Javascript window open ↵ananta@chromium.org2010-12-131-1/+1
| | | | | | | | | | | | | test on IE9. We receive multiple NavigateComplete notifications at times. BUG=none TEST=none Review URL: http://codereview.chromium.org/5703005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69070 0039d316-1c4b-4281-b951-d872f2087c98
* Improve filtering for false positive crashesamit@chromium.org2010-12-133-61/+42
| | | | | | | | | | | | | | | ...by inspecting if the module with the crash has the topmost handler in the SEH chain. If that's the case then the exception will very likely be handled. This covers the case of IsBadReadPtr adn family without any special code. It also lets us address IsValidInterface, an internal helper in urlmon. BUG=64348 TEST=covered by existing unit tests Review URL: http://codereview.chromium.org/5622006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69066 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create bogus 's' key in registry during Chrome Frame registrationgrt@chromium.org2010-12-131-1/+1
| | | | | | | | BUG=none TEST=register Chrome Frame on a fresh machine and note that bogus key HKCR\MIME\Database\s is no longer created. Review URL: http://codereview.chromium.org/5810001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69042 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ChromeFrame perf redness caused by an event name change.ananta@chromium.org2010-12-131-1/+1
| | | | | | | | | | TBR=amit BUG=none TEST=none Review URL: http://codereview.chromium.org/5812002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69026 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-135-9/+9
| | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5685007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add named testing interface."phajdan.jr@chromium.org2010-12-115-17/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=67300 The change has been approved conditionally, i.e. if the outstanding review comments are handled in a follow-up as the top priority. Two weeks have passed, and I have not seen the follow-up. It is risky to keep this change in the tree, as it is already non-trivial to revert. Conflicts: chrome/browser/automation/automation_provider.cc chrome/test/ui/named_interface_uitest.cc ipc/ipc_channel_posix.cc TBR=nirnimesh BUG=chromium-os:8512 TEST=none Review URL: http://codereview.chromium.org/5707006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68944 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 11:21:01 +0000