summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Revert 234367 "Base: Make RegistryOverrideManager support sharde..."tommycli@chromium.org2013-11-123-0/+12
| | | | | | | | | | | | | | | > Base: Make RegistryOverrideManager support sharded/parallel tests. > > BUG=314800 > TBR=ajwong@chromium.org > > Review URL: https://codereview.chromium.org/57423008 TBR=tommycli@chromium.org Review URL: https://codereview.chromium.org/69793004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234627 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use UpdateRegistryFromResourceS as it's not in 2013scottmg@chromium.org2013-11-121-0/+6
| | | | | | | | | | | | | | | | | | | ATL version that ships with 2013 doesn't have a suffix. UpdateRegistryFromResource used to select either an S or a D suffix based on the value of _ATL_STATIC_REGISTRY, however in ATL 12 (vs2013), UpdateRegistryFromResource now just means UpdateRegistryFromResourceS, and UpdateRegistryFromResourceD is separate. We want to keep building with 2010 and 2013, so #if based on _ATL_VER. R=ananta@chromium.org, robertshield@chromium.org BUG=309197 Review URL: https://codereview.chromium.org/66583008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234439 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Fix error handling on wrong file in UploadDatatzik@chromium.org2013-11-124-7/+10
| | | | | | | | | | | * Handle file error as a failure rather than handling it as empty file. * Change Chrome Frame error handling for URLRequest failure, from DCHECK hit to ignoring failing input file. BUG=310548, 317432 Review URL: https://codereview.chromium.org/39203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234436 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unused includes of webkit/glue/webkit_glue.htfarina@chromium.org2013-11-121-4/+0
| | | | | | | | | | | | | | | | | This patch was generated by: $ git grep -l webkit/glue/webkit_glue.h > list.txt $ for f in $(cat list.txt); do if ! grep -q 'PlatformFileInfoToWebFileInfo' $f ; then echo $f; fi; done $ for f in $(cat list.txt); do if ! grep -q 'SetJavaScript' $f ; then echo $f; fi; done BUG=None TEST=unit_tests, content_unittests R=thestig@chromium.org TBR=joth,avi,jamesr Review URL: https://codereview.chromium.org/59323005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234409 0039d316-1c4b-4281-b951-d872f2087c98
* Do not load Chrome Frame into IE11+.grt@chromium.org2013-11-121-0/+5
| | | | | | | | | BUG=264800 R=robertshield@chromium.org Review URL: https://codereview.chromium.org/67893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234398 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Make RegistryOverrideManager support sharded/parallel tests.tommycli@chromium.org2013-11-123-12/+0
| | | | | | | | | BUG=314800 TBR=ajwong@chromium.org Review URL: https://codereview.chromium.org/57423008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234367 0039d316-1c4b-4281-b951-d872f2087c98
* Use the large pdb workaround on more unittests.sebmarchand@chromium.org2013-11-091-0/+1
| | | | | | | | | | If we don't do this we can't compile these targets in Debug with component='static_library'. BUG= Review URL: https://codereview.chromium.org/67223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234100 0039d316-1c4b-4281-b951-d872f2087c98
* Use the large pdb workaround on chrome_frame_reliability_tests.sebmarchand@chromium.org2013-11-081-0/+1
| | | | | | | | | | If we don't do this we can't compile this target in Debug with component='static_library'. BUG= Review URL: https://codereview.chromium.org/61913005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233803 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the chrome namespace around ChromeContent[Renderer]Client.wez@chromium.org2013-11-061-2/+2
| | | | | | Review URL: https://codereview.chromium.org/24544004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233373 0039d316-1c4b-4281-b951-d872f2087c98
* Fix spelling: "supress" -> "suppress"mseaborn@chromium.org2013-11-022-2/+2
| | | | | | | | | | BUG=165339 TEST=none TBR=bulach@chromium.org,pkasting@chromium.org Review URL: https://codereview.chromium.org/49693005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232557 0039d316-1c4b-4281-b951-d872f2087c98
* [Net] Add a priority parameter to URLRequest's constructorakalin@chromium.org2013-10-311-4/+5
| | | | | | | | | | | | | | | | | | | This is so that it is clearer what the intended initial priority of a URLRequest is. It is also needed so that we can later enforce that if a URLRequest is set to ignore limits, it has MAXIMUM_PRIORITY; otherwise, we'd have to mandate that SetPriority() is called before set_load_flags(), which is fiddly. Also standardize on a single URLRequest constructor. BUG=166689 R=jam@chromium.org, jamesr@chromium.org, joth@chromium.org, mmenke@chromium.org, scottbyer@chromium.org, sky@chromium.org, tommi@chromium.org Review URL: https://codereview.chromium.org/51953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232219 0039d316-1c4b-4281-b951-d872f2087c98
* Remove trailing "." from message lines.thakis@chromium.org2013-10-311-2/+2
| | | | | | | | | | | | | | | | | cs.chromium.org has way fewer hits for 'message'.*\.',?$ file:gyp than for 'message'.*[^\.]',?$ file:gyp so standardize on the latter. BUG=none TEST=less ocd when watching build output NOTRY=true Review URL: https://codereview.chromium.org/51843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232166 0039d316-1c4b-4281-b951-d872f2087c98
* Always show the Chrome Frame turndown prompt.grt@chromium.org2013-10-317-188/+2
| | | | | | | | | | | This change removes the dismiss button (reverting r213426 and r213521) as well as the reshow delta (effectively making the delta 0). BUG=none Review URL: https://codereview.chromium.org/52583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232064 0039d316-1c4b-4281-b951-d872f2087c98
* Track execution phase of browser process and track it asrtenneti@chromium.org2013-10-281-0/+4
| | | | | | | | | | | | | | | | | | | | a UMA histogram. As a first attempt, tracked the following - Before starting metrics service, - Before creating profile - Before starting startup time bomb - Before starting thread watcher - Before starting main message loop - Before starting shutdown time bomb - clean shutdown. R=jar@chromium.org Review URL: https://codereview.chromium.org/28283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231334 0039d316-1c4b-4281-b951-d872f2087c98
* net: Rework how blocking delegates are logged.mmenke@chromium.org2013-10-251-1/+7
| | | | | | | | | | | | | | | | | | | | Switch to logging an event before calling into delegates, and after they return instead of only in the case that they block. This allows delegates to log events as they take turns blocking a network request. Also allows delegates to log events when delaying the start of a request, and when delaying the start of reading the body of a request (But not between normal body reads). Also allows delegates to log delegate information that will not be displayed to the user. BUG=294920 Review URL: https://codereview.chromium.org/25097004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231084 0039d316-1c4b-4281-b951-d872f2087c98
* Preparing to support fragment resolution against non-hierarchical schemeskristianm@chromium.org2013-10-242-2/+2
| | | | | | | | | | | | | Adds a new GURL::GetContent() to retrieve the text after scheme: specifically intended for use in non-hierarchical schemes (data: etc). Doing the first part of https://codereview.chromium.org/23835019/ in a preparation CL. BUG=291747 Review URL: https://codereview.chromium.org/23549039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230781 0039d316-1c4b-4281-b951-d872f2087c98
* Show the Chrome Frame turndown prompt daily.grt@chromium.org2013-10-241-1/+1
| | | | | | | | | BUG=310806 R=robertshield@chromium.org Review URL: https://codereview.chromium.org/37173006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230642 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce a separate gyp file for content shell and testsjochen@chromium.org2013-10-191-1/+1
| | | | | | | | | | | | This will make it possible to depend on components from content shell BUG=247431 R=jam@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/28123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229620 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 229469 "Disables ChromeFrameTestWithWebServer.WidgetModeI..."sky@chromium.org2013-10-181-3/+1
| | | | | | | | | | | | | | | | | > Disables ChromeFrameTestWithWebServer.WidgetModeIE_ObjectFocus > > BUG=308847 > TEST=none > R=grt@chromium.org > TBR=grt@chromium.org > > Review URL: https://codereview.chromium.org/29863002 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/30103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229488 0039d316-1c4b-4281-b951-d872f2087c98
* Disables ChromeFrameTestWithWebServer.WidgetModeIE_ObjectFocussky@chromium.org2013-10-181-1/+3
| | | | | | | | | | | BUG=308847 TEST=none R=grt@chromium.org TBR=grt@chromium.org Review URL: https://codereview.chromium.org/29863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229469 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 229320 "Disable ChromeFrameTestWithWebServer.WidgetModeIE..."grt@chromium.org2013-10-181-3/+1
| | | | | | | | | | | | | | | | The revert of r229285 at r229410 shoud resolve this for now. > Disable ChromeFrameTestWithWebServer.WidgetModeIE_ObjectFocus. It regressed in [229275:229286] > > BUG=308847 > > Review URL: https://codereview.chromium.org/28223004 TBR=pfeldman@chromium.org Review URL: https://codereview.chromium.org/29313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229427 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ChromeFrameTestWithWebServer.WidgetModeIE_ObjectFocus. It regressed ↵pfeldman@chromium.org2013-10-181-1/+3
| | | | | | | | | | in [229275:229286] BUG=308847 Review URL: https://codereview.chromium.org/28223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229320 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Remove Mac specific function from BookmarkNodeData.tfarina@chromium.org2013-10-121-2/+2
| | | | | | | | | | | | | | | | This removes another ifdef, which should be avoided in general. This is a follow up to the clean up started in crrev.com/225862. See discussion from https://codereview.chromium.org/25022004/ BUG=None TEST=None, no behavior changed. R=sky@chromium.org,asvitkine@chromium.org TBR=darin # for trivial changes in content/ Review URL: https://codereview.chromium.org/25435002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228347 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to sconsbuild.thakis@chromium.org2013-10-121-1/+1
| | | | | | | | | | | scons hasn't been used in a long time. BUG=305702 NOTRY=true Review URL: https://codereview.chromium.org/26718002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228308 0039d316-1c4b-4281-b951-d872f2087c98
* Explicit initialization of aura::Env for browser shell.dnicoara@chromium.org2013-10-091-0/+2
| | | | | | | | | | | | | | | | | | Most implementations (x11 aura with and without chromeos) do not explicitly call aura::Env::GetInstance() to initialize it. These build work as is because the call is done when performing other operations, such as adding observers. In OZONE there are no such calls, so the OZONE build fails when trying to create a compositor since the Compositor::Initialize hasn't been called. This patch adds an explicit initialization for aura based builds to fix this issue. BUG= Review URL: https://codereview.chromium.org/23882007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227745 0039d316-1c4b-4281-b951-d872f2087c98
* Canonical encoding name : windows-949 => EUC-KRjshin@chromium.org2013-10-081-1/+1
| | | | | | | | | | | | | | | | | | This is the chromium side of a blink change at https://codereview.chromium.org/25870005 Until the corresponding blink CL above is re-landed (it's landed but reverted), disable EUC-KR-related test temporarily. This is a copy of https://codereview.chromium.org/25769005/ (lgtm'd and approved). BUG=277027, 95963 TEST=browser test: BrowserEncodingTest.* and EncodingAlias*. TBR=thakis,robertshield Review URL: https://codereview.chromium.org/26439002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227506 0039d316-1c4b-4281-b951-d872f2087c98
* Don't modify Secure Mime Handlers if there's no need.grt@chromium.org2013-10-031-16/+43
| | | | | | | | | | | | | | | | | | | When Chrome creates Google Update's OnDemandMachineAppsClass by way of the elevation moniker, the eventual setup.exe's process security token doesn't have the SeSecurityPrivilege. This prevents Chrome Frame from reading and/or modifying the security descriptor on the Secure Mime Handlers registry key. This had been resulting in error 7 when trying to manually update a Chrome that shared binaries with Chrome Frame. With this change, the values are probed before trying to modify them. Chances are that they will already hold the correct data, so the update should succeed. BUG=224043 TEST=see comment #3 in bug Review URL: https://codereview.chromium.org/25738003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226810 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move PerfTimer out of test/ directory.tfarina@chromium.org2013-09-291-1/+0
| | | | | | | | | | | | | | | | | | Reason: PerfTimer is used by production code, so it doesn't make sense to have it as test only. - Rename it to ElapsedTimer. - Move into base namespace. - Move into timer/ directory. BUG=None TEST=None, no functional change R=brettw@chromium.org TBR=grt@chromium.org # for chrome_frame Review URL: https://codereview.chromium.org/24265005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225898 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove some FromWStringHack() calls in chrome/installer.thestig@chromium.org2013-09-261-1/+1
| | | | | | | | | BUG=76112 R=grt@chromium.org Review URL: https://codereview.chromium.org/23645012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225291 0039d316-1c4b-4281-b951-d872f2087c98
* net: Use ScopedVector::Pass() to pass element readers for UploadDataStream's ↵hashimoto@chromium.org2013-09-241-1/+1
| | | | | | | | | | | | | | | ctor ScopedVector supports Pass() method. Use of Pass() makes it clear that the ownership of the readers moves to the newly created UploadDataStream. BUG=None TEST=git cl try TBR=sky@chromium.org for content/browser, mpcomplete@chromium.org for chrome/browser/extensions/api/web_request Review URL: https://chromiumcodereview.appspot.com/23929005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224960 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 224269 "Don't persist HPKP if PrivacyMode is enabled."tkent@chromium.org2013-09-201-1/+0
| | | | | | | | | | | | | | | | | | | | | | | It broke Google Chrome ChromeOS bot. http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/58548/steps/compile/logs/stdio#error1 FAILED: g++ ... -c ../../net/socket/ssl_client_socket_nss.cc -o obj/net/socket/net.ssl_client_socket_nss.o ../../net/socket/ssl_client_socket_nss.cc: In member function 'int net::SSLClientSocketNSS::DoVerifyCertComplete(int)': ../../net/socket/ssl_client_socket_nss.cc:3445:64:error: no matching function for call to 'net::TransportSecurityState::GetDomainState(const string&, bool&, net::TransportSecurityState::DomainState*)' ../../net/socket/ssl_client_socket_nss.cc:3445:64: note: candidate is: ../../net/http/transport_security_state.h:212:8: note: bool net::TransportSecurityState::GetDomainState(const string&, bool, bool, net::TransportSecurityState::DomainState*) ../../net/http/transport_security_state.h:212:8: note: candidate expects 4 arguments, 3 provided > Don't persist HPKP if PrivacyMode is enabled. > > BUG=258667 > > Review URL: https://chromiumcodereview.appspot.com/19269012 TBR=mef@chromium.org Review URL: https://codereview.chromium.org/24251011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224275 0039d316-1c4b-4281-b951-d872f2087c98
* Don't persist HPKP if PrivacyMode is enabled.mef@chromium.org2013-09-201-0/+1
| | | | | | | | BUG=258667 Review URL: https://chromiumcodereview.appspot.com/19269012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224269 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 223894 "Revert "Enable device discovery notifications.""vitalybuka@chromium.org2013-09-191-0/+3
| | | | | | | | | | | | | | | | | | | | Re-enable device discovery. It should not regress perf after r224052. > Revert "Enable device discovery notifications." > > This reverts commit 15e19ede41054676329caafa49f0b29065e5f1e3. This commit is > being reverted since it causes a significant increase in memory usage. > > TBR=vitalybuka > BUG=292754 > > Review URL: https://codereview.chromium.org/23536066 TBR=teravest@chromium.org Review URL: https://codereview.chromium.org/24191003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224162 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Enable device discovery notifications."teravest@chromium.org2013-09-181-3/+0
| | | | | | | | | | | | This reverts commit 15e19ede41054676329caafa49f0b29065e5f1e3. This commit is being reverted since it causes a significant increase in memory usage. TBR=vitalybuka BUG=292754 Review URL: https://codereview.chromium.org/23536066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223894 0039d316-1c4b-4281-b951-d872f2087c98
* base: Split logging functions and PerfTimeLogger out of perftimer.htfarina@chromium.org2013-09-173-15/+23
| | | | | | | | | | | | | | | | Soon PerfTimer will move into base/timer/ directory as it is already used by production code. This splits the logging stuff into their owns files and also moves PerfTimeLogger into its own files. BUG=None TEST=base_unittests, ipc_perftests, etc... R=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/23985006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223486 0039d316-1c4b-4281-b951-d872f2087c98
* content: Move kHttpScheme constant into content namespace.tfarina@chromium.org2013-09-152-4/+4
| | | | | | | | | | BUG=None TEST=None, no functional change. TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/23658056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223272 0039d316-1c4b-4281-b951-d872f2087c98
* Enable device discovery notifications.vitalybuka@chromium.org2013-09-131-0/+3
| | | | | | | | | | | Add kill switch for notifications. Disable notifications for task manager test. BUG=286157 Review URL: https://chromiumcodereview.appspot.com/23903024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223106 0039d316-1c4b-4281-b951-d872f2087c98
* Remove page cyclers from chrome binary.tonyg@chromium.org2013-09-041-1/+1
| | | | | | | | | | | | The page cyclers run with Telemetry now. They should not be baked into the chrome binary itself. This causes unwanted dependencies on test code and bloats the binary. BUG=280157 Review URL: https://chromiumcodereview.appspot.com/23498004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221201 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ref-counting from StreamListenSocketszym@chromium.org2013-09-032-18/+19
| | | | | | | | | | Changes APIs for StreamListenSocket, TCPListenSocket, UnixDomainSocket and derived test classes to use scoped_ptr instead of scoped_refptr. BUG=263963 Review URL: https://chromiumcodereview.appspot.com/20142003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220992 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out a perf test result printer method.tonyg@chromium.org2013-09-022-1/+2
| | | | | | | | | | This is to allow cc_perftests to share this code without depending on chrome/. BUG= Review URL: https://chromiumcodereview.appspot.com/23509002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220803 0039d316-1c4b-4281-b951-d872f2087c98
* Move ReadFileToString to the base namespace.brettw@chromium.org2013-08-304-5/+5
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/19579005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220612 0039d316-1c4b-4281-b951-d872f2087c98
* Fix more fallouts of variations target move.asvitkine@chromium.org2013-08-292-2/+2
| | | | | | | | | | | | | Broken by: https://codereview.chromium.org/23097007 I wish these were caught by the try bots. BUG=266007 TBR=lambroslambrou@chromium.org Review URL: https://codereview.chromium.org/23493012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220345 0039d316-1c4b-4281-b951-d872f2087c98
* content: Move kHttpsScheme constant into content namespace.tfarina@chromium.org2013-08-262-5/+4
| | | | | | | | | BUG=None TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/23112033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219495 0039d316-1c4b-4281-b951-d872f2087c98
* Move perftimer.* into base/test/ directory.tfarina@chromium.org2013-08-242-2/+2
| | | | | | | | | | | | | This should address the TODO from tools/gn/secondary/base/BUILD.gn BUG=None TEST=test_support_perf R=brettw@chromium.org TBR=cpu, dalecurtis, akalin, thestig Review URL: https://chromiumcodereview.appspot.com/22887041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219448 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FullTabNavigationTest.FormPostBackForwardvabr@chromium.org2013-08-221-1/+2
| | | | | | | | | | | It is flaky on ie6. More details in http://crbug.com/255098#c11 BUG=255098 TBR=robertshield Review URL: https://codereview.chromium.org/22859052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219013 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FullTabUITest.TabCrashReloadvabr@chromium.org2013-08-221-1/+2
| | | | | | | | | | | Flaky on ie7, more info on the bug. BUG=277406 TBR=tommi@chromium.org Review URL: https://codereview.chromium.org/22831028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218981 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce GURL::SchemeIsHttpFamily(), which returns true for http and https.cdn@chromium.org2013-08-221-1/+1
| | | | | | | | | | BUG=274679 TEST=N/A TBR=cbentzel, jamesr, simonjam, tzik, stevet, mpcomplete Review URL: https://chromiumcodereview.appspot.com/23064011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218893 0039d316-1c4b-4281-b951-d872f2087c98
* Remove useless string copy.etienneb@chromium.org2013-08-211-1/+1
| | | | | | | | | | | | This issue was found by a linter. R=tommi@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/23375003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218813 0039d316-1c4b-4281-b951-d872f2087c98
* Remove useless function name qualifier.etienneb@chromium.org2013-08-211-1/+1
| | | | | | | | | | | | This issue was found by a linter. R=tommi@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/23375002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218786 0039d316-1c4b-4281-b951-d872f2087c98
* reland 'Set chrome_multiple_dll=1 by default on Windows in static_library'scottmg@chromium.org2013-08-211-1/+1
| | | | | | | | | | | Previously: https://codereview.chromium.org/22909017/ TBR=jam@chromium.org BUG=237249 Review URL: https://chromiumcodereview.appspot.com/23320004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218663 0039d316-1c4b-4281-b951-d872f2087c98