| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
use cases."
This reverts commit r120574. Test failures.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the browser use case it is convenient to have a single ContentMain entry point function that handles all initialization, run and shutdown. For embedded use cases it is often necessary to integrate with existing application message loops where initialization and shutdown must be handled separately.
To support sharing of this code the following changes were required:
1. Refactor the ContentMain function to create a ContentMainRunner class containing separate initialization, run and shutdown functions.
2. Refactor the BrowserMain function and BrowserMainLoop class to create a BrowserMainRunner class containing separate initialization, run and shutdown functions.
3. Add a new BrowserMainParts::GetMainMessageLoop method. This is necessary to support creation of a custom MessageLoop implementation while sharing BrowserMainRunner initialization and shutdown code.
BUG=112507
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9190018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a Chrome Frame regression from http://crrev.com/117588
Also fixes a failing CF net test, URLRequestTestHTTP.TestPostChunkedDataBeforeStart.
BUG=112459
TEST=chrome_frame_tests.exe
Review URL: http://codereview.chromium.org/9316067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PartialPreReadImage has much the smae interface as PreReadImage except the bytes to read becomes a percentage to read and it reads a certain percentage of each section in the binary.
Also adds some unittest coverage.
BUG=chromium:98508
TEST=
Review URL: http://codereview.chromium.org/9235053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Responses were being cached by IE, so there was a reasonable probability that two permutations used the same URL. This change adds a no-cache header so the URL doesn't matter.
BUG=99235
TEST=none -- covered by chrome_frame_tests.exe
Review URL: https://chromiumcodereview.appspot.com/9323031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because it consistently fails and times out.
BUG=112599
TEST=none
TBR=robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9325027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These tests were counting on a guarantee that value change events would come in before menu popup events. As it happens, this isn't always the case. The tests now wait for the inital value change event to come in before performing subsequent operations, thereby avoiding the race.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9323025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, a magic timeout of 4s was used to end certain tests (listed below). This changes them so that they stop when they're done. This makes the test FASTER in release builds (yay!) and WORK in debug builds (omg!). Given the nature of these tests, I won't be surprised if there's a failure on some combination of OS/IE versions. Hopefully these can be fixed without adding 4s delays.
I found that, at least on my machine, explicitly putting a Cache-control: no-cache header on responses helped make the tests more reliable.
The tests are:
*/FullTabNavigationTest.RefreshContents/*
FullTabDownloadTest.TopLevelPostReissueFromChromeFramePage
*/FullTabNavigationTest.RefreshContentsUATest/*
BUG=none
TEST=win_cf trybot runs chrome_frame_tests.exe, so no special testing is needed.
Review URL: https://chromiumcodereview.appspot.com/9316022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The matcher TabContentsTitleEq is now used by expectations so that actions are only performed when the relevant render window's document is loaded.
BUG=111916
TEST=covered by chrome_frame_tests.exe
Review URL: https://chromiumcodereview.appspot.com/9159030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make sure early return from PreCreateThreads aborts the startup sequence.
BUG=110671
TEST=Launch Chrome with --try-chrome-again=0, select "Dont bug me" and Chrome should not launch.
Review URL: https://chromiumcodereview.appspot.com/9150033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation of adding asynchronous API to UploadDataStream.
Doing initialization in Init() is cleaner anyway.
BUG=72001
TEST=try bots
Review URL: http://codereview.chromium.org/9235079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9225051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
files.
BUG=111326
R=jam
TBR=sky,tony,ajwong,ananta
Review URL: http://codereview.chromium.org/9232060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The language code is ms. This adds the necessary files to generate
the locale pak file. Translations will arrive later.
BUG=111670
TBR=gfeher
Review URL: http://codereview.chromium.org/9232056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
constituent classes.
BUG=none
TEST=none (code cleanup)
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/9159004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that could result in an IE browser hang on a JS error dialog.
BUG=111384
TEST=chrome_frame_tests.exe
Review URL: https://chromiumcodereview.appspot.com/9290026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and hide LeakyLazyInstanceTraits in base::internal to discourage cargo-culting
new users.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9117038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The tests verify whether requests can be cancelled when blocking in certain states. A first pass seems to suggest that, under Chrome Frame, the Chrome network stack never enters these states (the transitions occur entirely in IE network stack), thus cannot block in them, and thus the tests are not relevant.
TEST=chrome_frame_net_tests run and pass on machines with IE9 installed.
R=robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9270045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a useful return value to LaunchIEAndNavigate, indicating which step failed.
Also fix a crash in the HungCOMCallDetector if LaunchIEAndNavigate() fails.
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9160029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In component=shared_library builds, it isn't safe to load npchrome_frame.dll into a process that has its own AtExit manager, singletons, logging, etc. So now spin off a new run of the given test executable to do the registration.
BUG=110492
TEST=none (covered by cf_win trybot)
Review URL: https://chromiumcodereview.appspot.com/9146054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin@chromium.org
BUG=62079
TEST=none
Review URL: http://codereview.chromium.org/9074004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[ RUN ] ChromeFrameTestWithWebServer.FullTabModeIE_WindowClose
.\test\test_with_web_server.cc(214): error: Value of: server_mock_.posted_result()
Actual: ""
Expected: result
Which is: "OK"
[ FAILED ] ChromeFrameTestWithWebServer.FullTabModeIE_WindowClose (45217 ms)
BUG=111074
TEST=marked flaky
Review URL: http://codereview.chromium.org/9235013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=110492
TEST=none
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/9270056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
comprehensible logs, and log the method and path received by the test web server when it handles a request. Such logging is no longer limited to debug builds.
BUG=none
TEST=run any GCF test with --v=1 and watch the events fly by
Review URL: http://codereview.chromium.org/9272004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PathService will give back the path to base.dll, which isn't what is wanted in specific cases. For the DLL redirector, the true path to npchrome_frame must be used, primarily for testing purposes, but it's also the right thing to do. For pinnig, npchrome_frame.dll must be pinned rather than base.dll.
BUG=110492
TEST=the integration tests (chrome_frame_tests.exe) cover it
R=robertshield@chromium.org
Review URL: http://codereview.chromium.org/9141015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=110492
TEST=none
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/9250003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
due to recent histogram
parameter validations. Changes based on a discussion with Jim.
BUG=none
TEST=ChromeFrame should load in IE in debug builds.
Review URL: http://codereview.chromium.org/9139036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=109817
TEST=none
Review URL: http://codereview.chromium.org/9168032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=ananta@chromium.org
BUG=108171
TEST=
Review URL: http://codereview.chromium.org/9187024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes a race condition in Chrome Frame's net tests that could cause URLRequestJobs to be created and destroyed on different threads. This in turn leaks PowerObservers from SystemMonitor's observer list, resulting in an observer list full of dangling pointers. In debug mode this may eventually dcheck if heap addresses are reused.
BUG=109733
TEST=chrome_frame_net_tests.exe does not DCHECK.
Review URL: http://codereview.chromium.org/9158012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117078
Review URL: http://codereview.chromium.org/9150016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PluginService to content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead.
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Review URL: http://codereview.chromium.org/9150016
TBR=jam@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
Some code (extensions+promos) used the fact that RDH is NULL in unittests as a signal to not use the utility process. I've switches those unittests to set a flag on the objects instead.
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Review URL: http://codereview.chromium.org/9150016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bypass tricks to run IE in special ways if the tests are running at high integrity. Otherwise, the medium-integrity broker exits and low-integrity IE is therefore unable to get chrome_launcher running at medium integrity.
BUG=60987
TEST=no manual testing needed; chrome_frame_tests.exe will either become better or worse.
Review URL: http://codereview.chromium.org/9133001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Over 341 CLs, in ~3 months, touching 3251 unique files!
Top 5 most CLs:
(121) jhawkins
( 45) dcheng
( 24) achuith
( 23) csilv
( 12) tfarina
( 12) groby
~1000 files touched:
(918) jhawkins
100+ files touched:
(486) ajwong
(385) willchan
(372) dcheng
(126) csilv
(123) fischman
(112) sergeyu
49+ files touched:
(65) tfarina
(57) acolwell
(52) adamk
(49) tzik
BUG=35223
TEST=existing
Review URL: http://codereview.chromium.org/9114020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
line.
This makes debugging easier for developers, since crashes will start the postmortem debugger.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9123008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requests makes it across to the
server which responds with a status code of 204 indicating no content. However the underlying urlmon layer
calls the OnStopBinding method on the bind status callback with the E_ABORT status code.
We should be reading the response codes off the binding.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=109335
BUG=109335
Review URL: http://codereview.chromium.org/9114022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98919
TEST=existing
Review URL: http://codereview.chromium.org/9111032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
exclusively. This allows updating all the creaters of TCW to not include tab_contents.h as well, and use WebContents::Create instead.
BUG=98716
Review URL: http://codereview.chromium.org/9108025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome Frame is no longer a separate build configuration, so there's no
need to support separate handling of the CF build output.
BUG=none
TEST=Buildbots still archive/process the Chrome Frame files.
Review URL: http://codereview.chromium.org/9109021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:109114
TEST=flakes go away.
TBR=amit@chromium.org
Review URL: http://codereview.chromium.org/9088007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Kill off NewRunnableMethod() and remove silly declarations of unused ScopedRunnableMethodFactory(s).
BUG=none
TEST=existing.
Review URL: http://codereview.chromium.org/9034032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crash in the Chrome renderer process in
the WebKit accessibility code. The WebKit bug https://bugs.webkit.org/show_bug.cgi?id=75279 was fixed last week.
KeyboardInput
WidgetModeIE_InitializeHidden
WidgetModeIE_ObjectFocus
FormPostBackForward
Core
TBR=robertshield
Review URL: http://codereview.chromium.org/9084001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=groby,awong,csilv
Review URL: http://codereview.chromium.org/9028009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=108508
TEST=
Review URL: http://codereview.chromium.org/9007039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ajwong
Review URL: http://codereview.chromium.org/8956019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: http://codereview.chromium.org/9019004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107739
TEST=No visible code changes. Removing constants and code related to CEEE.
Review URL: http://codereview.chromium.org/8909009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser tests.
BUG=107745
Review URL: http://codereview.chromium.org/8971004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114944
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114993 0039d316-1c4b-4281-b951-d872f2087c98
|