| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=316496
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/126143005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
namespace, and clean up the header."
This is a speculative revert of r242414.
BUG=330681
TEST=as in bug
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/109673004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/102993018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=329295
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/113403006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
use the base:: namespace.
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/112433004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
clean up the header.
BUG=none
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/100543005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=grt@chromium.org
BUG=329295
Review URL: https://codereview.chromium.org/113143006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For WebRTC virtual host scoped network interfaces are not useful, but if present they take processing time and webrtc applications keep sending STUN ping messages from virtual network interfaces.
This CL adding a policy for net::GetNetworkList method, which allows users of the method to include or exclude these interfaces.
R=agl@chromium.org,sergeyu@chromium.org
TBR=bbudge@chromium.org,ananta@chromium.org
Review URL: https://codereview.chromium.org/99133020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=316496, 316203
R=ananta@chromium.org, ananta
Review URL: https://codereview.chromium.org/109683005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to more clearly see which automation calls are left, since that code is also deprecated and will be removed in Q1.
BUG=316496,316203
R=ananta@chromium.org
Review URL: https://codereview.chromium.org/117033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
process.
BUG=316496
R=ananta@chromium.org
Review URL: https://codereview.chromium.org/102763005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This move enables using the files derived from policy_templates.json in iOS
builds. List of changes:
- cloud_policy_codegen.gyp and policy_templates.gypi have been merged into
components/policy.gypi
- policy_templates.json moved into components/policy/resources/
- policy_templates.grd and *.xtb files moved into components/policy/resources/
- syntax_check_policy_templates_json.py and
chrome/tools/build/generate_policy_source.py moved into
components/policy/tools
BUG=271392
R=jochen@chromium.org, pastarmovj@chromium.org
Review URL: https://codereview.chromium.org/108513011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=316496
TBR=jcivelli@chromium.org
Review URL: https://codereview.chromium.org/110163004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using gtest.gyp:gtest_main is very uncommon in chromium tree, there
are only two instances. By running it through base:run_all_unittests
should be more robust. Previous CL was
https://codereview.chromium.org/110983002
BUG=None
TEST=vectored_handler_tests
R=ananta@chromium.org,grt@chromium.org
Review URL: https://codereview.chromium.org/103453006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts parts of the following CLs committed ~week ago:
https://codereview.chromium.org/85503004
https://codereview.chromium.org/86773003
TBR=sky,erikwright
BUG=236893
Review URL: https://codereview.chromium.org/105803003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/102873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/100573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/99923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a crash when navigating to an URL containing an
internationalized domain name.
BUG=324855
R=robertshield@chromium.org
Review URL: https://codereview.chromium.org/99623003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This also swaps the order of the parameters to GetShmemTempDir so the out
parameter is last, and enhances some documentation.
Review URL: https://codereview.chromium.org/93263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves EmptyString*, kWhitespace*, and the UTF 8 Byte Order Marker to the base:: namespace.
Many of them just got changed to a default-constructed string when a reference was not required.
I qualified some string16s with base:: when I was changing adjacent code. I need to do another pass to finish these up.
BUG=
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/89243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In general, the OS API contract doesn't guarantee that output variables are
not modified on failure, so a Reeceive pattern is fundamentally insecure.
BUG=318531
TEST=current tests
tbr'ing owners for the consumers.
TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237459
Review URL: https://codereview.chromium.org/71013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_frame_unittests
This is still behind --brave-new-test-launcher command-line flag.
BUG=236893
R=erikwright@chromium.org
Review URL: https://codereview.chromium.org/86773003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Causing compile failure in chrome_util.cc on "Google Chrome Win" http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/21803
TBR=cpu@chromium.org,jvoung@chromium.org,thakis@chromium.org,sergeyu@chromium.org,grt@chromium.org,gene@chromium.org,youngki@chromium.org,rvargas@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/90963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In general, the OS API contract doesn't guarantee that output variables are
not modified on failure, so a Reeceive pattern is fundamentally insecure.
BUG=318531
TEST=current tests
tbr'ing owners for the consumers.
TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org
Review URL: https://codereview.chromium.org/71013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL simplifies some MetricsLog APIs, consolidating
RecordEnvironment and RecordEnvironmentProto as well as
RecordIncrementalStabilityElements and WriteStabilityElement.
This reduces the MetricsLog API surface, simplifying things
for some upcoming changes I'm planning to make (recording
startup stability stats separately from startup histograms
and profiler data).
No changes to logic/functionality.
BUG=312733, 109818
TEST=Existing unit tests.
TBR=grt@chromium.org
Review URL: https://codereview.chromium.org/69603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LazyFeatureProvider is not thread safe and can cause crashes.
This CL removes LazyFeatureProvider altogether.
BUG=313743
Review URL: https://codereview.chromium.org/57863004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step for moving ui.gyp into ui/base/
After this lands, Blink will be updated to reference the new file under
ui/resources.
Then the by-pass target will be removed from ui.gyp. And then we can
move it to its finall location.
BUG=299841
TEST=None
R=ben@chromium.org
Review URL: https://codereview.chromium.org/74853003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use simple setters rather than With* methods.
* Explicitly transfer memory ownership.
* Rename "Builder" to "Factory"
* Eliminate the side-effect of resetting the builder from the Create* methods.
Along the way, fix a memory leak in the Android WebView.
BUG=315499
TEST=none (code should continue to compile and tests should continue to pass)
R=joi@chromium.org
Review URL: https://codereview.chromium.org/64193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=264800
R=robertshield@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/59883014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 98ee7dd64463c42a076782c923330107e60b8fad.
Reapply of https://codereview.chromium.org/57423008 now that a blocking issue has been fixed.
BUG=314800
TBR=grt,owners
Review URL: https://codereview.chromium.org/68743005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=318423
TBR=owners
Review URL: https://codereview.chromium.org/68193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20VS2013%20%28dbg%29/builds/101/steps/compile/logs/stdio
R=robertshield@chromium.org
BUG=309197
Review URL: https://codereview.chromium.org/71963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Base: Make RegistryOverrideManager support sharded/parallel tests.
>
> BUG=314800
> TBR=ajwong@chromium.org
>
> Review URL: https://codereview.chromium.org/57423008
TBR=tommycli@chromium.org
Review URL: https://codereview.chromium.org/69793004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ATL version that ships with 2013 doesn't have a suffix.
UpdateRegistryFromResource used to select either an S or
a D suffix based on the value of _ATL_STATIC_REGISTRY,
however in ATL 12 (vs2013), UpdateRegistryFromResource
now just means UpdateRegistryFromResourceS, and
UpdateRegistryFromResourceD is separate.
We want to keep building with 2010 and 2013, so #if based
on _ATL_VER.
R=ananta@chromium.org, robertshield@chromium.org
BUG=309197
Review URL: https://codereview.chromium.org/66583008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Handle file error as a failure rather than handling it as empty file.
* Change Chrome Frame error handling for URLRequest failure, from DCHECK hit to ignoring failing input file.
BUG=310548, 317432
Review URL: https://codereview.chromium.org/39203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by:
$ git grep -l webkit/glue/webkit_glue.h > list.txt
$ for f in $(cat list.txt); do if ! grep -q 'PlatformFileInfoToWebFileInfo' $f ; then echo $f; fi; done
$ for f in $(cat list.txt); do if ! grep -q 'SetJavaScript' $f ; then echo $f; fi; done
BUG=None
TEST=unit_tests, content_unittests
R=thestig@chromium.org
TBR=joth,avi,jamesr
Review URL: https://codereview.chromium.org/59323005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=264800
R=robertshield@chromium.org
Review URL: https://codereview.chromium.org/67893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=314800
TBR=ajwong@chromium.org
Review URL: https://codereview.chromium.org/57423008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If we don't do this we can't compile these targets in Debug with component='static_library'.
BUG=
Review URL: https://codereview.chromium.org/67223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If we don't do this we can't compile this target in Debug with component='static_library'.
BUG=
Review URL: https://codereview.chromium.org/61913005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/24544004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=165339
TEST=none
TBR=bulach@chromium.org,pkasting@chromium.org
Review URL: https://codereview.chromium.org/49693005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is so that it is clearer what the intended initial priority of
a URLRequest is.
It is also needed so that we can later enforce that if a URLRequest
is set to ignore limits, it has MAXIMUM_PRIORITY; otherwise, we'd have
to mandate that SetPriority() is called before set_load_flags(), which
is fiddly.
Also standardize on a single URLRequest constructor.
BUG=166689
R=jam@chromium.org, jamesr@chromium.org, joth@chromium.org, mmenke@chromium.org, scottbyer@chromium.org, sky@chromium.org, tommi@chromium.org
Review URL: https://codereview.chromium.org/51953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cs.chromium.org has way fewer hits for
'message'.*\.',?$ file:gyp
than for
'message'.*[^\.]',?$ file:gyp
so standardize on the latter.
BUG=none
TEST=less ocd when watching build output
NOTRY=true
Review URL: https://codereview.chromium.org/51843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change removes the dismiss button (reverting r213426 and r213521)
as well as the reshow delta (effectively making the delta 0).
BUG=none
Review URL: https://codereview.chromium.org/52583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a UMA histogram.
As a first attempt, tracked the following
- Before starting metrics service,
- Before creating profile
- Before starting startup time bomb
- Before starting thread watcher
- Before starting main message loop
- Before starting shutdown time bomb
- clean shutdown.
R=jar@chromium.org
Review URL: https://codereview.chromium.org/28283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch to logging an event before calling into delegates, and after
they return instead of only in the case that they block. This allows
delegates to log events as they take turns blocking a network
request.
Also allows delegates to log events when delaying the start of
a request, and when delaying the start of reading the body of a
request (But not between normal body reads).
Also allows delegates to log delegate information that will not be
displayed to the user.
BUG=294920
Review URL: https://codereview.chromium.org/25097004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a new GURL::GetContent() to retrieve the text after scheme: specifically
intended for use in non-hierarchical schemes (data: etc).
Doing the first part of https://codereview.chromium.org/23835019/
in a preparation CL.
BUG=291747
Review URL: https://codereview.chromium.org/23549039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=310806
R=robertshield@chromium.org
Review URL: https://codereview.chromium.org/37173006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230642 0039d316-1c4b-4281-b951-d872f2087c98
|