| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
RunnableMethods easier.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2830006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if_modified_since, etc to pass through the host network
stack. Filtering out these issues causes POST requests issued by buzz to fail.
Fixes bug http://b/issue?id=2321282
Bug=2321282
Test=Covered by ChromeFrame unit test.
Review URL: http://codereview.chromium.org/2846005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
needs some plumbing in the external tab
container to populate the navigation history for the tab contents when it is created.
Bug=46615
TBR=amit
Review URL: http://codereview.chromium.org/2813009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
net::HttpNetworkDelegate is an interface for providing hooks into http network activity. ChromeNetworkDelgate implements this interface in chrome/ code. In the future, it might also implement other interfaces. My only current intended consumer for this would be extensions. There's no actual behavior change, this is all just plumbing for now.
BUG=29314
Review URL: http://codereview.chromium.org/2749015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on Chrome Frame.
BUG=0
TEST=none
Review URL: http://codereview.chromium.org/2776010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2791006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for tracking chrome frame crash metrics via
2 new counters which track successful navigations and crashes. These counters are persisted in the registry under
HKCU\Software\Google\ChromeFrameMetrics.
Any other histogram data like AutomationServer launch time, IE versions etc are simply dropped if IE is shutdown before
they are sent out. The metrics data is uploaded on similar lines as Chrome.
Bug=46057
Review URL: http://codereview.chromium.org/2714003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was unjustly reverted due to flaky unit-test failure.
Original review:
http://codereview.chromium.org/2358003
TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/2720003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems to be breaking the ExtensionAPIClientTest.CreateWindowW unit-test.
BUG=25564
TEST=none
Review URL: http://codereview.chromium.org/2358003
TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/2782003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25564
TEST=none
Review URL: http://codereview.chromium.org/2358003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Allows binding on 0.0.0.0 to allow connections from a VM (for example).
Simple GMock class and Actions.
Review URL: http://codereview.chromium.org/2620006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=chrome frame tests
Review URL: http://codereview.chromium.org/2620001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=See bug.
BUG=46045
Review URL: http://codereview.chromium.org/2728001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
function.
BUG=24874
TEST=trybots
Review URL: http://codereview.chromium.org/2632006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notification on the TabContentsDelegate which
the ExternalTabContainer implements is ignored if the window close is not initiated from the host.
Fix is to send over an automation message AutomationMsg_CloseExternalTab to the external host where we close the window.
Currently this functionality is only provided by the active document.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=45930
Bug=45930
Test=Covered by chrome frame unit test FullTabModeIE_WindowCloseInChrome
Review URL: http://codereview.chromium.org/2691004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add interface for multi_pref_store_manager.
BUG=40259
TEST=Unittests in pref_service_unittest.cc, pref_value_store_unittest.cc
Review URL: http://codereview.chromium.org/1957005
Patch from Markus Heintz <markusheintz@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24874
TEST=trybots
Review URL: http://codereview.chromium.org/2637001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=See bug description.
BUG=45384
Review URL: http://codereview.chromium.org/2675001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
briefly until the navigation was initiated from IE.
We have code in the ChromeFrame external tab container to initiate the navigation during initialization if we have a valid url
passed in while creating the external tab. The URL would not get passed down even though it was available from ChromeFrame.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=43482
Bug=43482
Review URL: http://codereview.chromium.org/2600002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
into line with worst-case expectations on Vista.
BUG=None
TeST=run GCF perftests
Review URL: http://codereview.chromium.org/2544003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, make it work better when using backup jobs / late binding (the display was very confused before because of how these asynchronous events would nest).
Also changed the paradigm for how PassiveLogCollector preserves these async associations -- this fixes how it replays the events to net-internals. (Before we would collapse the event streams into the SOURCE_URL_REQUEST which lost some hiearchy.. now I keep the separate streams).
Some of the particular changes to the event streams:
* ConnectJobs now create their own source stream internally.
* Sockets are now bounded by +SOCKET_ALIVE / -SOCKET_ALIVE events (removed the one-off SOCKET_DONE event).
* The socket log streams contains +SOCKET_IN_USE / -SOCKET_IN_USE event blocks to show which URLRequest was controlling it at various points in time (this makes it much easier to understand which read/writes belonged to a particular network transaction when a socket gets re-used).
* ConnectJobs are bounded by +SOCKET_POOL_CONNECT_JOB / - SOCKET_POOL_CONNECT_JOB events.
* ConnectJobs log the net error they failed with.
* Removed the SOCKET_BACKUP_TIMER_EXTENDED event.
Review URL: http://codereview.chromium.org/2363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Original review URL: http://codereview.chromium.org/2173002
Review URL: http://codereview.chromium.org/2375003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2486004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35036
TEST=Check chrome_launcher.exe properties, check that it has version information.
Review URL: http://codereview.chromium.org/2497001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
enabling warn-on-signed-versus-unsigned-equality-comparisions on Windows.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2395001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
pointless comment about use of ARRAYSIZE_UNSAFE().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2364003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Frame. (Stuff the data in the lpfnWndProc member of the WNDCLASSEX structure instead).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2272002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
identifiers directly. This required renaming a few identifiers to avoid macro renaming conflicts when including the Chrome headers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2359002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IE still works.
BUG=none
TEST=none
Review url: http://codereview.chromium.org/2173002
Review URL: http://codereview.chromium.org/2374002
TBR=kkania@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review url: http://codereview.chromium.org/2173002
Review URL: http://codereview.chromium.org/2374002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=gyp works on cygwin on windows
TBR=xiyuan
Review URL: http://codereview.chromium.org/2379002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
average about 50% faster than the previous version.
Review URL: http://codereview.chromium.org/2278003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2222002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and use their FilePath equivalents.
BUG=24874
TEST=included
Review URL: http://codereview.chromium.org/2125021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SetClasSLongPtr doesn't reset the error code on success and yet said code must be used to check for failure.
BUG=45041
TEST=none
Review URL: http://codereview.chromium.org/2229003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrameAutomationProxy::SendAsAsync function can be passed a NULL callback. The dispatcher needs
to check for the same and ignore the returned callback message. We currently crash on trunk.
Review URL: http://codereview.chromium.org/2227001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98.
Revert "Missed a file as part of checkin for r48186"
This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b.
Revert "Enable warning 4389 as an error on windows builds. This will make"
This reverts commit c78936bcfc65b98edf288191d927a495b0364621.
TBR=mbelshe
Review URL: http://codereview.chromium.org/2253001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handlers on the page are invoked correctly. To flag success or
failure we now set the state in the localStorage object instead of setting this via cookies as the cookies are set in IE on the UI thread
causing this test to fail.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=40814
Bug=40814
Review URL: http://codereview.chromium.org/2215001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2081007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG==25457
Review URL: http://codereview.chromium.org/2152004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
being minimized by default. This was because of a call
to IWebBrowser2::put_visible after initiating the navigation. The put_visible call eventually calls SetForegroundWindow setting focus
back to the current document thus causing focus to switch away from the new window.
Fix is to remove call to put_visible.
Fixes bug http://b/issue?id=2692416
Bug=2692416
Review URL: http://codereview.chromium.org/2153006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The cycle is between installer.gyp and chrome.gyp. The fix is to switch installer.gyp into installer.gypi and include it into chrome.gyp
BUG=35308
Review URL: http://codereview.chromium.org/2067018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
exception barrier version which only reports crashes
in ChromeFrame while calling the original function. We also use the other version of the ExceptionBarrier when we switch the mime
type from text/html. This is to prevent the vectored exception handler from handling this exception and reporting a false positive
if any stack based exception handler actually handles this exception.
The other change is to remove the IHttpNegotiate::OnResponse patch as it did not do anything useful and some crashes were being reported
while invoking the original function.
Fixes bugs http://code.google.com/p/chromium/issues/detail?id=44767 and http://code.google.com/p/chromium/issues/detail?id=44765
Bug=44767,44765
Review URL: http://codereview.chromium.org/2078030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
JsonPrefStore and PrefStore to chrome/common. This is because JsonPrefStore is needed in the service process
BUG=None.
TEST=Updated unit-tests
Review URL: http://codereview.chromium.org/2066015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the constructor instead of FinalConstruct as there are
codepaths in which the base FinalConstruct is not called.
Bug=44465
Review URL: http://codereview.chromium.org/2093011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the active document is released before the prompt is clicked
on. This only happens on IE6 where the prompt dialog is modeless in the context of the InternetSetCookieEx call.
To ensure that the active document remains valid for the duration of the call we maintain a reference on the container for the duration of
the InternetSetCookie call.
The cookie calls in IE are now handled on the UI thread as we cannot block the IPC thread in case the set cookie calls result in a prompt.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=44465
The FullTabModeIE_UnloadEventTest has been disabled as the change to execute the cookie calls on the UI thread would break it.
Bug=44465, 40814
Review URL: http://codereview.chromium.org/2091015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2117021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is a tentative fix, since I was unable to reproduce crash in AcroPDF.dll
Review URL: http://codereview.chromium.org/2087017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change corrects the offset and the condition to avoid crash in
IBrowserService2::v_MayTranslateAccelerator.
BUG=25457
Review URL: http://codereview.chromium.org/2109010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LoadLibrary during DllRegisterServer.
BUG=44468
Review URL: http://codereview.chromium.org/2089016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47696 0039d316-1c4b-4281-b951-d872f2087c98
|