| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=27414
TEST=None
Review URL: http://codereview.chromium.org/384094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implements the PluginRequestHandler
interface which is maintained by individual requests which can outlive the active document/activex instances.
I ran into a crash where UrlmonUrlRequest was calling into an invalid PluginRequestHandler pointer which
had been destroyed just before.
We also need to ensure that UrlmonUrlRequest and ChromeFrameActiveXBase select the multi threaded model as
AddRef/Release can be invoked from multiple threads.
I also removed the CleanupAsyncRequests function in ChromeFrameAutomationClient and moved all the code to CleanupRequests, which ensures that we treat synchronous
and asynchronous requests similarly.
There are instances where an automation client instance is created and destroyed without being initialized which causes a spurious assert to fire in the Uninitialize function. I added a check in the Uninitialize function to return if the state is uninitialized.
Bug=none
Review URL: http://codereview.chromium.org/386014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HTTP sites. This was because
the automation resource message filter tracked HTTP requests based on the request ids which are generated
by the renderer process. As a result a new request would get created say with id 0, while an existing request
would end in ChromeFrame causing the new request to incorrectly shutdown.
Fix is to revert back to the original way of tracking requests with an auto incrementing id. The automation url
job maintains both ids now, i.e. the automation request id and the chrome request id. The download notification
receives the automation id and basically looks up the associated automation request id and sends the notification
back to ChromeFrame.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=27401
Other fixes in this CL include the following:-
1. The active document instance would never get destroyed. This was because we call ShowUI on the doc host
which maintains a reference. We need to call HideUI in Setsite of NULL, which releases the reference.
2. When the active x instance is shutting down we try to shutdown all running requests in the OnDestroy handler.
To ensure that the request is deleted from the request map and released in the same thread which created it
we post a task back to the ui thread which never runs as the window is being destroyed. Fix is to create
a message only window with every urlmonrequest instance which supports task marshaling.
Tests in a future CL.
Bug=27401
Review URL: http://codereview.chromium.org/386008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
is already registered as an NPAPI plugin, keep that registration information up to date across updates.
Review URL: http://codereview.chromium.org/385015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. http://code.google.com/p/chromium/issues/detail?id=27200
This was a crash which would occur in the Stop function in the UrlmonUrlRequest object
which would get invoked when the active document instance was being destroyed. The crash
occured if the active document instance was reused in which case we end up reusing the
automation client instance. The fix is to ensure that we clean up existing requests from
the map before reusing the automation client instance.
2. http://code.google.com/p/chromium/issues/detail?id=27202
This was a DCHECK which would occur when adding a new request to the request map, which
indicated that an existing request with the same request id existed in the map. This would
occur during a redirect where the request id is reused by Chrome. Fix is to remove the
request from the map when we handle the AutomationMsg_RequestEnd message in the UI thread
itself. The UrlmonUrlRequest functions which attempt to remove the request from the map
now check if the request is valid before doing this.
Bug=27200,27202
Review URL: http://codereview.chromium.org/388008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
change (not calling SetEnableExtensionAutomation on startup unless some
functions are being automated) that missed this outstanding issue.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/380009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* provide a new 'overlay' prompt mode that includes a "close" button with a cookie that respects the user preference for any originating site
* handle requesting the install UI from a host page loaded from a file:// URL
* expands UA detection to stop taunting Win2K (and below) users with visions of WebKit goodness
* preserves full compat with previous version
BUG=23057,22738,23132
TEST=see new test files in this change or build chrome_frame_tests and run with: chrome_frame_tests.exe --gtest_filter=*CFInstall*
Review URL: http://codereview.chromium.org/345032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move GetSystemCommitCharge() into bsae\process_util*.
Kill PrintChromeMemoryUsageInfo(), which was only used by
reliability_tests.exe on Windows and whose stats are obsolete.
Delete the now-unnecessary chrome\test\perf\mem_usage* files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/371025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flexible testing when you want to automate different sets of functions
in different tests. Now instead of needing to destroy your CF and
then create a new one with a different automation functions attribute,
you can just call the function to reset on the existing one, then call
it again to enable a different set.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/375014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab for all extension views. Previously, API routing to the
automation client would only work for extension views that were
contained in the particular ExternalTab instance being automated. This
meant you couldn't test API calls from e.g. background pages.
Also using async functions instead of the previous RVH-based hack.
Updating one of the UI tests to make the API calls from a background
page, to provide an end-to-end test of the new routing.
This makes AutomationProvider::SetEnableAutomationExtension
Windows-only, but it effectively always was since it was already
dependent on ExternalTabContainer (indirectly, to provide a non-empty
implementation of TabContentsDelegate::ForwardMessageToExternalHost).
BUG=none
TEST=ui_tests.exe, chrome_frame_tests.exe, chrome_frame_unittests.exe
Review URL: http://codereview.chromium.org/366025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
notable change here is that url automation job id's no longer exist and instead a request id is used. There's a 1 to 1 relation between a job and a request so this is more convenient.
Review URL: http://codereview.chromium.org/355036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
suspect splitting utf_string_conversions out of string_utils on the Chrome side helped here.
If I don't eliminate these, I need to patch them for bug 4010, but I'm not going to do that if they aren't needed.
BUG=4010
TEST=none
Review URL: http://codereview.chromium.org/371039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use a test-specific subclass to isolate the stopgap use of 'ps'
to collect memory stats on Mac.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/342070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome.dll. This reworks the browser distribution code to use the ChromeFrameBrowserDistribution iff --chrome-frame is present on the command line.
Also,
* At startup, chrome.exe now uses the BrowserDistribution code to determine where the Chromium version key resides (instead of hard coding it).
* The installer now propagates the presence of --verbose-logging to uninstalls.
* The chrome_launcher now allows the --chrome-frame switch through to chrome.
* The installer now accepts a --chrome-frame switch.
* Remove almost all occurences of the CHROME_FRAME_BUILD define from the installer.
BUG=26012, 26603
TEST=Chrome Frame still builds and runs correctly. Chrome Frame builds built without 'branding'='Chrome' now install correctly.
Review URL: http://codereview.chromium.org/345021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=26549
TBR=ananta
Review URL: http://codereview.chromium.org/348051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
issue where a page that uses CF would be loaded in an IFRAME on Google Images.Instead of attempting to load CF (not supported), we now defer to the host browser. Previously a blank page was displayed.TEST=Run new unit tests: FullTabModeIE_SubIFrame and FullTabModeIE_SubFrameBUG=22989
Review URL: http://codereview.chromium.org/343086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/354012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This gives us one less file to load on startup. This does mean
that some tests need to explicitly include theme_resources.rc.
BUG=24035
Review URL: http://codereview.chromium.org/348033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ananta
TEST=none
BUG=26372
Review URL: http://codereview.chromium.org/348026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CFUrlRequestUnittestRunner constructor.
This causes a CHECK to fire in the extensions service initialization which happens when we
initialize the profile. The CHECK was added in revision 30550. Given the spate of these test
failures we should really speed up the process of moving the chrome frame builder to the main
waterfall.
TBR=tommi
Review URL: http://codereview.chromium.org/346019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the chrome frame builder which is
an XP machine with IE8 (It was not supposed to return on IE8 :) The reason being that the VK_UP keyboard
message we were passing in via SendInput needs the extended flag to be true. I added the extended flag
as an argument to the SendVirtualKey helper function.
On a related note, I removed the GetIEVersion check from the utility function which launches IE as a COM
server as the IE version checking function checks the version of the current module and compares it against
IE versions which is hilarious. In any case these tests work fine.
TBR=amit
Review URL: http://codereview.chromium.org/339076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cases:-
1. A window.open call issued from a page within ChromeFrame in IE full tab mode makes it back
to IE before being shunted into Chrome.
2. Brings up the chrome frame context menu in full tab mode and invokes the About Chrome frame
option.
While I was working on these tests based on a lot of help from Stoyan, we had these tests use gmock
and I also changed the disallowed URL test to use gmock.
The other changes are to always run the chrome frame tests in the STA apartment as the newly added
full tab mode tests cannot handle calls coming in from background RPC worker threads.
Bug=26066,26172
Review URL: http://codereview.chromium.org/340029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/340010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
where the network tests run. Some of the url request tests rely on having a valid
notification service pointer in the TLS on the current thread.
TBR=tommi
Review URL: http://codereview.chromium.org/344025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the post_data_len_ member variable to the PluginUrlRequest class.TEST=This is a tentative fix for bug 25531.BUG=25531
Review URL: http://codereview.chromium.org/340006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
view-source in chrome frame
BUG=26129
TEST=cf:view-source:javascript:alert('foo') should not work in chrome frame.
Review URL: http://codereview.chromium.org/348006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
automation proxies, which I maintain is a bad thing.
BUG=Start IE with debug CF installed, navigate to a chrome frame page, exit IE, see the DCHECK.
Review URL: http://codereview.chromium.org/342018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a DCHECK fire in
the Chrome frame network tests for whether the current thread is the UI thread. We need to invoke
the correct constructor.
The other fix is in our com_util::IDispatchImpl class where we end up crashing if we fail to find
the type information for the passed in interface. Strangely this is failing for the IChromeFrame
interface which is an IDispatch derivative and seems to be correctly registered. It also fails
with the ATL IDispatchImpl classes though. However we should not crash here :) I also removed
the NOTREACHED as it keeps firing on debug test runs. Will take a look at this closely later.
TBR=tommi
Review URL: http://codereview.chromium.org/343013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/344009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
with resulting fallout.
Also, remove several instances of Chrome Frame using wstrings instead of FilePaths.
The main goal of this patch is to move towards ensuring that Chrome Frame and Google Chrome share binary-identical exes and dlls except for setup.exe and mini_installer.exe.
Review URL: http://codereview.chromium.org/338025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=amit
Review URL: http://codereview.chromium.org/340015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browsers don't preserve the
request method, i.e. they convert the POST request to GET. For 307 redirects browsers preserve redirects.
This CL fixes the following issues :-
1. As per the above description, we reset the method which
ensures that we don't generate the post related headers.
The Post302RedirectGet net test does test this very case.
However it works correctly as Chrome follows the redirect
and reissues the GET request. In this case this does not
occur as the only calls which are invoked on the bind
status callback after the redirect are GetBindInfo and
BeginningTransaction where we incorrectly return the post
related information. Ideally we would want to turn off
follow redirects in Urlmon or Chrome. I tried the latter
which has a number of issues.
2. In debug mode the chrome_frame_net_tests cause a DCHECK
to be fired which indicates that the test is not being
run on the UI thread.
3. As the Urlmon requests are now destroyed asynchronously
having a DCHECK after the Stop call on the Urlmon
request object in the CleanupAsyncRequests function is
incorrect. Removed this DCHECK
Fixes bug http://code.google.com/p/chromium/issues/detail?id=25643
Bug=25643
Review URL: http://codereview.chromium.org/333043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=25354
Review URL: http://codereview.chromium.org/329035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds ok
Review URL: http://codereview.chromium.org/295049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a ctor for creating a CommandLine for carrying arguments;
convert all the users to either that or the FilePath version.
BUG=24672
Review URL: http://codereview.chromium.org/329017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Added a check in the OnDestroy handler for the ChromeFrame ActiveX as to whether the
worker thread is valid before posting a task to it.
2. Added a helper function in ChromeFrameAutomationClient to support asynchronous host network
stack requests deletion.
If this does not work I will revert the previous CL's.
TBR=amit
Review URL: http://codereview.chromium.org/338010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builder. Fixes as below:-
1. Removed a DCHECK from
ChromeFrameAutomationClient::CleanupRequests which checks
if the request was actually deleted. This DCHECK is not
correct anymore as the request is stopped asynchronously.
2. We now stop the worker thread in WM_DESTROY as the
activex window needs to be valid for Urlmon requests
to be released correctly. In some cases IE reuses the
ActiveX instance. So we need to create the worker
thread on demand.
TBR=amit
Review URL: http://codereview.chromium.org/334020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of my change r29986 to run
URL requests issued in IE in a separate thread.
TBR=amit
Review URL: http://codereview.chromium.org/328020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and complete URL downloads requested by ChromeFrame, executes in the UI thread of IE.
While this works fine in most cases for large data sizes, the IE UI thread ends up being
busy pulling the data in our IBindStatusCallback::OnDataAvailable implementation. As a result
the browser hangs until all data is pulled out.
The fix is to handle Urlmon requests on a separate thread.
This fixes http://code.google.com/p/chromium/issues/detail?id=24007
Changes to plugin_url_request.cc/.h are to set the LF property on these files.
Bug=24007
Review URL: http://codereview.chromium.org/292035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=amit
Review URL: http://codereview.chromium.org/335013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23845
TEST=none
Review URL: http://codereview.chromium.org/337002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
APIs to forward (and thus stub out in your test), while others will
keep being fulfilled as per usual. This lets you build tests that
stub out one piece of behavior while testing that some side effects of
another API happen as expected.
BUG=none
TEST=Run ui_tests.exe
Review URL: http://codereview.chromium.org/314015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=see unit tests
BUG=0
Review URL: http://codereview.chromium.org/284017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24266
TEST=No functional change so make sure nothing changes.
Review URL: http://codereview.chromium.org/307045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
mode (via a "--server" command line).
This allows the test executable to just start the local server and wait which can be useful for debugging failing tests.
Review URL: http://codereview.chromium.org/307042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/303023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29696 0039d316-1c4b-4281-b951-d872f2087c98
|