summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Part 3 of reapplying r64637.erg@google.com2010-11-121-1/+1
| | | | | | | | | | | | | This moves SecurityStyle and PageType into chrome/common/ and removes the chrome_frame dependency on chrome/browser/tab_contents/. This undoes the temporary DEPS hack on chrome/common/. BUG=51409 TEST=compiles Review URL: http://codereview.chromium.org/4697005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65965 0039d316-1c4b-4281-b951-d872f2087c98
* Support specifying the GSSAPI library that will be used.danno@chromium.org2010-11-121-3/+5
| | | | | | | | | | | | This preference can be set either via command-line or via group policy. BUG=53625 TEST=unittests: ConfigurationPolicyPrefStore*; net_unittests: HttpAuthHandlerNegotiateTest.*:HttpAuthGSSAPIPOSIXTest.*; manually: start Chrome with command-line switch --gssapi-library-name=XYZ and see if this results in the Chrome process loading /usr/lib/whatever/XYZ as soon as an authenticated HTTP site is encountered. Review URL: http://codereview.chromium.org/4560001 Patch from Jakob Kummerow <jkummerow@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65939 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile errorananta@chromium.org2010-11-111-1/+1
| | | | | | | | | Bug=62853 TBR=amit Review URL: http://codereview.chromium.org/4696005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65839 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in the code which attempts to append the user agent to the list ↵ananta@chromium.org2010-11-111-14/+15
| | | | | | | | | | | | | | | of outgoing headers in ChromeFrame sub requests. The crash occurs because the current headers passed in the BeginningTransaction are NULL. Fixes bug http://code.google.com/p/chromium/issues/detail?id=62853 Bug=62853 Review URL: http://codereview.chromium.org/4792002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65834 0039d316-1c4b-4281-b951-d872f2087c98
* Mark FLAKY_ rather than DISABLED_ so I can debug the test on the Chromejoi@chromium.org2010-11-111-1/+1
| | | | | | | | | | | | Frame build bots, without turning them red. BUG=62636 TEST=none Review URL: http://codereview.chromium.org/4691006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65804 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of reapplying r64637.erg@google.com2010-11-1011-12/+12
| | | | | | | | | | | | | Move the automation message files from chrome/test/automation to chrome/common/. This requires a temporary override to chrome/common/DEPS until Part 3 lands. BUG=51409 TEST=compiles Review URL: http://codereview.chromium.org/4758001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65695 0039d316-1c4b-4281-b951-d872f2087c98
* Forgotten attributes for IChromeFrameInternal in the last commit.hansl@google.com2010-11-101-1/+4
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/4660003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65670 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the ShouldShowVersionMismatchDialog chrome frame test as it fails ↵ananta@chromium.org2010-11-101-1/+2
| | | | | | | | | | | | | all the time. Bug=62636 TBR=joi Review URL: http://codereview.chromium.org/4727004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65638 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a privileged callback used in IE CF to check whether to showjoi@chromium.org2010-11-108-41/+294
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | the version mismatch warning dialog. Used this in ceee/ to only show it once per tab. Changed the logic in Firefox to show the warning dialog even when in privileged mode. This will mean it gets shown once per Firefox window. Wrote a unit test for the additional logic in ChromeFrameActivex. To write the unit test, used com_mock.py to generate a mock of the IChromeFramePrivileged interface. This can be extended to generate mocks of the other CF interfaces. Discovered duplication of np_browser_functions.h and .cc, resolved this to a single copy (the one under chrome_frame). Changed things around so chrome_tab.idl is built only once; this also lets me more easily depend on it in the com_mock rule. BUG=none TEST=chrome_frame_unittests.exe Review URL: http://codereview.chromium.org/4563001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65613 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the CtrlN ChromeFrame test failures on IE7. On IE7 it appears that ↵ananta@chromium.org2010-11-101-1/+3
| | | | | | | | | | | | we receive two window open notifications for the window pattern Internet Explorer*. Not clear why. Updated the expectations of the test to account for this. Review URL: http://codereview.chromium.org/4700003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65603 0039d316-1c4b-4281-b951-d872f2087c98
* Instructions, and an xcopy exclusion list, to help you run Chrome Framejoi@chromium.org2010-11-101-0/+68
| | | | | | | | | | | | | | tests on a machine separate from your build machine. Useful e.g. if you are running IE9 on your build machine, which the tests currently aren't fully compatible with, or if you'd like to get other work done while the tests run. BUG=none TEST=try out the instructions, see if they work Review URL: http://codereview.chromium.org/4676003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65599 0039d316-1c4b-4281-b951-d872f2087c98
* Popup windows launched in a new window in ChromeFrame on IE8 would open ↵ananta@chromium.org2010-11-092-2/+2
| | | | | | | | | | | | | | | | | | | | behind and would not render any content until the user clicked on them. This is because in this context IE8 attempts to inplace activate the object with the active document as the doc host. We don't support in place activation and return E_NOTIMPL. However ieframe specifically expects the return value to be OLEOBJ_E_INVALIDVERB and ends up not sending in the other verbs like OLEIVERB_SHOW, OLEIVERB_UIACTIVATE etc leading to this problem. Fixes bug http://b/issue?id=3174688 Bug=3174688 Review URL: http://codereview.chromium.org/4690004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65595 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for IPersist to the ActiveX implementation.tommi@chromium.org2010-11-091-0/+1
| | | | | | | | | | | | | This can be useful when hosts have a pointer to the object and need to know the clsid of the implementation. Currently it is possible to get at this via IPersistPropertyBag, but since we support IPersist directly in our ActiveDoc implementation I think it's more consistent to support it on the ActiveX implementation as well. BUG=none TEST=No change. Review URL: http://codereview.chromium.org/4669004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65540 0039d316-1c4b-4281-b951-d872f2087c98
* Split out command IDs from chrome_dll_resource.h.evan@chromium.org2010-11-081-1/+1
| | | | | | | | | | | | The name of this file is a leftover from Windows. Split the command ids (which are used on all platforms) out, leaving just the Windows-specific resource IDs in the original file. TEST=compiles Review URL: http://codereview.chromium.org/4710001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply part of r64637, which caused mysterious failures on mac waterfall.erg@google.com2010-11-0813-20/+24
| | | | | | | | | | | | | This applies only the rename of IPC::ContextMenuParams to IPC::MiniContextMenuParams so that it doesn't conflict with ::ContextMenuParams (defined in webkit). This is about half the original patch. BUG=51409 TEST=compiles Review URL: http://codereview.chromium.org/4669005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65429 0039d316-1c4b-4281-b951-d872f2087c98
* Move Windows-specific Event Tracing for Windows implementation to base/win. siggi@chromium.org2010-11-061-6/+6
| | | | | | | | | | | fix users of same. BUG=none TEST=unittests Review URL: http://codereview.chromium.org/4517004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65310 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the FlashCreationTest.PerfWarm test as it seems to fail on the ↵ananta@chromium.org2010-11-051-1/+1
| | | | | | | | | | perf builder. TBR=amit Review URL: http://codereview.chromium.org/4501002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65280 0039d316-1c4b-4281-b951-d872f2087c98
* Some input tests no longer marked flakyamit@chromium.org2010-11-053-5/+50
| | | | | | | | | | | | | | | | For tests like CtrlW, CtrlN it's better to notice failures when they execute and not run them at all if the workstation is locked i.e. when they will certainly fail. Added a check to do exactly that :) BUG=none TESTS=CtrlR, CtrlW, CtrlN, CtrlF, AltD Review URL: http://codereview.chromium.org/4615001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65279 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for returning the session_id in both CreateExternalTab and ↵hansl@google.com2010-11-0512-47/+95
| | | | | | | | | | | | ConnectExternalTab. The ChromeFrame objects now provides an unfrozen interface called IChromeFramePrivate. This interface provides a GetSessionId() which returns the ID used by Chrome in its Tab javascript object. This ID is necessary in CEEE for its tabs management. BUG=None TEST=None Review URL: http://codereview.chromium.org/4467002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65257 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of single-module-per-logon-session-per-profile implementation ↵robertshield@chromium.org2010-11-055-87/+542
| | | | | | | | | | | | for Chrome Frame. BUG=61383 TEST=Run IE with version X of CF loaded. Register version Y of CF. Run a second IE process, notice that version Y when loaded defers to version X. Review URL: http://codereview.chromium.org/4144008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65236 0039d316-1c4b-4281-b951-d872f2087c98
* Back forward transitions would not work within ChromeFrame when attempted ↵ananta@chromium.org2010-11-054-6/+90
| | | | | | | | | | | | | | | | | | via the context menu. This was because the Back and Forward menu items on the context menu were disabled. The context menu is displayed by the active document in IE and it attempts to enable/disable these items based on entries in the IE travel log. The enabling of these items was failing as we were incorrectly passing in the string id of these options instead of their command id equivalents Should fix bug http://code.google.com/p/chromium/issues/detail?id=34657 Bug=34657 Test=Covered by new ChromeFrame context menu back forward test. Review URL: http://codereview.chromium.org/4500002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65231 0039d316-1c4b-4281-b951-d872f2087c98
* Use the LeakyLazyInstanceTraits in the ProxyFactory and metrics upload ↵ananta@chromium.org2010-11-042-2/+2
| | | | | | | | | | | | | thread objects in ChromeFrame as we don't control the threads on which these objects are instantiated and thus cannot terminate them gracefully. This should suppress the annoying DCHECKS during IE shutdown. Review URL: http://codereview.chromium.org/4517002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65136 0039d316-1c4b-4281-b951-d872f2087c98
* Remove FLAKY from tests that are no longer flaky.amit@chromium.org2010-11-041-11/+5
| | | | | | | | | | BUG=32321,37009,37087,30622 TEST=concerned tests Review URL: http://codereview.chromium.org/4486001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65117 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up some dependencies in Chrome Framesiggi@chromium.org2010-11-041-39/+11
| | | | | | | | | | | | | | | | | Libraries that depend on other targets cause the propagation of the other targets closure of library targets to all their dependents. This was the case with chrome_frame_ie, which caused npchrome_frame to link gmock and gtest. Best case, this will slow down the build. Worst case we're open to regressions that ship test code, as useful as our unittests are, I don't think users have much appreciation for installing them :). This may require another change in build\all.gyp, as building the crash tests is no longer implicit in building npchrome_frame. Also removed the base_noicu target, as all its dependents have a dependency on base.lib, so this won't prevent ICU usage regressions. TEST=none BUG=none Review URL: http://codereview.chromium.org/4406001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65043 0039d316-1c4b-4281-b951-d872f2087c98
* Reenabling the ChromeFrame test FullTabModeIE_WindowClose which failed ↵ananta@chromium.org2010-11-031-5/+1
| | | | | | | | | | | | | because the type lib needs to be generated and included in the chrome frame binary. This may need a clobber. Bug=61011 TBR=amit Review URL: http://codereview.chromium.org/4445001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64989 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move CaseInsensitiveCompare traits into the base namespace.tfarina@chromium.org2010-11-031-1/+1
| | | | | | | | | | | | | | | This should fix conflicts like: 2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope 2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare' Reported-by: Jeff Timanus <twiz@google.com> BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4366001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64877 0039d316-1c4b-4281-b951-d872f2087c98
* Add explicit build dependencies from npchrome_frame to chrome and ↵robertshield@chromium.org2010-11-021-0/+2
| | | | | | | | | | | chrome_dll. This is to avoid having non-versioned matched components in the build directory if only buildingg npchrome_frame which causes all manner of trouble. BUG=version-mismatched binaries can reside in the build folder when building only npchrome_frame TEST=NONE Review URL: http://codereview.chromium.org/4288001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64759 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression in ChromeFrame which would cause the headers like the UA to ↵ananta@chromium.org2010-11-021-3/+3
| | | | | | | | | | | | be appended twice. Bug=none Review URL: http://codereview.chromium.org/4249001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64694 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where in having ChromeFrame installed on the machine would cause a ↵ananta@chromium.org2010-11-0111-498/+8
| | | | | | | | | | | | | | | | | | | | | | | | non chrome frame email site to automatically logout after logging in. ChromeFrame appends the chromeframe string to the user agent to outgoing requests initiated from IE. However this was only done in the protocol sink patch for top level requests. Sub requests would carry the IE user agent which in this case would cause the web server to get confused and drop the connection. Fix is to resurrent the IHttpNegotiate vtable patch for the protocol patch as well. Removed the code which read the patch method from the registry and turned on the moniker or the httpequiv patch. It is unlikely that we will need this in the future. Cleaned up the http negotiate patch by removing references to the navigation manager and the ReportProgress patch which is not needed anymore. Fixes bug http://code.google.com/p/chromium/issues/detail?id=60745 Bug=60745 Review URL: http://codereview.chromium.org/4247001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64688 0039d316-1c4b-4281-b951-d872f2087c98
* An attempt to fix the flakiness with the JavascriptWindow open test series. ↵ananta@chromium.org2010-11-011-6/+4
| | | | | | | | | | | | These tests validate the window dimensions. The code to validate this was all wrong. TBR=amit Review URL: http://codereview.chromium.org/4102017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64652 0039d316-1c4b-4281-b951-d872f2087c98
* Adding IChromeFrameInternal as an interface. It is not implemented yet.hansl@google.com2010-11-011-1/+11
| | | | | | Review URL: http://codereview.chromium.org/4102016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64649 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor automation messages." due to mysterious problems on mac.erg@google.com2010-11-0118-36/+33
| | | | | | | | | | | | | This reverts commit c1c1fed998ee4d839bfe256150e5e59220ebc0ef (r64637). TBR=nirnimesh@ BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4194007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64644 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor automation messages.erg@google.com2010-11-0118-33/+36
| | | | | | | | | | | | | | | | | automation_messages used to live in chrome/test/automation, when it's needed by browser and chrome_frame. When I started lifting code out of headers and into implementation files, I was getting link errors and temporarily solved the problem by compiling the cc files manually into libbrowser.a. Now this is part of chrome/common/ which is included by all targets needed. While doing this, discover that automation IPC redefines the ContextMenuParams struct. Rename it to MiniContextMenuParams. BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4200007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64637 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this to see if this fixes ChromeFrame tests. Please reland with ↵ananta@chromium.org2010-10-2813-92/+35
| | | | | | | | | | | | | the tests fixed. Revert 64252 - The ChromeFrame objects now provides an unfrozen interface called IChromeFramePrivate. This interface provides a GetSessionId() which returns the ID used by Chrome in its Tab javascript object. Review URL: http://codereview.chromium.org/3541017 TBR=hansl@google.com Review URL: http://codereview.chromium.org/4134008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64287 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for built-in DNS resolver/cache.agayev@chromium.org2010-10-282-2/+2
| | | | | | | | | BUG=60149 TEST=None Review URL: http://codereview.chromium.org/4216001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64271 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of FLAKY_ tests to match current realitystuartmorgan@chromium.org2010-10-281-3/+1
| | | | | | | | | | | Mostly this is removing FLAKY_ where the bug was fixed but the label never removed, but also switches some FLAKY_ to platform-specific FAILS_. BUG=28372,32048,32070,35341,45561,48544,48562,52858 TEST=N/A Review URL: http://codereview.chromium.org/4087009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64264 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame objects now provides an unfrozen interface called ↵hansl@google.com2010-10-2813-35/+92
| | | | | | | | IChromeFramePrivate. This interface provides a GetSessionId() which returns the ID used by Chrome in its Tab javascript object. Review URL: http://codereview.chromium.org/3541017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64252 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64202 - Initial support for built-in DNS resolver/cache.yusukes@chromium.org2010-10-282-2/+2
| | | | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3693001 TBR=agayev@chromium.org Review URL: http://codereview.chromium.org/4208002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64204 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for built-in DNS resolver/cache.agayev@chromium.org2010-10-282-2/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3693001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64202 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the FullTabModeIE_WindowClose ChromeFrame test as it causes ↵ananta@chromium.org2010-10-271-9/+5
| | | | | | | | | | | | | IE7/IE8 to put a security warning infobar. Bug=61011 TBR=amit Review URL: http://codereview.chromium.org/4168005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64173 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a number of failing chrome frame tests on Vista with IE7. Most of ↵ananta@chromium.org2010-10-273-0/+76
| | | | | | | | | | | | | | | these failures appear related to WebBrowser2::Navigate for the new window disposition opening up the popup in a new tab thus causing the tests to fail. A couple of failures are unrelated and need investigation. Bug=60987 TBR=amit Review URL: http://codereview.chromium.org/4143004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64153 0039d316-1c4b-4281-b951-d872f2087c98
* Pass Chrome's UA with chromeframe appended at the end in the user agent ↵ananta@chromium.org2010-10-271-6/+9
| | | | | | | | | | | | | | passed in ChromeFrame requests initiated in IE. Fixes bug http://b/issue?id=3022937 Bug=3022937 Review URL: http://codereview.chromium.org/4202003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64102 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for OnClose event in ActiveX and NPAPIamit@chromium.org2010-10-278-2/+124
| | | | | | | | | | | | | | | Provide event notification for window.close called within ActiveX and NPAPI. Currently this is handled in ActiveDocument to close the popups. In ActiveX and NPAPI plugin we just fire an event as it is upto the container to decide what's the right thing to do. BUG=59664 TEST=New tests ChromeFrameTestWithWebServer.FullTabModeIE_WindowClose, ChromeFrameTestWithWebServer.FullTabModeFF_WindowClose Review URL: http://codereview.chromium.org/4152005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64092 0039d316-1c4b-4281-b951-d872f2087c98
* Change miscellaneous LOG(INFO)s to VLOG()s that I missed the first time ↵pkasting@chromium.org2010-10-276-11/+12
| | | | | | | | | | | | through, either because they were LOG_IF() (which I didn't search for) or they were added during the week I was changing things. Plus a few misc. cleanup bits. BUG=none TEST=none Review URL: http://codereview.chromium.org/4111002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63998 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in ChromeFrame if chrome launch timeouts.stoyan@chromium.org2010-10-261-2/+3
| | | | | | | BUG=60550 Review URL: http://codereview.chromium.org/4096003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63958 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the parsing of X-UA-COMPATIBLE header (and meta tag) to allow comma ↵erikwright@chromium.org2010-10-263-11/+31
| | | | | | | | | | or semi-colon as delimiter for backwards compatibility. BUG=52601 TEST=chrome_frame_unittests / UtilTests.XUaCompatibleDirectiveTest Review URL: http://codereview.chromium.org/4103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63937 0039d316-1c4b-4281-b951-d872f2087c98
* Add metrics tracking how many times users are bugged with "version mismatch, ↵robertshield@chromium.org2010-10-262-0/+2
| | | | | | | | | | | please restart your browser" dialogs during CF udpates. If this number gets high, we should do something better. BUG=none TEST=none Review URL: http://codereview.chromium.org/4110001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63936 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame network tests were broken since the change to honor the ↵ananta@chromium.org2010-10-262-1/+20
| | | | | | | | | | | | | | | | | | | | | | automation protocol version in ChromeFrame which basically breaks the automation connection if the protocols don't match. While this is fine when chrome is the automation client, it breaks chrome frame net tests because when the automation channel is established the automation provider sends over the version of the current module in the hello message. In the case when the current module is chrome the version goes over correctly. For chrome frame net tests there is no version string. Hence the channel never gets established. Fix is to retrieve the protocol version via a virtual protected function in the automation provider. The testing automation provider overrides this function in the network tests and returns the version of chrome.dll TBR=amit,robertshield Review URL: http://codereview.chromium.org/4160002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63860 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-266-11/+12
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crasher observed in ChromeFrame stable build 7.0.517.43. Crash occurs ↵ananta@chromium.org2010-10-253-11/+33
| | | | | | | | | | | | | | | | | | | | when we attempt to terminate the urlmon transaction with a spurious BindToObject call which is supposed to fail but release the transaction. While this works mostly it causes a crash in urlmon at times on IE7. To workaround this we now save away the IInternetProtocol interface which represents the transaction object in our bind context info structure which is maintained per bind context and terminate the protocol when we want the transaction to be destroyed. Fixes bug http://code.google.com/p/chromium/issues/detail?id=60370 Bug=60370 Review URL: http://codereview.chromium.org/3984006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63769 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-24 16:58:24 +0000