| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- simplify the public interface
- remove unneeded methods
- make it easier to understand
TEST=none
BUG=49680
Review URL: http://codereview.chromium.org/2881028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3029019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
build error I was seeing on my machine.
TBR=amit
Review URL: http://codereview.chromium.org/3048010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/3031009
A different approach to avoid crashes in buggy 3rd party BHOs.This time we're more preceise and only target the buggy components.Behaviour for components that handle browser events correctly, is unchanged even in the presence of buggy DLLs.The core class here is the BuggyBhoTls class and here's the comment for that class:
// Construct an instance of this class on the stack when firing web browser
// events that can be sent to buggy BHOs. This class will intercept those
// BHOs (see list in cc file) and ignore notifications to those components
// for as long as the BuggyBhoTls instance on the stack lives.
TEST=A better fix for bug 44463 but also fixes bug 49373 and a number of crashes that haven't been associated with bug reports yet.
BUG=44463, 49373
Review URL: http://codereview.chromium.org/3053008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
happens whenever a tab rendering a chrome frame
page receives focus by switching to it. Whenever we receive focus in ChromeFrame we send over an IPC to set the initial
focus to Chrome. In this IPc we invoke the FocusThroughTabTraversal function on the TabContents which basically cycles
through the focus on the page which is not correct for full tab mode.
Fix is to handle the WM_SETFOCUS message in the active document and invoke the GiveFocusToChrome with false indicating
that we don't want to invoke the FocusThroughTabTraversal function which cycles through the view. It is sufficient to
set focus to the tab.
We also handle the WM_SHOWWINDOW message in the active document and set focus to the document if it is visible. This
ensures that the page gets focused correctly.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=48459
Fixes bug http://code.google.com/p/chromium/issues/detail?id=25890
Bug=48459, 25890
Review URL: http://codereview.chromium.org/2825061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BHOs.This time we're more preceise and only target the buggy components.Behaviour for components that handle browser events correctly, is unchanged even in the presence of buggy DLLs.The core class here is the BuggyBhoTls class and here's the comment for that class:
// Construct an instance of this class on the stack when firing web browser
// events that can be sent to buggy BHOs. This class will intercept those
// BHOs (see list in cc file) and ignore notifications to those components
// for as long as the BuggyBhoTls instance on the stack lives.
TEST=A better fix for bug 44463 but also fixes bug 49373 and a number of crashes that haven't been associated with bug reports yet.
BUG=44463, 49373
Review URL: http://codereview.chromium.org/3031009
TBR=tommi@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we're more preceise and only target the buggy components.Behaviour for components that handle browser events correctly, is unchanged even in the presence of buggy DLLs.The core class here is the BuggyBhoTls class and here's the comment for that class:
// Construct an instance of this class on the stack when firing web browser
// events that can be sent to buggy BHOs. This class will intercept those
// BHOs (see list in cc file) and ignore notifications to those components
// for as long as the BuggyBhoTls instance on the stack lives.
TEST=A better fix for bug 44463 but also fixes bug 49373 and a number of crashes that haven't been associated with bug reports yet.
BUG=44463, 49373
Review URL: http://codereview.chromium.org/3031009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=48987
Review URL: http://codereview.chromium.org/3010018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/3007008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
headers to be terminated by
a single \r\n combination as wininet adds the terminating \r\n at the end while sending the headers out.
TBR=stoyan
Review URL: http://codereview.chromium.org/2888019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Create separate RGS file for registering CLSID as a BHO. Remove the code that manually did the BHO registration.
BUG=48987
Review URL: http://codereview.chromium.org/3029007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=see bug
BUG=44463
Review URL: http://codereview.chromium.org/2824056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2825053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logs now have the following format:
[list_size, log1, log2, ..., log_n, checksum].
where each log is bzipped before being written. Upon reading the logs from disk, we verify the data and register whether we faced corruptions or not.
r=jar
Review URL: http://codereview.chromium.org/2936005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
value in the http headers needs to be
terminated with a trailing \r\n\r\n combination instead of a single \r\n value.
TBR=stoyan
Review URL: http://codereview.chromium.org/3019010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2824057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requests issued by chrome.
--host-resolver-parallelism=XXX
This is a useful debugging tool, since for some users too many parallel DNS requests results in spurious DNS failures from their resolver.
BUG=44489
Review URL: http://codereview.chromium.org/3019007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use a scoped_ptr<Lock> instead of Lock in resource bundle.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3038005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=should be no functional change except if there are buggy BHOs that we know of loaded in IE.
BUG=44463
Review URL: http://codereview.chromium.org/2906011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(and possible murder of NavigationManager).
Review URL: http://codereview.chromium.org/2813053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
IPC on a NULL automation server.
Bug=49132
TBR=amit
Review URL: http://codereview.chromium.org/2868052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
occur if the page had an unload handler.
We execute unload handlers in the WM_DESTROY message in the external tab and spin a nested loop waiting for the
unload handlers to finish. This causes a deadlock at times if a windows message is dispatched to IE which is blocked
in DestroyWindow.
The fix is to remove the nested loop mess from the external tab and instead send over a special automation message
to Chrome in which context we execute the unload handlers. The message contains the notification window and the
actual window message to be posted back when the unload handlers finish executing.
The active document/activex spin a GetMessage loop waiting for this message to arrive. To ensure that we don't wait
indefinitely we have a 1 second timer and exit the loop if this timer is received.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=49132
Bug=49132
Test=Covered by existing unload event test.
Review URL: http://codereview.chromium.org/3014001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously committed as r52349 and r52336. Related commits: r52367, r52364
and r52343.
Rerunning trybots due to previous trybot breakage.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2965015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2893015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If chrome is warmed up during a single reboot, it gets paged
in for subsequent reboots and the cold startup times essentially
look like warm times thereafter! The 'warm up' is done by
setting up a 'RunOnce' key during DLLRegisterServer of
npchrome_frame.dll.
This works because chrome prefetch becomes part of boot
prefetch file ntosboot-b00dfaad.pf and paged in on subsequent
reboots. As long as the sytem does not undergo significant
memory pressure those pages remain in memory and we get pretty
amazing startup times, down to about 300 ms from 1200 ms
The downside is:
- Whether chrome frame is used or not, there's a read penalty
(1200-300 =) 900 ms for every boot.
- Heavy system memory usage after reboot will nullify the benefits
but the user will still pay the cost.
- Overall the time saved will always be less than total time spent
paging in chrome
- We are not sure when the chrome 'warm up' will age out from the
boot prefetch file.
The idea here is to try this out on chrome frame dev channel
and see if it produces a significant drift in startup numbers.
Review URL: http://codereview.chromium.org/2936010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hang occurs because of a race condition
in registering the http/https protocol factories. The net tests registers a protocol factory and the Chrome
AutomationResourceMessageFilter also registers factories. If the net tests ends up being first in the chain then
the requests are incorrectly dropped.
Fix is to register the net tests protocol factory before instantiating the AutomationResourceMessageFilter.
TBR=stoyan
Review URL: http://codereview.chromium.org/2959013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_active_document.cc.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2955011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2934005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on IHttpNegotiate patch.
Moved some code based on over-conservative assumptions to execute earlier in pipeline.
Will prevent BUG=38480 to manifest itself.
BUG=47879
Review URL: http://codereview.chromium.org/2987001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
seems to be a race condition causing
the tests to hang on startup on the builder. It appears that on chrome frame net tests startup we process an initial
HTTP head request in the test automation provider factory and end up sending this as the response to IE instead of
the expected dummy chrome frame page. This causes the tests to hang.
Fix is to also check for a valid tab handle in the test automation provider factory instead of just asserting for
the same.
TBR=amit
Review URL: http://codereview.chromium.org/2951015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
history if the back and the current page both
were rendered in ChromeFrame. This was because the back operation would incorrectly navigate twice. Once via IE history
navigation and the other navigation would originate within the renderer and would execute as a new navigation in IE.
Fix is to not report backforward navigations as top level navigations to the external host.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=44403
Bug=44403
Test=Covered by ChromeFrame test
Review URL: http://codereview.chromium.org/2982003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to control resource id assignment across all grd
files so we can avoid id collisions.
BUG=48625
Review URL: http://codereview.chromium.org/2961002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window.
I'm not sure why the server couldn't be created but we shouldn't crash.
BUG=48846
TEST=Fixes crash.
Review URL: http://codereview.chromium.org/2895010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sink tests. Have the test mock contain, not inherit the IE event sink. Use the new test server to verify the right requests are being sent.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2822016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome would open up a popup window which
opened up in IE. This is because of an orphan external tab container created to handle the popup. This tab is destroyed
in the normal case when the active document window is destroyed, which is the parent of the external tab container.
However in this case the active document is destroyed without its window being created thus resulting in the external tab
container lying around which holds a reference to the automation provider.
Fix is to pass the ChromeFrameAutomationClient window as the parent window in the AutomationMsg_ConnectExternalTab
message.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=48732
Bug=48732
Covered by ChromeFrame test FullTabNavigationTest.JavascriptWindowOpenDifferentDomain
Review URL: http://codereview.chromium.org/2911006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prefs, to manage preferences set by extensions.
Update various callers of the PrefValueStore constructor accordingly.
The initial user will be the proxy extension API.
BUG=266
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/2823037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BINDSTATUS_MIMETYPEAVAILABLE.
BUG=48685
Review URL: http://codereview.chromium.org/2951006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correctly during startup" for hansl@.
Original review here: http://codereview.chromium.org/2909003/show
TBR=hansl
Review URL: http://codereview.chromium.org/2924004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=stoyan
Bug=48175
Review URL: http://codereview.chromium.org/2886019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be registered (and thus used) if the installer is run with the --chrome-frame flag.
Remove a bunch of CF-specific code in the process.
BUG=46818
TEST=Can use the same mini_installer.exe to install either Chrome or Chrome Frame.
Review URL: http://codereview.chromium.org/2839009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Upstreamed support for partial results from devtools' version
- Made DidRead receive data and length (in order to support websockets data)
- Fixed all the clients.
Added net/server with http socket implementation that supports websockets. Will remove net/tools fetch client and server later.
Review URL: http://codereview.chromium.org/2868036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead. XP ignores pages read as data
while mapping image sections. This shows a reasonable improvement in cold startup performance on XP.
This change only comes into effect for headless mode which enables us to try out the effect on the perf bots
and for chrome frame processes.
Code mostly written by Amit.
Added a chrome frame perf tests which measures LoadLibrary in cold mode with pre-reading.
Bug=45510
Review URL: http://codereview.chromium.org/2805064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2838041
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2864039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2838041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will enable chrome to display all cookies used/blocked on the current site to the user instead of just the information that something was blocked. The cookies are collected in data structures suitable for displaying them using the cookies tree model.
BUG=45230
TEST=none
Review URL: http://codereview.chromium.org/2370001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=48175
Review URL: http://codereview.chromium.org/2810045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to not terminate at times leading to
extract build failures.
TBR=amit
Bug=47596
Review URL: http://codereview.chromium.org/2838036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
address bar to initiate navigation.
These tests fail at times on the builders because of an incorrect URL actually being sent in to Chrome.
Fix is to increase the delay between selecting the address bar via Alt+D and sending the url.
TBR=amit
Review URL: http://codereview.chromium.org/2827036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that the dll unloads correctly
after every test.
Review URL: http://codereview.chromium.org/2813039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51147 0039d316-1c4b-4281-b951-d872f2087c98
|