| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
build. These
crashes occur in the Chrome HTTP stack which is used for uploading UMA data. I could not
repro these crashes though and they seem to occur while posting tasks to a deleted message
loop. Currently we create an io thread on the fly for uploading the uma data and destroy
it when we are done. To workaround this issue we are attempting to create one IO thread
and leave it running. At this point this thread object is leaked as we don't have a good
way of stopping this from the IO thread. Added a TODO in the code to this effect.
I also added a check for whether the ChromeFrameMetricsDataUploader::Initialize function
succeeds as it appears that there are failures on the field due to failure in creating
the unnamed window.
The ChromeFrame metrics service object is no longer a ThreadLocal object.
Review URL: http://codereview.chromium.org/3396005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on first request and cache them.
In order to refresh the policy settings the browser has to be restarted. Future implementations may support pushing out policy changes without requiring the user to restart the browser.
TEST=Use the policy templates to change the default renderer ("Configure the default renderer for Chrome Frame") and relevant exclusion lists.
BUG=29349
Review URL: http://codereview.chromium.org/3435004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProxyService::CreateDirect.
(Note: This was a TODO for eroman).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3336021
Revert Review URL: http://codereview.chromium.org/3444001/show
TBR=eroman@chromium.org
Fix the bad git svn rebase (that caused a bad merge, that integrates other files
in the original cl, now this should be fixed).
Review URL: http://codereview.chromium.org/3413008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
error.
Bug=47596
Review URL: http://codereview.chromium.org/3432005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the ChromeFrame request context is
destroyed.
Bug=55467
Review URL: http://codereview.chromium.org/3393002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_frame.gyp a little while back.
BUG=0
TEST=None
Review URL: http://codereview.chromium.org/3443001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 59362 - net: Rename ProxyService::CreateNull to ProxyService::CreateDirect.
(Note: This was a TODO for eroman).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3336021
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/3444001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This was a TODO for eroman).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3336021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome's http stack in
ChromeFrame to upload this data. The crash occurs in the HttpAuthHandlerNegotiate code while
attempting to perform a DNS resolution with a null HostResolver pointer.
Fix is to use the net::HttpAuthHandlerRegistryFactory::Create function to create the AuthHandler factory as this function takes in
the host resolver as an argument.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=55467
Bug=55467
Review URL: http://codereview.chromium.org/3328023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Bug=54908
TBR=robertshield
Review URL: http://codereview.chromium.org/3328022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cleanup patch isn't as impactful; this only shrinks our .a files by 304k.
This patch also renames chrome/browser/history/download_type.h to download_create_info.h because there are then two download_type.cc files and MSVS will have the .obj from one of those overwrite the other.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3351005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Differences from the above CL include the following:
- RendererPreferences settings for ExtensionHosts are now extracted from the associated_tab_contents(). This ensures that extension hosts will also forward top level navigation requests.
- Instead of explicitly setting the delegate on the TabContents in ExtensionHost::ShowCreatedWindow, instead I instruct the associated tab-contents to add the newly build tab-contents. Note that this is the exact same behaviour performed by TabContents when initiating a top-level navigation to the host browser.
Points of interest:
- See the TODO in navigation_controller.cc. This problem of an unrecognized navigation entry needs further investigation.
- Also, I found that if the ActiveX control is navigated to a chrome-extension URL, then the top-level-navigation will fail because of the format of the URL. The fix was to construct a temporary url in place of the chrome-extension url.
BUG=51091
TEST=None
Review URL: http://codereview.chromium.org/3357013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame when we
update the navigation state. We now default to SECURELOCK_SET_UNSECURE in case of any auth
errors.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=53649
Bug=53649
Review URL: http://codereview.chromium.org/3345020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
user level.
Review URL: http://codereview.chromium.org/3320018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This generalizes the existing pattern matching code to support UTF8 strings.
BUG=53158
TEST=string_util_unittests.cc
Review URL: http://codereview.chromium.org/3295018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
server. This allows
us to control the behavior of the http server in the future.
The change in the \chrome_frame_tester_helpers.js file is to send over asynchronous XHR post
requests to prevent the browser from blocking in the UI thread while waiting for a response.
We copy the the CFInstall and CFInstance scripts to the test\data folder to enable the mock
server to serve them. Added support for the /echoheader? based GET requests. Some ChromeFrame
tests rely on this.
Bug=54908
Review URL: http://codereview.chromium.org/3356013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failing since
we started passing in the profile name in the list of parameters being passed to the
attach external tab request. The tests failed because when we launch the automation server
we match the profile names which end up being different for the original document url which
defaults to iexplore and the attach tab request which contains the profile name under which
chrome is launched which changes to Google Chrome Frame for IE6/7. We also need to escape
out the profile name while parsing it in the ParseAttachExternalTabUrl helper class.
Will add a test in a subsequent CL.
TBR=amit,twiz
Review URL: http://codereview.chromium.org/3299017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
can not be used to navigate to http and https URLs.
BUG=none
TEST=NavigationTest.GcfProtocol2, NavigationTest.GcfProtocol3
Review URL: http://codereview.chromium.org/3307019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(http://codereview.chromium.org/3295019)
The problem is that by allowing ActiveX controls to hook top-level requests, the redirect in the ChromeFrameTestWithWebServer.WidgetModeIE_SrcProperty was being forwarded to the host browser in IE8.
BUG=54920
TEST=ChromeFrameTestWithWebServer.WidgetModeIE_SrcProperty
TBR=ananta
Review URL: http://codereview.chromium.org/3325019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the host browser with a ChromeFrame instance. If a ChromeFrame instance was loaded with a given profile, the bho used to always forward top-level navigation requests to a CF full-tab instance using the default (iexplore) profile. This caused problems with the automation channel, and the navigation would not complete.
I also cleaned up the gcf and host networking registry keys used by Chrome-Frame so that ActiveX instances will also respect their values.
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/3295019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome frame helper processes on launch (after setting its own hook).
BUG=53127
TEST=You can't start more than one medium/low integrity chrome_frame_helper.exe per desktop.
Review URL: http://codereview.chromium.org/3371002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
symbols.
BUG=53127
TEST=the .exe and .dll as well as their respective .pdbs get archived by the builder.
Review URL: http://codereview.chromium.org/3297017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_frame.gyp:chrome_frame_tests since the tests refuse to start without the crash service built.
TEST=clobber, build chrome_frame_tests, see if they run
BUG=None
Review URL: http://codereview.chromium.org/3295004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WM_NOTIFYPARENT messages. The hosted CF instance may have spawned a pop-up window. We do not want that pop-up window to lose focus/or dismiss itself when interacting with the CF instance as a result of the SetFocus(...) call here. To prevent this problem, we compare the root owner windows of the focus and plugin windows, instead of just testing !IsChild.
Reviewer note: The semantics of comparing root owner windows are slightly different from before. Will this modified test be safe for the purposes of the original test?
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2063009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
EXE's pdb at build time.
BUG=53127
TEST=build both chrome_frame_helper and chrome_frame_helper_dll and get two pdbs.
Review URL: http://codereview.chromium.org/3308012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
injection technique.
BUG=53127
TEST=With two chrome_frame_helper.exe processes running, only a single BHO instance is created and SetSite is only called on the BHO once.
Review URL: http://codereview.chromium.org/3338011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome Frame's per-user registration method. Note that the process is not shutdown during un-registration in order for the process to keep running through updates. Shutdown for uninstallation will be done by the installer directly.
BUG=53127
TEST=chrome_frame_helper.exe starts running when Chrome Frame is registered in per-user mode.
Review URL: http://codereview.chromium.org/3291014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=53127
TEST=Run script, chrome_frame_helper.exe is shut down.
Review URL: http://codereview.chromium.org/3312010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is not directly
caused by ChromeFrame as such and occurs because of buggy IE plugins which intercept urlmon
and wininet and crash due to these dlls being unloaded while leaving vtable patches or hooks
in place.
Approach we are attempting is to use the Chrome HTTP stack via the URLFetcher object to
upload UMA data.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=54419
Bug=54419
Review URL: http://codereview.chromium.org/3296006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows.
It's that large.
TBR=nsylvain
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3296005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53127
TEST=chrome_frame_helper.exe connects to the crash process.
Review URL: http://codereview.chromium.org/3287008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
added during http://src.chromium.org/viewvc/chrome?view=rev&revision=57989.
BUG=53875
TEST="error" in the log is not followed by a ':' and an error code.
Review URL: http://codereview.chromium.org/3316002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=54345
TEST=gcf:http://www.google.com should not work by default
and should work only if 'AllowUnsafeURLs' is set to a
non-zero value in registry.
Review URL: http://codereview.chromium.org/3365008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
accessibility is on by default since revision 49344.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3336008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scheduled for updates.
Review URL: http://codereview.chromium.org/3362001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
refactor/cleanup in the chrome frame reliability tests.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3304004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Collect crash dump in the ReportData and ReportResult code path
only if chrome frame is directly at fault. We are getting too
much noise since this is high frequency intercept and quite
popular code path for crashes.
BUG=51488,44463
TEST=none
Review URL: http://codereview.chromium.org/3295008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54107
TEST=BHO registration happens during install.
Review URL: http://codereview.chromium.org/3348008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=53963
Review URL: http://codereview.chromium.org/3306003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
does not apply the patches itself.
TEST=There should be no changes but we were seeing some potential problems in house with other proprietary browser extensions.
BUG=none
Review URL: http://codereview.chromium.org/3359001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to supporess false positive crash reports,
add ExceptionBarrierReportOnlyModule to places where we
do not wrap the sink and just call original API.
BUG=51960
Review URL: http://codereview.chromium.org/3309002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This causes the installer to try to register the DLL which fails (since it doesn't export DllRegisterServer).
BUG=54107
TEST=The installer works again.
Review URL: http://codereview.chromium.org/3353001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
registration.
BUG=53127
TEST=Can register the CF DLL with non-admin privileges when calling into the alternate registration entry points.
Review URL: http://codereview.chromium.org/3190005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It won't link anymore otherwise.
TBR=nsylvain
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3330003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on SendInput.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3222004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the *TabCrashReload* tests.
TEST=Run debug versions of *TabCrashReload* tests. There should be no more dchecks.
BUG=none
Review URL: http://codereview.chromium.org/3241008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
IE's.
TEST=Set IsDefaultRenderer to 1 (REG_DWORD) under the ChromeFrame registry key. Check if the User agent header in requests is the Chrome user agent. Then set the value to 0 and make sure the regular user-agent header is there.
BUG=50788
Review URL: http://codereview.chromium.org/3130016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
uses redirects. We were not correctly marking the navigation as completed (when it was).
Fix the description of the timeout setting in the chrome frame reliability tests.
BUG=53875
TEST=Use an URL list that includes a URL that navigates to a site that uses redirects (e.g. www.google.com outside of the US). See that no error appears in the log for that site.
Review URL: http://codereview.chromium.org/3239008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
navigation sequence missing for the second URL loaded as part of the test. We were not firing the BeforeNavigate event for IE6 for navigations initiated by Webkit. This should also fix the Form post back forward tests which were failing on IE6.
TBR=amit
Review URL: http://codereview.chromium.org/3266011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3162047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57896 0039d316-1c4b-4281-b951-d872f2087c98
|