| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
work correctly
specifically when the attachment is downloaded in response to a form POST.
Fixes bug http://code.google.com/p/chromium/issues/detail?can=1&q=36694
Bug=36694
Test=There are some issues with downloading attachments off a localhost based URL. Will
submit a test once these issues are resolved.
TBR=stoyan
Review URL: http://codereview.chromium.org/3743005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=40797
Review URL: http://codereview.chromium.org/3646004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3750001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome, and requesting that |restore_focus_to_view| be passed as true, the Chrome-Frame instance will immediately focus the first focusable item on the loaded page. This does not match the focus behaviour of Chrome, or other browsers.
This focus behaviour was introduced in CL http://codereview.chromium.org/664009
. See changes TabProxy::SetInitialFocus.
I also corrected the Chrome-Frame unit-test file so that it no longer assumes that assigning focus to the Chrome-Frame instance will propagate the focus to the first focusable element in the loaded page.
BUG=none
TEST=ChromeFrameTestWithWebServer.WidgetModeIE_ObjectFocus
Review URL: http://codereview.chromium.org/3555020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change to return
true from the AutomationResourceMessageFilter::OnMessageReceived for network request IPCs. ChromeFrame
net tests also have a AutomationResourceMessageFilter instance which is not registered as a
real message filter and is instead invoked from the TestAutomationProvider.
Fix is to remove the dummy AutomationResourceMessageFilter instance and instead register the
filter as a real message filter. To achieve this the automation_resource_message_filter_
member in the AutomationProvider class is now protected.
TBR=tommi
Review URL: http://codereview.chromium.org/3741001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Include browser_thread instead of chrome_thread in more 97 files.
Now the remaining files that are including chrome_thread.h are:
chrome_thread.cc and browser_thread.h.
They will be fixed next.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3717004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I want to get to r492 to pick up the fix for http://code.google.com/p/googletest/issues/detail?id=321 , but r446 needs some changes, so I'm doing an extra commit for this revision. See comments at http://code.google.com/p/googletest/source/detail?r=446
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3705002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Rename entries starting from shell_integration.cc. More 30 files covered.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3708001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
namespace.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3695001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a memory leak in ChromeFrame which is caused by leaking the urlmon transaction objects.
This occurs because we return INET_E_TERMINATED_BIND from our IBindStatusCallback::OnDataAvailable
implementation to keep the transaction around, which leaks.
To ensure that it is freed correctly we issue a dummy BindToObject call on the moniker
which fails and cleans up the transaction.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=57549
Bug=57549
TBR=stoyan
Review URL: http://codereview.chromium.org/3539021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
plugin.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3614014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the urlmon transaction objects.
This occurs because we return INET_E_TERMINATED_BIND from our IBindStatusCallback::OnDataAvailable
implementation to keep the transaction around, which leaks.
To ensure that it is freed correctly we issue a dummy BindToObject call on the moniker
which fails and cleans up the transaction.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=57549
Bug=57549
Review URL: http://codereview.chromium.org/3570017
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/3619014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
transaction objects.
This occurs because we return INET_E_TERMINATED_BIND from our IBindStatusCallback::OnDataAvailable
implementation to keep the transaction around, which leaks.
To ensure that it is freed correctly we issue a dummy BindToObject call on the moniker
which fails and cleans up the transaction.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=57549
Bug=57549
Review URL: http://codereview.chromium.org/3570017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Landed in r61789, reverted in r61801 in case it was causing Vista Tests
(dbg)(1) to crash. Turns out that it wasn't, so this is the reland.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=test added.
Review URL: http://codereview.chromium.org/3614012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts r61789. It may have broken Vista Tests (dbg), maybe.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch gets us most of the way. The next patch finishes plumbing
into the SSL client socket pool.
BUG=none
TEST=none
http://codereview.chromium.org/3533013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=amit
Review URL: http://codereview.chromium.org/3588010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
MSAA AccessibleChildren.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3579010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Initial skeleton for refactored ChromeFrameAutomationClient and AutomationProxy for the needs of ChromeFrame.
TBR=amit
Review URL: http://codereview.chromium.org/3567019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3555012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Patch from Mitchell Berkowitz <mberkowitz@chromium.org>
Review URL: http://codereview.chromium.org/3310023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3319017
Patch from Mitchell Berkowitz <mberkowitz@chromium.org>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and AutomationProxy for the needs of ChromeFrame.
CFProxy is ready to some extent, while CFAC is mostly structure-only.
Review URL: http://codereview.chromium.org/3528004
TBR=stoyan@chromium.org
Review URL: http://codereview.chromium.org/3547013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
AutomationProxy for the needs of ChromeFrame.
CFProxy is ready to some extent, while CFAC is mostly structure-only.
Review URL: http://codereview.chromium.org/3528004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Frame should handle.
TEST=This adds a new policy list for Chrome Frame, "ChromeFrameContentTypes", which can be used to specify a list of content types that should always be rendered in Chrome Frame.
BUG=56543
Review URL: http://codereview.chromium.org/3611002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
during chrome-initiated xmlhttprequest aborts. Two similar problems are fixed by this CL.
I found a race condition during the early-termination processing of the NpapiUrlRequest objects. If NpapiUrlRequest::Stop is invoked before NpapiUrlRequest::OnStreamCreated, then it is possible that a new stream will be created on the Chrome-Frame side, for which an operation that has been officially cancelled within Chrome. The fix is to add a new parameter fo the NPAPIUrlRequest, stop_requested_ that is used to track this behaviour. If a new stream is created on a request that has been stopped, then that stream is immediately destroyed, without notification back to Chrome.
If Chrome requests an abort of a url request, then Chrome-Frame should not send any notifications back to Chrome concerning the tear-down of that request. The delegate is revoked in NPAPIUrlRequest::Stop to achieve this behaviour.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3530002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
network stack.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=57455
Bug=57455
Test=Covered by updated ChromeFrame test.
Review URL: http://codereview.chromium.org/3536005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=55918
Review URL: http://codereview.chromium.org/3595004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: this is a TODO in string_util.h)
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3594002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NPAPI implementation.
These include window.open requests, hrefs with target _blank, etc.
The ChromeFrame NPAPI plugin needs to set the renderer pref which indicates that the host browser
can handle top level requests.
We also pass an additional flag in the CreateExternal tab IPC which indicates whether the host
browser supports full tab mode browsing or not. This defaults to true for IE, as the activex
implementation relies on being able to launch a new window with the attach external tab prefix.
which assumes support for full tab mode for IE being available. If the host browser does not
support full tab browsing the window.open request which comes into the ExternalTabContainer
instance creates a dummy ExternalTabContainer instance which is destroyed when the top level
navigation info is sent back to the host browser.
This CL is a short term fix for the issues with the NPAPI ChromeFrame plugin. Will do some
investigation into a better approach.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=57319
Test=Covered by existing ChromeFrame widget mode tests WidgetModeIE_SrcProperty and
WidgetModeFF_SrcProperty
Fixed incorrect assumptions in the test files used by these tests.
Bug=57319
Review URL: http://codereview.chromium.org/3549006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
build slave :(
BUG=None
TBR=ananta@chromium.org
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that allows this test to wait until both events have occurred, irrespective of their relative ordering.
BUG=None
TEST=chrome_frame_tests --gtest_filter=DeleteBrowsingHistoryTest.*
Review URL: http://codereview.chromium.org/3609001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix "Save As" test by sending a single WM_CHAR to the text box.
BUG=56294
TEST=chrome_frame_tests --gtest_filter=*CFSaveAs
Review URL: http://codereview.chromium.org/3531004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the default registry factory would crash if it saw a Negotiate header when trying to do a CNAME lookup because of a NULL resolver. Since then I've changed HttpAuthHandlerNegotiate to skip the CNAME lookup step when the resolver_ is NULL.
So, one option is to make CreateDefault accept an optional HostResolver argument. My concern is that since passing in NULL is the easier choice, people will do it and encounter user problems when going through a Negotiate proxy. Hence, I force the correct behavior.
BUG=56819
TEST=net_unittests, try fetch client through a Negotiate authenticating proxy.
Review URL: http://codereview.chromium.org/3518001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the Chrome Frame Tests (IE8) build agent.
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/3528001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
user agent
TEST=The test currently fails, but you can run it!
BUG=55758
Review URL: http://codereview.chromium.org/3433026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
integers to memory. Since Chrome-Frame runs on Intelx86 architecture, this assumption was incorrect. To prevent future endian problems, I changed the routine to explicitly extract the minor and major version.
This versioning error was prevent access to the NPVERS_HAS_URL_AND_AUTH_INFO set of APIS, as the returned version was always zero.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3396028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
argument.
Previously the default registry factory would crash if it saw a Negotiate header when trying to do a CNAME lookup because of a NULL resolver. Since then I've changed HttpAuthHandlerNegotiate to skip the CNAME lookup step when the resolver_ is NULL.
So, one option is to make CreateDefault accept an optional HostResolver argument. My concern is that since passing in NULL is the easier choice, people will do it and encounter user problems when going through a Negotiate proxy. Hence, I force the correct behavior.
BUG=56819
TEST=net_unittests, try fetch client through a Negotiate authenticating proxy.
Review URL: http://codereview.chromium.org/3447027
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/3413039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the default registry factory would crash if it saw a Negotiate header when trying to do a CNAME lookup because of a NULL resolver. Since then I've changed HttpAuthHandlerNegotiate to skip the CNAME lookup step when the resolver_ is NULL.
So, one option is to make CreateDefault accept an optional HostResolver argument. My concern is that since passing in NULL is the easier choice, people will do it and encounter user problems when going through a Negotiate proxy. Hence, I force the correct behavior.
BUG=56819
TEST=net_unittests, try fetch client through a Negotiate authenticating proxy.
Review URL: http://codereview.chromium.org/3447027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The feature was never covered by automated tests, and a recent changelist addressed a bug in the feature (http://codereview.chromium.org/3167040).
The test validates the following:
1) That cached files are re-retrieved after the user requests their deletion.
2) That saved form data is deleted after the user requests its deletion.
3) That Chrome Frame tabs do not crash when the user deletes browsing history.
BUG=56212
TEST= (1) Run "chrome_frame_tests.exe --gclient_filter=DeleteBro*" (should pass) (2) Run the test, and immediately lock your workstation before it starts. It should still pass. (3) Comment out the call to RemoveBrowsingData in DeleteChromeHistory::OnAutomationServerReady (chrome_frame/delete_chrome_history.cc) and run the test. It fails. (4) Revert changes from 3, comment out the check for low integrity level in DeleteChromeHistory::DeleteBrowsingHistory (same file) and run the test. It fails.
Review URL: http://codereview.chromium.org/3365010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
already running before test launch (i.e., no spurious error message, leave it running as it was). Also, if it needs to be started, rather than waiting 500ms and assuming it is launched, poll the pipe and return when server is listening.
BUG=None
TEST="chrome_frame_tests" (optionally with a --gtest_filter=...). Allow it to run to completion (notice crash service starts and then stops). Launch test suite again, kill it after crash_service starts, launch it again. Notice it does not start new crash_service, nor log a needless "Failed to terminate process" warning. Watch debug.log for traces about the launch of crash_service.
Review URL: http://codereview.chromium.org/3437012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- AccountScreenTest.TestBasic (bug 49004)
- NPAPIVisiblePluginTester.VerifyNPObjectLifetimeTest (bug 34997)
- ChromeFrameTestWithWebServer.WidgetModeFF_CFInstanceSingleton (bug 31532, still one test to be fixed in that bug)
- SavePageBrowserTest.FileNameFromPageTitle (bug 52292)
- FilePathWatcherTest.DisappearingDirectory (bug 54822)
- FilePathWatcherTest.DestroyWithPendingNotification (bug 54822)
- FilePathWatcherTest.WatchDirectory (bug 54822)
- FilePathWatcherTest.Unregister (bug 54822)
- FilePathWatcherTest.DeleteDuringNotify (bug 54822)
- WindowAppleScriptTest.WindowOrder (bug 53584)
TBR=mal
BUG=49004, 34997, 31532, 52292, 54822, 53584
TEST=none
Review URL: http://codereview.chromium.org/3471020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed the message
pump we spin at the end of each test and replaced it with a simple Wait on the process handle.
Use the KillProcesses helper function in base to terminate running iexplore processes.
Review URL: http://codereview.chromium.org/3419022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that we allow switching using http header.
BUG=56269
TEST=none
Review URL: http://codereview.chromium.org/3397025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
loading language DLLs that did not have a region specifier.
BUG=56432
TEST=Chrome Frame loads correctly in non-region specific languages, e.g. French.
Review URL: http://codereview.chromium.org/3439020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60465 0039d316-1c4b-4281-b951-d872f2087c98
|