summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
...
* Small refactoring in preparation of the assassination of HttpNegotiate patch ↵stoyan@chromium.org2010-07-152-9/+7
| | | | | | | | (and possible murder of NavigationManager). Review URL: http://codereview.chromium.org/2813053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52547 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IE crash while attempting to send the AutomationMsg_RunUnloadHandlers ↵ananta@chromium.org2010-07-151-3/+9
| | | | | | | | | | | IPC on a NULL automation server. Bug=49132 TBR=amit Review URL: http://codereview.chromium.org/2868052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52546 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame tabs would hang at times while closing. This would randomly ↵ananta@chromium.org2010-07-156-2/+76
| | | | | | | | | | | | | | | | | | | | | | | | occur if the page had an unload handler. We execute unload handlers in the WM_DESTROY message in the external tab and spin a nested loop waiting for the unload handlers to finish. This causes a deadlock at times if a windows message is dispatched to IE which is blocked in DestroyWindow. The fix is to remove the nested loop mess from the external tab and instead send over a special automation message to Chrome in which context we execute the unload handlers. The message contains the notification window and the actual window message to be posted back when the unload handlers finish executing. The active document/activex spin a GetMessage loop waiting for this message to arrive. To ensure that we don't wait indefinitely we have a 1 second timer and exit the loop if this timer is received. Fixes bug http://code.google.com/p/chromium/issues/detail?id=49132 Bug=49132 Test=Covered by existing unload event test. Review URL: http://codereview.chromium.org/3014001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52523 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt four at landing the "histogram.h removed from message_loop.h" patch.erg@chromium.org2010-07-151-0/+1
| | | | | | | | | | | | | | Previously committed as r52349 and r52336. Related commits: r52367, r52364 and r52343. Rerunning trybots due to previous trybot breakage. TEST=none BUG=none Review URL: http://codereview.chromium.org/2965015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52496 0039d316-1c4b-4281-b951-d872f2087c98
* Do not wrap non-HTTP(s) requests.stoyan@chromium.org2010-07-151-1/+7
| | | | | | Review URL: http://codereview.chromium.org/2893015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52494 0039d316-1c4b-4281-b951-d872f2087c98
* Boot prefetch optimization for Chrome Frame (experimental)amit@chromium.org2010-07-151-45/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If chrome is warmed up during a single reboot, it gets paged in for subsequent reboots and the cold startup times essentially look like warm times thereafter! The 'warm up' is done by setting up a 'RunOnce' key during DLLRegisterServer of npchrome_frame.dll. This works because chrome prefetch becomes part of boot prefetch file ntosboot-b00dfaad.pf and paged in on subsequent reboots. As long as the sytem does not undergo significant memory pressure those pages remain in memory and we get pretty amazing startup times, down to about 300 ms from 1200 ms The downside is: - Whether chrome frame is used or not, there's a read penalty (1200-300 =) 900 ms for every boot. - Heavy system memory usage after reboot will nullify the benefits but the user will still pay the cost. - Overall the time saved will always be less than total time spent paging in chrome - We are not sure when the chrome 'warm up' will age out from the boot prefetch file. The idea here is to try this out on chrome frame dev channel and see if it produces a significant drift in startup numbers. Review URL: http://codereview.chromium.org/2936010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52489 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at fixing the chrome frame net tests hang on the builders. This ↵ananta@chromium.org2010-07-141-1/+6
| | | | | | | | | | | | | | | | hang occurs because of a race condition in registering the http/https protocol factories. The net tests registers a protocol factory and the Chrome AutomationResourceMessageFilter also registers factories. If the net tests ends up being first in the chain then the requests are incorrectly dropped. Fix is to register the net tests protocol factory before instantiating the AutomationResourceMessageFilter. TBR=stoyan Review URL: http://codereview.chromium.org/2959013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52366 0039d316-1c4b-4281-b951-d872f2087c98
* Replace NavigationManager DCHECK in favor of DLOG_IF(ERROR, ...) in ↵ericdingle@chromium.org2010-07-141-1/+1
| | | | | | | | | | | chrome_active_document.cc. BUG=None TEST=None Review URL: http://codereview.chromium.org/2955011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52354 0039d316-1c4b-4281-b951-d872f2087c98
* Sample of running integration test as a simple performance test.stoyan@chromium.org2010-07-141-0/+227
| | | | | | Review URL: http://codereview.chromium.org/2934005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52338 0039d316-1c4b-4281-b951-d872f2087c98
* Implement HTTP headers sniffing in the ProtocolSinkWrap, instead of relying ↵stoyan@chromium.org2010-07-143-40/+71
| | | | | | | | | | | | on IHttpNegotiate patch. Moved some code based on over-conservative assumptions to execute earlier in pipeline. Will prevent BUG=38480 to manifest itself. BUG=47879 Review URL: http://codereview.chromium.org/2987001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52337 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the chrome frame net tests failures on the builders. There ↵ananta@chromium.org2010-07-141-2/+2
| | | | | | | | | | | | | | | | | seems to be a race condition causing the tests to hang on startup on the builder. It appears that on chrome frame net tests startup we process an initial HTTP head request in the test automation provider factory and end up sending this as the response to IE instead of the expected dummy chrome frame page. This causes the tests to hang. Fix is to also check for a valid tab handle in the test automation provider factory instead of just asserting for the same. TBR=amit Review URL: http://codereview.chromium.org/2951015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52280 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame back forward navigations at times would mess up the navigation ↵ananta@chromium.org2010-07-133-1/+89
| | | | | | | | | | | | | | | | | | history if the back and the current page both were rendered in ChromeFrame. This was because the back operation would incorrectly navigate twice. Once via IE history navigation and the other navigation would originate within the renderer and would execute as a new navigation in IE. Fix is to not report backforward navigations as top level navigations to the external host. Fixes bug http://code.google.com/p/chromium/issues/detail?id=44403 Bug=44403 Test=Covered by ChromeFrame test Review URL: http://codereview.chromium.org/2982003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52235 0039d316-1c4b-4281-b951-d872f2087c98
* Assign resource ids from a central file.tony@chromium.org2010-07-131-1/+1
| | | | | | | | | | | This allows us to control resource id assignment across all grd files so we can avoid id collisions. BUG=48625 Review URL: http://codereview.chromium.org/2961002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52211 0039d316-1c4b-4281-b951-d872f2087c98
* Handling case where automation server is NULL when creating the active doc ↵tommi@chromium.org2010-07-132-1/+12
| | | | | | | | | | | | | window. I'm not sure why the server couldn't be created but we shouldn't crash. BUG=48846 TEST=Fixes crash. Review URL: http://codereview.chromium.org/2895010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52191 0039d316-1c4b-4281-b951-d872f2087c98
* [chrome_frame] Refactor/merge IE no interference tests with other mock event ↵kkania@chromium.org2010-07-1227-2134/+2875
| | | | | | | | | | sink tests. Have the test mock contain, not inherit the IE event sink. Use the new test server to verify the right requests are being sent. BUG=none TEST=none Review URL: http://codereview.chromium.org/2822016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52137 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame would leave chrome processes running if a page rendered in ↵ananta@chromium.org2010-07-121-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | Chrome would open up a popup window which opened up in IE. This is because of an orphan external tab container created to handle the popup. This tab is destroyed in the normal case when the active document window is destroyed, which is the parent of the external tab container. However in this case the active document is destroyed without its window being created thus resulting in the external tab container lying around which holds a reference to the automation provider. Fix is to pass the ChromeFrameAutomationClient window as the parent window in the AutomationMsg_ConnectExternalTab message. Fixes bug http://code.google.com/p/chromium/issues/detail?id=48732 Bug=48732 Covered by ChromeFrame test FullTabNavigationTest.JavascriptWindowOpenDifferentDomain Review URL: http://codereview.chromium.org/2911006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52094 0039d316-1c4b-4281-b951-d872f2087c98
* Add an ExtensionPrefStore, layered between the user prefs and the managed ↵pam@chromium.org2010-07-121-6/+2
| | | | | | | | | | | | | | prefs, to manage preferences set by extensions. Update various callers of the PrefValueStore constructor accordingly. The initial user will be the proxy extension API. BUG=266 TEST=covered by unit tests Review URL: http://codereview.chromium.org/2823037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52088 0039d316-1c4b-4281-b951-d872f2087c98
* Forward both BINDSTATUS_SERVER_MIMETYPEAVAILABLE and ↵stoyan@chromium.org2010-07-091-1/+0
| | | | | | | | | | BINDSTATUS_MIMETYPEAVAILABLE. BUG=48685 Review URL: http://codereview.chromium.org/2951006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51990 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up .grds, step 1: Alphabetize.pkasting@chromium.org2010-07-081-5/+4
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51906 0039d316-1c4b-4281-b951-d872f2087c98
* Applying "Solving a bug in Chrome Frame that Firefox doesn't set preferences ↵robertshield@chromium.org2010-07-081-1/+0
| | | | | | | | | | | | | correctly during startup" for hansl@. Original review here: http://codereview.chromium.org/2909003/show TBR=hansl Review URL: http://codereview.chromium.org/2924004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51881 0039d316-1c4b-4281-b951-d872f2087c98
* Reenabling the ChromeFrame JavascriptWindowOpen test. ananta@chromium.org2010-07-081-3/+1
| | | | | | | | | TBR=stoyan Bug=48175 Review URL: http://codereview.chromium.org/2886019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51810 0039d316-1c4b-4281-b951-d872f2087c98
* Include the Chrome Frame binary in Chrome installers. Note that it will only ↵robertshield@chromium.org2010-07-071-1/+1
| | | | | | | | | | | | | be registered (and thus used) if the installer is run with the --chrome-frame flag. Remove a bunch of CF-specific code in the process. BUG=46818 TEST=Can use the same mini_installer.exe to install either Chrome or Chrome Frame. Review URL: http://codereview.chromium.org/2839009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51729 0039d316-1c4b-4281-b951-d872f2087c98
* Brushed up listen socket:pfeldman@chromium.org2010-07-052-7/+12
| | | | | | | | | | | - Upstreamed support for partial results from devtools' version - Made DidRead receive data and length (in order to support websockets data) - Fixed all the clients. Added net/server with http socket implementation that supports websockets. Will remove net/tools fetch client and server later. Review URL: http://codereview.chromium.org/2868036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51635 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the pre-reading of chrome.dll to read it as an image section ↵ananta@chromium.org2010-07-031-7/+45
| | | | | | | | | | | | | | | | | | | instead. XP ignores pages read as data while mapping image sections. This shows a reasonable improvement in cold startup performance on XP. This change only comes into effect for headless mode which enables us to try out the effect on the perf bots and for chrome frame processes. Code mostly written by Amit. Added a chrome frame perf tests which measures LoadLibrary in cold mode with pre-reading. Bug=45510 Review URL: http://codereview.chromium.org/2805064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51594 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51572 - Clean up .grds, step 1: Alphabetize.pkasting@chromium.org2010-07-021-4/+5
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2838041 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/2864039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51575 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up .grds, step 1: Alphabetize.pkasting@chromium.org2010-07-021-5/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2838041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51572 0039d316-1c4b-4281-b951-d872f2087c98
* Store blocked and accessed cookies in the tab contents.jochen@chromium.org2010-07-021-2/+2
| | | | | | | | | | | This will enable chrome to display all cookies used/blocked on the current site to the user instead of just the information that something was blocked. The cookies are collected in data structures suitable for displaying them using the cookies tree model. BUG=45230 TEST=none Review URL: http://codereview.chromium.org/2370001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51545 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a crashing test: NoInterferenceTest.JavascriptWindowOpensatish@chromium.org2010-07-021-2/+4
| | | | | | | | | | TBR=ananta BUG=48175 Review URL: http://codereview.chromium.org/2810045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51530 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the ChromeFrame NavigationToRestrictedSite test as it causes IE8 ↵ananta@chromium.org2010-07-011-1/+3
| | | | | | | | | | | | | to not terminate at times leading to extract build failures. TBR=amit Bug=47596 Review URL: http://codereview.chromium.org/2838036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51333 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the ChromeFrame tests which rely on sending input to the IE ↵ananta@chromium.org2010-06-301-1/+1
| | | | | | | | | | | | | | address bar to initiate navigation. These tests fail at times on the builders because of an incorrect URL actually being sent in to Chrome. Fix is to increase the delay between selecting the address bar via Alt+D and sending the url. TBR=amit Review URL: http://codereview.chromium.org/2827036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51211 0039d316-1c4b-4281-b951-d872f2087c98
* Set ChromeFrame unpinned mode for the duration of the perf tests to ensure ↵ananta@chromium.org2010-06-292-4/+4
| | | | | | | | | | that the dll unloads correctly after every test. Review URL: http://codereview.chromium.org/2813039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51147 0039d316-1c4b-4281-b951-d872f2087c98
* Change chrome from statically enabling high resolution timers on windowsmbelshe@chromium.org2010-06-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | to enabling them dynamically - only when the application really needs them. I am working on some test cases for this, and will add them. But wanted to send out the concept for review. In this implementation, I modify the message loop to detect when the application has requested high resolution timers. Note that there are multiple MessageLoops active in a single process. After a period of time, we simply shut it off again. We could have set a timer or kept a count of active timers, or any number of more complex algorithms. But I think this algorithm is very simple and good enough. If an application continues needing high resolution timers for more than 1s, we'll turn the high-resolution timers back on again. One last change - since we've implemented the clamp at 4ms, there isn't a lot of point to our use of 1ms for timeBeginPeriod. I've modified that to 2 (which is half of 4ms, our target minimal interval). BUG=46531 TEST=MessageLoop.HighResolutionTimers Review URL: http://codereview.chromium.org/2822035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51102 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling the ChromeFrame reference build perf memory test as it causes a ↵ananta@chromium.org2010-06-291-1/+6
| | | | | | | | | | | crash for subsequent test runs. Bug=47812 TBR=amit Review URL: http://codereview.chromium.org/2845030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51101 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix ChromeFrame perf test failures on the experimental builder. ↵ananta@chromium.org2010-06-291-0/+1
| | | | | | | | | | | | | | | | | The test fails because of a crash while running one of the chrome frame creation tests. This test causes a crash on the builder and it appears to occur because of multiple chrome frame dlls being loaded in the process. One from the regular release\servers folder and the other one from the reference build. Attempted fix is to add a sleep after the call to CoFreeUnusedLibraries to allow the currently loaded chrome frame binary to unload. TBR=amit Review URL: http://codereview.chromium.org/2840024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51095 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame reference perf tests failures. CoFreeUnusedLibraries at ↵ananta@chromium.org2010-06-291-1/+0
| | | | | | | | | | | | times does not unload the chrome frame dll. Removing the corresponding expectation that validates whether the dll has been unloaded. TBR=amit Review URL: http://codereview.chromium.org/2847033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51084 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame perf tests now depend on Chrome's reference build. The ↵ananta@chromium.org2010-06-281-3/+1
| | | | | | | | | | | ChromeFrame reference build under trunk/deps/reference_builds/chrome_frame will be deleted in a separate CL. This fixes a crash while running chrome frame perf tests on the perf builder. Review URL: http://codereview.chromium.org/2859031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51060 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some unncessary dependencies on libxml.mad@google.com2010-06-271-1/+0
| | | | | | | | | | | As working on change committed in rev50132, instead of yet adding another project to the dependency list of libxml, I decided to abstract the dependency in the metrics helper. BUG=0 TEST=None Review URL: http://codereview.chromium.org/2753010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50952 0039d316-1c4b-4281-b951-d872f2087c98
* Massively simplify the NetworkChangeNotifier infrastructure:pkasting@chromium.org2010-06-251-10/+5
| | | | | | | | | | | | | | * Use a process-wide object (singleton pattern) * Create/destroy this object on the main thread, make it outlive all consumers * Make observer-related functions threadsafe As a result, the notifier can now be used by any thread (eliminating things like NetworkChangeObserverProxy and NetworkChangeNotifierProxy, and expanding its usefulness); its creation and inner workings are much simplified (eliminating implementation-specific classes); and it is simpler to access (eliminating things like NetworkChangeNotifierThread and a LOT of passing pointers around). BUG=none TEST=Unittests; network changes still trigger notifications Review URL: http://codereview.chromium.org/2802015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50895 0039d316-1c4b-4281-b951-d872f2087c98
* Make new (CTransaction) hooking and sniffing mechanism the default one.stoyan@chromium.org2010-06-242-7/+19
| | | | | | Review URL: http://codereview.chromium.org/2822028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50750 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the ChromeFrame reliability and perf tests startup in headless ↵ananta@chromium.org2010-06-236-29/+64
| | | | | | | | | | | | mode and also start crash_service.exe, which would serve as the crash handler for the duration of the test runs. This ensures that the tests don't hang for 60 seconds while unloading the chrome frame dll which waits for the exception handler code to uninitialize which blocks on machines which don't have the official crash server running. Review URL: http://codereview.chromium.org/2810024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50594 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully the last of the ChromeFrame window open test failures. The ↵ananta@chromium.org2010-06-231-27/+13
| | | | | | | | | | | | DocumentComplete event at times is fired twice by all IE versions for new windows. Updated the expectations to account for this. TBR=stoyan Review URL: http://codereview.chromium.org/2802017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50593 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the randomly failing ChromeFrame window open tests to account for the ↵ananta@chromium.org2010-06-231-17/+8
| | | | | | | | | | | | additional DocumentComplete event fired on IE8 as well on the same lines as IE7. This event fires twice randomly. Modified the expectations to handle this. TBR=stoyan Review URL: http://codereview.chromium.org/2799026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50576 0039d316-1c4b-4281-b951-d872f2087c98
* Some more ChromeFrame test fixes to get the failing IE7 new window tests to ↵ananta@chromium.org2010-06-233-14/+66
| | | | | | | | | | | | pass. On IE7 the DocumentComplete event is fired twice at times for popup windows. We need to add expectations for those. TBR=stoyan Review URL: http://codereview.chromium.org/2809031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50567 0039d316-1c4b-4281-b951-d872f2087c98
* Fix files with svn:executable permissions.thestig@chromium.org2010-06-231-0/+0
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50566 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame JavascriptWindowOpen test tries to open a popup in the ↵ananta@chromium.org2010-06-224-8/+14
| | | | | | | | | | | | | onload notification, which is blocked on IE7/8 by the popup blocker thus causing this test to consistently fail. Fix is to open the popup in the ondblclick notification and to fire dummy mouse down events to the IE window to trigger this event. TBR=amit Review URL: http://codereview.chromium.org/2866013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50458 0039d316-1c4b-4281-b951-d872f2087c98
* In pages rendered in ChromeFrame window open requests or link clicks with ↵ananta@chromium.org2010-06-222-1/+106
| | | | | | | | | | | | | | | | | | | | | target blank which target a different origin should initiate the navigation in the host browser. We achieve this by performing an origin check on the opener frame and the URL being opened. If the origins don't match we allow the host browser to handle this navigation. There is still one issue here as a popup window creation request is still initiated and sent out to the host browser which initiates a dummy attach external tab navigation. Subsequently while applying policy the OpenURL IPC is sent out to the host browser which initiates the navigation to the expected URL. This causes a dummy attach external tab entry to be created in the host browser's history which would have to be deleted. Fixes bug http://code.google.com/p/chromium/issues/detail?id=46667 Bug=46667 Test=Covered by new chrome frame unit test. Review URL: http://codereview.chromium.org/2855017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50416 0039d316-1c4b-4281-b951-d872f2087c98
* Make FixupURL() return a GURL instead of a string (i.e. do fixup + ↵pkasting@chromium.org2010-06-181-3/+2
| | | | | | | | | | | | | | canonicalization). Nearly every caller was already doing this. This in turn allows us to do better fixup/canonicalization of view-source: URLs. We now convert "view-source:google.com" into "view-source:http://google.com/". With a few changes scattered through the omnibox code, this also means we can do HTTP-stripping on view-source: URLs, and support the user typing in things like the case above. This also fixes some weirdness where if you tried to type something starting with "view-source:", the What You Typed match in the dropdown would show only a scheme, or a scheme plus "http:", in some cases. BUG=46612 TEST="view-source:google.com" should work. Review URL: http://codereview.chromium.org/2817011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50290 0039d316-1c4b-4281-b951-d872f2087c98
* The ChromeFrame UMA upload currently occurs every 30 seconds which is ↵ananta@chromium.org2010-06-182-6/+26
| | | | | | | | | | | | | | incorrect. We should emulate Chrome's upload model where there is an initial UMA upload followed by subsequent uploads every 30 minutes. The initial chrome frame UMA upload now occurs after 30 seconds followed by one every 10 minutes. Bug=46057 Review URL: http://codereview.chromium.org/2840010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50249 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an issue with the ChromeFrame protocol patch which shows up in the ↵ananta@chromium.org2010-06-181-1/+2
| | | | | | | | | | | | NavigationToRestrictedSite test. It appears that on IE7 we don't receive the NavigateComplete notification. The protocol patch is now active on the IE7 builder TBR=stoyan Review URL: http://codereview.chromium.org/2835010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50207 0039d316-1c4b-4281-b951-d872f2087c98
* Pref service strings should be std::string.estade@chromium.org2010-06-181-1/+1
| | | | | | | | | | | Part 1: Convert RegisterStringPref. BUG=none TEST=compile Review URL: http://codereview.chromium.org/2809022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50202 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 12:25:28 +0000