summaryrefslogtreecommitdiffstats
path: root/chrome_frame
Commit message (Collapse)AuthorAgeFilesLines
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-135-9/+9
| | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5685007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add named testing interface."phajdan.jr@chromium.org2010-12-115-17/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=67300 The change has been approved conditionally, i.e. if the outstanding review comments are handled in a follow-up as the top priority. Two weeks have passed, and I have not seen the follow-up. It is risky to keep this change in the tree, as it is already non-trivial to revert. Conflicts: chrome/browser/automation/automation_provider.cc chrome/test/ui/named_interface_uitest.cc ipc/ipc_channel_posix.cc TBR=nirnimesh BUG=chromium-os:8512 TEST=none Review URL: http://codereview.chromium.org/5707006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68944 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68932 - Make members of Singleton<T> private and only visible to the ↵satish@chromium.org2010-12-112-9/+6
| | | | | | | | | | | | | | | | | | singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 TBR=satish@chromium.org Review URL: http://codereview.chromium.org/5721005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68936 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequestJob URLRequestJob;tfarina@chromium.org2010-12-111-2/+2
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5607004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68935 0039d316-1c4b-4281-b951-d872f2087c98
* Make members of Singleton<T> private and only visible to the singleton type. ↵satish@chromium.org2010-12-112-6/+9
| | | | | | | | | | | | | | | This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness. As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file. There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5682008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68932 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a unit test broken by overriding reg keysamit@chromium.org2010-12-101-5/+7
| | | | | | | | | | | | | | | Earlier change to temporarily override registry keys caused shell API SHGetFolderLocation to fail. solution is to move this test out of the test fixture. TBR=tommi BUG=none TEST=UtilTests, GetTempInternetFiles Review URL: http://codereview.chromium.org/5769001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68800 0039d316-1c4b-4281-b951-d872f2087c98
* Sanitize PrefStore interface.mnissler@chromium.org2010-12-091-9/+7
| | | | | | | | | | | | | | | | | This reworks the PrefStore interface, specifically: - Split up the interface into PrefStore, which only provides reading functionality, and the derived PersistentPrefStore for the actual user pref store - Remove the hurt-me-plenty prefs() function from PrefStore, instead provide Get/Set/Remove operations - Remove special handling of default and user pref store from PrefValueStore and put it into PrefService - Pref change notification handling now almost exclusively handled through PrefValueStore - Adjust all consumers of these interfaces (but keep ConfigurationPolicyPrefStore untouched, that's up next on the list) BUG=64232 TEST=existing unit tests Review URL: http://codereview.chromium.org/5646003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68736 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary workaround to get tests that reference singletons either directly ↵tommi@chromium.org2010-12-097-88/+138
| | | | | | | | | | | | | | | | or indirectly to pass. With the recent Singleton refactoring, these tests started exposing some inherent problems with singletons, namely that one test can reference a state set by a different test, which can cause all sorts of flakiness. Furthermore, some of these tests could reference the registry which may have some user specific settings that could cause the tests to fail To work around these issues, I'm adding a few utility classes for tests (registry virtualization) and exposing a method to reset singletons before a test is run. TEST=Fixes flakiness and a few tests that could fail on the waterfall. BUG=none Review URL: http://codereview.chromium.org/5564009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68701 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for detecting text selection in chrome frame tests. This ↵kkania@chromium.org2010-12-096-21/+144
| | | | | | | | | | requires adding support for IAccessible2 interfaces. BUG=none TEST=none Review URL: http://codereview.chromium.org/4406002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68680 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Simplify the magic required to create IPC message headers.This gets rid ↵jam@chromium.org2010-12-082-44/+44
| | | | | | | | | of having to include the files in a magic place because of xcode dependency issues, and just makes it simpler to create new IPC message classes. It also gets rid of including the X_messages_internal.h file multiple times, which simplifies things and should make the build a little faster. In a future change, I will remove the "internal.h" files since they're no longer needed. Review URL: http://codereview.chromium.org/5526008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68664 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of std::wstring version of HasSwitch.tfarina@chromium.org2010-12-083-4/+4
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/5649003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68650 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in UrlmonUrlRequest to clear the map during shutdownamit@chromium.org2010-12-081-1/+1
| | | | | | | | | | | | | In UrlmonUrlRequestManager::StopAll we meant to clear the map but used map.empty() instead of map.clear(). BUG=none TEST=none Review URL: http://codereview.chromium.org/5656004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68649 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Chrome Frame metric to track channel errors that result in sad tabs.robertshield@chromium.org2010-12-083-2/+14
| | | | | | | | | BUG=65899 TEST=None Review URL: http://codereview.chromium.org/5665003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68631 0039d316-1c4b-4281-b951-d872f2087c98
* Some installer cleanup: introduced ChannelInfo class for fiddling with "ap" ↵grt@chromium.org2010-12-081-4/+0
| | | | | | | | | | | ClientState value. BUG=61609 TEST=added to and modified chrome/installer_util_unittests.exe appropriately Review URL: http://codereview.chromium.org/5656002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68603 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new GetInstance() method for singleton classes, take 2.satish@chromium.org2010-12-0810-66/+86
| | | | | | | | | | | | | | | | | | This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it. This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs). Suggested files to focus for reviewers: - joi@ for files under src/ceee - tommi@ for files under src/chrome_frame - maruel@ for the rest of the files. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5581008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
* Addressing code review comments from Tommi from the orignal CL ↵ananta@chromium.org2010-12-081-10/+9
| | | | | | | | | | | http://codereview.chromium.org/5632003/ BUG=65295 TEST=As described in the bug Review URL: http://codereview.chromium.org/5535008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68554 0039d316-1c4b-4281-b951-d872f2087c98
* Create new test binary for Chrome Frame for running QA tests. Original patch ↵kkania@chromium.org2010-12-082-0/+124
| | | | | | | | | by mberkowitz@chromium.org. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68546 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a DCHECK which fired in ChromeFrame which indicated that we had a ↵ananta@chromium.org2010-12-071-1/+17
| | | | | | | | | | | | | | | | | | | | | | pending request which is created when we switch into ChromeFrame and the URL request received from Chrome was for a different URL. This scenario occurs when we receive requests from Chrome for the current page which is being navigated away from while a new document is coming up. Fix is to disallow these requests while we have a pending request. The other fix is in the ExternalTabContainer where a spurious DCHECK was being fired in the BeforeUnload code path. Fixes bug http://code.google.com/p/chromium/issues/detail?id=65295 BUG=65295 TEST=As described in the bug. Review URL: http://codereview.chromium.org/5632003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68526 0039d316-1c4b-4281-b951-d872f2087c98
* Add PxSecure.dll to the list of buggy BHOs to which Chrome Frame avoids ↵robertshield@chromium.org2010-12-071-1/+1
| | | | | | | | | | | firing events. BUG=65748 TEST=Fewer crashes are received with PxSecure.dll at the top of the stack. Review URL: http://codereview.chromium.org/5550004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68522 0039d316-1c4b-4281-b951-d872f2087c98
* Removed code which was added only for debugging. ananta@chromium.org2010-12-061-1/+0
| | | | | | | | | | TBR=amit BUG=none TEST=none Review URL: http://codereview.chromium.org/5515005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68359 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race in the ChromeFrame metrics service start up code. This race could ↵ananta@chromium.org2010-12-042-1/+11
| | | | | | | | | | | | | | | | | be triggered if multiple BHO's attempted to start the metrics service object from different threads. Fix is to lock access to the Start and Stop methods. Fixes bug http://b/issue?id=3251823 BUG=3251823 TEST=none Review URL: http://codereview.chromium.org/5519007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68261 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove stub scoped_variant_win.h file.tfarina@chromium.org2010-12-046-30/+27
| | | | | | | | | | | Fix the callers and add base::win in the call sites. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/5507001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68251 0039d316-1c4b-4281-b951-d872f2087c98
* Refreshing a ChromeFrame page which was received in response to a top level ↵ananta@chromium.org2010-12-035-9/+143
| | | | | | | | | | | | | | | | | | | | | | | | | | | POST to a page in IE should reissue the POST request after bringing up a confirmation dialog. This CL adds support to ChromeFrame to achieve this. Ideally we would want IE to display the confirmation dialog for the POST. However the doc object host which is implemented by IEFrame expects the doc object to implement the IHTMLDocument interface and a bunch of private interfaces. To reissue the POST request we save away the POST data and headers in the navigation manager instance which is per BHO. When we refresh the page in ChromeFrame the active document on seeing that we have posted data issues a navigation back to the URL with the posted data and saved headers. All other refreshes continue to work the same way as before, i.e. the refresh request is sent to Chrome on the automation channel. The confirmation dialog is put up by the active document with the same text and caption as that in Chrome. Fixes bug http://code.google.com/p/chromium/issues/detail?id=64901 BUG=64901 TEST=Covered by new ChromeFrame unit test Review URL: http://codereview.chromium.org/5595002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68213 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash reported seen in ChromeFrame in version 8.0.552.215 which was ↵ananta@chromium.org2010-12-031-5/+6
| | | | | | | | | | | | | pushed to stable. Crash occurs while dereferencing a NULL TabProxy pointer. BUG=65319 TEST=none Review URL: http://codereview.chromium.org/5625004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68210 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the expectations. Under some circumstances, the NCCALCSIZE event may ↵erikwright@chromium.org2010-12-031-0/+19
| | | | | | | | | | be sent twice. Expect the sequence of NCCALCSIZE, MOVE, SIZE either 0 or 1 times. BUG=None TEST=chrome_frame_unittests --gtest_filter=Infobar* Review URL: http://codereview.chromium.org/5549006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68178 0039d316-1c4b-4281-b951-d872f2087c98
* Add an infobar facility to Chrome Frame. Allows clients to display and hide ↵erikwright@chromium.org2010-12-0312-0/+1457
| | | | | | | | | | arbitrary content at the top or botom of an IE tab. BUG=None TEST=chrome_frame_unittests --gtest_filter=Infobars* Review URL: http://codereview.chromium.org/4766003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68176 0039d316-1c4b-4281-b951-d872f2087c98
* Rename module_utils.cc|h and associated test to dll_redirector.cc|h etc. to ↵robertshield@chromium.org2010-12-035-10/+8
| | | | | | | | | | | match what's actually in those files. It's been a TODO for a while and a recent chat shamed me into action. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/5560002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68128 0039d316-1c4b-4281-b951-d872f2087c98
* scons: excise more scons references from the code baseevan@chromium.org2010-12-031-1/+1
| | | | | | | | | | I got to undo some hacks, too! TEST=compiles Review URL: http://codereview.chromium.org/5535003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68119 0039d316-1c4b-4281-b951-d872f2087c98
* Move:ben@chromium.org2010-12-022-2/+2
| | | | | | | | | | | | | | | file_path_watcher into subdir profile* into profiles/ subdir login* into ui/login visitedlink* into subdir BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/5606002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
* Always use persistent profile for CF+CEEE installs.joi@chromium.org2010-12-013-4/+15
| | | | | | | | | BUG=64840 TEST=With --enable-ceee, CF profiles on IE7 should not be under Temporary Internet Files. Review URL: http://codereview.chromium.org/5254012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67890 0039d316-1c4b-4281-b951-d872f2087c98
* Disable running selenium tests on IE7 builderamit@chromium.org2010-12-011-0/+8
| | | | | | | | | | | | | There's an issue that's seen only on this builder so far that any window.open just hangs. Disabling the selenium tests on this builder since tests opening popups fail. BUG=NONE TEST=FullTabSeleniumTest.Core Review URL: http://codereview.chromium.org/5473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67885 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the installer to support multi-install.tommi@chromium.org2010-12-011-16/+18
| | | | | | | | | | | | | | | | | | The installer now does its work based on distributions and target installation paths. Each distribution has exactly one target installation path but each installation path can have more than one distribution. In the absense of the --multi-install switch, the installer should continue to work as before. The biggest difference here is that we don't rely on a single global distribution object that controls the entire installation flow and we have a few classes for the new abstractions instead of global functions. It's far from perfect, but it's a step towards separating the core file package required for all distributions from the distributions themselves. Additionally, there are tons of little changes here such as consistant usage of FilePath and CommandLine instead of mixing them with std::wstring. TEST=Install, uninstall, upgrade, etc. Everything install related. BUG=61609 Review URL: http://codereview.chromium.org/5172011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67818 0039d316-1c4b-4281-b951-d872f2087c98
* The View->Source menu item in the IE9 menu bar is disabled for ChromeFrame ↵ananta@chromium.org2010-12-011-1/+1
| | | | | | | | | | | | | | | pages. This CL fixes that. We need to enable the MSHTML command id IDM_VIEWSOURCE Fixes bug http://code.google.com/p/chromium/issues/detail?id=64857 BUG=64857 TEST=Launch IE9 and observe that the View->Source menu item is enabled on chrome frame pages. Review URL: http://codereview.chromium.org/5367011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67806 0039d316-1c4b-4281-b951-d872f2087c98
* Post the WM_SYSKEYDOWN/WM_SYSKEYUP messages to the parent window when ↵ananta@chromium.org2010-11-301-9/+11
| | | | | | | | | | | | | | | | | | | ChromeFrame is active. This ensures that the Alt key is processed correctly in IE9, i.e. the menu bar is dropped down. On IE8 it appears that the Alt key is processed by the Ole control site in the context of WM_SYSKEYUP message even though it still returns S_FALSE. IE8 continues to work with this change as well. Fixes bug http://code.google.com/p/chromium/issues/detail?id=55763 BUG=55763 TEST=Launch IE9 and navigate to a chrome frame site. Press the Alt key and verify that the menu bar is dropped down. Review URL: http://codereview.chromium.org/5390004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67780 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak chrome Frame Selenium test expectationsamit@chromium.org2010-11-301-3/+3
| | | | | | | | | | | | ...due to failures caused by popup blocker. TEST=FullTabSeleniumTest.Core BUG=NONE Review URL: http://codereview.chromium.org/5314011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67774 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequest URLRequest;tfarina@chromium.org2010-11-302-7/+7
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5384002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
* Disable CFOpenLinkInNewWindow on IE7.kkania@chromium.org2010-11-301-0/+5
| | | | | | | | BUG=64794 TEST=none Review URL: http://codereview.chromium.org/5315011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67737 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome frame context menu tests. Patch by mdu@chromium.org.kkania@chromium.org2010-11-306-1/+310
| | | | | | | | BUG=none TEST=none Review at http://codereview.chromium.org/3656002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67717 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Selenium test for chrome Frameamit@chromium.org2010-11-301-1/+1
| | | | | | | | | | | as now we have selenium checkout on bots and it should work BUG=50372 TEST=FullTabSeleniumTest.Core Review URL: http://codereview.chromium.org/5380005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67714 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67662 - FBTF: Remove unneeded headers from base/ (part 10)thestig@chromium.org2010-11-305-3/+9
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5139006 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/5270010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67674 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 10)thestig@chromium.org2010-11-305-9/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5139006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67662 0039d316-1c4b-4281-b951-d872f2087c98
* Undo removal of chrome_dll_version from r67457.joi@chromium.org2010-11-301-2/+2
| | | | | | | | | | | | | This is not a straight revert as we keep the part where chrome.dll directly includes the generated .rc file instead of having it included via chrome_dll.rc, as that seems to cause other dependency issues. BUG=none TEST=it builds, incremental builds on changes to chrome/VERSION work. Review URL: http://codereview.chromium.org/5259007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67657 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame perf builder redness caused by an event name change.ananta@chromium.org2010-11-301-1/+1
| | | | | | | | | | TBR=amit BUG=NONE TEST=Covered by existing chrome frame perf tests. Review URL: http://codereview.chromium.org/5361008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67632 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the flakiness on IE9 in the ChromeFrame CtrlR test which ↵ananta@chromium.org2010-11-301-7/+7
| | | | | | | | | | | | tests page refresh. TBR=amit BUG=none TEST=Covered by existing ChromeFrame CtrlR test Review URL: http://codereview.chromium.org/5354005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67617 0039d316-1c4b-4281-b951-d872f2087c98
* net: Add namespace net to URLRequest and URLRequestJob classes.tfarina@chromium.org2010-11-281-3/+6
| | | | | | | | | BUG=64263 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/5298008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67497 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NPAPI registrationgrt@chromium.org2010-11-271-2/+2
| | | | | | | | | BUG=none TEST=Set the persist NPAPI marker, upgrade GCF, then check to see if registration took place. Review URL: http://codereview.chromium.org/5366003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67482 0039d316-1c4b-4281-b951-d872f2087c98
* Use BRANDING settings for IE CEEE. Simplify chrome_dll_version handling.joi@chromium.org2010-11-261-1/+1
| | | | | | | | | | | | | | | | | | | Adding new CEEE_PRODUCT_FULLNAME key to the BRANDING file. Adapting version.h.in to define a preprocessor constant for it. Using this and the other version/product name constants in IE CEEE's .rc files. Piggybacking on MAD's recent changes to make %NAME% a variable in the .rgs files to fairly easily get the product name from branding in there. Naming the toolband with the product name directly (as it is what shows up in IE's View/Toolbars menu), the BHO with an added "Helper" and the broker with an added "Broker". Removing the 'chrome_dll_version' target from chrome.gyp, and skipping code generation of chrome_dll_version.rc. Instead we have a source file with that name, that includes the verson.h generated by the 'chrome_version_header' target. This is cleaner and less code generation. Fixing 'chrome_dll_nacl64' target, it seemed like it wanted to have version information, but it didn't. Cleaning up the way sources are specified in several of the chrome_tests.gypi targets, to use fewer source! statements just to remove source files that are Windows-only (put them in the Windows-only section instead). BUG=none TEST=Visible change should be that user-visible names in Chromium builds are like "Chromium Extensions Execution Environment" (with "Broker" or "Helper" appended when appropriate), i.e. they lose the "Google" part. Review URL: http://codereview.chromium.org/5360002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67457 0039d316-1c4b-4281-b951-d872f2087c98
* Implement exponential back-off mechanism.joi@chromium.org2010-11-251-1/+0
| | | | | | | | | | | | | | | | | | | | | | | Contributed by yzshen@google.com, original review http://codereview.chromium.org/4194001/ Implement exponential back-off mechanism. Enforce it at the URLRequestHttpJob level for all outgoing HTTP requests. The reason why to make this change is that we need back-off logic at a lower enough level to manage all outgoing HTTP traffic, so that the browser won't cause any DDoS attack. This change: 1) patches http://codereview.chromium.org/2487001/show, which is the exponential back-off implementation. 2) resolves conflicts with URLFetcher, by removing its own back-off logic: -- removes url_fetcher_protect.{h,cc}; -- integrates the sliding window mechanism of URLFetcherProtectEntry into RequestThrottlerEntry. 3) resolves conflicts with CloudPrintURLFetcher. 4) makes unit tests of CloudPrintURLFetcher, URLFetcher and URLRequest work. BUG=none TEST=pass all existing tests and also the newly-added request_throttler_unittest.cc Review URL: http://codereview.chromium.org/5276007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67375 0039d316-1c4b-4281-b951-d872f2087c98
* Export the new sessionid property of Chrome Frame form the NPAPI interface.rogerta@chromium.org2010-11-248-3/+100
| | | | | | | | | BUG=0 TEST=see included unit test Review URL: http://codereview.chromium.org/5331003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67311 0039d316-1c4b-4281-b951-d872f2087c98
* Add named testing interface. This allows you to connect to a pre-existing ↵nirnimesh@chromium.org2010-11-245-7/+17
| | | | | | | | | | | | | | | | | | | | | Chrome process and run tests on it. This is an addition to the low level interface underlying testing frameworks like PyAuto and WebDriver. Normally, test frameworks communicate with Chrome over an unnamed socket pair on POSIX. The test creates the socket pair and then launches the browser as a child process, passing an open file descriptor for one end of the socket to the browser. This change adds a command line switch that, when passed to the browser, causes it to listen on a named socket instead, eliminating this parent/child process requirement. Therefore, you can potentially connect any number of tests to a preexisting browser process. For ChromeOS, this allows you to run tests on the instance of Chrome that is launched on startup, which controls things like the login and lock screens, the battery meter, the wireless UI, etc. Currently there is no way to run tests on a pre-existing Chrome instance. Eventually this will also allow you to connect both PyAuto and WebDriver to the same Chrome instance and run both in the same test. If you pass the browser the following command line switch: ./chrome --testing-channel=NamedTestingInterface:/path/to/file This causes the browser to listen for incoming connections. An AutomationProxy can connect to the browser by connecting a Unix domain socket to the specified path and control the browser over the socket. This is currently only for POSIX. Windows support will come in a future change. Also, this initial change only allows one connection; multiple connection support will come in a future change. BUG=chromium-os:8512 TEST=Run Chrome with --testing-interface=/var/tmp/NamedTestingInterface, then run NamedInterfaceTest.BasicNamedInterface under ui_tests. Review URL: http://codereview.chromium.org/4202004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67300 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 02:45:41 +0000