| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current timeout value of 3 seconds is not enough in some cases.
Chrome metrics shows that more than 1% of requests exceeds 4s.
New timeout will be 3, 6, 12, 12 ... in seconds.
Bug=internal b/24033308
Review URL: https://codereview.chromium.org/1338713006
Cr-Commit-Position: refs/heads/master@{#349007}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UrlRequestContextBuilder was already taking ownership in most cases, so
it should be taking scoped_ptr's instead of raw pointers. This change
should help enforce proper ownership and has already identified two
ownership bugs. I'm fixing the ownership bugs (a double-free of
ProxyConfigService in Cronet and of NetLog in AwURLRequestContextGetter)
in this change also. I'm changing UrlRequestContextBuilder to not take
ownership of NetLog however as this conflicts with some other uses of
NetLog, like how it's exposed via ContentBrowserClient.
BUG=508553
TBR=jam
Review URL: https://codereview.chromium.org/1303493002
Cr-Commit-Position: refs/heads/master@{#346637}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromecast has no battery so its system time might be changing
during connectivity checking. Changing system time may be the
cause of cert error, such as DATE_INVALID, if negative result
is cached.
Clear client session cache before checking or when cert error
is encountered.
BUG=internal b/23619920
Review URL: https://codereview.chromium.org/1315523009
Cr-Commit-Position: refs/heads/master@{#346540}
|
|
|
|
|
|
|
|
| |
TBR=zelidrag@chromium.org (chromeos)
Review URL: https://codereview.chromium.org/1284833004
Cr-Commit-Position: refs/heads/master@{#342983}
|
|
|
|
|
|
|
|
| |
BUG= b/17615224
Review URL: https://codereview.chromium.org/1219773003
Cr-Commit-Position: refs/heads/master@{#338126}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Log the certificate status when a connectivity check fails due to
a SSL certificate error.
BUG=internal b/21857001
R=gunsch@chromium.org,byungchul@chromium.org
TBR=wzhong@chromium.org
Review URL: https://codereview.chromium.org/1184183013
Cr-Commit-Position: refs/heads/master@{#334706}
|
|
|
|
|
|
|
|
|
|
|
| |
In case that no response has been received within 3 seconds,
cancel the current request and start a new one.
BUG=internal b/21298386
Review URL: https://codereview.chromium.org/1169163002
Cr-Commit-Position: refs/heads/master@{#333634}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Consolidate OnIPAddressChanged and OnConnectionTypeChanged to keep
behaviour consistent.
R=gunsch@chromium.org,wzhong@chromium.org
BUG=internal b/21633149
Review URL: https://codereview.chromium.org/1145243012
Cr-Commit-Position: refs/heads/master@{#332939}
|
|
|
|
|
|
|
|
|
|
| |
All callers have been updated now.
TBR=sky
Review URL: https://codereview.chromium.org/1163103004
Cr-Commit-Position: refs/heads/master@{#332778}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove redefinition of observer list in impl class. Move observer
list into private in base class and expose a protected Notify
method.
BUG=
R=gunsch@chromium.org,byungchul@chromium.org
Review URL: https://codereview.chromium.org/1169533002
Cr-Commit-Position: refs/heads/master@{#332643}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make ConnectivityChecker virtual and add default implementation.
Add FakeConnectivityChecker for use in tests.
TEST=Build cast_shell. Build/run internal unittests.
BUG=
Review URL: https://codereview.chromium.org/1152293006
Cr-Commit-Position: refs/heads/master@{#332499}
|
|
|
|
|
|
|
|
|
|
| |
method for testing.
Also rename SetConnectivity() to SetConnected() to be more consistent with Connected()
Review URL: https://codereview.chromium.org/1162213003
Cr-Commit-Position: refs/heads/master@{#332269}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org
BUG=391045
Review URL: https://codereview.chromium.org/1142513004
Cr-Commit-Position: refs/heads/master@{#330578}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By default, OnSSLCertificateError() just cancels current request.
For connectivity_checker, it needs to cancel the current request
and starts next check. In particular, this handles the case that
SSL cert fails when device system time is changing (syncing to
NTP server).
BUG=internal b/20775908
Review URL: https://codereview.chromium.org/1145723004
Cr-Commit-Position: refs/heads/master@{#330557}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add NetworkChangeNotifierFactoryCast to create instance of
NetworkChangeNotifierLinux that ignores interfaces that will not be
used to connect to internet.
BUG=469863
R=gunsch@chromium.org
Review URL: https://codereview.chromium.org/1138923002
Cr-Commit-Position: refs/heads/master@{#329445}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/1137483004/)
Reason for revert:
broke the Android builds. Not sure how "cast_shell_android" passed, actually.
Original issue's description:
> [Chromecast] Ignore interfaces not used to connect to internet.
>
> Add NetworkChangeNotifierFactoryCast to create instance of
> NetworkChangeNotifierLinux that ignores interfaces that will not be
> used to connect to internet.
>
> BUG=469863
> R=gunsch@chromium.org,byungchul@chromium.org,wzhong@chromium.org
>
> Committed: https://crrev.com/561d7adb5ec842c5e56ece4524d0e486691ca614
> Cr-Commit-Position: refs/heads/master@{#329319}
TBR=byungchul@chromium.org,wzhong@chromium.org,derekjchow@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=469863
Review URL: https://codereview.chromium.org/1141503002
Cr-Commit-Position: refs/heads/master@{#329348}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add NetworkChangeNotifierFactoryCast to create instance of
NetworkChangeNotifierLinux that ignores interfaces that will not be
used to connect to internet.
BUG=469863
R=gunsch@chromium.org,byungchul@chromium.org,wzhong@chromium.org
Review URL: https://codereview.chromium.org/1137483004
Cr-Commit-Position: refs/heads/master@{#329319}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add "netifs-to-ignore" flag, which specifies that certain
interfaces should not be used for internet connectivity.
R=gunsch@chromium.org
BUG=internal b/20305035
Review URL: https://codereview.chromium.org/1117923003
Cr-Commit-Position: refs/heads/master@{#327815}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some netifs could be ignored by command line flag, --netifs-to-ignore, and
internet could be accessible via those netifs.
Many testing scripts and developers set this for ethernet link and
use ethernet to get testing results.
BUG=internal b/19593970
Review URL: https://codereview.chromium.org/1037693005
Cr-Commit-Position: refs/heads/master@{#322288}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the ability to pass in a custom CookieStore to a URLRequest. It's
a small change to net/url_request which then balloons to everything in the
project that ever makes a URLRequest.
This reverts the rest of https://codereview.chromium.org/188693003 (and then
does a whole lot more because URLRequest constructors were unified recently to
always require passing in the fourth argument).
BUG=457344
Review URL: https://codereview.chromium.org/1003953008
Cr-Commit-Position: refs/heads/master@{#321820}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Observing ConnectionType alone doesn't detect network
changes on some OEM platforms. Observe IP address
to address this.
BUG=
Review URL: https://codereview.chromium.org/995933002
Cr-Commit-Position: refs/heads/master@{#320148}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Perform connectivity check even if offline. NetworkChangeNotifier
does not accuratly report IsOffline on some platforms.
R=gunsch@chromium.org,wzhong@chromium.org
BUG=
Review URL: https://codereview.chromium.org/963163003
Cr-Commit-Position: refs/heads/master@{#318502}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cast will use NetworkChangeNotifierLinux. This commit also fixes a
some logging messages and tear down in ConnectivityChecker.
R=gunsch@chromium.org
BUG=391064
Review URL: https://codereview.chromium.org/960693002
Cr-Commit-Position: refs/heads/master@{#318156}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds ConnectivityChecker and CastResourceDispatcherHostDelegate
classes. Performs connectivity checks on startup, network changes
and failed resource loads.
R=gunsch@chromium.org,byungchul@chromium.org
BUG=336640
Review URL: https://codereview.chromium.org/925183003
Cr-Commit-Position: refs/heads/master@{#317388}
|
|
|
|
|
|
|
|
|
|
|
| |
See: https://codereview.chromium.org/831863003
R=lcwu@chromium.org
BUG=417463
Review URL: https://codereview.chromium.org/837453003
Cr-Commit-Position: refs/heads/master@{#310131}
|
|
|
|
|
|
|
|
|
| |
R=damienv@chromium.org,dcheng@chromium.org
BUG=417463
Review URL: https://codereview.chromium.org/630663003
Cr-Commit-Position: refs/heads/master@{#298250}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org,byungchul@chromium.org,phajdan.jr@chromium.org
BUG=409163
Review URL: https://codereview.chromium.org/518773003
Cr-Commit-Position: refs/heads/master@{#294523}
|
|
build scripts.
BUG=336640
Review URL: https://codereview.chromium.org/223143003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282508 0039d316-1c4b-4281-b951-d872f2087c98
|