| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHost was calling out to WebContents to get the URL, but it
was getting the wrong URL (e.g., possibly the transient one) and then
never looking at it. Worse, WebContents then called ComputeWebkitPrefs
on the wrong RVH (the old one, not the pending one).
This only seems to come up in corner cases, like chrome://history on
Android when Javascript is disabled.
BUG=454063
TEST=See bug.
TBR=jam
Review URL: https://codereview.chromium.org/919933002
Cr-Commit-Position: refs/heads/master@{#316081}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is just a small correction, it should be 'repack_cast_shell_pak'
rather than 'repack_cast_shell_pack'. Notice the end is 'pak', because
that is the term for these files and also the output is called
cast_shell.pak.
BUG=None
TEST=cast_shell
R=lcwu@chromium.org,gunsch@chromiuum.org
Review URL: https://codereview.chromium.org/918573002
Cr-Commit-Position: refs/heads/master@{#315857}
|
|
|
|
|
|
|
|
|
|
|
| |
This unifies the WebContents creation code between each platform.
R=lcwu@chromium.org,byungchul@chromium.org
BUG=internal b/18934906
Review URL: https://codereview.chromium.org/874683006
Cr-Commit-Position: refs/heads/master@{#315818}
|
|
|
|
|
|
|
|
|
|
|
| |
Forgot to 'git add' on the previous CL.
R=lcwu@chromium.org
BUG=internal b/19004169
Review URL: https://codereview.chromium.org/914863005
Cr-Commit-Position: refs/heads/master@{#315811}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org
BUG=internal b/19004169
Review URL: https://codereview.chromium.org/915923002
Cr-Commit-Position: refs/heads/master@{#315716}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org,wzhong@chromium.org
BUG=internal b/18512518
Review URL: https://codereview.chromium.org/912143003
Cr-Commit-Position: refs/heads/master@{#315693}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This log statement is useless, since we already have
another log statement inside that loop, that will give us
enough information.
BUG=none
Review URL: https://codereview.chromium.org/908023002
Cr-Commit-Position: refs/heads/master@{#315407}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per crbug/444930 discussion, BrowserCdm should generally remain on UI
thread. Interactions between the CMA pipeline and BrowserCdm should
remain thread-safe.
R=erickung@chromium.org,lcwu@chromium.org
Review URL: https://codereview.chromium.org/903083003
Cr-Commit-Position: refs/heads/master@{#315359}
|
|
|
|
|
|
|
|
|
|
| |
Cast shell needs to exist when the parent process dies.
BUG=internal b/19182288
Review URL: https://codereview.chromium.org/872073005
Cr-Commit-Position: refs/heads/master@{#315356}
|
|
|
|
|
|
|
|
|
| |
R=jam@chromium.org,erickung@chromium.org
BUG=444930
Review URL: https://codereview.chromium.org/894173002
Cr-Commit-Position: refs/heads/master@{#314937}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/897123002
Cr-Commit-Position: refs/heads/master@{#314646}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GPU process is launching before CrashDumpManager is initialized,
calling into CastContentBrowserClient::GetAdditionalMappedFilesForProcess.
Make sure to start CrashDumpManager earlier.
R=lcwu@chromium.org,kjoswiak@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/893303002
Cr-Commit-Position: refs/heads/master@{#314449}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These IPCs hold this param as a gfx::Rect and the RenderWidget and RenderView
set the size. On the receiving end, the size is sometimes used so initial_pos
was a misnomer.
This is a mechanical rename, there should be no functional difference.
TBR=
BUG=
Review URL: https://codereview.chromium.org/889403004
Cr-Commit-Position: refs/heads/master@{#314430}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org,byungchul@chromium.org
BUG=internal b/18934906
Review URL: https://codereview.chromium.org/876633003
Cr-Commit-Position: refs/heads/master@{#314413}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org
BUG=451482
Review URL: https://codereview.chromium.org/874663002
Cr-Commit-Position: refs/heads/master@{#314178}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for adding preconnect support which goes through
the same underlying plumbing. dns_prefetch was too restrictive of a
component name and was only exposing the single method.
There are no functionality changes in this CL, just the rename (the namespace was also renamed)
BUG=450682
Review URL: https://codereview.chromium.org/848303005
Cr-Commit-Position: refs/heads/master@{#314001}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org,erickung@chromium.org
BUG=408189
Review URL: https://codereview.chromium.org/886583002
Cr-Commit-Position: refs/heads/master@{#313552}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org,dougsteed@chromium.org
BUG=336640
Review URL: https://codereview.chromium.org/876373004
Cr-Commit-Position: refs/heads/master@{#313424}
|
|
|
|
|
|
|
|
|
|
|
| |
See: https://codereview.chromium.org/831523005
R=dtrainor@chromium.org,lcwu@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/879073002
Cr-Commit-Position: refs/heads/master@{#313391}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org,servolk@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/878843004
Cr-Commit-Position: refs/heads/master@{#313352}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Damien mentioned an odd issue when adding this about it not compiling
correctly at the time. It compiles fine for me now.
R=lcwu@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/881043002
Cr-Commit-Position: refs/heads/master@{#313333}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org,erickung@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/882563002
Cr-Commit-Position: refs/heads/master@{#313211}
|
|
|
|
|
|
|
|
|
|
|
| |
See: https://codereview.chromium.org/870693002
R=erickung@chromium.org,dalecurtis@chromium.org
BUG=450764
Review URL: https://codereview.chromium.org/869283003
Cr-Commit-Position: refs/heads/master@{#313195}
|
|
|
|
|
|
|
|
|
|
| |
Old <incremental>-only number is preserved in CAST_BUILD_INCREMENTAL.
BUG=
Review URL: https://codereview.chromium.org/866843004
Cr-Commit-Position: refs/heads/master@{#312887}
|
|
|
|
|
|
|
|
|
|
|
| |
cast_shell creates aura::WindowTreeHost during main loop, and when running with
ozone-platform=egltest this causes a thread_restriction I/O FATAL.
BUG=448802
Review URL: https://codereview.chromium.org/853073003
Cr-Commit-Position: refs/heads/master@{#312869}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sending the moderate memory pressure notification now has the same
effect on v8's garbage collection as sending critical memory pressure
notification, which will trigger immediate gargabe collection and cause
some unexpected (performance) side effect. Given that render_thread_impl
is already asking v8 periodically to do idle garbage collection, we
should remove the moderate memory pressure notification.
BUG=
Review URL: https://codereview.chromium.org/798043008
Cr-Commit-Position: refs/heads/master@{#312675}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The cast web content window wasn't properly gaining focus which caused all of
the key input events to be dispatched to the wrong window where they were
silently dropped.
BUG=
Review URL: https://codereview.chromium.org/797023005
Cr-Commit-Position: refs/heads/master@{#312649}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Activity lifecycle is different when coming out of sleep mode, since
the activity doesn't actually have focus. For whatever reason, this
results in an extra onPause/onStop/onStart/onResume sequence before
the app is "started".
Details: http://stackoverflow.com/questions/25369909/
R=lcwu@chromium.org,byungchul@chromium.org
Review URL: https://codereview.chromium.org/864923003
Cr-Commit-Position: refs/heads/master@{#312550}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org
BUG=internal b/16490877
Review URL: https://codereview.chromium.org/859863003
Cr-Commit-Position: refs/heads/master@{#312546}
|
|
|
|
|
|
|
|
|
|
|
| |
CastNetworkDelegate in url_request_context_factory may use components
initialized by cast service.
BUG=
Review URL: https://codereview.chromium.org/862203002
Cr-Commit-Position: refs/heads/master@{#312517}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Make it work with Windows.
2. Remove non-existent messages.
3. Use _generator.h files where possible, e.g. adds missing extension_utility_messages.h.
R=gunsch@chromium.org, tsepez@chromium.org
TBR=ttuttle@chromium.org
BUG=450268
Committed: https://chromium.googlesource.com/chromium/src/+/faf8b453fa03869b3109258702ca7cf7b8157f5b
Review URL: https://codereview.chromium.org/848453003
Cr-Commit-Position: refs/heads/master@{#312466}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/848453003/)
Reason for revert:
The review doesn't show it, but this added back third_party/libc++(abi)
for some reason:
https://chromium.googlesource.com/chromium/src/+/faf8b453fa03869b3109258702ca7cf7b8157f5b
This was moved elsewhere in https://codereview.chromium.org/788063003
and it being back causes all kinds of things, for example me being
unable to run `git cl upload`. Please reland this without adding back
libc++.
This reverts commit faf8b453fa03869b3109258702ca7cf7b8157f5b.
Original issue's description:
> Ipclist fixes.
>
> 1. Make it work with Windows.
> 2. Remove non-existent messages.
> 3. Use _generator.h files where possible, e.g. adds missing extension_utility_messages.h.
>
> R=gunsch@chromium.org, tsepez@chromium.org
> TBR=ttuttle@chromium.org
> BUG=450268
>
> Committed: https://chromium.googlesource.com/chromium/src/+/faf8b453fa03869b3109258702ca7cf7b8157f5b
TBR=tsepez@chromium.org,gunsch@chromium.org,jar@chromium.org,ttuttle@chromium.org,inferno@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450268
Review URL: https://codereview.chromium.org/862043003
Cr-Commit-Position: refs/heads/master@{#312455}
|
|
|
|
|
|
|
|
|
|
|
| |
See: https://codereview.chromium.org/850183002/
R=lcwu@chromium.org,xhwang@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/861153004
Cr-Commit-Position: refs/heads/master@{#312444}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Make it work with Windows.
2. Remove non-existent messages.
3. Use _generator.h files where possible, e.g. adds missing extension_utility_messages.h.
R=gunsch@chromium.org, tsepez@chromium.org
TBR=ttuttle@chromium.org
BUG=450268
Review URL: https://codereview.chromium.org/848453003
Cr-Commit-Position: refs/heads/master@{#312315}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See internal build failures for "content_shell_clang_tot_public".
Initially triggered in https://codereview.chromium.org/814543006/
R=lcwu@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/861843002
Cr-Commit-Position: refs/heads/master@{#312294}
|
|
|
|
|
|
|
|
|
|
| |
This check just got turned on upstream, see crrev.com/803603003
BUG=
Review URL: https://codereview.chromium.org/857573004
Cr-Commit-Position: refs/heads/master@{#311920}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using --disable-gpu to fix the GPU process crash. Unfortunately this exposed
a different crash in our teardown process. For now, I've removed the test code
that shuts down render processes. The problem with this is Chromecast code
reacts to the render process dying and tries to start the error screen just as
it's about to be shut down. This ultimately leads to a crash.
Chromecast code shuts down the render processes itself, so I don't believe we
need the FastShutdownIfPossible calls in this test.
BUG=
Review URL: https://codereview.chromium.org/818803004
Cr-Commit-Position: refs/heads/master@{#311801}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org
BUG=internal b/19004169
Review URL: https://codereview.chromium.org/801153003
Cr-Commit-Position: refs/heads/master@{#311686}
|
|
|
|
|
|
|
|
| |
BUG=366349
Review URL: https://codereview.chromium.org/829133009
Cr-Commit-Position: refs/heads/master@{#311475}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes TagAppStart as its functionality is redundant. Also
separates out updating SDK info into UpdateSDKInfo.
R=byungchul@chromium.org
BUG=
Review URL: https://codereview.chromium.org/836923003
Cr-Commit-Position: refs/heads/master@{#311300}
|
|
|
|
|
|
|
|
|
|
| |
DevToolsManagerDelegate::CreateSocketForTethering was called from handler thread where there is no control over DevToolsManagerDelegate's lifetime.
BUG=
Review URL: https://codereview.chromium.org/820693003
Cr-Commit-Position: refs/heads/master@{#311235}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/844253002
Cr-Commit-Position: refs/heads/master@{#311007}
|
|
|
|
|
|
|
|
| |
(2) MetricsService has to stop before destruction of CastBrowserProcess, which is referenced inside MetricsService's stopping code.
Review URL: https://codereview.chromium.org/845003002
Cr-Commit-Position: refs/heads/master@{#310958}
|
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org
TBR=lcwu@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/844683005
Cr-Commit-Position: refs/heads/master@{#310942}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org
BUG=336640
Review URL: https://codereview.chromium.org/843173002
Cr-Commit-Position: refs/heads/master@{#310925}
|
|
|
|
|
|
|
|
|
|
|
| |
See recent "content_shell_androidtv_tot_x86" build failures.
R=lcwu@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/843933003
Cr-Commit-Position: refs/heads/master@{#310875}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org
BUG=336640
Review URL: https://codereview.chromium.org/838213004
Cr-Commit-Position: refs/heads/master@{#310829}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
command-line flag.
The command-line flag --disable-application-cache is slated to be
removed. See https://codereview.chromium.org/837363002/.
BUG=
Review URL: https://codereview.chromium.org/845803002
Cr-Commit-Position: refs/heads/master@{#310827}
|
|
|
|
|
|
|
|
|
| |
(2) Re-order class members inside cast_browser_process, so that
they are destructed in correct order.
Review URL: https://codereview.chromium.org/839153004
Cr-Commit-Position: refs/heads/master@{#310813}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialize() and Finalize() are for tasks which should be done when IO is allowed.
Start() and Stop() are for tasks which should be done when RenderProcesses are valid. For example, web_contents are not accessible during CastBrowserMainParts::PostMainMessageLoopRun() because RendererProcessHost is already destroyed.
In addition, handle SIGTERM and SIGINT to exit cast_shell properly on those signals.
BUG=
Review URL: https://codereview.chromium.org/834923002
Cr-Commit-Position: refs/heads/master@{#310641}
|