summaryrefslogtreecommitdiffstats
path: root/chromeos/dbus/bluetooth_adapter_client.cc
Commit message (Collapse)AuthorAgeFilesLines
* replace OVERRIDE and FINAL with override and final in chromeos/mostynb2014-10-061-11/+11
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/628883002 Cr-Commit-Position: refs/heads/master@{#298229}
* Fix minor issues about DBusThreadManager.pneubeck2014-09-111-1/+2
| | | | | | | | | | | | | | - Remove the global unstub_client_mask_ and accordingly make DBusThreadManager::IsUsingStub a non-static function. This makes it obvious when it's ok to call this function (and prevents misuse), namely only after the Manager is initialized. - By moving the mask to the DBusClientBundle, the cyclic dependency between bundle and manager is broken. The Bundle does not know about the Manager anymore. - Fix the difference between DBusClientTypeMask ("A set of DBusClients") and DBusClientType ("A single DBusClient"). BUG=408617 Review URL: https://codereview.chromium.org/556833003 Cr-Commit-Position: refs/heads/master@{#294361}
* Remove fake client creation from DBusClients' Create() functions.pneubeck@chromium.org2013-12-031-7/+2
| | | | | | | | | | | | The DBusClient interfaces shouldn't provide functionality related to testing code (like Stubs/fake implementations). Instead fake clients are now directly created without relying on the static Create() functions. The now unused DBusClientImplementationType argument of the Create() functions could be removed. BUG=275286 R=satorux@chromium.org Review URL: https://codereview.chromium.org/91413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238330 0039d316-1c4b-4281-b951-d872f2087c98
* Split construction and initialization of DBus clients.pneubeck@chromium.org2013-08-271-14/+13
| | | | | | | | | | | | | | | Before, each Client had a Create function which constructed an instance of the client and initialized it (with a dbus::Bus*). To make the Clients separately replaceable in the DBusThreadManager, it's necessary to separate the construction of the Clients from their initialization. This CL, splits each Create function into Create (which only calls the constructor of either the real Impl or the Stub) and Init(dbus::Bus*). This is a pure refactoring. BUG=275286 Review URL: https://chromiumcodereview.appspot.com/23119006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219775 0039d316-1c4b-4281-b951-d872f2087c98
* Bluetooth: drop "Experimental" from Chrome OS backendkeybuk@chromium.org2013-06-121-0/+270
| | | | | | | | | BUG=221813 TEST=device_unittests Review URL: https://chromiumcodereview.appspot.com/14932007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205777 0039d316-1c4b-4281-b951-d872f2087c98
* Bluetooth: remove legacy backendkeybuk@chromium.org2013-05-251-755/+0
| | | | | | | | | BUG=221813 TEST=device_unittests Review URL: https://chromiumcodereview.appspot.com/15020009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202281 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Add FakeOldBluetooth{Adapter,Device,Manager}haruki@chromium.org2013-05-011-177/+2
| | | | | | | | | | | | They are used in MockDBusThreadManagerWithoutGMock and stub implementations in DBusThreadManager. BUG=234084,234461 TEST=trybots R=satorux@chromium.org Review URL: https://codereview.chromium.org/14508007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197604 0039d316-1c4b-4281-b951-d872f2087c98
* D-Bus: notify properties changed from fakeskeybuk@chromium.org2013-04-241-1/+0
| | | | | | | | | | | | | | | | | Call the property changed callback when fakes use ReplaceValue() or ReplaceValueWithSetValue(), since the actual implementation will always call the callback. This avoids issues with property changed notifications being missing when properties structures are built within fakes. BUG=none TEST=dbus_unittests, device_unittests R=satorux@chromium.org, youngki@chromium.org Review URL: https://codereview.chromium.org/14443003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195977 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Debug restriction on Bluetooth log messageskeybuk@chromium.org2013-03-081-8/+6
| | | | | | | | | | | | We frequently need to access these in real builds after all. BUG=none TEST=chrome --vmodule=*bluetooth*=3 Review URL: https://chromiumcodereview.appspot.com/12379062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187064 0039d316-1c4b-4281-b951-d872f2087c98
* Bluetooth: Increase the DBus CreatePairedDevice timeout to 120sdeymo@chromium.org2013-02-211-1/+1
| | | | | | | | | | | | | The previous timeout was 70 seconds, and given the feedback saw, it wasn't enough. BUG=chromium-os:37387 TEST=Connect/pair to a device and let it timeout. An "Unknown error" should NOT be shown. Review URL: https://chromiumcodereview.appspot.com/12289017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183722 0039d316-1c4b-4281-b951-d872f2087c98
* Bluetooth: Fix error_message parsing on a dbus error response.deymo@chromium.org2012-12-221-2/+2
| | | | | | | | | | | | | Fix an incorrect use of "bool Message::PopString(std::string*)" where we were assigning a boolean value to the result. BUG=None TEST=Bluetooth error messages show in the log with the right error_message value instead of a \x01. Review URL: https://chromiumcodereview.appspot.com/11669016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174541 0039d316-1c4b-4281-b951-d872f2087c98
* Bluetooth: Increment the timeout for CreatePairedDevice dbus calldeymo@chromium.org2012-12-201-1/+9
| | | | | | | | | | | | | DBus was timeouting before BlueZ in the case of paring with a device that requires a pincode and the user takes too long to put it. With this increased timeout, the timeout error is returned by BlueZ. BUG=chromium-os:37387 Review URL: https://chromiumcodereview.appspot.com/11571067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174081 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up weak_ptr_factory destruction order.gdk@chromium.org2012-09-071-6/+8
| | | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10917115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155319 0039d316-1c4b-4281-b951-d872f2087c98
* bluetooth: Create stub manager, adapter and device.keybuk@chromium.org2012-08-151-3/+68
| | | | | | | | | | | | | | | | | | | | These stub classes are used when building Chrome on Linux with chromeos=1. They allow sufficient UI to work to show a Bluetooth adapter, enable and disable it, and show an unconnected fake device associated with it. This can be trivially extended to provide all manner of fake Bluetooth information for UI development. BUG=chromium-os:28555 TEST=out/Debug/chrome Change-Id: I7af28be76355fad735389aaf2fa499d0a8dfd76b Review URL: https://chromiumcodereview.appspot.com/10823301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151621 0039d316-1c4b-4281-b951-d872f2087c98
* Fix lint errors for chromeos/dbus/bluetooth*bryeung@chromium.org2012-06-221-0/+1
| | | | | | | | | | TEST=compiles BUG=none Review URL: https://chromiumcodereview.appspot.com/10640008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143596 0039d316-1c4b-4281-b951-d872f2087c98
* bluetooth: obtain D-Bus error for select methodskeybuk@google.com2012-06-041-45/+93
| | | | | | | | | | | | | | | For the CreateDevice, CreatePairedDevice and Connect methods use CallMethodWithErrorCallback rather than CallMethod so that we obtain richer error information from the BlueZ service. BUG=chromium-os:27902 TEST=make chrome Change-Id: If801d834604e4c2142c20169603bc527bde09403 Review URL: https://chromiumcodereview.appspot.com/10409062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140334 0039d316-1c4b-4281-b951-d872f2087c98
* Move files inside chrome/browser/chromeos/dbus to chromeos/dbushashimoto@chromium.org2012-04-061-0/+809
Move files in chrome/browser/chromeos/dbus/ to chromeos/dbus Add chromeos/dbus/DEPS Add chromeos.gyp:chromeos_test_support and chromeos.gyp:chromeos_unittests Add CHROMEOS_EXPORT to classes Move power related proto targets to chromeos.gyp Rewrite and sort #includes BUG=119583 TEST=component chromeos build success, checkdeps success Review URL: https://chromiumcodereview.appspot.com/9838085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131065 0039d316-1c4b-4281-b951-d872f2087c98