| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromium-review.googlesource.com/207610 modified cros-disks to
report, via the GetDeviceProperties DBus method, if a disk is on a
removable device. This CL updates the CrosDisksClient to make sure of
that.
BUG=393345
TEST=Unit tests and manually tested a few removable USB/SD media.
Review URL: https://codereview.chromium.org/391783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284620 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc 4.7 gives the following error when compiling chromeos_unittests on Linux (with chromeos=1):
../../chromeos/dbus/cros_disks_client_unittest.cc: In member function 'virtual void chromeos::CrosDisksClientTest_DiskInfo_Test::TestBody()':
../../chromeos/dbus/cros_disks_client_unittest.cc:125:3: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]
See googletest issue 322 (https://code.google.com/p/googletest/issues/detail?id=322) for details.
This CL works around the issue by switching the unit test from EXPECT_EQ(false, something) to EXPECT_TRUE(false == something)
BUG=None
TEST=Build and run chromeos_unittests with gcc 4.7
Review URL: https://chromiumcodereview.appspot.com/18339011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
Code stack of CrosDisksClient, DiskMountManager and FileManagerEventRouter need some refactoring, but most of the code lack tests.
BUG=None
TEST=chromeos_unittests
R=satorux@chromium.org
Review URL: https://codereview.chromium.org/18734002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210350 0039d316-1c4b-4281-b951-d872f2087c98
|
