summaryrefslogtreecommitdiffstats
path: root/chromeos/dbus/fake_shill_service_client.cc
Commit message (Collapse)AuthorAgeFilesLines
* Remove legacy StartsWithASCII function.brettw2015-07-161-5/+5
| | | | | | | | | | | This replaces it with base::StartsWith and the appropriate case flag. Since the existing version only ever did case-insensitive tests in ASCII, there should be no behavior change. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1242023005 Cr-Commit-Position: refs/heads/master@{#339175}
* Move StartsWith[ASCII] to base namespace.brettw2015-06-121-4/+4
| | | | | | | | | NOPRESUBMIT=true (no presubmit due to removing base:: from a ScopedAllowIO) Review URL: https://codereview.chromium.org/1172183002 Cr-Commit-Position: refs/heads/master@{#334108}
* chromeos: Remove use of MessageLoopProxy and deprecated MessageLoop APIsskyostil2015-06-111-42/+31
| | | | | | | | | | This patch was mostly autogenerated with https://codereview.chromium.org/1010073002/. BUG=465354 Review URL: https://codereview.chromium.org/1173593002 Cr-Commit-Position: refs/heads/master@{#333996}
* Use networkingPrivate.startConnect (Take 2)stevenjb2015-04-161-18/+16
| | | | | | | | | | | | | | | This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. Original CL (reverted for unrelated failure): https://codereview.chromium.org/1043343002/ BUG=430115 TBR=michaelpg, pneubeck, mpearson@chromium.org Review URL: https://codereview.chromium.org/1091043002 Cr-Commit-Position: refs/heads/master@{#325484}
* Revert of Use networkingPrivate.startConnect (patchset #12 id:240001 of ↵mpearson2015-04-141-16/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1043343002/) Reason for revert: Causes browser_test failure on Win7 bot. https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20(1) [ RUN ] WebNavigationApiTest.Failures [4444:4508:0414/144708:WARNING:data_reduction_proxy_config.cc(319)] SPDY proxy OFF at startup [4444:2028:0414/144708:ERROR:bluetooth_adapter_win.cc(102)] NOT IMPLEMENTED [180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x5) while retrieving error. (0xE8) [180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 2147483650, remote ID 3) [180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error [180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x3B01) while retrieving error. (0xE8) [180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1) [180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error [4444:2028:0414/144709:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframe", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframeNavigation", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[FAIL] cancel: Received unexpected event 'onCompleted':{"frameId":0,"processId":0,"tabId":0,"timeStamp":0,"url":"chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/e.html"} Error at captureEvent (chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:194:17) at chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:219:5 at EventImpl.dispatchToListener (extensions::event_bindings:395:22) at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:94:26) at EventImpl.dispatch_ (extensions::event_bindings:379:35) at dispatchArgs (extensions::event_bindings:247:26) at dispatchEvent (extensions::event_bindings:256:7)", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) [4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistent", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0) c:\b\build\slave\win_x64_builder\build\src\chrome\browser\extensions\api\web_navigation\web_navigation_apitest.cc(468): error: Value of: RunExtensionTest("webnavigation/failures") Actual: false Expected: true Failed 1 of 4 tests [4444:2028:0414/144710:ERROR:browser_thread.h(263)] DeleteSoon failed on thread 0 [ FAILED ] WebNavigationApiTest.Failures, where TypeParam = and GetParam() = (2465 ms) Original issue's description: > Use networkingPrivate.startConnect > > This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. > It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. > > BUG=430115 > > Committed: https://crrev.com/e22e5bcbad2cea941993b32e6cc3b082822a42fc > Cr-Commit-Position: refs/heads/master@{#325108} TBR=armansito@chromium.org,michaelpg@chromium.org,pneubeck@chromium.org,stevenjb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=430115 Review URL: https://codereview.chromium.org/1085993002 Cr-Commit-Position: refs/heads/master@{#325145}
* Use networkingPrivate.startConnectstevenjb2015-04-141-18/+16
| | | | | | | | | | | This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. BUG=430115 Review URL: https://codereview.chromium.org/1043343002 Cr-Commit-Position: refs/heads/master@{#325108}
* Provide GUID in ONC for all networks in ManagedNetworkConfigurationHandlerstevenjb2015-01-151-0/+15
| | | | | | | | BUG=448445 Review URL: https://codereview.chromium.org/821643005 Cr-Commit-Position: refs/heads/master@{#311747}
* chromeos networking: move from security to securityclass propertyquiche2015-01-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Adopt shill's kSecurityClassProperty, in place of shill's kSecurityProperty. This eliminates the need for Chrome to understand the equivalence of WPA and RSN networks. This CL introduces only one functional change. Namely, NetworkState::GetSpecifier will now collapse WPA and RSN networks into one class (by virtue of using kSecurityClassProperty). The previous behavior is considered a bug. After this CL, only WifiAccessPointInfoProviderChromeOs still uses kSecurityProperty. In that one case, we want to break out WPA and RSN networks, to understand what fraction of systems are connecting through older APs. While there: remove a couple of unused files in chromeos/test/data/network/policy/. BUG=chromium:440032 TEST=ManagedNetworkConfigurationHandlerTest.* TEST=ONC* Review URL: https://codereview.chromium.org/788633003 Cr-Commit-Position: refs/heads/master@{#310840}
* Add 'setProperties' to InternetOptionsHandlerstevenjb2014-11-191-37/+33
| | | | | | | | | | | Replaces simple custom setters with setProperties call, matching the networkingPrivate API. BUG=430113 Review URL: https://codereview.chromium.org/694533007 Cr-Commit-Position: refs/heads/master@{#304780}
* Fix reconnect in case of empty global network policy.pneubeck2014-10-201-4/+8
| | | | | | | | | | While there, remove some error messages because of incomplete test setup or incorrect fake behavior. BUG=425049 Review URL: https://codereview.chromium.org/648623004 Cr-Commit-Position: refs/heads/master@{#300284}
* Use GUID in captive portal API instead of service pathstevenjb@chromium.org2014-07-141-1/+4
| | | | | | | | | | | | Also changes the fake implementations and other tests to explicitly specify guids. BUG=none For components/wifi/fake_wifi_service.cc: TBR=mef@chromium.org Review URL: https://codereview.chromium.org/377063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282995 0039d316-1c4b-4281-b951-d872f2087c98
* Rely on Service.Visible instead of Manager.Servicesstevenjb@chromium.org2014-06-201-20/+36
| | | | | | | | | | | | With this change we rely on Service.Visible and only use Manager.Services to determine which services to observe. BUG=384380 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/330833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278594 0039d316-1c4b-4281-b951-d872f2087c98
* Merge FavoriteState into NetworkStatestevenjb@chromium.org2014-06-121-11/+13
| | | | | | | | | | | | BUG=375955 For trivial renaming: R=armansito@chromium.org, pneubeck@chromium.org TBR=derat@chromium.org, xiyuan@chromium.org Review URL: https://codereview.chromium.org/289383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276822 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up shill fake implementationsstevenjb@chromium.org2014-06-061-8/+5
| | | | | | | | | | | | | | | | | | This is in preparation of merging NetworkState and FavoriteState, crbug.com/375955. The merge will involve a number of changes to ShillPropertyHandler and in the process of making those changes some additional logging and test cleanup was necessary that isn't directly related to the merge itself. BUG=none For trivial changes to chrome/browser/ui/webui/options/ TBR=dbeam@chromium.org Review URL: https://codereview.chromium.org/299403012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275551 0039d316-1c4b-4281-b951-d872f2087c98
* Implement networkingPrivate.getNetworksstevenjb@chromium.org2014-05-191-1/+1
| | | | | | | | | | | | | Design Doc and Proposal here: https://docs.google.com/a/google.com/document/d/1QWIzDvf_-iZJW8CINvhxzIERwwKeg72302hNUw0ZrSM/edit This CL depends on https://codereview.chromium.org/275543005/ BUG=371966 Review URL: https://codereview.chromium.org/280023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271490 0039d316-1c4b-4281-b951-d872f2087c98
* Improve functionality of FakeShillProfileClientstevenjb@chromium.org2014-05-141-7/+60
| | | | | | | | | | | | | | | | Note: The fake shill client behaviors are tested by the higher level tests that use them. They may be reaching a complexity level that merits explicit testing, but it's not clear whether or not that would actually be a win. These changes are being added to support https://codereview.chromium.org/275543005/. BUG=none R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/284673004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270486 0039d316-1c4b-4281-b951-d872f2087c98
* Provide IPConfigs in networkingPrivate.GetPropertiesstevenjb@chromium.org2014-05-091-1/+2
| | | | | | | | | | | | BUG=365848 For components/wifi fixes for tests: R=pneubeck@chromium.org TBR=mef@chromium.org Review URL: https://codereview.chromium.org/267433005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269334 0039d316-1c4b-4281-b951-d872f2087c98
* Replace misc. network and power stub flags with more flexible onesstevenjb@chromium.org2014-03-061-30/+9
| | | | | | | | | | | | | | | | | | | | This replaces the following flags: --default-stub-network-state-idle --enable-stub-interactive (for Shill only) --enable-stub-portalled-wifi --enabled-stub-network-types With: --shill-stub={options} Specific option values are commented in the code. BUG=345033 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/181413006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255422 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome OS: Use Manager.DefaultService for Default Networkstevenjb@chromium.org2014-03-051-3/+22
| | | | | | | | | | | | | | | | | | This changes Chrome to use Manager.DefaultService to provide the default network to Chrome (i.e. NetworkChangeNotifier) instead of relying on Manager.Services[0]. This should fix some timing issues and make the NCS more in sync with Shill. One change in behavior that should be benign is that Shill considers a connecting network to be the default network, whereas previously only a connected network would be considered. BUG=159540, 330873 R=gauravsh@chromium.org, pneubeck@chromium.org, tbarzic@chromium.org Review URL: https://codereview.chromium.org/175243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255124 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup shill_stub_helper, GetSharedProfilePath -> ShillProfileClientstevenjb@chromium.org2014-03-031-2/+5
| | | | | | | | | | | Also replaces IsStubPortalledWifiEnabled() with more robust logic. BUG=345033 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/183033004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254492 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for -Wunused-function on Linux, Android and ChromeOShans@chromium.org2013-11-121-5/+0
| | | | | | | | | BUG=315884, 78045 TBR=owners Review URL: https://codereview.chromium.org/67923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234373 0039d316-1c4b-4281-b951-d872f2087c98
* cryptohome: Convet all *Stub classes into Fake* classessatorux@chromium.org2013-10-211-0/+569
ShillProfileClientStub is renamed to FakeShillProfileClient. ShillServiceClientStub is renamed to FakeShillServiceClient ShillManagerClientStub is renamed to FakeShillManagerClient, and the original FakeShillManagerClient is removed. BUG=309506 TEST=none Review URL: https://codereview.chromium.org/31773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229770 0039d316-1c4b-4281-b951-d872f2087c98