| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Updated all clients that wrap HasObserver and expose it to also take a
const pointer. This change avoids further propagation of non-constness
(which was previously required when using HasObserver methods).
BUG=429588
TBR=michaeln@chromium.org,nyquist@chromium.org,pkotwicz@chromium.org,satorux@chromium.org,sky@chromium.org,zea@chromium.org
Review URL: https://codereview.chromium.org/697953002
Cr-Commit-Position: refs/heads/master@{#303428}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the time has not been set automatically via network syncing, the system
clock can be changed. This dialog allows the user to change the date, time
and time zone when possible. The motivation is to unbrick devices with
the wrong time that need to be rolled out into time-sensitive networks.
Documentation of the changes to Chrome OS and Ash for this CL is here:
https://docs.google.com/a/google.com/drawings/d/1T3demthtROnXf1iE31p5aIPcQzK9SmjfE9EjnJbZ4zs
System Time Manual Update UI design doc:
https://docs.google.com/a/google.com/document/d/1djzhBrtbx-52Gctp3Fd5MIosARbTwQh_lMmd_qUnqgo
Screenshot with timezone:
https://drive.google.com/a/google.com/file/d/0B6HSBrih6pNUd3p2SFBoVktjVzQ
Screenshot from settings page, no timezone:
https://drive.google.com/a/google.com/file/d/0B6HSBrih6pNUXzk0TjNiT0tKMTQ
BUG=232066
TEST=SetTimeWebUITest, DateTimeOptionsWebUITest
R=stevenjb@chromium.org,nkostylev@chromium.org,dbeam@chromium.org,derat@chromium.org,asvitkine@chromium.org
TBR=sky@chromium.org
# TBR for adding resources to chrome/browser/chrome_resources.grd
Please review:
stevenjb@chromium.org
- ash/system
- chromeos/dbus
derat@chromium.org:
- chrome/browser/chromeos
- chrome/browser/ui/ash
- chromeos/dbus (optional)
nkostylev@chromium.org:
- chrome/app
- chrome/browser/chromeos
- chrome/browser/resources/chromeos
- chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
- chrome/browser/ui/webui/chromeos
- chrome/browser/ui/webui/options/chromeos
- chrome/browser/browser_resources.grd
- chrome/chrome_*.gypi
- chrome/common
dbeam@chromium.org:
- chrome/browser/resources/options
- chrome/browser/ui/webui/options/*.cc
sky@chromium.org:
- chrome/browser/browser_resources.grd
Review URL: https://codereview.chromium.org/247663003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266431 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before, each Client had a Create function which constructed an instance of the client and initialized it (with a dbus::Bus*).
To make the Clients separately replaceable in the DBusThreadManager, it's necessary to separate the construction of the Clients from their initialization.
This CL, splits each Create function into Create (which only calls the constructor of either the real Impl or the Stub) and Init(dbus::Bus*).
This is a pure refactoring.
BUG=275286
Review URL: https://chromiumcodereview.appspot.com/23119006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
These fake classes do nothing for now. We can implement fake behaviors when necessary.
BUG=234458,234499
TEST=trybots
Review URL: https://codereview.chromium.org/13890017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196674 0039d316-1c4b-4281-b951-d872f2087c98
|
