summaryrefslogtreecommitdiffstats
path: root/chromeos/dbus/shill_client_helper.cc
Commit message (Collapse)AuthorAgeFilesLines
* Track active references in ShillClientHelper (Take 3)stevenjb@chromium.org2013-10-071-21/+84
| | | | | | | | | | | | | | To prevent Shill Service DBus ObjectProxy instances from accumulating, remove them when the service becomes inactive. Hopefully includes ASAN fixes. BUG=223483 TBR=hashimoto@chromium.org Review URL: https://codereview.chromium.org/26289002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227371 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 227100 "Track active references in ShillClientHelper (Tak..."stevenjb@chromium.org2013-10-041-84/+21
| | | | | | | | | | | | | | | | | | | | | | > Track active references in ShillClientHelper (Take 2) > To prevent Shill Service DBus ObjectProxy instances from accumulating, > remove them when the service becomes inactive. > > Original CL: https://codereview.chromium.org/23658053/ > > BUG=223483 > TBR=hashimoto@chromium.org > > Review URL: https://codereview.chromium.org/24558004 Failure: http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28amd64%29%20ASAN/builds/6931 TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/26075002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227139 0039d316-1c4b-4281-b951-d872f2087c98
* Track active references in ShillClientHelper (Take 2)stevenjb@chromium.org2013-10-041-21/+84
| | | | | | | | | | | | | | To prevent Shill Service DBus ObjectProxy instances from accumulating, remove them when the service becomes inactive. Original CL: https://codereview.chromium.org/23658053/ BUG=223483 TBR=hashimoto@chromium.org Review URL: https://codereview.chromium.org/24558004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227100 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate DBus service constants from flimflam namespace to shill namespace.benchan@chromium.org2013-09-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | All shill DBus service constants have been moved from the flimflam namespace to the shill namespace. This CL makes the corresponding changes on the Chrome side. Related CLs: https://chromium-review.googlesource.com/#/c/170123/ https://chromium-review.googlesource.com/#/c/170205/ https://chromium-review.googlesource.com/#/c/170206/ https://chromium-review.googlesource.com/#/c/170207/ https://chromium-review.googlesource.com/#/c/170208/ https://chromium-review.googlesource.com/#/c/170209/ https://chromium-review.googlesource.com/#/c/170223/ https://chromium-review.googlesource.com/#/c/170230/ https://chromium-review.googlesource.com/#/c/170231/ BUG=295425 R=stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/24286008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224934 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 224179 "Track active references in ShillClientHelper"kkania@chromium.org2013-09-191-84/+21
| | | | | | | | | | | | | | | | | | Use after free on ASAN chromiumos. > Track active references in ShillClientHelper > To prevent Shill Service DBus ObjectProxy instances from accumulating, > remove them when the service becomes inactive. > > BUG=223483 > > Review URL: https://chromiumcodereview.appspot.com/23658053 TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/24293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224204 0039d316-1c4b-4281-b951-d872f2087c98
* Track active references in ShillClientHelperstevenjb@chromium.org2013-09-191-21/+84
| | | | | | | | | | | To prevent Shill Service DBus ObjectProxy instances from accumulating, remove them when the service becomes inactive. BUG=223483 Review URL: https://chromiumcodereview.appspot.com/23658053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224179 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate NetworkLibrary!stevenjb@chromium.org2013-09-111-29/+1
| | | | | | | | | | | | | There should be no functionality changes with this CL, it should only eliminate unused code. It also removes cros_network_functions and all Shill blocking dbus calls (now unused). BUG=245494 Review URL: https://chromiumcodereview.appspot.com/23477058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222615 0039d316-1c4b-4281-b951-d872f2087c98
* Switch ObserverList::size() to ObserverList::might_have_observers() Pt.1caitkp@chromium.org2013-08-261-4/+3
| | | | | | | | | | | | This is in preparation for making ObserverList::size() protected (see bug for details). BUG=278526 TEST=no change TBR=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/23190045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219580 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for Service.SetPropertiesstevenjb@chromium.org2013-07-101-0/+18
| | | | | | | | | BUG=258633 R=satorux@chromium.org Review URL: https://codereview.chromium.org/18619006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210899 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate inconsistent is_null check from Shill stubsstevenjb@chromium.org2013-07-101-0/+15
| | | | | | | | | | | | The non-stub code does not do any is_null checks before calling the callbacks, so the stub code should be consistent. BUG=None R=hashimoto@chromium.org, satorux@chromium.org Review URL: https://codereview.chromium.org/18355007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210867 0039d316-1c4b-4281-b951-d872f2087c98
* Resolve certificate references in ONC by PEM.pneubeck@chromium.org2013-07-031-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | In ONC, Server and CA certificates are referenced by GUID. Before, the GUID was stored in the nickname of each certificate and used to identify each certificate. After this change, the GUID is resolved and replaced by the PEM encoding of the certificate during import. The nickname is not used. This commit only affects Server and CA certificates (including IssuerCARef in CertificatePatterns). Client certificates are still identified by GUID. This CL also - uses the new *CaCertPEMProperty fields of Shill. - prepares for a list of CaCerts (for EAP, IPsec and OpenVPN) Side-effect of this CL: IssuerCARef is stored in the UIData service-property in Shill. Because this CL replaces IssuerCARef by IssuerCAPEMs, IssuerCARef entries of old UIData properties are ignored. This may break network configurations which were configured via chrome://net-internals. Reimporting such a configuration will fix the problem. BUG=208986 TBR=eroman@chromium.org (for net_internals_ui.cc) Review URL: https://chromiumcodereview.appspot.com/16946002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210019 0039d316-1c4b-4281-b951-d872f2087c98
* Replace HasNext() by !IsAtEnd() in network related folders.pneubeck@chromium.org2013-04-041-1/+1
| | | | | | | | | BUG=162611 Review URL: https://chromiumcodereview.appspot.com/13532002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192294 0039d316-1c4b-4281-b951-d872f2087c98
* Remove blocking_method_caller.h dependency in shill_client_helper.hstevenjb@chromium.org2013-03-111-3/+4
| | | | | | | | | BUG=none Review URL: https://chromiumcodereview.appspot.com/12726002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187324 0039d316-1c4b-4281-b951-d872f2087c98
* This adds the remaining extension functions for networkingPrivate.gspencer@chromium.org2013-02-201-129/+188
| | | | | | | | | | BUG=chromium:172996 TEST=ran new unit and browser tests. Review URL: https://chromiumcodereview.appspot.com/12286012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183358 0039d316-1c4b-4281-b951-d872f2087c98
* Shill: Delay the ConnectToSignal call until an observer is added.deymo@chromium.org2013-02-141-0/+17
| | | | | | | | | | | | | | | | | This patch delayes the call to ObjectProxy::ConnectToSignal made from the ShillClientHelper in order to call it only when there's an observer for the signal. If no observer is currently added, as in the case of a ShillClientHelper used only for method calls, this fix will efectively cause the helper to not add an unnecessary match rule in the dbus connection. This notably reduces the number of match rules used by Shill to only the number of connected networks instead of the number of available networks. BUG=chromium:170182 Review URL: https://chromiumcodereview.appspot.com/12220128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182525 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes a crash in ShillDeviceClient when the helper is NULL.gspencer@chromium.org2013-01-311-0/+3
| | | | | | | | | BUG=chromium:170541 Review URL: https://chromiumcodereview.appspot.com/12091076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179816 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Remove unused CrosAddIPConfig/CrosRemoveIPConfig functionshashimoto@chromium.org2012-11-131-15/+0
| | | | | | | | | BUG=126964 TEST=build Review URL: https://chromiumcodereview.appspot.com/11361211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167354 0039d316-1c4b-4281-b951-d872f2087c98
* Added ClearProperties to the Shill service client.gspencer@chromium.org2012-11-071-0/+30
| | | | | | | | | | | | | Must be committed only after the corresponding service_constants.h change goes in. BUG=chromium-os:35900 TEST=built Review URL: https://chromiumcodereview.appspot.com/11364089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166427 0039d316-1c4b-4281-b951-d872f2087c98
* This converts the Shill clients to allow propagation of shill errorsgspencer@chromium.org2012-09-281-3/+41
| | | | | | | | | | | | back from the function calls. The existing implentation completely ignores most shill errors, and the javascript implementation will want to be able to receive them to aid in diagnosis. BUG=chromium:147620,chromium:146616 TEST=Ran unit tests, ran on device. Review URL: https://chromiumcodereview.appspot.com/10949030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159325 0039d316-1c4b-4281-b951-d872f2087c98
* This converts the Shill clients to use an observer patterngspencer@chromium.org2012-09-271-13/+16
| | | | | | | | | | | | | | | for property change notifications because in a future CL the javascript private API will need to listen directly to shill notifications as well, and the previous implementation was limited to a single handler. BUG=chromium:147620,chromium:146616 TEST=Ran unit tests, ran on device. Review URL: https://chromiumcodereview.appspot.com/10965045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158972 0039d316-1c4b-4281-b951-d872f2087c98
* Renaming instances of "flimflam" with "shill", now that we're only using shill.gspencer@chromium.org2012-09-071-0/+287
Does not rename things from the flimflam:: namespace in service_constants.h: that will be saved for a later pass. I think this counts as refactoring, so I'm TBR'ing the OWNERS checks. TBR=zelidrag@chromium.org,glotov@chromium.org BUG=chromium:146616 TEST=built and ran Review URL: https://chromiumcodereview.appspot.com/10915106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155477 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 22:05:41 +0000