| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.
This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.
BUG=417463
R=hashimoto@chromium.org
Review URL: https://codereview.chromium.org/817853005
Cr-Commit-Position: refs/heads/master@{#311851}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also changes the fake implementations and other tests to explicitly specify guids.
BUG=none
For components/wifi/fake_wifi_service.cc:
TBR=mef@chromium.org
Review URL: https://codereview.chromium.org/377063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change we rely on Service.Visible and only use
Manager.Services to determine which services to observe.
BUG=384380
R=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/330833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation of merging NetworkState and FavoriteState,
crbug.com/375955.
The merge will involve a number of changes to ShillPropertyHandler
and in the process of making those changes some additional logging
and test cleanup was necessary that isn't directly related to the
merge itself.
BUG=none
For trivial changes to chrome/browser/ui/webui/options/
TBR=dbeam@chromium.org
Review URL: https://codereview.chromium.org/299403012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: The fake shill client behaviors are tested by the higher level
tests that use them. They may be reaching a complexity level that merits
explicit testing, but it's not clear whether or not that would actually
be a win.
These changes are being added to support https://codereview.chromium.org/275543005/.
BUG=none
R=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/284673004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DBusClient interfaces shouldn't provide functionality related to testing code (like Stubs/fake implementations).
Instead fake clients are now directly created without relying on the static Create() functions. The now unused DBusClientImplementationType argument of the Create() functions could be removed.
BUG=275286
R=satorux@chromium.org
Review URL: https://codereview.chromium.org/91413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change untangles some of the Shill*Stubs' implementation from the setup of a default network environment. In particular the setup function has now access to all Shill*Stubs during this setup.
This also correctly adds stub networks with status 'online' to a profile, so that the respective FavoriteState is created.
BUG=126870
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/24150004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There should be no functionality changes with this CL, it should only
eliminate unused code.
It also removes cros_network_functions and all Shill blocking dbus calls (now unused).
BUG=245494
Review URL: https://chromiumcodereview.appspot.com/23477058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before, each Client had a Create function which constructed an instance of the client and initialized it (with a dbus::Bus*).
To make the Clients separately replaceable in the DBusThreadManager, it's necessary to separate the construction of the Clients from their initialization.
This CL, splits each Create function into Create (which only calls the constructor of either the real Impl or the Stub) and Init(dbus::Bus*).
This is a pure refactoring.
BUG=275286
Review URL: https://chromiumcodereview.appspot.com/23119006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently connected networks are moved to the top of the list, but no other sorting is performed. We should do a similar sort to Shill when a Service's State changes:
* Active (connected, connecting, etc) networks followed by Inactive networks
* Sorted by type: Ethernet, Wifi, Cellular, Wimax, VPN
This should make the stub based networking tests less fragile
BUG=256810
TBR=gauravsh@chromium.org, gspencer@chromium.org
Review URL: https://codereview.chromium.org/22315002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=258633
R=satorux@chromium.org
Review URL: https://codereview.chromium.org/18619006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL tracks Manager.ServiceCompleteList to provide a list of
favorite/preferred networks to the UI. It uses
Service.GetLoadableProfileEntries to remove preferred services.
A test UI is provided in the status area (behind a flag).
Stub behavior is updated to enable testing the UI on Linux.
BUG=251922
Review URL: https://chromiumcodereview.appspot.com/17778003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See issue for discussion of implementation notes, specifically
comment #5.
BUG=251922
R=gspencer@chromium.org, pneubeck@chromium.org
Review URL: https://codereview.chromium.org/18034014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adapts in particular the ManagedNetworkConfigurationHandler, the
networkingPrivate extension API and the network configuration extension.
BUG=223869
TBR=thestig@chromium.org (for chrome_browser_chromeos.gypi)
Review URL: https://chromiumcodereview.appspot.com/12676017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
default network
BUG=164501
TEST=verify that dns refreshes while in connected state result in a dns change.
Review URL: https://chromiumcodereview.appspot.com/12634019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Add Devices/Services to Manager client when addded to Device or Service client
* Do not include services for disabled technologies in service lists
BUG=none
Review URL: https://codereview.chromium.org/12381002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of calling ModemReset on completing activation for an LTE modem, instead call the new CompleteCellularActivation shill service method.
R=gspencer@chromium.org,benchan@chromium.org
BUG=172526
Review URL: https://chromiumcodereview.appspot.com/12279012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Must be committed only after the corresponding service_constants.h
change goes in.
BUG=chromium-os:35900
TEST=built
Review URL: https://chromiumcodereview.appspot.com/11364089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The intention for this class is to provide up-to-date state information about the network for the majority of the network related UI. It should also serve as a foundation for classes monitoring the state of the active network.
This code is not designed to provide detailed information about specific network service or device properties, not should it provide the ability to set (configure) those properties.
BUG=154072
Review URL: https://chromiumcodereview.appspot.com/11192024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will help write functional tests for network handlers written on top of the Shill client code.
BUG=154072
TEST=NetworkSmsHandlerTest.SmsHandlerDbusStub passes
Review URL: https://chromiumcodereview.appspot.com/11365022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
back from the function calls. The existing implentation completely ignores most shill errors, and the javascript implementation will want to be able to receive them to aid in diagnosis.
BUG=chromium:147620,chromium:146616
TEST=Ran unit tests, ran on device.
Review URL: https://chromiumcodereview.appspot.com/10949030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for property change notifications because in a future CL the
javascript private API will need to listen directly to shill
notifications as well, and the previous implementation was limited to
a single handler.
BUG=chromium:147620,chromium:146616
TEST=Ran unit tests, ran on device.
Review URL: https://chromiumcodereview.appspot.com/10965045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Does not rename things from the flimflam:: namespace in service_constants.h: that will be saved for a later pass.
I think this counts as refactoring, so I'm TBR'ing the OWNERS checks.
TBR=zelidrag@chromium.org,glotov@chromium.org
BUG=chromium:146616
TEST=built and ran
Review URL: https://chromiumcodereview.appspot.com/10915106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155477 0039d316-1c4b-4281-b951-d872f2087c98
|