summaryrefslogtreecommitdiffstats
path: root/chromeos/disks/disk_mount_manager_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Update {virtual,override,final} to follow C++11 style in chromeos.dcheng2015-01-211-3/+3
| | | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=zelidrag@chromium.org Review URL: https://codereview.chromium.org/856563004 Cr-Commit-Position: refs/heads/master@{#312426}
* Part 3: Merged FakedDBusThreadManager with DBusThreadManager.zelidrag2014-08-271-6/+2
| | | | | | | | | | BUG=401192 TEST=existing tests TBR=sky,stevenjb,keybuk Review URL: https://codereview.chromium.org/477663004 Cr-Commit-Position: refs/heads/master@{#292072}
* Read from CrosDisks to determine If a disk is on a removable device.benchan@chromium.org2014-07-221-0/+3
| | | | | | | | | | | | | | https://chromium-review.googlesource.com/207610 modified cros-disks to report, via the GetDeviceProperties DBus method, if a disk is on a removable device. This CL updates the CrosDisksClient to make sure of that. BUG=393345 TEST=Unit tests and manually tested a few removable USB/SD media. Review URL: https://codereview.chromium.org/391783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284620 0039d316-1c4b-4281-b951-d872f2087c98
* Use cros-disks Format DBus call instead of deprecated FormatDevice.benchan@chromium.org2014-05-061-91/+36
| | | | | | | | | | | | | | | | | | | | | The cros-disks FormatDevice DBus call has been long deprecated (back in 2011). This CL modifies CrosDisksClient and DiskMountManager to use the Format DBus call instead. BUG=369877 TEST=Tested the following: 1. Run chromeos_unittests. 2. Insert a USB drive and format the mounted partition via Files.app. Verify that Files.app notifies the successful completion of the format operation. 3. Insert a write-protected SD card and format the mounted partition via Files.app. Verify that Files.app reports an error. R=stevenjb@chromium.org, tbarzic@chromium.org Review URL: https://codereview.chromium.org/262393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268623 0039d316-1c4b-4281-b951-d872f2087c98
* Observe cros-disks FormatCompleted signal instead of FormattingFinished.benchan@chromium.org2014-05-061-14/+14
| | | | | | | | | | | | | | | | | | | | | | | The FormattingFinished signal has been long deprecated (back in 2011) and replaced by the FormatCompleted signal, which allows cros-disks to properly notify Chrome the completion of a format operation with an appropriate error code. This CL modifies CrosDisksClient and DiskMountManager to use the FormatCompleted signal. BUG=369877 TEST=Tested the following: 1. Run chromeos_unittests. 2. Insert a USB drive and format the mounted partition via Files.app. Verify that Files.app notifies the successful completion of the format operation. 3. Insert a write-protected SD card and format the mounted partition via Files.app. Verify that Files.app reports an error. R=stevenjb@chromium.org, tbarzic@chromium.org Review URL: https://codereview.chromium.org/266143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268398 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeOS: Remove MockDBusThreadManager.pneubeck@chromium.org2013-11-101-2/+4
| | | | | | | | | | | | | | | | | | - Extends FakeDBusThreadManager about DBusClient setters. - Removes default initialization of DBusClients from FakeDBusThreadManager. - Replaces all occurrences of MockDBusThreadManager in tests by FakeDBusThreadManager. - Every test now creates exactly the DBusClients that are required. - Removes all references to Fake/Stub implementations from the DBusThreadManagerImpl used for production. Depends on: https://codereview.chromium.org/50243005/ BUG=275286 TBR=miket@chromium.org,mkwst@chromium.org,rtenneti@chromium.org Review URL: https://codereview.chromium.org/49773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234172 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Rename MockDBusTreadManagerWithoutGMock to FakeDBusThreadManagersatorux@chromium.org2013-10-221-7/+5
| | | | | | | | | | | | | The original name was a misnomer as the class behaves like a fake and hosts fake D-Bus client classes. No semantic changes. BUG=223061 TEST=none R=hashimoto@chromium.org, miket@chromium.org, nona@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/31793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230035 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in chromeos/.avi@chromium.org2013-07-171-1/+1
| | | | | | | | | | BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19468003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212154 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Use base::MessageLoop.xhwang@chromium.org2013-05-291-1/+1
| | | | | | | | | BUG=236029 R=oshima@chromium.org Review URL: https://codereview.chromium.org/15774005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202997 0039d316-1c4b-4281-b951-d872f2087c98
* Use MockDBusThreadManagerWithoutGMock for DiskMountManagerTestharuki@chromium.org2013-05-141-97/+104
| | | | | | | | | | | | Adding FakeCrosDisksClient some utilities to inspect methods calls. BUG=223061 TEST=trybots R=satorux@chromium.org Review URL: https://codereview.chromium.org/14565003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199905 0039d316-1c4b-4281-b951-d872f2087c98
* Add callback to DiskMountManager::UnmountPathtbarzic@chromium.org2013-03-141-10/+12
| | | | | | | | | | | | | The callback makes it easier to handle failures (in comparison to observing mount manager for MountEvents). TEST=existing BUG=tested formatting still works Review URL: https://chromiumcodereview.appspot.com/12537016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188161 0039d316-1c4b-4281-b951-d872f2087c98
* Small refactoring in DiskMountManager (event reporting; format method).tbarzic@chromium.org2012-11-151-0/+625
* Rename DiskMountManager::Observer methods to On____Event format. * Break up DiskMountManagerEventType enum. * Add separate observer method for formatting events. * Pass formatting event success using bool instead of adding '!' in front of the path (but only in events from DiskMountManager; will remove it from CrosDisksClient events in another patch). * Add unit tests for formatting handling in DiskMountManager. (TODO: add more tests) TBR:vandebo@chromium.org (for mechanical changes in chrome/browser/system_monitor) BUG=157587, 126815 TEST=manual: formatting works (and Formatting pending notification goes away) chromeos_unittests::DiskMountManagerTest.* Review URL: https://chromiumcodereview.appspot.com/11365142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167799 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-09-05 22:26:05 +0000