summaryrefslogtreecommitdiffstats
path: root/chromeos/disks
Commit message (Collapse)AuthorAgeFilesLines
* Fix leak in DiskMountManagertbarzic@chromium.org2012-11-211-0/+2
| | | | | | | | | | BUG=161294 TEST=DiskMountManagerTest* under valgrind/heapcheck Review URL: https://chromiumcodereview.appspot.com/11416017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169049 0039d316-1c4b-4281-b951-d872f2087c98
* Try 2 - [Media Gallery][ChromeOS] Improve device media gallery names.kmadhusu@chromium.org2012-11-152-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | | (1) When a SD card is attached, report a more generic string like "SD card" on the media permissions dialog. (2) When the attached device is not a SD card or when a sub folder of the device is selected as a media gallery, report the gallery name in the following format: <Device_storage_size> <Selected_sub_folder_gallery_name> <Volume_Name> <(Vendor_Name, Model_Name)> Sample gallery names: (1) 1GB TEST_USB (2) 4GB DCIM - RED_USB (3) 8KB PHOTOS - (TESTCOMPANY, A101) (4) 4GB SD Card (5) 16MB SD Card Original Review CL: http://codereview.chromium.org/11366144/ Reverted CL: https://codereview.chromium.org/11363236/ BUG=159671, 158600 TEST=none TBR=oshima@chromium.org Review URL: https://chromiumcodereview.appspot.com/11365258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167835 0039d316-1c4b-4281-b951-d872f2087c98
* Small refactoring in DiskMountManager (event reporting; format method).tbarzic@chromium.org2012-11-155-157/+816
| | | | | | | | | | | | | | | | | | | | | | | | | | * Rename DiskMountManager::Observer methods to On____Event format. * Break up DiskMountManagerEventType enum. * Add separate observer method for formatting events. * Pass formatting event success using bool instead of adding '!' in front of the path (but only in events from DiskMountManager; will remove it from CrosDisksClient events in another patch). * Add unit tests for formatting handling in DiskMountManager. (TODO: add more tests) TBR:vandebo@chromium.org (for mechanical changes in chrome/browser/system_monitor) BUG=157587, 126815 TEST=manual: formatting works (and Formatting pending notification goes away) chromeos_unittests::DiskMountManagerTest.* Review URL: https://chromiumcodereview.appspot.com/11365142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167799 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 167606 - [Media Gallery][ChromeOS] Improve device media gallery names.hbono@chromium.org2012-11-142-15/+6
| | | | | | | | | | | | | | | | | | | | | | | | | (1) When a SD card is attached, report a more generic string like "SD card" on the media permissions dialog. (2) When the attached device is not a SD card or when a sub folder of the device is selected as a media gallery, report the gallery name in the following format: <Device_storage_size> <Selected_sub_folder_gallery_name> <Volume_Name> <(Vendor_Name, Model_Name)> Sample gallery names: (1) 1GB TEST_USB (2) 4GB DCIM - RED_USB (3) 8KB PHOTOS - (TESTCOMPANY, A101) (4) 4GB SD Card (5) 16MB SD Card BUG=159671,158600 TEST=none Review URL: https://chromiumcodereview.appspot.com/11366144 TBR=kmadhusu@chromium.org Review URL: https://codereview.chromium.org/11363236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167609 0039d316-1c4b-4281-b951-d872f2087c98
* [Media Gallery][ChromeOS] Improve device media gallery names.kmadhusu@chromium.org2012-11-142-6/+15
| | | | | | | | | | | | | | | | | | | | | | (1) When a SD card is attached, report a more generic string like "SD card" on the media permissions dialog. (2) When the attached device is not a SD card or when a sub folder of the device is selected as a media gallery, report the gallery name in the following format: <Device_storage_size> <Selected_sub_folder_gallery_name> <Volume_Name> <(Vendor_Name, Model_Name)> Sample gallery names: (1) 1GB TEST_USB (2) 4GB DCIM - RED_USB (3) 8KB PHOTOS - (TESTCOMPANY, A101) (4) 4GB SD Card (5) 16MB SD Card BUG=159671,158600 TEST=none Review URL: https://chromiumcodereview.appspot.com/11366144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167606 0039d316-1c4b-4281-b951-d872f2087c98
* Do lazy unmount only when the disk has been physically removed.tbarzic@chromium.org2012-10-104-20/+34
| | | | | | | | | | | | | | | | | Also, wire up unmount failure event to file manager so error message for unmount failure can e displayed. TEST=manual (try unmounting USB while copying a file to the device -> unmount should fail and error message should be displayed; remove USB while copying a file to it in progress -> the device should be unmounted) BUG=154403 Review URL: https://chromiumcodereview.appspot.com/11099004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161072 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: IWYU for base/time.h. Also fix misc lint errors.thestig@chromium.org2012-10-101-1/+0
| | | | | | | | TBR=ben,brettw,oshima,rdsmith Review URL: https://chromiumcodereview.appspot.com/11087021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160999 0039d316-1c4b-4281-b951-d872f2087c98
* [Chrome OS] Construct device label and unique id using vendor and product ↵kmadhusu@chromium.org2012-09-172-5/+7
| | | | | | | | | | | | | | | details. If the device uuid is unavailable, construct the unique id using vendor id and product id values. If the device label is unavailable, construct the name using vendor and product names. BUG=none TEST=none TBR=satorux@chromium.org Review URL: https://chromiumcodereview.appspot.com/10908277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157089 0039d316-1c4b-4281-b951-d872f2087c98
* When unmounting, unmount all mounts thaty are mounted from unmounting disk.tbarzic@chromium.org2012-09-151-0/+19
| | | | | | | | | | | TEST=manual (mount a zip from a usb device, unmount the usb device.. the zip should also be unmounted) BUG=126972 Review URL: https://chromiumcodereview.appspot.com/10919234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157017 0039d316-1c4b-4281-b951-d872f2087c98
* Populate vendor and product information of devices reported by CrosDisks.benchan@google.com2012-09-133-0/+52
| | | | | | | | | | | | | | BUG=chromium-os:33225 TEST=Tested the following: 1. Build Chrome OS. 2. browser_tests --gtest_filter='ExtensionFileBrowserPrivateApiTest*' 3. Manually insert a few removable devices on Chrome OS and verify that DiskMountManager correctly populates vendor and product information returned by org.chromium.CrosDisks.GetDeviceProperties DBus call. Review URL: https://codereview.chromium.org/10905254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156616 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Fix clang warnings about missing virtual and OVERRIDE annotations.tfarina@chromium.org2012-08-301-2/+4
| | | | | | | | | | BUG=115047 TBR=satorux@chromium.org Review URL: https://chromiumcodereview.appspot.com/10916011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154232 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Move src/chrome/browser/chromeos/disks to src/chromeoshashimoto@chromium.org2012-08-264-0/+1269
GetSizeStatsOnFileThread is moved from disk_mount_manager.cc to file_browser_private_api.cc BUG=None TEST=build TBR=estade@chromium.org, kaznacheev@chromium.org Review URL: https://chromiumcodereview.appspot.com/10874067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153402 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 04:27:20 +0000